From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D0B2C43334 for ; Wed, 20 Jul 2022 09:48:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235145AbiGTJsv (ORCPT ); Wed, 20 Jul 2022 05:48:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231826AbiGTJst (ORCPT ); Wed, 20 Jul 2022 05:48:49 -0400 Received: from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com [IPv6:2a00:1450:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58E39655AF; Wed, 20 Jul 2022 02:48:48 -0700 (PDT) Received: by mail-wr1-x42c.google.com with SMTP id z13so5771235wro.13; Wed, 20 Jul 2022 02:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=c+pvmwXxIE3jKXaJBEBBqNcZCeI+2ftzet1Ejv5LXxE=; b=Bl/Uxa8xKm77kppS+zbyPUqMX6ThytrscVsgl1YNbRNeKe8x3wNYy9xN2LJQgC4b+m CVtxDHN3+NlCmmeGfSPK3c/2bgbcIaqjyJ8UOOrc7fgYnHXVJpL9/jlthv7pWdx9kOH1 LZ8Ke+TTociEGnkw6Kb2NrqYVzWsyeo9vazoQxsfc7PDfRMUmtJMmZ2JjxhubAt8pfFH oIQiGQ/fJdWsK3BswigHb/+Qw2e86Dg2TDS2EAHuCLGkXQC7NROzCqqyLHBKgPM7Xxl8 znyAJjdKjHqrO6ONRWcA3n3b8veOJmnjbOX7I+MBtOPTMpYlt0dx+flde0eKnhS9oZA+ 5LkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=c+pvmwXxIE3jKXaJBEBBqNcZCeI+2ftzet1Ejv5LXxE=; b=zm/QX45d+Mq9PhohE71568aOFJBPpbFe7wxDQk34r2O2J8cCArx5iVOiwWhmnBxQWz e+9/7NCWMYxGOdb450CFH13Xs8+wD2HvMjZk/aK6teRylv4EcO6sf9FL9nfI9X+GuljY t3TApFUPaqbN8SzVKt7cmA4B+ge5/uDhjLKArCJBjIARuUMM0OnGD230e8JujxssWXpA ncDZooT4JZLS1TApVC5i7jHiDNBp1TW4MU3h9OFf49Gg4IiBfOETKvmE0V1KGvqOUt7G Yn46NBlMQ32/2eWQpyrnkCg/4ajf4fEUizgM/0V6jqmusoQFIMh9PPQDNirhY47+Mo8D azwA== X-Gm-Message-State: AJIora9Nws0kRDpeOhHskrMn3R+TY5xMg7/PGShiCuaPk8hajCH7cOxJ VllcfJuzXjYnrG+pFKpJr8H1BNSdRGiwZA+0bTU= X-Google-Smtp-Source: AGRyM1s8IpIYDGuU/DLqKsFdsmyV+rKVmTfi/oduAoH5rNHnTn85/TiMyb4eENWpu+Y5Z15JoqFBASYG/TlH/hH8hGo= X-Received: by 2002:a05:6000:98b:b0:21d:b70f:2726 with SMTP id by11-20020a056000098b00b0021db70f2726mr29986145wrb.237.1658310526656; Wed, 20 Jul 2022 02:48:46 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-12-peterwu.pub@gmail.com> <20220720094510.GA29755@cyhuang-hp-elitebook-840-g3.rt> In-Reply-To: <20220720094510.GA29755@cyhuang-hp-elitebook-840-g3.rt> From: ChiYuan Huang Date: Wed, 20 Jul 2022 17:48:34 +0800 Message-ID: Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support To: Andy Shevchenko Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org ChiYuan Huang =E6=96=BC 2022=E5=B9=B47=E6=9C=8820=E6= =97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=885:45=E5=AF=AB=E9=81=93=EF=BC=9A > > On Fri, Jul 15, 2022 at 08:29:42PM +0200, Andy Shevchenko wrote: > > On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wrote= : > > > > > > From: ChiYuan Huang > > > > > > The MediaTek MT6370 is a highly-integrated smart power management IC, > > > which includes a single cell Li-Ion/Li-Polymer switching battery > > > charger, a USB Type-C & Power Delivery (PD) controller, dual > > > Flash LED current sources, a RGB LED driver, a backlight WLED driver, > > > a display bias driver and a general LDO for portable devices. > > > > > > In MediaTek MT6370, there are four channel current-sink RGB LEDs that > > > support hardware pattern for constant current, PWM, and breath mode. > > > Isink4 channel can also be used as a CHG_VIN power good indicator. > > > > ... > > > > > + This driver can also be built as a module. If so the module > > > > so, the > > > > > + will be called "leds-mt6370.ko". > > > > No ".ko". > > > > Why did you ignore these comments? Please go and fix _everywhere_ in > > your series. > > It's basically the rule of thumb, if the reviewer gives a comment > > against an occurrence of something, go through entire series and check > > if there are other places like commented one and address them all. > > > > ... > > > > > + * Author: Alice Chen > > > > Strange, the commit message doesn't have a corresponding SoB, why? > > > Yes, there're two authors Alice and me. > I'll correct it in next. > > ... > > > > > +#define MT6370_PWM_DUTY 31 > > > +#define MT6372_PMW_DUTY 255 > > > > Looks like these are limits by hardware? > > Check with the datasheet if (BIT(x) - 1) makes more sense here. > > > > ... > > > > > + switch (led_no) { > > > + case MT6370_LED_ISNK1: > > > + sel_field =3D F_LED1_DUTY; > > > + break; > > > + case MT6370_LED_ISNK2: > > > + sel_field =3D F_LED2_DUTY; > > > + break; > > > + case MT6370_LED_ISNK3: > > > + sel_field =3D F_LED3_DUTY; > > > + break; > > > + default: > > > + sel_field =3D F_LED4_DUTY; > > > > Missed break; > > > > > + } > > > > ... > > > > > + switch (led_no) { > > > + case MT6370_LED_ISNK1: > > > + sel_field =3D F_LED1_FREQ; > > > + break; > > > + case MT6370_LED_ISNK2: > > > + sel_field =3D F_LED2_FREQ; > > > + break; > > > + case MT6370_LED_ISNK3: > > > + sel_field =3D F_LED3_FREQ; > > > + break; > > > + default: > > > + sel_field =3D F_LED4_FREQ; > > > > Ditto. > > > > > + } > > > > ... > > > > > + switch (led_no) { > > > + case MT6370_LED_ISNK1: > > > + case MT6370_LED_ISNK2: > > > + case MT6370_LED_ISNK3: > > > + *base =3D MT6370_REG_RGB1_TR + led_no * 3; > > > + break; > > > + default: > > > + *base =3D MT6370_REG_RGB_CHRIND_TR; > > > > Ditto. > > It seems you dropped them for all switch-cases. It's not goot, please > > restore them back. > > > > > + } > > > > ... > > > > > + u8 val[P_MAX_PATTERNS / 2] =3D {0}; > > > > { } should suffice > > > > > In the above range selector, we use the 'logic or' to generate the typo, it's 'below'. > pattern values. > > If to change it from '{0} to '{ }', is it correct? > > > + /* > > > + * Pattern list > > > + * tr1: byte 0, b'[7: 4] > > > + * tr2: byte 0, b'[3: 0] > > > + * tf1: byte 1, b'[7: 4] > > > + * tf2: byte 1, b'[3: 0] > > > + * ton: byte 2, b'[7: 4] > > > + * toff: byte 2, b'[3: 0] > > > + */ > > > + for (i =3D 0; i < P_MAX_PATTERNS; i++) { > > > + curr =3D pattern + i; > > > + > > > + sel_range =3D i =3D=3D P_LED_TOFF ? R_LED_TOFF : R_LE= D_TRFON; > > > + > > > + linear_range_get_selector_within(priv->ranges + sel_r= ange, > > > + curr->delta_t, &sel)= ; > > > + > > > + val[i / 2] |=3D sel << (4 * ((i + 1) % 2)); > > > + } > > > + > > > + memcpy(pattern_val, val, 3); > > > + return 0; > > > +} > > > > ... > > > > > +out: > > > > out_unlock: > > > > > + mutex_unlock(&priv->lock); > > > + > > > + return ret; > > > > ... > > > > > +out: > > > > Ditto. And so on. > > > > > + mutex_unlock(&priv->lock); > > > + > > > + return ret; > > > > ... > > > > > + sub_led =3D devm_kzalloc(priv->dev, > > > + sizeof(*sub_led) * MC_CHANNEL_= NUM, > > > + GFP_KERNEL); > > > > NIH devm_kcalloc(). Also check if you really need zeroed data. > > > Ok, and after the check, I also need to add one line to set the intensity= to 0. > > > + if (!sub_led) > > > + return -ENOMEM; > > > > ... > > > > > + ret =3D fwnode_property_read_u32(child, "colo= r", &color); > > > + if (ret) { > > > + dev_err(priv->dev, > > > + "led %d, no color specified\n= ", > > > + led->index); > > > + return ret; > > > > return dev_err_probe(...) ; ? > > > > Ditto for many places in your entire series. > > > > > + } > > > > ... > > > > > + priv =3D devm_kzalloc(&pdev->dev, > > > + struct_size(priv, leds, count), GFP_KERNE= L); > > > > At least one parameter can be placed on the previous line. > > > > > + if (!priv) > > > + return -ENOMEM; > > > > -- > > With Best Regards, > > Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E86BC433EF for ; Wed, 20 Jul 2022 09:48:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 56EF911B8E3; Wed, 20 Jul 2022 09:48:49 +0000 (UTC) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6BA6311B8E3 for ; Wed, 20 Jul 2022 09:48:48 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id n12so12491225wrc.8 for ; Wed, 20 Jul 2022 02:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=c+pvmwXxIE3jKXaJBEBBqNcZCeI+2ftzet1Ejv5LXxE=; b=Bl/Uxa8xKm77kppS+zbyPUqMX6ThytrscVsgl1YNbRNeKe8x3wNYy9xN2LJQgC4b+m CVtxDHN3+NlCmmeGfSPK3c/2bgbcIaqjyJ8UOOrc7fgYnHXVJpL9/jlthv7pWdx9kOH1 LZ8Ke+TTociEGnkw6Kb2NrqYVzWsyeo9vazoQxsfc7PDfRMUmtJMmZ2JjxhubAt8pfFH oIQiGQ/fJdWsK3BswigHb/+Qw2e86Dg2TDS2EAHuCLGkXQC7NROzCqqyLHBKgPM7Xxl8 znyAJjdKjHqrO6ONRWcA3n3b8veOJmnjbOX7I+MBtOPTMpYlt0dx+flde0eKnhS9oZA+ 5LkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=c+pvmwXxIE3jKXaJBEBBqNcZCeI+2ftzet1Ejv5LXxE=; b=b96HBKgIDQQbPKRyZm6pMa4bYBznt7OinZDtyIHq8MhNlmyU4BECLgRSz8z2xREDZN ML8ZL2d2OFjTj8s71NvF5T6g2Nnr4PAREvOXJubdJwCGCl6r6OHmLhoNqcpdAHbAcAdV Cyrf570VI1lUg8ITAvdIKxRZSU6/TgNh2AMcI2b7sPsqWBZiyE+ahzJNY9ISvVbMcaWV dmJn+l9mWGt8FVJJLG+ixW4hgRc30S8yK8+9zb9POSNtlTMLftRai+aQ2VsJxu9fxVqe I6jRkRiQq9zDP66vrjAj+4xLPuBY+ERepAJUqPGQ/IUjePwfWa6r/4cZUWrLAXigjVVW +ocg== X-Gm-Message-State: AJIora9Vjx4s7AgppsZdv7HGiZlqWLrLuw1Z/g+2qN7U3WscabhkD9Pp vfKaNC9xNAnB+l5cE92UtmlIfri3KgfFNC4GmDImSbB45ME= X-Google-Smtp-Source: AGRyM1s8IpIYDGuU/DLqKsFdsmyV+rKVmTfi/oduAoH5rNHnTn85/TiMyb4eENWpu+Y5Z15JoqFBASYG/TlH/hH8hGo= X-Received: by 2002:a05:6000:98b:b0:21d:b70f:2726 with SMTP id by11-20020a056000098b00b0021db70f2726mr29986145wrb.237.1658310526656; Wed, 20 Jul 2022 02:48:46 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-12-peterwu.pub@gmail.com> <20220720094510.GA29755@cyhuang-hp-elitebook-840-g3.rt> In-Reply-To: <20220720094510.GA29755@cyhuang-hp-elitebook-840-g3.rt> From: ChiYuan Huang Date: Wed, 20 Jul 2022 17:48:34 +0800 Message-ID: Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support To: Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:FRAMEBUFFER LAYER" , "Krogerus, Heikki" , Pavel Machek , Alice Chen , linux-iio , dri-devel , Liam Girdwood , cy_huang , Krzysztof Kozlowski , Lee Jones , Linux LED Subsystem , Daniel Thompson , Helge Deller , Rob Herring , Chunfeng Yun , Guenter Roeck , devicetree , Linux PM , szuni chen , Mark Brown , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , ChiaEn Wu , linux-arm Mailing List , Jingoo Han , USB , Sebastian Reichel , Linux Kernel Mailing List , ChiaEn Wu , Greg Kroah-Hartman , Jonathan Cameron Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" ChiYuan Huang =E6=96=BC 2022=E5=B9=B47=E6=9C=8820=E6= =97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=885:45=E5=AF=AB=E9=81=93=EF=BC=9A > > On Fri, Jul 15, 2022 at 08:29:42PM +0200, Andy Shevchenko wrote: > > On Fri, Jul 15, 2022 at 1:29 PM ChiaEn Wu wrote= : > > > > > > From: ChiYuan Huang > > > > > > The MediaTek MT6370 is a highly-integrated smart power management IC, > > > which includes a single cell Li-Ion/Li-Polymer switching battery > > > charger, a USB Type-C & Power Delivery (PD) controller, dual > > > Flash LED current sources, a RGB LED driver, a backlight WLED driver, > > > a display bias driver and a general LDO for portable devices. > > > > > > In MediaTek MT6370, there are four channel current-sink RGB LEDs that > > > support hardware pattern for constant current, PWM, and breath mode. > > > Isink4 channel can also be used as a CHG_VIN power good indicator. > > > > ... > > > > > + This driver can also be built as a module. If so the module > > > > so, the > > > > > + will be called "leds-mt6370.ko". > > > > No ".ko". > > > > Why did you ignore these comments? Please go and fix _everywhere_ in > > your series. > > It's basically the rule of thumb, if the reviewer gives a comment > > against an occurrence of something, go through entire series and check > > if there are other places like commented one and address them all. > > > > ... > > > > > + * Author: Alice Chen > > > > Strange, the commit message doesn't have a corresponding SoB, why? > > > Yes, there're two authors Alice and me. > I'll correct it in next. > > ... > > > > > +#define MT6370_PWM_DUTY 31 > > > +#define MT6372_PMW_DUTY 255 > > > > Looks like these are limits by hardware? > > Check with the datasheet if (BIT(x) - 1) makes more sense here. > > > > ... > > > > > + switch (led_no) { > > > + case MT6370_LED_ISNK1: > > > + sel_field =3D F_LED1_DUTY; > > > + break; > > > + case MT6370_LED_ISNK2: > > > + sel_field =3D F_LED2_DUTY; > > > + break; > > > + case MT6370_LED_ISNK3: > > > + sel_field =3D F_LED3_DUTY; > > > + break; > > > + default: > > > + sel_field =3D F_LED4_DUTY; > > > > Missed break; > > > > > + } > > > > ... > > > > > + switch (led_no) { > > > + case MT6370_LED_ISNK1: > > > + sel_field =3D F_LED1_FREQ; > > > + break; > > > + case MT6370_LED_ISNK2: > > > + sel_field =3D F_LED2_FREQ; > > > + break; > > > + case MT6370_LED_ISNK3: > > > + sel_field =3D F_LED3_FREQ; > > > + break; > > > + default: > > > + sel_field =3D F_LED4_FREQ; > > > > Ditto. > > > > > + } > > > > ... > > > > > + switch (led_no) { > > > + case MT6370_LED_ISNK1: > > > + case MT6370_LED_ISNK2: > > > + case MT6370_LED_ISNK3: > > > + *base =3D MT6370_REG_RGB1_TR + led_no * 3; > > > + break; > > > + default: > > > + *base =3D MT6370_REG_RGB_CHRIND_TR; > > > > Ditto. > > It seems you dropped them for all switch-cases. It's not goot, please > > restore them back. > > > > > + } > > > > ... > > > > > + u8 val[P_MAX_PATTERNS / 2] =3D {0}; > > > > { } should suffice > > > > > In the above range selector, we use the 'logic or' to generate the typo, it's 'below'. > pattern values. > > If to change it from '{0} to '{ }', is it correct? > > > + /* > > > + * Pattern list > > > + * tr1: byte 0, b'[7: 4] > > > + * tr2: byte 0, b'[3: 0] > > > + * tf1: byte 1, b'[7: 4] > > > + * tf2: byte 1, b'[3: 0] > > > + * ton: byte 2, b'[7: 4] > > > + * toff: byte 2, b'[3: 0] > > > + */ > > > + for (i =3D 0; i < P_MAX_PATTERNS; i++) { > > > + curr =3D pattern + i; > > > + > > > + sel_range =3D i =3D=3D P_LED_TOFF ? R_LED_TOFF : R_LE= D_TRFON; > > > + > > > + linear_range_get_selector_within(priv->ranges + sel_r= ange, > > > + curr->delta_t, &sel)= ; > > > + > > > + val[i / 2] |=3D sel << (4 * ((i + 1) % 2)); > > > + } > > > + > > > + memcpy(pattern_val, val, 3); > > > + return 0; > > > +} > > > > ... > > > > > +out: > > > > out_unlock: > > > > > + mutex_unlock(&priv->lock); > > > + > > > + return ret; > > > > ... > > > > > +out: > > > > Ditto. And so on. > > > > > + mutex_unlock(&priv->lock); > > > + > > > + return ret; > > > > ... > > > > > + sub_led =3D devm_kzalloc(priv->dev, > > > + sizeof(*sub_led) * MC_CHANNEL_= NUM, > > > + GFP_KERNEL); > > > > NIH devm_kcalloc(). Also check if you really need zeroed data. > > > Ok, and after the check, I also need to add one line to set the intensity= to 0. > > > + if (!sub_led) > > > + return -ENOMEM; > > > > ... > > > > > + ret =3D fwnode_property_read_u32(child, "colo= r", &color); > > > + if (ret) { > > > + dev_err(priv->dev, > > > + "led %d, no color specified\n= ", > > > + led->index); > > > + return ret; > > > > return dev_err_probe(...) ; ? > > > > Ditto for many places in your entire series. > > > > > + } > > > > ... > > > > > + priv =3D devm_kzalloc(&pdev->dev, > > > + struct_size(priv, leds, count), GFP_KERNE= L); > > > > At least one parameter can be placed on the previous line. > > > > > + if (!priv) > > > + return -ENOMEM; > > > > -- > > With Best Regards, > > Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4823C43334 for ; Wed, 20 Jul 2022 09:49:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/m50ZOz2c57HQGvRG6XubbjMBgtxw1Dv5m3zy9b3QdE=; b=ZLMIjW2/i4VZKg 9/DVJQCGxtuAkslcflDdQF9SbNuf33xKV4RnSyxqjfRzCpKurwUpntiLkLCEcm6eQutTroLJOqtX3 ZoZ0sqjqboOvCmABrSva+R/svEgrqF1Hk8WBGbB4U0bR1aQEysln3Wv9/6gYOsptT/T7Qr952G0Xu CIIqgLpkRS7I/lpqLJ4DbPk2VImzXvkZio6SXP2q8/ZjtCCPdF4qAY09a2uta418gV8z5yuKIH6rl lcTMBX7ZUsPJzbt3Ms2Vqk4qc7qqnBX+6FqVMwW5OUUr208Gj2zRTUQEvoJaZ21VBkt1DIY8ntBw0 t8DQkNF7n56G/Rjc1OPA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oE6K4-003Whh-Rf; Wed, 20 Jul 2022 09:48:52 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oE6K0-003Wfc-OX; Wed, 20 Jul 2022 09:48:50 +0000 Received: by mail-wr1-x435.google.com with SMTP id a5so25309242wrx.12; Wed, 20 Jul 2022 02:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=c+pvmwXxIE3jKXaJBEBBqNcZCeI+2ftzet1Ejv5LXxE=; b=Bl/Uxa8xKm77kppS+zbyPUqMX6ThytrscVsgl1YNbRNeKe8x3wNYy9xN2LJQgC4b+m CVtxDHN3+NlCmmeGfSPK3c/2bgbcIaqjyJ8UOOrc7fgYnHXVJpL9/jlthv7pWdx9kOH1 LZ8Ke+TTociEGnkw6Kb2NrqYVzWsyeo9vazoQxsfc7PDfRMUmtJMmZ2JjxhubAt8pfFH oIQiGQ/fJdWsK3BswigHb/+Qw2e86Dg2TDS2EAHuCLGkXQC7NROzCqqyLHBKgPM7Xxl8 znyAJjdKjHqrO6ONRWcA3n3b8veOJmnjbOX7I+MBtOPTMpYlt0dx+flde0eKnhS9oZA+ 5LkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=c+pvmwXxIE3jKXaJBEBBqNcZCeI+2ftzet1Ejv5LXxE=; b=8CYAcvcN3PNVuyZ0dG+430smAaRy5hZkHU6eu6n8MrcXQTZVxdnKKbMmeqtdILKw3H hvhzDwlHvkoNdVU4E67RNtkL6Ha7qe4+xNU45bqhLGXC8gsTmocH+1pIGD70hJptGu8j K9tQewk9C9qK7vcm2PhzZMmv6whQVLL2QN8Q6KQiQGA754yxdkByHxyuDjJLkiHtTwjN bQDlyPnjFad+vXISN1O+t6BMR2EgFYgie7hRJLUY+iUAxrGzxSYiJzQm5lsKe2AAdHaT /VAzB6LQsyTeMKBy1lGSZ1dCyIX/M8swImqTuFgra8JoFxoaXIEjSo4SD4NpVDBVdX2l vhQw== X-Gm-Message-State: AJIora9iCnGl9KLt3IC6fKyi0rhpHfoCjWJpZ4nID3F9yQtg+YAx0gmA nYDQQAPaDk2RKqN/qu3cVz55Vdy6bYUBzlMBB8I= X-Google-Smtp-Source: AGRyM1s8IpIYDGuU/DLqKsFdsmyV+rKVmTfi/oduAoH5rNHnTn85/TiMyb4eENWpu+Y5Z15JoqFBASYG/TlH/hH8hGo= X-Received: by 2002:a05:6000:98b:b0:21d:b70f:2726 with SMTP id by11-20020a056000098b00b0021db70f2726mr29986145wrb.237.1658310526656; Wed, 20 Jul 2022 02:48:46 -0700 (PDT) MIME-Version: 1.0 References: <20220715112607.591-1-peterwu.pub@gmail.com> <20220715112607.591-12-peterwu.pub@gmail.com> <20220720094510.GA29755@cyhuang-hp-elitebook-840-g3.rt> In-Reply-To: <20220720094510.GA29755@cyhuang-hp-elitebook-840-g3.rt> From: ChiYuan Huang Date: Wed, 20 Jul 2022 17:48:34 +0800 Message-ID: Subject: Re: [PATCH v5 11/13] leds: mt6370: Add MediaTek MT6370 current sink type LED Indicator support To: Andy Shevchenko Cc: ChiaEn Wu , Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sebastian Reichel , Chunfeng Yun , Greg Kroah-Hartman , Jonathan Cameron , Lars-Peter Clausen , Liam Girdwood , Mark Brown , Guenter Roeck , "Krogerus, Heikki" , Helge Deller , ChiaEn Wu , Alice Chen , cy_huang , dri-devel , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Linux PM , USB , linux-iio , "open list:FRAMEBUFFER LAYER" , szuni chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220720_024848_826298_D26AD377 X-CRM114-Status: GOOD ( 39.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Q2hpWXVhbiBIdWFuZyA8dTAwODQ1MDBAZ21haWwuY29tPiDmlrwgMjAyMuW5tDfmnIgyMOaXpSDp gLHkuIkg5LiL5Y2INTo0NeWvq+mBk++8mgo+Cj4gT24gRnJpLCBKdWwgMTUsIDIwMjIgYXQgMDg6 Mjk6NDJQTSArMDIwMCwgQW5keSBTaGV2Y2hlbmtvIHdyb3RlOgo+ID4gT24gRnJpLCBKdWwgMTUs IDIwMjIgYXQgMToyOSBQTSBDaGlhRW4gV3UgPHBldGVyd3UucHViQGdtYWlsLmNvbT4gd3JvdGU6 Cj4gPiA+Cj4gPiA+IEZyb206IENoaVl1YW4gSHVhbmcgPGN5X2h1YW5nQHJpY2h0ZWsuY29tPgo+ ID4gPgo+ID4gPiBUaGUgTWVkaWFUZWsgTVQ2MzcwIGlzIGEgaGlnaGx5LWludGVncmF0ZWQgc21h cnQgcG93ZXIgbWFuYWdlbWVudCBJQywKPiA+ID4gd2hpY2ggaW5jbHVkZXMgYSBzaW5nbGUgY2Vs bCBMaS1Jb24vTGktUG9seW1lciBzd2l0Y2hpbmcgYmF0dGVyeQo+ID4gPiBjaGFyZ2VyLCBhIFVT QiBUeXBlLUMgJiBQb3dlciBEZWxpdmVyeSAoUEQpIGNvbnRyb2xsZXIsIGR1YWwKPiA+ID4gRmxh c2ggTEVEIGN1cnJlbnQgc291cmNlcywgYSBSR0IgTEVEIGRyaXZlciwgYSBiYWNrbGlnaHQgV0xF RCBkcml2ZXIsCj4gPiA+IGEgZGlzcGxheSBiaWFzIGRyaXZlciBhbmQgYSBnZW5lcmFsIExETyBm b3IgcG9ydGFibGUgZGV2aWNlcy4KPiA+ID4KPiA+ID4gSW4gTWVkaWFUZWsgTVQ2MzcwLCB0aGVy ZSBhcmUgZm91ciBjaGFubmVsIGN1cnJlbnQtc2luayBSR0IgTEVEcyB0aGF0Cj4gPiA+IHN1cHBv cnQgaGFyZHdhcmUgcGF0dGVybiBmb3IgY29uc3RhbnQgY3VycmVudCwgUFdNLCBhbmQgYnJlYXRo IG1vZGUuCj4gPiA+IElzaW5rNCBjaGFubmVsIGNhbiBhbHNvIGJlIHVzZWQgYXMgYSBDSEdfVklO IHBvd2VyIGdvb2QgaW5kaWNhdG9yLgo+ID4KPiA+IC4uLgo+ID4KPiA+ID4gKyAgICAgICAgIFRo aXMgZHJpdmVyIGNhbiBhbHNvIGJlIGJ1aWx0IGFzIGEgbW9kdWxlLiBJZiBzbyB0aGUgbW9kdWxl Cj4gPgo+ID4gc28sIHRoZQo+ID4KPiA+ID4gKyAgICAgICAgIHdpbGwgYmUgY2FsbGVkICJsZWRz LW10NjM3MC5rbyIuCj4gPgo+ID4gTm8gIi5rbyIuCj4gPgo+ID4gV2h5IGRpZCB5b3UgaWdub3Jl IHRoZXNlIGNvbW1lbnRzPyBQbGVhc2UgZ28gYW5kIGZpeCBfZXZlcnl3aGVyZV8gaW4KPiA+IHlv dXIgc2VyaWVzLgo+ID4gSXQncyBiYXNpY2FsbHkgdGhlIHJ1bGUgb2YgdGh1bWIsIGlmIHRoZSBy ZXZpZXdlciBnaXZlcyBhIGNvbW1lbnQKPiA+IGFnYWluc3QgYW4gb2NjdXJyZW5jZSBvZiBzb21l dGhpbmcsIGdvIHRocm91Z2ggZW50aXJlIHNlcmllcyBhbmQgY2hlY2sKPiA+IGlmIHRoZXJlIGFy ZSBvdGhlciBwbGFjZXMgbGlrZSBjb21tZW50ZWQgb25lIGFuZCBhZGRyZXNzIHRoZW0gYWxsLgo+ ID4KPiA+IC4uLgo+ID4KPiA+ID4gKyAqIEF1dGhvcjogQWxpY2UgQ2hlbiA8YWxpY2VfY2hlbkBy aWNodGVrLmNvbT4KPiA+Cj4gPiBTdHJhbmdlLCB0aGUgY29tbWl0IG1lc3NhZ2UgZG9lc24ndCBo YXZlIGEgY29ycmVzcG9uZGluZyBTb0IsIHdoeT8KPiA+Cj4gWWVzLCB0aGVyZSdyZSB0d28gYXV0 aG9ycyBBbGljZSBhbmQgbWUuCj4gSSdsbCBjb3JyZWN0IGl0IGluIG5leHQuCj4gPiAuLi4KPiA+ Cj4gPiA+ICsjZGVmaW5lIE1UNjM3MF9QV01fRFVUWSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgMzEKPiA+ID4gKyNkZWZpbmUgTVQ2MzcyX1BNV19EVVRZICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAyNTUKPiA+Cj4gPiBMb29rcyBsaWtlIHRoZXNlIGFyZSBsaW1pdHMgYnkg aGFyZHdhcmU/Cj4gPiBDaGVjayB3aXRoIHRoZSBkYXRhc2hlZXQgaWYgKEJJVCh4KSAtIDEpIG1h a2VzIG1vcmUgc2Vuc2UgaGVyZS4KPiA+Cj4gPiAuLi4KPiA+Cj4gPiA+ICsgICAgICAgc3dpdGNo IChsZWRfbm8pIHsKPiA+ID4gKyAgICAgICBjYXNlIE1UNjM3MF9MRURfSVNOSzE6Cj4gPiA+ICsg ICAgICAgICAgICAgICBzZWxfZmllbGQgPSBGX0xFRDFfRFVUWTsKPiA+ID4gKyAgICAgICAgICAg ICAgIGJyZWFrOwo+ID4gPiArICAgICAgIGNhc2UgTVQ2MzcwX0xFRF9JU05LMjoKPiA+ID4gKyAg ICAgICAgICAgICAgIHNlbF9maWVsZCA9IEZfTEVEMl9EVVRZOwo+ID4gPiArICAgICAgICAgICAg ICAgYnJlYWs7Cj4gPiA+ICsgICAgICAgY2FzZSBNVDYzNzBfTEVEX0lTTkszOgo+ID4gPiArICAg ICAgICAgICAgICAgc2VsX2ZpZWxkID0gRl9MRUQzX0RVVFk7Cj4gPiA+ICsgICAgICAgICAgICAg ICBicmVhazsKPiA+ID4gKyAgICAgICBkZWZhdWx0Ogo+ID4gPiArICAgICAgICAgICAgICAgc2Vs X2ZpZWxkID0gRl9MRUQ0X0RVVFk7Cj4gPgo+ID4gTWlzc2VkIGJyZWFrOwo+ID4KPiA+ID4gKyAg ICAgICB9Cj4gPgo+ID4gLi4uCj4gPgo+ID4gPiArICAgICAgIHN3aXRjaCAobGVkX25vKSB7Cj4g PiA+ICsgICAgICAgY2FzZSBNVDYzNzBfTEVEX0lTTksxOgo+ID4gPiArICAgICAgICAgICAgICAg c2VsX2ZpZWxkID0gRl9MRUQxX0ZSRVE7Cj4gPiA+ICsgICAgICAgICAgICAgICBicmVhazsKPiA+ ID4gKyAgICAgICBjYXNlIE1UNjM3MF9MRURfSVNOSzI6Cj4gPiA+ICsgICAgICAgICAgICAgICBz ZWxfZmllbGQgPSBGX0xFRDJfRlJFUTsKPiA+ID4gKyAgICAgICAgICAgICAgIGJyZWFrOwo+ID4g PiArICAgICAgIGNhc2UgTVQ2MzcwX0xFRF9JU05LMzoKPiA+ID4gKyAgICAgICAgICAgICAgIHNl bF9maWVsZCA9IEZfTEVEM19GUkVROwo+ID4gPiArICAgICAgICAgICAgICAgYnJlYWs7Cj4gPiA+ ICsgICAgICAgZGVmYXVsdDoKPiA+ID4gKyAgICAgICAgICAgICAgIHNlbF9maWVsZCA9IEZfTEVE NF9GUkVROwo+ID4KPiA+IERpdHRvLgo+ID4KPiA+ID4gKyAgICAgICB9Cj4gPgo+ID4gLi4uCj4g Pgo+ID4gPiArICAgICAgIHN3aXRjaCAobGVkX25vKSB7Cj4gPiA+ICsgICAgICAgY2FzZSBNVDYz NzBfTEVEX0lTTksxOgo+ID4gPiArICAgICAgIGNhc2UgTVQ2MzcwX0xFRF9JU05LMjoKPiA+ID4g KyAgICAgICBjYXNlIE1UNjM3MF9MRURfSVNOSzM6Cj4gPiA+ICsgICAgICAgICAgICAgICAqYmFz ZSA9IE1UNjM3MF9SRUdfUkdCMV9UUiArIGxlZF9ubyAqIDM7Cj4gPiA+ICsgICAgICAgICAgICAg ICBicmVhazsKPiA+ID4gKyAgICAgICBkZWZhdWx0Ogo+ID4gPiArICAgICAgICAgICAgICAgKmJh c2UgPSBNVDYzNzBfUkVHX1JHQl9DSFJJTkRfVFI7Cj4gPgo+ID4gRGl0dG8uCj4gPiBJdCBzZWVt cyB5b3UgZHJvcHBlZCB0aGVtIGZvciBhbGwgc3dpdGNoLWNhc2VzLiBJdCdzIG5vdCBnb290LCBw bGVhc2UKPiA+IHJlc3RvcmUgdGhlbSBiYWNrLgo+ID4KPiA+ID4gKyAgICAgICB9Cj4gPgo+ID4g Li4uCj4gPgo+ID4gPiArICAgICAgIHU4IHZhbFtQX01BWF9QQVRURVJOUyAvIDJdID0gezB9Owo+ ID4KPiA+IHsgfSBzaG91bGQgc3VmZmljZQo+ID4KPiA+Cj4gSW4gdGhlIGFib3ZlIHJhbmdlIHNl bGVjdG9yLCB3ZSB1c2UgdGhlICdsb2dpYyBvcicgdG8gZ2VuZXJhdGUgdGhlCnR5cG8sIGl0J3Mg J2JlbG93Jy4KPiBwYXR0ZXJuIHZhbHVlcy4KPgo+IElmIHRvIGNoYW5nZSBpdCBmcm9tICd7MH0g dG8gJ3sgfScsIGlzIGl0IGNvcnJlY3Q/Cj4gPiA+ICsgICAgICAgLyoKPiA+ID4gKyAgICAgICAg KiBQYXR0ZXJuIGxpc3QKPiA+ID4gKyAgICAgICAgKiB0cjE6IGJ5dGUgMCwgYidbNzogNF0KPiA+ ID4gKyAgICAgICAgKiB0cjI6IGJ5dGUgMCwgYidbMzogMF0KPiA+ID4gKyAgICAgICAgKiB0ZjE6 IGJ5dGUgMSwgYidbNzogNF0KPiA+ID4gKyAgICAgICAgKiB0ZjI6IGJ5dGUgMSwgYidbMzogMF0K PiA+ID4gKyAgICAgICAgKiB0b246IGJ5dGUgMiwgYidbNzogNF0KPiA+ID4gKyAgICAgICAgKiB0 b2ZmOiBieXRlIDIsIGInWzM6IDBdCj4gPiA+ICsgICAgICAgICovCj4gPiA+ICsgICAgICAgZm9y IChpID0gMDsgaSA8IFBfTUFYX1BBVFRFUk5TOyBpKyspIHsKPiA+ID4gKyAgICAgICAgICAgICAg IGN1cnIgPSBwYXR0ZXJuICsgaTsKPiA+ID4gKwo+ID4gPiArICAgICAgICAgICAgICAgc2VsX3Jh bmdlID0gaSA9PSBQX0xFRF9UT0ZGID8gUl9MRURfVE9GRiA6IFJfTEVEX1RSRk9OOwo+ID4gPiAr Cj4gPiA+ICsgICAgICAgICAgICAgICBsaW5lYXJfcmFuZ2VfZ2V0X3NlbGVjdG9yX3dpdGhpbihw cml2LT5yYW5nZXMgKyBzZWxfcmFuZ2UsCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBjdXJyLT5kZWx0YV90LCAmc2VsKTsKPiA+ID4gKwo+ID4g PiArICAgICAgICAgICAgICAgdmFsW2kgLyAyXSB8PSBzZWwgPDwgKDQgKiAoKGkgKyAxKSAlIDIp KTsKPiA+ID4gKyAgICAgICB9Cj4gPiA+ICsKPiA+ID4gKyAgICAgICBtZW1jcHkocGF0dGVybl92 YWwsIHZhbCwgMyk7Cj4gPiA+ICsgICAgICAgcmV0dXJuIDA7Cj4gPiA+ICt9Cj4gPgo+ID4gLi4u Cj4gPgo+ID4gPiArb3V0Ogo+ID4KPiA+IG91dF91bmxvY2s6Cj4gPgo+ID4gPiArICAgICAgIG11 dGV4X3VubG9jaygmcHJpdi0+bG9jayk7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICByZXR1cm4gcmV0 Owo+ID4KPiA+IC4uLgo+ID4KPiA+ID4gK291dDoKPiA+Cj4gPiBEaXR0by4gQW5kIHNvIG9uLgo+ ID4KPiA+ID4gKyAgICAgICBtdXRleF91bmxvY2soJnByaXYtPmxvY2spOwo+ID4gPiArCj4gPiA+ ICsgICAgICAgcmV0dXJuIHJldDsKPiA+Cj4gPiAuLi4KPiA+Cj4gPiA+ICsgICAgICAgICAgICAg ICBzdWJfbGVkID0gZGV2bV9remFsbG9jKHByaXYtPmRldiwKPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgc2l6ZW9mKCpzdWJfbGVkKSAqIE1DX0NIQU5ORUxfTlVN LAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHRlBfS0VSTkVM KTsKPiA+Cj4gPiBOSUggZGV2bV9rY2FsbG9jKCkuIEFsc28gY2hlY2sgaWYgeW91IHJlYWxseSBu ZWVkIHplcm9lZCBkYXRhLgo+ID4KPiBPaywgYW5kIGFmdGVyIHRoZSBjaGVjaywgSSBhbHNvIG5l ZWQgdG8gYWRkIG9uZSBsaW5lIHRvIHNldCB0aGUgaW50ZW5zaXR5IHRvIDAuCj4gPiA+ICsgICAg ICAgICAgICAgICBpZiAoIXN1Yl9sZWQpCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIHJl dHVybiAtRU5PTUVNOwo+ID4KPiA+IC4uLgo+ID4KPiA+ID4gKyAgICAgICAgICAgICAgICAgICAg ICAgcmV0ID0gZndub2RlX3Byb3BlcnR5X3JlYWRfdTMyKGNoaWxkLCAiY29sb3IiLCAmY29sb3Ip Owo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICBpZiAocmV0KSB7Cj4gPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgZGV2X2Vycihwcml2LT5kZXYsCj4gPiA+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAibGVkICVkLCBubyBjb2xvciBzcGVjaWZp ZWRcbiIsCj4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsZWQt PmluZGV4KTsKPiA+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gcmV0 Owo+ID4KPiA+IHJldHVybiBkZXZfZXJyX3Byb2JlKC4uLikgOyA/Cj4gPgo+ID4gRGl0dG8gZm9y IG1hbnkgcGxhY2VzIGluIHlvdXIgZW50aXJlIHNlcmllcy4KPiA+Cj4gPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgIH0KPiA+Cj4gPiAuLi4KPiA+Cj4gPiA+ICsgICAgICAgcHJpdiA9IGRldm1f a3phbGxvYygmcGRldi0+ZGV2LAo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgc3Ry dWN0X3NpemUocHJpdiwgbGVkcywgY291bnQpLCBHRlBfS0VSTkVMKTsKPiA+Cj4gPiBBdCBsZWFz dCBvbmUgcGFyYW1ldGVyIGNhbiBiZSBwbGFjZWQgb24gdGhlIHByZXZpb3VzIGxpbmUuCj4gPgo+ ID4gPiArICAgICAgIGlmICghcHJpdikKPiA+ID4gKyAgICAgICAgICAgICAgIHJldHVybiAtRU5P TUVNOwo+ID4KPiA+IC0tCj4gPiBXaXRoIEJlc3QgUmVnYXJkcywKPiA+IEFuZHkgU2hldmNoZW5r bwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgt YXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJt LWtlcm5lbAo=