All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gleb Mazovetskiy <glex.spb@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] Fix -latomic for CMake packages
Date: Fri, 16 Apr 2021 23:36:56 +0100	[thread overview]
Message-ID: <CADjhFRC3+ZQzDHPTAMv-ccDidoSAsV5teH5CNUfhEfXkd9bjFQ@mail.gmail.com> (raw)
In-Reply-To: <CADjhFRCWeu9Z39_aVEBLY79y9dBEkBKHdwn-kx-yy+gEs1xZ3Q@mail.gmail.com>

Can the maintainers please merge this?

It's still a better way to do this, quoting Peter Seiderer:

> Still +1 for the patch (as the CMAKE_EXE_LINKER_FLAGS usage is smarter
than the '$(TARGET_CXXFLAGS) -latomic' dance....

On Thu, Apr 15, 2021 at 10:02 PM Gleb Mazovetskiy <glex.spb@gmail.com>
wrote:

> > Thanks for providing the defconfig, as far as I can see nothing special
> (and no poppler enabled?),
>
> Poppler is a transitive dependency of another package (
> https://github.com/batocera-linux/batocera.linux/blob/95f96803e04027b7996c73ae05b40a891dad0ca9/package/batocera/emulationstation/batocera-emulationstation/Config.in
> )
>
> On Thu, Apr 15, 2021 at 10:00 PM Gleb Mazovetskiy <glex.spb@gmail.com>
> wrote:
>
>> My host cmake is 3.20.0 from Ubuntu 20.10
>> It must be some environment / host cmake difference but I can't pinpoint
>> it either, thus my vague commit message
>>
>> If I run this in a Docker container with an older Ubuntu I can't
>> reproduce it either
>>
>> On Thu, Apr 15, 2021 at 9:46 PM Arnout Vandecappelle <arnout@mind.be>
>> wrote:
>>
>>>
>>>
>>> On 15/04/2021 21:44, Peter Seiderer wrote:
>>> > Hello Gleb,
>>> >
>>> > On Thu, 15 Apr 2021 04:49:29 +0100, Gleb Mazovetskiy <
>>> glex.spb at gmail.com> wrote:
>>> >
>>> >> Hi Peter,
>>> >>
>>> >> The failing defconfig is here (it's specific to this buildroot):
>>> >>
>>> https://github.com/batocera-linux/batocera.linux/blob/8d8038a6ddaae03f0150fd28a2d23c371156ebf2/configs/batocera-odroidgoa_defconfig
>>> >
>>> > Thanks for providing the defconfig, as far as I can see nothing
>>> special (and no
>>> > poppler enabled?), normal buildroot-glibc-gcc-10.x toolchain..., and I
>>> am not
>>> > able to reproduce your problem (did only test without ccache)...
>>>
>>>  CMake is known to do weird things with -isystem, and this can change
>>> over cmake
>>> versions, and we use the host cmake if sufficiently recent. So that
>>> could make a
>>> difference.
>>>
>>>  Regards,
>>>  Arnout
>>>
>>> [snip]
>>>
>>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20210416/330f607f/attachment.html>

  reply	other threads:[~2021-04-16 22:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-13  6:09 [Buildroot] [PATCH 1/1] Fix -latomic for CMake packages Gleb Mazovetskiy
2021-04-13  6:26 ` [Buildroot] [PATCH v2 " Gleb Mazovetskiy
2021-04-14 17:49   ` Peter Seiderer
2021-04-15  3:49     ` Gleb Mazovetskiy
2021-04-15 19:44       ` Peter Seiderer
2021-04-15 20:46         ` Arnout Vandecappelle
2021-04-15 21:00           ` Gleb Mazovetskiy
2021-04-15 21:02             ` Gleb Mazovetskiy
2021-04-16 22:36               ` Gleb Mazovetskiy [this message]
2021-05-01 13:02   ` Arnout Vandecappelle
2021-05-07  7:28     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADjhFRC3+ZQzDHPTAMv-ccDidoSAsV5teH5CNUfhEfXkd9bjFQ@mail.gmail.com \
    --to=glex.spb@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.