From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id E42D7C433EF for ; Thu, 31 Mar 2022 16:38:20 +0000 (UTC) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by mx.groups.io with SMTP id smtpd.web11.1.1648744700041104661 for ; Thu, 31 Mar 2022 09:38:20 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=FmOboA7X; spf=pass (domain: gmail.com, ip: 209.85.218.42, mailfrom: bruce.ashfield@gmail.com) Received: by mail-ej1-f42.google.com with SMTP id bh17so476922ejb.8 for ; Thu, 31 Mar 2022 09:38:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pdQvtmUICcNY64uWNSmOQ5tgdHwNBEm7NpZavSS1cvQ=; b=FmOboA7XA4a2f1aaWIGr/27nXe8+PHASm3v3WtPqKl9XbbxVOE4sSInEqJcvC0e8y1 gobw9vlTW+GCbhwUUT+DFtdilCV0qda22VzC9fcwLeCmhALaQ1ZzcrGnmY8NBPNTM5rp acRiy7GTCXV2nb8d3lurLyfrt4IciEnwIDdbaQminD3/LgbpC+dUcf6U+T6+ubmg83nn 6cL4vhdjWAXyy4vpIj9J9aY7WUNnbExGxiyPzxMpoccBnUwQKWgr0slKAmFRfJ08EsXJ 5XVpXpeT1SoofES1IetmZJCmZcagJwRE9iPIUkCfNnp5JQEK0VmpZK6+ts/IZXRB7p6q bU4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pdQvtmUICcNY64uWNSmOQ5tgdHwNBEm7NpZavSS1cvQ=; b=I/2hlFBXr+AAjGuOy8i1Zza0N6hgxC3iRbVQl8bnwZSf65EXRnze2QRqvKn0Urntn6 9Z0SZ66VXOauf6jyloagTmoXvhuU7rRu2c4jBGRfiYVfYjzLPGncTBqCVYSPSNftr+Fp UhBy+Vjv1L/0NSVCoibJcuVkxBBncuXy9cRDzKK+FB1gQSAN+8VP698uydDrE4XSpd+d pfDphlHoR6RxpeUkQAhVZithxpUXXgVH8axNPU2ewzvcrxwACD3r0O1jeSGjRQaLKGoh 1Lz1NwboA+xxmOQZDKM+TJf+CCienegQuguMC4iQdF2Ct46i9hai7I098PiDpIaOiZiE AcKQ== X-Gm-Message-State: AOAM531uk7lzggZ515kt01dx704Kp30kwXQd1rMKV+4Vy14HYec5NA5o JXOQz0Rdx2p5UvlI+EH8OUeEnxVOum2ubr5VcTo= X-Google-Smtp-Source: ABdhPJyW9gVy9i4IUPBR3ZrxG7p3Vasn6qYZQHi0mq9y1oI0HDCTr5vMp5MIc51a9lsz/LwDybdc82Usa5TynNBwTN4= X-Received: by 2002:a17:907:3f29:b0:6df:7eac:7fa4 with SMTP id hq41-20020a1709073f2900b006df7eac7fa4mr5736610ejc.391.1648744695329; Thu, 31 Mar 2022 09:38:15 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bruce Ashfield Date: Thu, 31 Mar 2022 12:38:04 -0400 Message-ID: Subject: Re: k3s build issues on master To: Diego Sueiro Cc: "meta-virtualization@lists.yoctoproject.org" , nd Content-Type: multipart/alternative; boundary="000000000000e8b2e005db864959" List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Thu, 31 Mar 2022 16:38:20 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-virtualization/message/7121 --000000000000e8b2e005db864959 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 31, 2022 at 12:22 PM Diego Sueiro wrote: > Hi Bruce, > > Whilst investigating a build problem on our CI related to sstate mirror o= f > the k3s recipe, I found that the commit "k3s: update to 1.23.1" (8cba0652= 09dd668afe939f878da340a017ecdd7d) > didn't change the PV and SRCREV_k3s variables correctly. > > I changed those values to v1.23.1+k3s1 > and 08d538fb3a04a0fe904b34cf04f7e21191b82449 respectively and now I'm > getting the following do_compile error: > ``` > go: inconsistent vendoring in > /kas_build_dir/tmp/work/neoversen1-poky-linux/k3s/v1.23.3+k3s1-r0/k3s-v1.= 23.3+k3s1/src/import: > github.com/google/cadvisor@v0.43.0: is explicitly required in go.mod, > but not marked as explicit in vendor/modules.txt > [...] > k8s.io/sample-controller: is marked as replaced by > github.com/k3s-io/kubernetes/staging/src/k8s.io/sample-controller@v1.22.6= -k3s1 > in vendor/modules.txt, but replaced by > github.com/k3s-io/kubernetes/staging/src/k8s.io/sample-controller@v1.23.3= -k3s1 > in go.mod > > To ignore the vendor directory, use -mod=3Dreadonly or -mod=3Dmod. > To sync the vendor directory, run: > go mod vendor > ``` > > The short log is wrong, the SRCREV and PV are correct. There's some fundamental issues with 1.23.x that prevented it from building inside or outside of bitbake, so I scaled back the version bump at the last minute to stay in 1.22.x series. And yes, there's no more vendoring in k3s, so you can't just bump the SRCREV and PV, we have to adjust all of the git clones and shuffling to make it build. I have some more changes to that recipe pending, so I'll do a minor cleanup, with a shortlog that makes things clear. Cheers, Bruce > Unfortunately, I have zero knowledge in go and I have no idea how I could > fix this. > > Diego Sueiro > Staff Software Developer =E2=80=93 ARM =E2=80=93 Automotive and Industria= l Solutions > (CE-OSS) > --=20 - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II --000000000000e8b2e005db864959 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Thu, Mar 31, 2022 at 12:22 PM Diego Sueiro <<= a href=3D"mailto:Diego.Sueiro@arm.com" target=3D"_blank">Diego.Sueiro@arm.c= om> wrote:
Hi Bruce,

Whilst investigating a build problem on our CI related to sstate mirror of = the k3s recipe, I found that the commit "k3s: update to 1.23.1"=C2=A0(8cba065209dd668afe939f878da340a017ecd= d7d) didn't change the PV and=C2=A0SRCREV_k3s variables correctly.

I changed those values to=C2=A0v1.23.1+k3s1 and=C2=A008d538fb3a04a0fe904b34= cf04f7e21191b82449 respectively and now I'm getting the following do_co= mpile error:
```
go: inconsistent vendoring in /kas_build_dir/tmp/work/neoversen1-poky-linux= /k3s/v1.23.3+k3s1-r0/k3s-v1.23.3+k3s1/src/import:
=C2=A0 =C2=A0 github.com/google/cadvisor@v0.43.0: is explicitly required = in go.mod, but not marked as explicit in vendor/modules.txt
[...= ]
=C2= =A0 =C2=A0 k8= s.io/sample-controller: is marked as replaced by github.com/k3s-io/kubernetes/staging/src/k8s.io/sample-c= ontroller@v1.22.6-k3s1 in vendor/modules.txt, but replaced by github.com/k3s-io/kubernetes/staging/src/= k8s.io/sample-controller@v1.23.3-k3s1 in go.mod

=C2=A0 =C2=A0 To ignore the vendor directory, use -mod=3Dreadonly or -= mod=3Dmod.
=C2=A0 =C2=A0 To sync the vendor directory, run:
=C2=A0 =C2=A0 =C2=A0 =C2=A0 go mod vendor
```


The short log is wrong, the SRCREV and PV are = correct. There's some fundamental issues with 1.23.x that prevented it = from building inside or outside of bitbake, so I scaled back the version bu= mp at the last minute to stay in 1.22.x series.

And yes, there's no more vendoring in k3s, so yo= u can't just bump the SRCREV and PV, we have to adjust all of the git c= lones and shuffling to make it build.

I have some more changes to that recipe pending, so I'll d= o a minor cleanup, with a shortlog that makes things clear.

Cheers,

Bruce

=C2=A0
Unfortunately, I have zero knowledge in go and I have no idea how I could f= ix this.=C2=A0

Diego Sueiro
Staff Software Developer =E2=80=93 ARM =E2=80=93=C2=A0Automotive and Industrial Solutions (CE-OSS)



--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee= at its end
- "Use the force Harry" - Gandalf, Star Trek II
--000000000000e8b2e005db864959--