From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f65.google.com (mail-oi0-f65.google.com [209.85.218.65]) by mail.openembedded.org (Postfix) with ESMTP id 9D39F7017B for ; Thu, 12 May 2016 04:31:40 +0000 (UTC) Received: by mail-oi0-f65.google.com with SMTP id t140so7382278oie.0 for ; Wed, 11 May 2016 21:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=h6jt8QNsVnEhV1dwZMpZ2e5D+V34akH78WeZm998hQE=; b=RaN7Go7rqNJ7tR1UI7FvrYyOtzpcE5Al0iKizD0RCgTizCB7ynOVBldFaCV/zD35OS l9NyeLXVnolvUI7kJ0oizdWQF2GL4xKI+EChtpxumwxHCjgiutjHhJpof9zP8f2PcKi5 Dwy/5B87rL+i1EvLGCDGm62vgQHKscryu9xZkjXVl4mb8pNMV0jjXuVx+4ViqyiCmFyk ey2itjqYp7ym7KhMWDAvEdKjtonzASIJy0Nfw2lSdvNkGIGdjgUPH07tnlNYwlq1uCMb xwyY7Yk7+4uPcfHoVLLFpbO2j6S1KRIw7xhURtr90z5Vr2uqaTS9Cqrnzanu5Fx1pdNA 9qKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=h6jt8QNsVnEhV1dwZMpZ2e5D+V34akH78WeZm998hQE=; b=gouly4MWHG1qNhPmp2JZs4Pr1WnSmyZZXwnyX3jDHXTyc+VdoAS+t/Pxpd5GJ9Pl41 NPT+SdlkLLnypADiLNAn33ukU8FxiqOK5GOG84AeyZ94f1QU8RkN4BOSknTQKIqg6YbI VZMhh4471VKGDCLwNTApwg5KIjORKreKZfX5UKnuqPGb6MbRYorrPmrHLD15l/Yn9EVc hUfAqTzkCKQ0dCfpsV6d7PWL/HJ1bUgzekoAPbgV5emflRsitOFSO4V49obhbYebU5+Z WnkVP2g2LSXs+oXVc9EhVyoSGEakCMTyzqzrG0lFP5k+nU9NgInjNywnRcBjdhXC2EJ7 mfRA== X-Gm-Message-State: AOPr4FWwz4eSwkFPmPT6/EA9VCZXjtsAPOzfH7n6Oy9kPRLNeEYM9cPgAeKjeZjGy7Y4moKQe3j0IbfxSWk2vw== MIME-Version: 1.0 X-Received: by 10.157.16.27 with SMTP id h27mr4404712ote.118.1463027500797; Wed, 11 May 2016 21:31:40 -0700 (PDT) Received: by 10.157.32.135 with HTTP; Wed, 11 May 2016 21:31:40 -0700 (PDT) In-Reply-To: References: <2e51e9b5fb3911436afc1becd5feb9351b896fa4.1462987863.git.raj.khem@gmail.com> <1d16314288f1f93b21bacd0016d23abcab52b501.1462987863.git.raj.khem@gmail.com> Date: Thu, 12 May 2016 00:31:40 -0400 Message-ID: From: Bruce Ashfield To: Khem Raj Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 22/42] linux-yocto: Fix build on ppc with gcc-6 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 May 2016 04:31:41 -0000 Content-Type: multipart/alternative; boundary=001a113dffc07b57f105329da25f --001a113dffc07b57f105329da25f Content-Type: text/plain; charset=UTF-8 On Wed, May 11, 2016 at 5:55 PM, Khem Raj wrote: > On Wed, May 11, 2016 at 2:36 PM, Bruce Ashfield > wrote: > > > > > > On Wed, May 11, 2016 at 5:30 PM, Khem Raj wrote: > >> > >> On Wed, May 11, 2016 at 2:27 PM, Bruce Ashfield > >> wrote: > >> > > >> > > >> > On Wed, May 11, 2016 at 1:35 PM, Khem Raj wrote: > >> >> > >> >> Signed-off-by: Khem Raj > >> > > >> > > >> > > >> > These shouldn't be carried out of tree. So can you drop the > linux-yocto > >> > changes from the > >> > series, and I'll look at getting them integrated later. > >> > >> I could but, this series switches to using gcc6 which will start to > fail. > > > > > > I can coordinate the fix. We just don't carry patches like this for linux > > yocto. As you > > can see, your series will no longer apply with the consolidated pull > > requests that > > I just sent. > > Just include these patches in your pull request and send a v2. I will > then drop it from my list. > since these patches should work fine with older gcc as well your > changes then can go in first > or along with my changes. > Sounds good. I'll have them out first thing in the morning Thursday. Bruce > > > > > Bruce > > > >> > >> > >> > > >> > Bruce > >> > > >> >> > >> >> --- > >> >> ...ace-Fix-out-of-bounds-array-access-warnin.patch | 50 > >> >> ++++++++++++++++++++++ > >> >> meta/recipes-kernel/linux/linux-yocto_4.4.bb | 4 +- > >> >> 2 files changed, 53 insertions(+), 1 deletion(-) > >> >> create mode 100644 > >> >> > >> >> > meta/recipes-kernel/linux/linux-yocto/0001-powerpc-ptrace-Fix-out-of-bounds-array-access-warnin.patch > >> >> > >> >> diff --git > >> >> > >> >> > a/meta/recipes-kernel/linux/linux-yocto/0001-powerpc-ptrace-Fix-out-of-bounds-array-access-warnin.patch > >> >> > >> >> > b/meta/recipes-kernel/linux/linux-yocto/0001-powerpc-ptrace-Fix-out-of-bounds-array-access-warnin.patch > >> >> new file mode 100644 > >> >> index 0000000..05315ed > >> >> --- /dev/null > >> >> +++ > >> >> > >> >> > b/meta/recipes-kernel/linux/linux-yocto/0001-powerpc-ptrace-Fix-out-of-bounds-array-access-warnin.patch > >> >> @@ -0,0 +1,50 @@ > >> >> +From 32acc1d9a5738b02e8815047af8886978aa40ead Mon Sep 17 00:00:00 > 2001 > >> >> +From: Khem Raj > >> >> +Date: Mon, 25 Apr 2016 05:47:01 +0000 > >> >> +Subject: [PATCH V2] powerpc/ptrace: Fix out of bounds array access > >> >> warning > >> >> + > >> >> +gcc-6 correctly warns about a out of bounds access > >> >> + > >> >> +arch/powerpc/kernel/ptrace.c:407:24: warning: index 32 denotes an > >> >> offset > >> >> greater than size of 'u64[32][1] {aka long long unsigned int[32][1]}' > >> >> [-Warray-bounds] > >> >> + offsetof(struct thread_fp_state, fpr[32][0])); > >> >> + ^ > >> >> + > >> >> +check the end of array instead of beginning of next element to fix > >> >> this > >> >> + > >> >> +Signed-off-by: Khem Raj > >> >> +Cc: Kees Cook > >> >> +Cc: Michael Ellerman > >> >> +Cc: Segher Boessenkool > >> >> +--- > >> >> +Changes from v1 to v2: > >> >> + > >> >> +- Check for fpr[32] instead of fpr[31][1] > >> >> + > >> >> + arch/powerpc/kernel/ptrace.c | 4 ++-- > >> >> + 1 file changed, 2 insertions(+), 2 deletions(-) > >> >> + > >> >> +diff --git a/arch/powerpc/kernel/ptrace.c > >> >> b/arch/powerpc/kernel/ptrace.c > >> >> +index 737c0d0..b38fd08 100644 > >> >> +--- a/arch/powerpc/kernel/ptrace.c > >> >> ++++ b/arch/powerpc/kernel/ptrace.c > >> >> +@@ -376,7 +376,7 @@ static int fpr_get(struct task_struct *target, > >> >> const > >> >> struct user_regset *regset, > >> >> + > >> >> + #else > >> >> + BUILD_BUG_ON(offsetof(struct thread_fp_state, fpscr) != > >> >> +- offsetof(struct thread_fp_state, fpr[32][0])); > >> >> ++ offsetof(struct thread_fp_state, fpr[32])); > >> >> + > >> >> + return user_regset_copyout(&pos, &count, &kbuf, &ubuf, > >> >> + &target->thread.fp_state, 0, -1); > >> >> +@@ -404,7 +404,7 @@ static int fpr_set(struct task_struct *target, > >> >> const > >> >> struct user_regset *regset, > >> >> + return 0; > >> >> + #else > >> >> + BUILD_BUG_ON(offsetof(struct thread_fp_state, fpscr) != > >> >> +- offsetof(struct thread_fp_state, fpr[32][0])); > >> >> ++ offsetof(struct thread_fp_state, fpr[32])); > >> >> + > >> >> + return user_regset_copyin(&pos, &count, &kbuf, &ubuf, > >> >> + &target->thread.fp_state, 0, -1); > >> >> +-- > >> >> +1.9.1 > >> >> + > >> >> diff --git a/meta/recipes-kernel/linux/linux-yocto_4.4.bb > >> >> b/meta/recipes-kernel/linux/linux-yocto_4.4.bb > >> >> index b74903e..fbb592a 100644 > >> >> --- a/meta/recipes-kernel/linux/linux-yocto_4.4.bb > >> >> +++ b/meta/recipes-kernel/linux/linux-yocto_4.4.bb > >> >> @@ -22,7 +22,9 @@ SRCREV_machine ?= > >> >> "b18090556c1d1b449233cd555c27a04d38272d6d" > >> >> SRCREV_meta ?= "9ab4787fe2aea2ae0fcc31a5e067eaba19ef64c8" > >> >> > >> >> SRC_URI = > >> >> > >> >> "git:// > git.yoctoproject.org/linux-yocto-4.4.git;name=machine;branch=${KBRANCH}; > >> >> \ > >> >> - > >> >> > >> >> git:// > git.yoctoproject.org/yocto-kernel-cache;type=kmeta;name=meta;branch=yocto-4.4;destsuffix=${KMETA} > " > >> >> + > >> >> > >> >> git:// > git.yoctoproject.org/yocto-kernel-cache;type=kmeta;name=meta;branch=yocto-4.4;destsuffix=${KMETA} > >> >> \ > >> >> + > >> >> > file://0001-powerpc-ptrace-Fix-out-of-bounds-array-access-warnin.patch > >> >> \ > >> >> +" > >> >> > >> >> LINUX_VERSION ?= "4.4.3" > >> >> > >> >> -- > >> >> 2.8.2 > >> >> > >> >> -- > >> >> _______________________________________________ > >> >> Openembedded-core mailing list > >> >> Openembedded-core@lists.openembedded.org > >> >> http://lists.openembedded.org/mailman/listinfo/openembedded-core > >> > > >> > > >> > > >> > > >> > -- > >> > "Thou shalt not follow the NULL pointer, for chaos and madness await > >> > thee at > >> > its end" > > > > > > > > > > -- > > "Thou shalt not follow the NULL pointer, for chaos and madness await > thee at > > its end" > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" --001a113dffc07b57f105329da25f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Wed, May 11, 2016 at 5:55 PM, Khem Raj <raj.khem@gmail.com>= wrote:
On Wed, May 11, 2016 at 2:= 36 PM, Bruce Ashfield
<bruce.ashf= ield@gmail.com> wrote:
>
>
> On Wed, May 11, 2016 at 5:30 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On Wed, May 11, 2016 at 2:27 PM, Bruce Ashfield
>> <bruce.ashfield@gma= il.com> wrote:
>> >
>> >
>> > On Wed, May 11, 2016 at 1:35 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> >>
>> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> >
>> >
>> >
>> > These shouldn't be carried out of tree. So can you drop t= he linux-yocto
>> > changes from the
>> > series, and I'll look at getting them integrated later. >>
>> I could but, this series switches to using gcc6 which will start t= o fail.
>
>
> I can coordinate the fix. We just don't carry patches like this fo= r linux
> yocto. As you
> can see, your series will no longer apply with the consolidated pull > requests that
> I just sent.

Just include these patches in your pull request and send a v2. I wil= l
then drop it from my list.
since these patches should work fine with older gcc as well your
changes then can go in first
or along with my changes.

Sounds good. = I'll have them out first thing in the morning Thursday.

<= /div>
Bruce
=C2=A0

>
> Bruce
>
>>
>>
>> >
>> > Bruce
>> >
>> >>
>> >> ---
>> >>=C2=A0 ...ace-Fix-out-of-bounds-array-access-warnin.patch = | 50
>> >> ++++++++++++++++++++++
>> >>=C2=A0 meta/recipes-kernel/linux/linux-yocto_4.4.bb=C2= =A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 4 +-
>> >>=C2=A0 2 files changed, 53 insertions(+), 1 deletion(-) >> >>=C2=A0 create mode 100644
>> >>
>> >> meta/recipes-kernel/linux/linux-yocto/0001-powerpc-ptrace= -Fix-out-of-bounds-array-access-warnin.patch
>> >>
>> >> diff --git
>> >>
>> >> a/meta/recipes-kernel/linux/linux-yocto/0001-powerpc-ptra= ce-Fix-out-of-bounds-array-access-warnin.patch
>> >>
>> >> b/meta/recipes-kernel/linux/linux-yocto/0001-powerpc-ptra= ce-Fix-out-of-bounds-array-access-warnin.patch
>> >> new file mode 100644
>> >> index 0000000..05315ed
>> >> --- /dev/null
>> >> +++
>> >>
>> >> b/meta/recipes-kernel/linux/linux-yocto/0001-powerpc-ptra= ce-Fix-out-of-bounds-array-access-warnin.patch
>> >> @@ -0,0 +1,50 @@
>> >> +From 32acc1d9a5738b02e8815047af8886978aa40ead Mon Sep 17= 00:00:00 2001
>> >> +From: Khem Raj <raj.khem@gmail.com>
>> >> +Date: Mon, 25 Apr 2016 05:47:01 +0000
>> >> +Subject: [PATCH V2] powerpc/ptrace: Fix out of bounds ar= ray access
>> >> warning
>> >> +
>> >> +gcc-6 correctly warns about a out of bounds access
>> >> +
>> >> +arch/powerpc/kernel/ptrace.c:407:24: warning: index 32 d= enotes an
>> >> offset
>> >> greater than size of 'u64[32][1] {aka long long unsig= ned int[32][1]}'
>> >> [-Warray-bounds]
>> >> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 offsetof(struct thread_fp_st= ate, fpr[32][0]));
>> >> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 ^
>> >> +
>> >> +check the end of array instead of beginning of next elem= ent to fix
>> >> this
>> >> +
>> >> +Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> >> +Cc: Kees Cook <keescook@chromium.org>
>> >> +Cc: Michael Ellerman <mpe@ellerman.id.au>
>> >> +Cc: Segher Boessenkool <segher@kernel.crashing.org>
>> >> +---
>> >> +Changes from v1 to v2:
>> >> +
>> >> +- Check for fpr[32] instead of fpr[31][1]
>> >> +
>> >> + arch/powerpc/kernel/ptrace.c | 4 ++--
>> >> + 1 file changed, 2 insertions(+), 2 deletions(-)
>> >> +
>> >> +diff --git a/arch/powerpc/kernel/ptrace.c
>> >> b/arch/powerpc/kernel/ptrace.c
>> >> +index 737c0d0..b38fd08 100644
>> >> +--- a/arch/powerpc/kernel/ptrace.c
>> >> ++++ b/arch/powerpc/kernel/ptrace.c
>> >> +@@ -376,7 +376,7 @@ static int fpr_get(struct task_struc= t *target,
>> >> const
>> >> struct user_regset *regset,
>> >> +
>> >> + #else
>> >> +=C2=A0 =C2=A0 =C2=A0 =C2=A0BUILD_BUG_ON(offsetof(struct = thread_fp_state, fpscr) !=3D
>> >> +-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0offsetof(struct thread_fp_state, fpr[32][0]));
>> >> ++=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0offsetof(struct thread_fp_state, fpr[32]));
>> >> +
>> >> +=C2=A0 =C2=A0 =C2=A0 =C2=A0return user_regset_copyout(&a= mp;pos, &count, &kbuf, &ubuf,
>> >> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 &target-= >thread.fp_state, 0, -1);
>> >> +@@ -404,7 +404,7 @@ static int fpr_set(struct task_struc= t *target,
>> >> const
>> >> struct user_regset *regset,
>> >> +=C2=A0 =C2=A0 =C2=A0 =C2=A0return 0;
>> >> + #else
>> >> +=C2=A0 =C2=A0 =C2=A0 =C2=A0BUILD_BUG_ON(offsetof(struct = thread_fp_state, fpscr) !=3D
>> >> +-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0offsetof(struct thread_fp_state, fpr[32][0]));
>> >> ++=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0offsetof(struct thread_fp_state, fpr[32]));
>> >> +
>> >> +=C2=A0 =C2=A0 =C2=A0 =C2=A0return user_regset_copyin(&am= p;pos, &count, &kbuf, &ubuf,
>> >> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&target-&= gt;thread.fp_state, 0, -1);
>> >> +--
>> >> +1.9.1
>> >> +
>> >> diff --git a/meta/recipes-kernel/linux/linux-yocto_4.4.bb=
>> >> b/meta/recipes-kernel/linux/linux-yocto_4.4.bb
>> >> index b74903e..fbb592a 100644
>> >> --- a/meta/recipes-kernel/linux/linux-yocto_4.4.bb >> >> +++ b/meta/recipes-kernel/linux/linux-yocto_4.4.bb >> >> @@ -22,7 +22,9 @@ SRCREV_machine ?=3D
>> >> "b18090556c1d1b449233cd555c27a04d38272d6d"
>> >>=C2=A0 SRCREV_meta ?=3D "9ab4787fe2aea2ae0fcc31a5e067= eaba19ef64c8"
>> >>
>> >>=C2=A0 SRC_URI =3D
>> >>
>> >> "git://git.yoctoproject.org/linux-yocto-4.4.git;name=3Dmachine;branch= =3D${KBRANCH};
>> >> \
>> >> -
>> >>
>> >> git://git.yoctoproject.org/yocto-kernel-cache= ;type=3Dkmeta;name=3Dmeta;branch=3Dyocto-4.4;destsuffix=3D${KMETA}"= ;
>> >> +
>> >>
>> >> git://git.yoctoproject.org/yocto-kernel-cache= ;type=3Dkmeta;name=3Dmeta;branch=3Dyocto-4.4;destsuffix=3D${KMETA}
>> >> \
>> >> +
>> >> file://0001-powerpc-ptrace-Fix-out-of-bounds-array-access= -warnin.patch
>> >> \
>> >> +"
>> >>
>> >>=C2=A0 LINUX_VERSION ?=3D "4.4.3"
>> >>
>> >> --
>> >> 2.8.2
>> >>
>> >> --
>> >> _______________________________________________
>> >> Openembedded-core mailing list
>> >> Openembedded-core@lists.openembedded.org
>> >> http://lists.opene= mbedded.org/mailman/listinfo/openembedded-core
>> >
>> >
>> >
>> >
>> > --
>> > "Thou shalt not follow the NULL pointer, for chaos and m= adness await
>> > thee at
>> > its end"
>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness aw= ait thee at
> its end"



--
=
"Thou shalt not follow the NULL pointer= , for chaos and madness await thee at its end"
--001a113dffc07b57f105329da25f--