From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f176.google.com (mail-qk0-f176.google.com [209.85.220.176]) by mail.openembedded.org (Postfix) with ESMTP id 1A9597810B for ; Thu, 25 May 2017 12:01:43 +0000 (UTC) Received: by mail-qk0-f176.google.com with SMTP id y201so175015884qka.0 for ; Thu, 25 May 2017 05:01:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=4jVy3KUO3Wm1HTFybhrV8V170gg9TJOeoU5vBJytAOU=; b=tYKMkGvSTjXBKEpzPCb110z4mVKwc6Ji1kZMetFPS4Gj4093EzLTGnAILNLtbhp2/R 5V0HxSHUzsbUkqsx1t4ZCbW28mA1bemtx8ivaI47Wmaok4bo8CkTfm+ZwDKeZiehECpl adEmPdKuxk7WGhcx7rINz720KcZ25TvTHimxUMAJQo2GQFUaXBM+sZ8RpeYrYc8fG/WJ lyAw7Pe5Zec2ca8Z6Oo2/tMmD0fUcKqtDPzaJFxNPd+ZqDTOzA3Roz7TOHO71Radkaht Z2dd2T11T8P5O4+9Ji/uf+CmQyCDpY9WC8stMFPqAZ33rHJSHQSSLUZlVLOl4eolbPX7 yGqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=4jVy3KUO3Wm1HTFybhrV8V170gg9TJOeoU5vBJytAOU=; b=c9j6GqXNBR6nou/CLyiF1Wks33Cm+Whel2B3PKghiR8DgqLPmUm0u7yuRideY3F77u CZEInMxtolv/Xs9LkWL0nCw70i2cSKRJ9jcMFuMP3EwtL9nUU/73LDRiD1USpJdHZLzy L2mDP2f+JRP4zoGI6VXny185Z83pU69Zzwm6pmS8MHjgpXNCfT9dsBvLWbVxd0e7IeuY ViwpULfNkc3tEfCFxwbnsyV7Z1l3Pkv8Po99leZ338sQRwM4rsnxylvO5LycxuxUp20e HaroNpByRJGqj5flasK+7QIAOFnvNyWQGyK65nWXcAtn5ctkdIWy6a2/woJUJqIbxei7 4MaA== X-Gm-Message-State: AODbwcDApOn85oVdQdLXigJYZ7nDDqpl/qIEhD35ioYPRPfLe2FTBlks /W0f57eQJWyZJhCxU2kf60IjxlJ1Jg== X-Received: by 10.55.118.199 with SMTP id r190mr36371880qkc.43.1495713704744; Thu, 25 May 2017 05:01:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.182.109 with HTTP; Thu, 25 May 2017 05:01:44 -0700 (PDT) In-Reply-To: References: <20170522050042.42403-1-raj.khem@gmail.com> <20170522050042.42403-11-raj.khem@gmail.com> From: Bruce Ashfield Date: Thu, 25 May 2017 08:01:44 -0400 Message-ID: To: Khem Raj Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 11/15] linux-yocto: Enable drm by default X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 May 2017 12:01:45 -0000 Content-Type: multipart/alternative; boundary="94eb2c05e3640e9d08055057fc0c" --94eb2c05e3640e9d08055057fc0c Content-Type: text/plain; charset="UTF-8" On Wed, May 24, 2017 at 10:46 PM, Khem Raj wrote: > On Wed, May 24, 2017 at 7:40 PM, Bruce Ashfield > wrote: > > > > > > On Tue, May 23, 2017 at 3:36 PM, Bruce Ashfield < > bruce.ashfield@gmail.com> > > wrote: > >> > >> > >> > >> On Mon, May 22, 2017 at 1:06 PM, Khem Raj wrote: > >>> > >>> >> +SRC_URI += "file://drm.cfg" > >>> > > >>> > > >>> > > >>> > If anything gets added to the default configurations, they need to go > >>> > into > >>> > the kernel-cache > >>> > and then be included by the relevant kernel types there. > >>> > > >>> > If you want, I can take care of switching things to that format. > >>> > > >>> > >>> yes please. > >> > >> > >> Will do. I'll make it available to all active kernel versions + future > >> ones. > > > > > > As it turns out, we already have a similar fragment for vmware guests: > > > > cfg/vmware-guest.cfg > > > > -------------------- > > > > CONFIG_VMWARE_BALLOON=m > > > > CONFIG_VMWARE_PVSCSI=y > > > > CONFIG_VMWARE_VMCI=m > > > > CONFIG_VSOCKETS=m > > > > CONFIG_VMWARE_VMCI_VSOCKETS=m > > > > CONFIG_VMXNET3=y > > > > CONFIG_DRM_VMWGFX=m > > > > CONFIG_DRM_VMWGFX_FBCON=y > > > > CONFIG_FUSION=y > > > > CONFIG_FUSION_SPI=y > > > > CONFIG_FUSION_FC=y > > > > CONFIG_FUSION_SAS=y > > > > CONFIG_FUSION_MAX_SGE=128 > > > > CONFIG_FUSION_CTL=y > > > > CONFIG_FUSION_LAN=y > > > > CONFIG_FUSION_LOGGING=y > > > > CONFIG_SCSI_MPT2SAS=y > > > > CONFIG_SCSI_MPT2SAS_MAX_SGE=128 > > > > CONFIG_SCSI_MPT2SAS_LOGGING=y > > > > CONFIG_SCSI_MPT3SAS=y > > > > CONFIG_SCSI_MPT3SAS_MAX_SGE=128 > > > > CONFIG_SCSI_MPT3SAS_LOGGING=y > > > > ------------- > > > > To stay consistent with that naming, I'll call this > virtual-box-guest.cfg, > > and it can be enabled > > via KERNEL_FEATURES when needed. > > > > I'm hesitant to globally enable it, since we don't need those modules on > all > > linux-yocto > > kernels, just ones that are going to run on virtual box. > > > > I could enable them for qemux86*, since those already have virtio configs > > enabled by > > default and these have a similar goal. > > > > Thoughts ? I'd like to make sure that sounds reasonable, before spending > the > > time to > > make the changes and test. > > > > I would suggest to enable them by default since these are modules they > dont impact the size of kernel itself. Then we can use recommends to > choose them in machine configs. > We've never done that before, there's hundreds of modules we could turn on just in case, but instead only enable them for machines that can actually use them. Many users use the meta package for modules and expect the build to be as minimal as possible. So I'm balancing both those use cases. I'll complete the fragment and we can enable it in a second commit to keep the options open. Bruce > > > Bruce > > > >> > >> Cheers, > >> > >> Bruce > >> > >> > >> > >> -- > >> "Thou shalt not follow the NULL pointer, for chaos and madness await > thee > >> at its end" > > > > > > > > > > -- > > "Thou shalt not follow the NULL pointer, for chaos and madness await > thee at > > its end" > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" --94eb2c05e3640e9d08055057fc0c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, May 24, 2017 at 10:46 PM, Khem Raj <raj.khem@gmail.com>= ; wrote:
On Wed, May 24, 2017 at 7= :40 PM, Bruce Ashfield
<bruc= e.ashfield@gmail.com> wrote:
>
>
> On Tue, May 23, 2017 at 3:36 PM, Bruce Ashfield <bruce.ashfield@gmail.com>
> wrote:
>>
>>
>>
>> On Mon, May 22, 2017 at 1:06 PM, Khem Raj <raj.khem@gmail.com> wrote:
>>>
>>> >> +SRC_URI +=3D "file://drm.cfg"
>>> >
>>> >
>>> >
>>> > If anything gets added to the default configurations, the= y need to go
>>> > into
>>> > the kernel-cache
>>> > and then be included by the relevant kernel types there.<= br> >>> >
>>> > If you want, I can take care of switching things to that = format.
>>> >
>>>
>>> yes please.
>>
>>
>> Will do. I'll make it available to all active kernel versions = + future
>> ones.
>
>
> As it turns out, we already have a similar fragment for vmware guests:=
>
> cfg/vmware-guest.cfg
>
> --------------------
>
> CONFIG_VMWARE_BALLOON=3Dm
>
> CONFIG_VMWARE_PVSCSI=3Dy
>
> CONFIG_VMWARE_VMCI=3Dm
>
> CONFIG_VSOCKETS=3Dm
>
> CONFIG_VMWARE_VMCI_VSOCKETS=3Dm
>
> CONFIG_VMXNET3=3Dy
>
> CONFIG_DRM_VMWGFX=3Dm
>
> CONFIG_DRM_VMWGFX_FBCON=3Dy
>
> CONFIG_FUSION=3Dy
>
> CONFIG_FUSION_SPI=3Dy
>
> CONFIG_FUSION_FC=3Dy
>
> CONFIG_FUSION_SAS=3Dy
>
> CONFIG_FUSION_MAX_SGE=3D128
>
> CONFIG_FUSION_CTL=3Dy
>
> CONFIG_FUSION_LAN=3Dy
>
> CONFIG_FUSION_LOGGING=3Dy
>
> CONFIG_SCSI_MPT2SAS=3Dy
>
> CONFIG_SCSI_MPT2SAS_MAX_SGE=3D128
>
> CONFIG_SCSI_MPT2SAS_LOGGING=3Dy
>
> CONFIG_SCSI_MPT3SAS=3Dy
>
> CONFIG_SCSI_MPT3SAS_MAX_SGE=3D128
>
> CONFIG_SCSI_MPT3SAS_LOGGING=3Dy
>
> -------------
>
> To stay consistent with that naming, I'll call this virtual-box-gu= est.cfg,
> and it can be enabled
> via KERNEL_FEATURES when needed.
>
> I'm hesitant to globally enable it, since we don't need those = modules on all
> linux-yocto
> kernels, just ones that are going to run on virtual box.
>
> I could enable them for qemux86*, since those already have virtio conf= igs
> enabled by
> default and these have a similar goal.
>
> Thoughts ? I'd like to make sure that sounds reasonable, before sp= ending the
> time to
> make the changes and test.
>

I would suggest to enable them by default since these are modul= es they
dont impact the size of kernel itself. Then we can use recommends to
choose them in machine configs.

We'= ve never done that before, there's hundreds of modules we could turn on= =C2=A0
just in case, but instead only enable them for machines th= at can actually use
them.

Many users use= the meta package for modules and expect the build to be as
minim= al as possible.

So I'm balancing both those us= e cases.

I'll complete the fragment and we can= enable it in a second commit to keep the
options open.

Bruce
=C2=A0

> Bruce
>
>>
>> Cheers,
>>
>> Bruce
>>
>>
>>
>> --
>> "Thou shalt not follow the NULL pointer, for chaos and madnes= s await thee
>> at its end"
>
>
>
>
> --
> "Thou shalt not follow the NULL pointer, for chaos and madness aw= ait thee at
> its end"



--
=
"Tho= u shalt not follow the NULL pointer, for chaos and madness await thee at it= s end"
--94eb2c05e3640e9d08055057fc0c--