Re: [PATCH] [OE-core] [PATCHv2] systemtap: upgrade 4.3 -> 4.4

["Bruce Ashfield" <bruce.ashfield@gmail.com>]

On Fri, Dec 18, 2020 at 12:07 PM Bruce Ashfield via
lists.openembedded.org
<bruce.ashfield=gmail.com@lists.openembedded.org> wrote:
>
> On Tue, Dec 8, 2020 at 12:56 PM Bruce Ashfield via
> lists.openembedded.org
> <bruce.ashfield=gmail.com@lists.openembedded.org> wrote:
> >
> > If that symbol is required, then we'd need to add it to the
> > appropriate fragment in the
> > reference kernel configurations (kernel-cache), and make sure it is
> > built into the
> > various kernel types.
> >
> > Changes like that are submitted to the linux-yocto mailing list.
> >
> > That being said, I went and looked at the error, and the .c that
> > defines the missing
> > symbol is security.c, which is controlled by CONFIG_SECURITY, not
> > CONFIG_SECURITY_LOCKDOWN_LSM. And that option is already enabled in
> > all kernel types.
> >
> > It looks more like a missing .h, versus a missing option to me.
> >
> > Have you looked at the systemtap source for an include of security.h,
> > and traced why
> > it wouldn't be finding the function definition ?
> >
> > If this is the on-target build, versus a cross build test, then maybe
> > we are missing the
> > copy of a .h to the target (but you'd think that we'd get a more
> > obvious compile error
> > if a .h wasn't found).
>
>
> FYI. My 5.10 kernel testing has run into this issue, so I've grabbed
> the uprev patch and am working on a fix.
>
> If someone else already has it done, let me know and I'll happily take
> their fix :D

I have this fixed, and will include it in my next pull request:

root@qemux86-64:/tmp# stap --disable-cache -DSTP_NO_VERREL_CHECK /tmp/hello.stp
[   99.940036] Kprobes globally unoptimized
[   99.942537] stap_4280: loading out-of-tree module taints kernel.
hello world

root@qemux86-64:/tmp# uname -a
Linux qemux86-64 5.10.1-yocto-standard #1 SMP PREEMPT Thu Dec 17
17:33:21 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Bruce

>
> Bruce
>
> >
> > Bruce
> >
> > On Mon, Dec 7, 2020 at 10:03 PM zangrc <zangrc.fnst@cn.fujitsu.com> wrote:
> > >
> > > Ping
> > >
> > >
> > >
> > > From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of zangrc
> > > Sent: Friday, December 4, 2020 9:51 AM
> > > To: Leonardo Sandoval <leonardo.sandoval@linaro.org>
> > > Cc: openembedded-core@lists.openembedded.org
> > > Subject: Re: [PATCH] [OE-core] [PATCHv2] systemtap: upgrade 4.3 -> 4.4
> > >
> > >
> > >
> > > I think this problem should be because the kernel does not enable CONFIG_SECURITY_LOCKDOWN_LSM,
> > >
> > > do you need me to submit a patch to open this option of the kernel?
> > >
> > >
> > >
> > > Zangrc
> > >
> > >
> > >
> > > From: Zang, Ruochen/臧 若尘
> > > Sent: Thursday, November 26, 2020 2:18 PM
> > > To: 'Leonardo Sandoval' <leonardo.sandoval@linaro.org>
> > > Cc: openembedded-core@lists.openembedded.org
> > > Subject: RE: [PATCH] [OE-core] [PATCHv2] systemtap: upgrade 4.3 -> 4.4
> > >
> > >
> > >
> > > I will investigate, it may take some time, if the error is resolved, I will send a patch to the mailing list.
> > >
> > >
> > >
> > > zangrc
> > >
> > >
> > >
> > > From: Leonardo Sandoval <leonardo.sandoval@linaro.org>
> > > Sent: Thursday, November 26, 2020 6:09 AM
> > > To: Zang, Ruochen/臧 若尘 <zangrc.fnst@cn.fujitsu.com>
> > > Cc: openembedded-core@lists.openembedded.org
> > > Subject: Re: [PATCH] [OE-core] [PATCHv2] systemtap: upgrade 4.3 -> 4.4
> > >
> > >
> > >
> > > Hi Zangrc,
> > >
> > >
> > >
> > > this patch is now in master-next
> > >
> > >
> > >
> > >   https://patchwork.openembedded.org/series/27030/
> > >
> > >
> > >
> > > but autobuilder detected a compilation error in the upgraded version
> > >
> > >
> > >
> > >   https://autobuilder.yoctoproject.org/typhoon/#/builders/61/builds/2736/steps/13/logs/stdio
> > >
> > >
> > >
> > > Can you please take a look? (seems like a C macro is not defined).
> > >
> > >
> > >
> > > Thanks,
> > >
> > >
> > >
> > > lsg
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > On Mon, 23 Nov 2020 at 20:08, zangrc <zangrc.fnst@cn.fujitsu.com> wrote:
> > >
> > > The test log of oe-selftest is as follows:
> > > 2020-11-23 15:48:49,144 - oe-selftest - INFO - test_crosstap_helloworld (runtime_test.SystemTap)
> > > 2020-11-23 17:06:55,949 - oe-selftest - INFO -  ... ok
> > > 2020-11-23 17:06:55,951 - oe-selftest - INFO - test_crosstap_pstree (runtime_test.SystemTap)
> > > 2020-11-23 17:08:07,921 - oe-selftest - INFO -  ... ok
> > > 2020-11-23 17:08:07,922 - oe-selftest - INFO - test_crosstap_syscalls_by_pid (runtime_test.SystemTap)
> > > 2020-11-23 17:09:20,084 - oe-selftest - INFO -  ... ok
> > > 2020-11-23 17:09:20,085 - oe-selftest - INFO - test_crosstap_syscalls_by_proc (runtime_test.SystemTap)
> > > 2020-11-23 17:10:31,349 - oe-selftest - INFO -  ... ok
> > > 2020-11-23 17:12:58,052 - oe-selftest - INFO - ----------------------------------------------------------------------
> > > 2020-11-23 17:12:58,054 - oe-selftest - INFO - Ran 4 tests in 5051.537s
> > > 2020-11-23 17:12:58,054 - oe-selftest - INFO - OK
> > > 2020-11-23 17:13:08,416 - oe-selftest - INFO - RESULTS:
> > > 2020-11-23 17:13:08,417 - oe-selftest - INFO - RESULTS - runtime_test.SystemTap.test_crosstap_helloworld: PASSED (4686.81s)
> > > 2020-11-23 17:13:08,418 - oe-selftest - INFO - RESULTS - runtime_test.SystemTap.test_crosstap_pstree: PASSED (71.97s)
> > > 2020-11-23 17:13:08,418 - oe-selftest - INFO - RESULTS - runtime_test.SystemTap.test_crosstap_syscalls_by_pid: PASSED (72.16s)
> > > 2020-11-23 17:13:08,418 - oe-selftest - INFO - RESULTS - runtime_test.SystemTap.test_crosstap_syscalls_by_proc: PASSED (71.26s)
> > > 2020-11-23 17:13:08,432 - oe-selftest - INFO - SUMMARY:
> > > 2020-11-23 17:13:08,432 - oe-selftest - INFO - oe-selftest () - Ran 4 tests in 5051.540s
> > > 2020-11-23 17:13:08,432 - oe-selftest - INFO - oe-selftest - OK - All required tests passed (successes=4, skipped=0, failures=0, errors=0)
> > >
> > > Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com>
> > > ---
> > >  meta/recipes-kernel/systemtap/systemtap_git.inc | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta/recipes-kernel/systemtap/systemtap_git.inc b/meta/recipes-kernel/systemtap/systemtap_git.inc
> > > index 56fa51d61e..ae735025b7 100644
> > > --- a/meta/recipes-kernel/systemtap/systemtap_git.inc
> > > +++ b/meta/recipes-kernel/systemtap/systemtap_git.inc
> > > @@ -1,7 +1,7 @@
> > >  LICENSE = "GPLv2"
> > >  LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
> > > -SRCREV = "82b8e1a07a31bf37ed05d6ebc5162b054c0be9fd"
> > > -PV = "4.3"
> > > +SRCREV = "988f439af39a359b4387963ca4633649866d8275"
> > > +PV = "4.4"
> > >
> > >  SRC_URI = "git://sourceware.org/git/systemtap.git \
> > >             file://0001-Do-not-let-configure-write-a-python-location-into-th.patch \
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
> > --
> > - Thou shalt not follow the NULL pointer, for chaos and madness await
> > thee at its end
> > - "Use the force Harry" - Gandalf, Star Trek II
> >
> >
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
> 
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II