Re: [meta-virtualization][PATCH v2 1/3] xen, xen-tools: add recommendation for Qemu for non-hvm x86

[Bruce Ashfield <bruce.ashfield@gmail.com>]

On Fri, Apr 29, 2022 at 9:23 AM Bertrand Marquis
<Bertrand.Marquis@arm.com> wrote:
>
> Hi Christopher,
>
> > On 28 Apr 2022, at 01:06, Christopher Clark via lists.yoctoproject.org <christopher.w.clark=gmail.com@lists.yoctoproject.org> wrote:
> >
> > The Spectre and Meltdown mitigations for Xen run PV guests within
> > HVM virtual machines, so Qemu is no longer only needed for systems
> > configured to run HVM guests.
> >
> > With the split xen hypervisor and tools recipes, the bios dependencies
> > belong in the tools recipe, so move them and replace the hvm
> > PACKAGECONFIG option with the recommendation based on target arch.
> >
> > Signed-off-by: Christopher Clark <christopher.clark@starlab.io>
> Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
>
> I can build and run on x86 qemu and I get stuck during init in Dom0 (which is apparently already known).
>

It is likely the xencommond init.d still causing issues.

I'm doing a revert of all those changes locally, and will start some tests.

Bruce

> Cheers
> Bertrand
>
>
> > ---
> > Unchanged since v1
> >
> > recipes-extended/xen/xen-tools.inc | 9 ++-------
> > recipes-extended/xen/xen.inc       | 6 +++---
> > 2 files changed, 5 insertions(+), 10 deletions(-)
> >
> > diff --git a/recipes-extended/xen/xen-tools.inc b/recipes-extended/xen/xen-tools.inc
> > index 6bbc8cd..54bc477 100644
> > --- a/recipes-extended/xen/xen-tools.inc
> > +++ b/recipes-extended/xen/xen-tools.inc
> > @@ -30,14 +30,9 @@ RDEPENDS:${PN} = "\
> >
> > RDEPENDS:${PN}-dev = ""
> >
> > -# Qemu is necessary on ARM platforms, and to support HVM guests on x86
> > -QEMU = "${@bb.utils.contains('PACKAGECONFIG', 'hvm', 'qemu', '', d)}"
> > -QEMU:arm = "qemu"
> > -QEMU:aarch64 = "qemu"
> > -
> > RRECOMMENDS:${PN} = " \
> > -    ${QEMU} \
> > -    ${@bb.utils.contains('PACKAGECONFIG', 'hvm', 'seabios', '', d)} \
> > +    qemu \
> > +    ${@bb.utils.contains('XEN_TARGET_ARCH', 'x86_64', 'seabios ipxe vgabios', '', d)} \
> >     ${@bb.utils.contains('PACKAGECONFIG', 'externalblktap', '', '${BLKTAP_RRECOMMENDS}', d)} \
> >     ${PN}-flask \
> >     ${PN}-hvmloader \
> > diff --git a/recipes-extended/xen/xen.inc b/recipes-extended/xen/xen.inc
> > index 8b86de5..4c38ccf 100644
> > --- a/recipes-extended/xen/xen.inc
> > +++ b/recipes-extended/xen/xen.inc
> > @@ -9,13 +9,11 @@ require xen-arch.inc
> > PACKAGECONFIG ??= " \
> >     sdl \
> >     ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)} \
> > -    ${@bb.utils.contains('XEN_TARGET_ARCH', 'x86_64', 'hvm', '', d)} \
> >     "
> >
> > PACKAGECONFIG[sdl] = "--enable-sdl,--disable-sdl,virtual/libsdl,"
> > PACKAGECONFIG[xsm] = "--enable-xsmpolicy,--disable-xsmpolicy,checkpolicy-native,"
> > PACKAGECONFIG[systemd] = "--enable-systemd,--disable-systemd,systemd,"
> > -PACKAGECONFIG[hvm] = "--with-system-seabios="/usr/share/firmware/bios.bin",--disable-seabios,seabios ipxe vgabios,"
> > PACKAGECONFIG[externalblktap] = ",,,"
> >
> > DEPENDS = " \
> > @@ -132,7 +130,9 @@ EXTRA_OECONF += " \
> >     --disable-rombios \
> >     --disable-ocamltools \
> >     --disable-qemu-traditional \
> > -    ${@bb.utils.contains('XEN_TARGET_ARCH', 'x86_64', '--enable-pvshim', '--disable-pvshim', d)} \
> > +    ${@bb.utils.contains('XEN_TARGET_ARCH', 'x86_64', \
> > +        '--enable-pvshim --with-system-seabios="/usr/share/firmware/bios.bin"', \
> > +        '--disable-pvshim --disable-seabios', d)} \
> >     "
> >
> > EXTRA_OEMAKE += "STDVGA_ROM=${STAGING_DIR_HOST}/usr/share/firmware/vgabios-0.7a.bin"
> > --
> > 2.25.1
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#7226): https://lists.yoctoproject.org/g/meta-virtualization/message/7226
> > Mute This Topic: https://lists.yoctoproject.org/mt/90743682/3619089
> > Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> > Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bertrand.marquis@arm.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
>
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.



-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II