All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Andrei Gherzan <andrei@gherzan.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>,
	Andrei Gherzan <andrei.gherzan@huawei.com>
Subject: Re: [OE-core] [PATCH 1/1] go.bbclass: Allow network in do_compile
Date: Mon, 28 Feb 2022 20:17:41 -0500	[thread overview]
Message-ID: <CADkTA4N+Frh96ZEbdDVKgJFKKhH0-m8YXOxHaYHhKSM7p1pKxg@mail.gmail.com> (raw)
In-Reply-To: <20220228235433.3948994-1-andrei@gherzan.com>

On Mon, Feb 28, 2022 at 6:54 PM Andrei Gherzan <andrei@gherzan.com> wrote:
>
> From: Andrei Gherzan <andrei.gherzan@huawei.com>
>
> Compile pulls in the go.mod list requiring network. Without this, do
> compile would fail with a similar error to the following:
>
> dial tcp: lookup proxy.golang.org: Temporary failure in name resolution

This is something that needs to be carried in your own layers, IMHO it
isn't appropriate for core.

It isn't about the fetching, it is the entire gap in functionality
that we are missing if go starts fetching dependencies during compile.

Bruce

>
> Signed-off-by: Andrei Gherzan <andrei.gherzan@huawei.com>
> ---
>  meta/classes/go.bbclass | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/classes/go.bbclass b/meta/classes/go.bbclass
> index 9c4c92bffd..dc246c72cb 100644
> --- a/meta/classes/go.bbclass
> +++ b/meta/classes/go.bbclass
> @@ -113,6 +113,7 @@ go_do_compile() {
>  }
>  do_compile[dirs] =+ "${GOTMPDIR}"
>  do_compile[cleandirs] = "${B}/bin ${B}/pkg"
> +do_compile[network] = "1"
>
>  go_do_install() {
>         install -d ${D}${libdir}/go/src/${GO_IMPORT}
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#162517): https://lists.openembedded.org/g/openembedded-core/message/162517
> Mute This Topic: https://lists.openembedded.org/mt/89464905/1050810
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


  reply	other threads:[~2022-03-01  1:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-28 23:54 [PATCH 1/1] go.bbclass: Allow network in do_compile Andrei Gherzan
2022-03-01  1:17 ` Bruce Ashfield [this message]
     [not found] ` <16D81CEE77B62019.3953@lists.openembedded.org>
2022-03-01  1:55   ` [OE-core] " Bruce Ashfield
2022-03-01 11:42     ` Andrei Gherzan
2022-03-01 12:22       ` Richard Purdie
2022-03-01 13:14       ` Bruce Ashfield
2022-03-01 15:54         ` lukas.funke
2022-03-01 19:50           ` [OE-core] " Khem Raj
2022-03-01 20:15           ` Bruce Ashfield
2022-03-02 21:57             ` Andrei Gherzan
2022-03-03  3:34               ` Bruce Ashfield
2022-03-03 12:28                 ` Andrei Gherzan
2022-03-03 15:13                 ` lukas.funke
2022-03-03 16:46                   ` [OE-core] " Bruce Ashfield
2022-03-09  8:10                     ` lukas.funke
2022-03-09 18:43                       ` [OE-core] " Bruce Ashfield
2022-03-11 14:44                         ` lukas.funke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADkTA4N+Frh96ZEbdDVKgJFKKhH0-m8YXOxHaYHhKSM7p1pKxg@mail.gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=andrei.gherzan@huawei.com \
    --cc=andrei@gherzan.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.