Re: [PATCH 2/2] kernel-module-split: modules should recommend the kernel image

[Bruce Ashfield <bruce.ashfield@gmail.com>]

On Wed, Feb 9, 2022 at 12:30 PM Ross Burton <ross.burton@arm.com> wrote:
>
> Currently each split-out kernel module RDEPENDS on the top-level kernel
> package (e.g. kernel-5.15-yocto-standard). Whilst at first this seems
> correct, as modules obviously need their matching kernel, there are many
> situations where the kernel is provided out-of-band and forcing the
> kernel in via RDEPENDS in the wrong thing to do, for example an
> initramfs really shouldn't contain a kernel image, but can contain
> kernel modules.
>
> Change the module splitting logic to use RRECOMMENDS instead of
> RDEPENDS, and tighten the dependency to kernel-image instead of kernel
> to pull in just the image, which also means PACKAGE_EXCLUDE =
> "kernel-image-*" is sufficient to ensure the image doesn't get pulled
> into an image.
>

As much as I hate to suggest it, I think the strength of the image
dependency needs to be configurable. I know of situations were
rrecommends are disabled AND they use quite a few out of tree
modules. While I can't say that they are counting on RDEPENDS
heavily in this situation, I also can't rule it out .. so this is a breaking
change in behaviour for those configurations.

That being said, if RP doesn't want/like a conditional at this particular
spot, I can understand that as well .. and am happy to be ignored
in that case :)

Bruce

> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta/classes/kernel-module-split.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel-module-split.bbclass b/meta/classes/kernel-module-split.bbclass
> index a29c294810e..4429fee4b51 100644
> --- a/meta/classes/kernel-module-split.bbclass
> +++ b/meta/classes/kernel-module-split.bbclass
> @@ -175,7 +175,7 @@ python split_kernel_module_packages () {
>      module_pattern_suffix = d.getVar('KERNEL_MODULE_PACKAGE_SUFFIX')
>      module_pattern = module_pattern_prefix + kernel_package_name + '-module-%s' + module_pattern_suffix
>
> -    modules = do_split_packages(d, root='${nonarch_base_libdir}/modules', file_regex=module_regex, output_pattern=module_pattern, description='%s kernel module', postinst=postinst, postrm=postrm, recursive=True, hook=frob_metadata, extra_depends='%s-%s' % (kernel_package_name, kernel_version))
> +    modules = do_split_packages(d, root='${nonarch_base_libdir}/modules', file_regex=module_regex, output_pattern=module_pattern, description='%s kernel module', postinst=postinst, postrm=postrm, recursive=True, hook=frob_metadata, extra_recommends='%s-image-%s' % (kernel_package_name, kernel_version))
>      if modules:
>          d.appendVar('RDEPENDS:' + metapkg, ' '+' '.join(modules))
>
> --
> 2.25.1
>


--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II