Re: [meta-realtime][PATCH] layer.conf: set LAYERSERIES_COMPAT with honister

From: "Bruce Ashfield" <bruce.ashfield@gmail.com>
To: Kai <kai.kang@windriver.com>
Cc: Yocto Project Discussion <yocto@yoctoproject.org>
Subject: Re: [meta-realtime][PATCH] layer.conf: set LAYERSERIES_COMPAT with honister
Date: Fri, 4 Jun 2021 08:27:18 -0400	[thread overview]
Message-ID: <CADkTA4NLc6OHOjPrhvEyCp=s15JHZK4yRkU1EoRD=W-Pg3ApbA@mail.gmail.com> (raw)
In-Reply-To: <8a264bd7-49f4-1672-55b6-e97be9556ccd@windriver.com>

On Thu, Jun 3, 2021 at 11:35 PM Kai <kai.kang@windriver.com> wrote:
>
> On 6/4/21 11:22 AM, Bruce Ashfield wrote:
> > On Thu, Jun 3, 2021 at 11:06 PM <kai.kang@windriver.com> wrote:
> >> From: Kai Kang <kai.kang@windriver.com>
> >>
> >> Replace hardknott with honister in layer.conf which aligns with
> >> oe-core.
> >>
> > I had added this back in April, but apparently didn't push the change.
> >
> > I also noticed that I've been updating the wrong branch with compatibility.
> >
> > That should all be fixed now.
>
> Hi Bruce,
>
> Thanks. I have seen your commits.
>
> But 3 items in LAYERSERIES_COMPAT_realtime will cause layer index show
> warning:
>
>    WARNING: YPCompatibleVersion.name: dunfell gatesgarth hardknott:
> length 28 exceeds maximum (25), truncating
>
> Could we only keep the latest LAYERSERIES_CORENAMES (honister) in branch
> master, please?

Nope. It is compatible with those releases, so they need to stay. I
see no valid reason to be limited to a certain number of characters.

>
> Or it set in oe-core's layer.conf:
>
> LAYERSERIES_CORENAMES = "hardknott honister"
>
> we just align with it to keep the latest 2, please?

That is just as arbitrary, I'll keep it as-is.

Bruce

>
> Regards,
> Kai
>
> >
> > Bruce
> >
> >> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> >> ---
> >>   conf/layer.conf | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/conf/layer.conf b/conf/layer.conf
> >> index 007f578..8ae67ba 100644
> >> --- a/conf/layer.conf
> >> +++ b/conf/layer.conf
> >> @@ -15,6 +15,6 @@ BBFILE_PRIORITY_realtime = "5"
> >>   # This should only be incremented on significant changes that will
> >>   # cause compatibility issues with other layers
> >>   LAYERVERSION_realtime = "1"
> >> -LAYERSERIES_COMPAT_realtime = "hardknott"
> >> +LAYERSERIES_COMPAT_realtime = "honister"
> >>   LAYERDEPENDS_realtime = "core openembedded-layer"
> >>   LAYERRECOMMENDS_realtime = "meta-realtime-dl (= 3.2)"
> >> --
> >> 2.17.1
> >>
> >
>
> --
> Kai Kang
> Wind River Linux
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II