From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: Saul Wold <Saul.Wold@windriver.com>,
Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>,
Joshua Watt <JPEWhacker@gmail.com>
Subject: Re: [OE-core] [RFC PATCH 2/3] kernel.bbclass: remove do_strip() method
Date: Sat, 8 Jan 2022 14:27:48 -0500 [thread overview]
Message-ID: <CADkTA4NYGboThC2b5=R6vw13HeGKOu93raMbgUk9iPUmwPSX+Q@mail.gmail.com> (raw)
In-Reply-To: <838c638d90097e11725f01f525178c70a15dfcd9.camel@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 1303 bytes --]
On Fri, Jan 7, 2022 at 6:19 PM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2022-01-07 at 13:24 -0800, Saul Wold wrote:
> > Move the do_strip() functionality to a more common location in the
> > package split_and_strip_files() flow. This makes it possible for the
> > extended packaging data to be generated correctly for the kernel and
> > kernel modules. The KERNEL_IMAGE_STRIP_EXTRA_SECTIONS is reused in
> > the runstrip() part of package stripping.
> >
> > Signed-off-by: Saul Wold <saul.wold@windriver.com>
> > ---
> > meta/classes/kernel.bbclass | 35 +++--------------------------------
> > 1 file changed, 3 insertions(+), 32 deletions(-)
>
> As I mentioned in previous mails, I think this will mean the do_deploy
> output
> will change and become unstripped which may cause a problem for some
> platforms.
>
> We likely need to keep a strip task but call the new strip function from
> it?
>
> I personally think this is a reasonable direction apart from that though,
> at
> least in principle.
>
Agreed. It looks ok to me as well, with us making sure that do_deploy can
remain as it was.
Bruce
>
> Cheers,
>
> Richard
>
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II
[-- Attachment #2: Type: text/html, Size: 2290 bytes --]
next prev parent reply other threads:[~2022-01-08 19:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-07 21:24 [RFC PATCH 0/3] Extend create-spdx to build kernel spdx info Saul Wold
2022-01-07 21:24 ` [RFC PATCH 1/3] create-spdx: Add kernel work-shared source Saul Wold
2022-01-07 21:24 ` [RFC PATCH 2/3] kernel.bbclass: remove do_strip() method Saul Wold
2022-01-07 23:19 ` [OE-core] " Richard Purdie
2022-01-08 19:27 ` Bruce Ashfield [this message]
2022-01-11 0:42 ` Saul Wold
2022-01-11 11:27 ` Richard Purdie
2022-01-11 21:05 ` Saul Wold
2022-01-07 21:24 ` [RFC PATCH 3/3] package: Add support for kernel stripping Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADkTA4NYGboThC2b5=R6vw13HeGKOu93raMbgUk9iPUmwPSX+Q@mail.gmail.com' \
--to=bruce.ashfield@gmail.com \
--cc=JPEWhacker@gmail.com \
--cc=Saul.Wold@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.