Re: Request to backport KERNEL_DTC_FLAGS to Dunfell

From: "Bruce Ashfield" <bruce.ashfield@gmail.com>
To: Steve Sakoman <steve@sakoman.com>
Cc: "Jonas Mark (BT-FIR/ENG1-Grb)" <Mark.Jonas@de.bosch.com>,
	 "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	 "ovidiu.panait@windriver.com" <ovidiu.panait@windriver.com>,
	 "richard.purdie@linuxfoundation.org"
	<richard.purdie@linuxfoundation.org>,
	 "toertel@gmail.com" <toertel@gmail.com>,
	 "RUAN Tingquan (BT-FIR/ENG1-Zhu)" <Tingquan.Ruan@cn.bosch.com>
Subject: Re: Request to backport KERNEL_DTC_FLAGS to Dunfell
Date: Fri, 4 Jun 2021 11:25:36 -0400	[thread overview]
Message-ID: <CADkTA4NkMjTjTJbp_6HCapzasyzrWGwQkBWuen7GWgNi4ppZbw@mail.gmail.com> (raw)
In-Reply-To: <CAOSpxdZQBmu8Da90W2h01ZMRD+s9GVP3Lvq-xsSrSjJJRuFeNA@mail.gmail.com>

On Fri, Jun 4, 2021 at 11:09 AM Steve Sakoman <steve@sakoman.com> wrote:
>
> On Fri, Jun 4, 2021 at 2:45 AM Jonas Mark (BT-FIR/ENG1-Grb)
> <Mark.Jonas@de.bosch.com> wrote:
> >
> > Hi,
> >
> > We are using DT overlays and have the need to pass the -@ parameter in DTC_FLAGS to Linux' make. The patch
> >
> > "kernel-devicetree: Introduce KERNEL_DTC_FLAGS to pass dtc flags"
> > https://git.openembedded.org/openembedded-core/commit/?h=hardknott&id=063b5de86624a42b0aa784db6dddc7552a6dee7f
> >
> > makes that possible in a nice way. Would it be reasonable to request backporting of this patch to Dunfell?
>
> This is sort of in the grey area between feature and bug fix.  It does
> seem relatively safe, so I would consider taking the patch if there
> are no objections from the community.
>
> Added Bruce to the cc list to get his opinion.

Good timing, I happened to notice this earlier and was thinking about it.

While I also wouldn't call it a bug, I agree it is a small/standalone
change that shouldn't break anything.

A quick scan of the dunfell tested kernels shows unchanged Makefile
handling of the option, so there's little risk there.

I'd say that it would be fine for backport.

Bruce

>
> > We were also wondering what could be an alternative approach for getting this or a similar functionality. Patching a bbclass using a bbappend is not possible, is it?
>
> No, there is no equivalent of bbappend for classes.
>
> Other solutions are possible, but taking this patch would be the
> cleanest solution to your problem.  Let's see what others think before
> we go there :-)
>
> Steve
>
>
> >
> > Cheers,
> > Mark
> >
> >  Mark Jonas
> >
> > Building Technologies, Panel Software Fire (BT-FIR/ENG1-Grb)
> > Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com
> > Tel. +49 89 6290-1105 | Telefax +49 89 6290-281105 | Mark.Jonas@de.bosch.com
> >
> > Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118
> > Aufsichtsratsvorsitzender: Christian Fischer; Geschäftsführung: Thomas Quante, Andreas Bartz
> >

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II