Re: [OE-core] [PATCH 2/2] linux-yocto: Autoload sound driver on QEMU x86

[Bruce Ashfield <bruce.ashfield@gmail.com>]

On Wed, Jan 4, 2023 at 7:18 AM Mark Jonas <toertel@gmail.com> wrote:
>
> From: Mark Jonas <toertel@gmail.com>
>
> If DISTRO_FEATURES includes ALSA then automatically load the
> snd-intel8x0 kernel module on qemux86 and qemux86-64. This matches the
> machine configurations conf/machine/qemux86.conf and qemux86-64.conf.
>
> Signed-off-by: Mark Jonas <toertel@gmail.com>
> ---
>  meta/recipes-kernel/linux/linux-yocto.inc | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-kernel/linux/linux-yocto.inc b/meta/recipes-kernel/linux/linux-yocto.inc
> index 091003ed82..c8a9b0a1e3 100644
> --- a/meta/recipes-kernel/linux/linux-yocto.inc
> +++ b/meta/recipes-kernel/linux/linux-yocto.inc
> @@ -37,6 +37,11 @@ KERNEL_FEATURES:append = " ${@bb.utils.contains('MACHINE_FEATURES', 'efi', 'cfg/
>  KERNEL_FEATURES:append = " ${@bb.utils.contains('MACHINE_FEATURES', 'numa', 'features/numa/numa.scc', '', d)}"
>  KERNEL_FEATURES:append = " ${@bb.utils.contains('MACHINE_FEATURES', 'vfat', 'cfg/fs/vfat.scc', '', d)}"
>
> +# sound driver recommended by conf/machine/qemux86*.conf
> +ALSA_MODULES = "${@bb.utils.contains("DISTRO_FEATURES", "alsa", "snd-intel8x0", "", d)}"
> +KERNEL_MODULE_AUTOLOAD:qemux86 += "${ALSA_MODULES}"
> +KERNEL_MODULE_AUTOLOAD:qemux86-64 += "${ALSA_MODULES}"

This gets us most of the way, but if we are going to do this we should
complete the job.

We really need to make sure there's a configuration fragment that
explicitly enables
the modules we need (and not count on defaults, or other selects). That would go
into the kernel-cache.

It would then be something we'd add to the KERNEL_FEATRES triggered off the
distro feature. Just like we are doing with numa and vfat that is visible in the
context of the patch.

Bruce

> +
>  # A KMACHINE is the mapping of a yocto $MACHINE to what is built
>  # by the kernel. This is typically the branch that should be built,
>  # and it can be specific to the machine or shared
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#175471): https://lists.openembedded.org/g/openembedded-core/message/175471
> Mute This Topic: https://lists.openembedded.org/mt/96048827/1050810
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II