From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz0-f47.google.com ([209.85.210.47]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1SSDRC-0000mw-D7 for openembedded-core@lists.openembedded.org; Wed, 09 May 2012 22:24:42 +0200 Received: by dalh21 with SMTP id h21so706089dal.6 for ; Wed, 09 May 2012 13:14:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=NdZedLvhj/rSeipvEtslv0WdbBwr5CENO4G7GYg2+VI=; b=uewaec6758KcExeOqtSW/r6TMqDe9RjEGrGebtRYoqkvb9Thf2eHRSzCs2fr6Z/8uf 5o6azivDwpFQ3HSJKCeL6qzc6riy/VVACW1KHbUGjBrPIJzd7zFOyEGoBUodG5unDLEP XIB2QonIWJv8G+dnbUuxRCsT8EJHEjY0edsSXr6FQRLkxaIlJRLFhVLtAnYj7voCxLY8 wR5XQV3RNWCkH9v6xOb+DxuB+VuFZJ63Hs0YNEklYR7I7Km/N2JeEz6u4UgApbm2sxQY JHcfGyH7ghDnq3vhX4ocike6oDhIv3l3ztbWT94GCH6wc/d4+OTrRRdwXv1ayuY/Ce9T N6RA== MIME-Version: 1.0 Received: by 10.68.241.37 with SMTP id wf5mr12534445pbc.104.1336594488309; Wed, 09 May 2012 13:14:48 -0700 (PDT) Received: by 10.68.197.4 with HTTP; Wed, 9 May 2012 13:14:48 -0700 (PDT) In-Reply-To: <1336593873.2494.74.camel@ted> References: <1336546278.30349.26.camel@ted> <1336593873.2494.74.camel@ted> Date: Wed, 9 May 2012 16:14:48 -0400 Message-ID: From: Bruce Ashfield To: Patches and discussions about the oe-core layer Cc: saul.wold@intel.com Subject: Re: [PATCH 0/1] kernel-yocto: export GUILT_BASE X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Patches and discussions about the oe-core layer List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2012 20:24:42 -0000 Content-Type: text/plain; charset=ISO-8859-1 On Wed, May 9, 2012 at 4:04 PM, Richard Purdie wrote: > On Wed, 2012-05-09 at 09:08 -0400, Bruce Ashfield wrote: >> On Wed, May 9, 2012 at 8:42 AM, Bruce Ashfield wrote: >> > On Wed, May 9, 2012 at 2:51 AM, Richard Purdie >> > wrote: >> >> On Tue, 2012-05-08 at 15:23 -0400, Bruce Ashfield wrote: >> >>> Richard/Saul, >> >>> >> >>> As Frans Meulenbroeks noted this morning, guilt wasn't functional >> >>> in the devshell. The fix was simple enough, and by ensuring that >> >>> GUILT_BASE is exported, it works without any extra steps now. >> >>> >> >>> I wasn't sure if there a better way to call 'up' to the base >> >>> method, so I repeated the call to oe_terminal in the do_devshell() >> >>> in kernel-yocto.bbclass. >> >>> >> >>> If there's another approach, let me know and I'll respin the patch. >> >> >> >> Can't you just set: >> >> >> >> GUILT_BASE = "meta" >> > >> > Will that export to the subshell ? I didn't try it .. since I didn't >> > think it would. >> > I'll give that a go here :) >> >> With just that set in kernel-yocto.bbclass, and I launch devshell, I get this: >> >> % guilt applied >> Patches directory doesn't exist, try guilt-init >> >> So unless I misunderstood what you are suggesting, I still need that explicit >> export. > > Sorry, let me be more clear. I meant does: > > OE_TERMINAL_EXPORTS += "GUILT_BASE" > GUILT_BASE = "meta" Aha. Yes. That does work, since the setVar does that same thing :) I can drop my devshell override and it works. I'll update my patch and push it back to the branch in the pull request. Bruce > > work? > > I'm not sure we need everything in the original patch... > > Cheers, > > Richard > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"