All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bruce Ashfield" <bruce.ashfield@gmail.com>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: Diego Sueiro <diego.sueiro@arm.com>,
	meta-virtualization@lists.yoctoproject.org,  nd <nd@arm.com>
Subject: Re: [meta-virtualization][PATCH 1/3] podman: Add seccomp as REQUIRED_DISTRO_FEATURES
Date: Thu, 24 Jun 2021 15:48:28 -0400	[thread overview]
Message-ID: <CADkTA4P5nTDNHYUbHwUxsuah+tT3Usic_W0p0-qdvP1DbeuccA@mail.gmail.com> (raw)
In-Reply-To: <168B9C435EB7F916.14800@lists.yoctoproject.org>

On Thu, Jun 24, 2021 at 3:45 PM Bruce Ashfield via
lists.yoctoproject.org
<bruce.ashfield=gmail.com@lists.yoctoproject.org> wrote:
>
> What branch are you working with ?
>
> Now that seccomp is in core, we no longer have those restrictions, so
> I assume this is on an older branch ?

aha. never mind, I misread the change.

That being said, I honestly think this is a bug. If the main
libseccomp is dependent on a distro feature, each and every recipe
that has a hard dependency on it, should not have to do the distro
check.

so for now, I'm going to not apply these while I look for a better method.

Bruce

>
> Bruce
>
> On Thu, Jun 24, 2021 at 3:00 PM Diego Sueiro <diego.sueiro@arm.com> wrote:
> >
> > The libseccomp package is only available if seccomp is in DISTRO_FEATURES.
> >
> > Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
> > ---
> >  recipes-containers/podman/podman_git.bb | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/recipes-containers/podman/podman_git.bb b/recipes-containers/podman/podman_git.bb
> > index 9dcb21c..351f38b 100644
> > --- a/recipes-containers/podman/podman_git.bb
> > +++ b/recipes-containers/podman/podman_git.bb
> > @@ -6,6 +6,9 @@ DESCRIPTION = "Podman is a daemonless container engine for developing, \
> >      `alias docker=podman`. \
> >      "
> >
> > +inherit features_check
> > +REQUIRED_DISTRO_FEATURES ?= "seccomp"
> > +
> >  DEPENDS = " \
> >      go-metalinter-native \
> >      go-md2man-native \
> > --
> > 2.17.1
> >
> >
> >
> >
>
>
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II
>
> 
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

      parent reply	other threads:[~2021-06-24 19:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 18:59 [meta-virtualization][PATCH 1/3] podman: Add seccomp as REQUIRED_DISTRO_FEATURES Diego Sueiro
2021-06-24 18:59 ` [meta-virtualization][PATCH 2/3] packagegroup-container: Include podman if seccomp is in DISTRO_FEATURES Diego Sueiro
2021-06-24 18:59 ` [meta-virtualization][PATCH 3/3] slirp4netns: Add seccomp as REQUIRED_DISTRO_FEATURES Diego Sueiro
2021-06-24 19:44 ` [meta-virtualization][PATCH 1/3] podman: " Bruce Ashfield
2021-06-24 21:01   ` Martin Jansa
2021-06-25  2:49     ` Bruce Ashfield
2021-06-25  8:11       ` Diego Sueiro
2021-06-25 12:46         ` Bruce Ashfield
2021-06-25 12:48           ` Richard Purdie
2021-06-25 12:48           ` Martin Jansa
2021-06-25 14:16             ` Diego Sueiro
2021-06-25 15:18               ` Bruce Ashfield
     [not found]               ` <168BDC4B6AEEB1F5.20368@lists.yoctoproject.org>
2021-06-25 15:21                 ` Bruce Ashfield
     [not found]                 ` <168BDC756BE2FF71.10690@lists.yoctoproject.org>
2021-06-30  3:27                   ` Bruce Ashfield
2021-06-30  7:58                     ` Richard Purdie
2021-06-30 12:48                       ` Bruce Ashfield
     [not found] ` <168B9C435EB7F916.14800@lists.yoctoproject.org>
2021-06-24 19:48   ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADkTA4P5nTDNHYUbHwUxsuah+tT3Usic_W0p0-qdvP1DbeuccA@mail.gmail.com \
    --to=bruce.ashfield@gmail.com \
    --cc=diego.sueiro@arm.com \
    --cc=meta-virtualization@lists.yoctoproject.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.