All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] containerd-docker: remove the recipe
@ 2020-12-23  3:37 Yu, Mingli
  2020-12-23 13:42 ` [meta-virtualization] " Bruce Ashfield
  0 siblings, 1 reply; 3+ messages in thread
From: Yu, Mingli @ 2020-12-23  3:37 UTC (permalink / raw)
  To: meta-virtualization

From: Mingli Yu <mingli.yu@windriver.com>

There is build failure for containerd-docker as the below logic in
containerd-docker recipe.
do_compile_prepend() {
        bberror "${PN} is depreciated and will be removed in the future"
        bbfatal "use container-opencontainers for a working configuration"
}

So remove the containerd-docker recipe to avoid confusion.

Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
---
 .../containerd/containerd-docker_git.bb       | 22 -------------------
 1 file changed, 22 deletions(-)
 delete mode 100644 recipes-containers/containerd/containerd-docker_git.bb

diff --git a/recipes-containers/containerd/containerd-docker_git.bb b/recipes-containers/containerd/containerd-docker_git.bb
deleted file mode 100644
index 8d1a27a..0000000
--- a/recipes-containers/containerd/containerd-docker_git.bb
+++ /dev/null
@@ -1,22 +0,0 @@
-SRCREV = "3addd840653146c90a254301d6c3a663c7fd6429"
-SRC_URI = "\
-	git://github.com/docker/containerd.git;branch=v0.2.x;destsuffix=git/src/github.com/containerd/containerd \
-	"
-
-
-LIC_FILES_CHKSUM = "file://LICENSE.code;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
-
-include containerd.inc
-
-CONTAINERD_VERSION = "v0.2.x"
-S = "${WORKDIR}/git/src/github.com/containerd/containerd"
-
-PROVIDES += "virtual/containerd"
-RPROVIDES_${PN} = "virtual/containerd"
-
-DEPENDS += "btrfs-tools"
-
-do_compile_prepend() {
-	bberror "${PN} is depreciated and will be removed in the future"
-	bbfatal "use container-opencontainers for a working configuration"
-}
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [meta-virtualization] [PATCH] containerd-docker: remove the recipe
  2020-12-23  3:37 [PATCH] containerd-docker: remove the recipe Yu, Mingli
@ 2020-12-23 13:42 ` Bruce Ashfield
  2020-12-24  2:03   ` Yu, Mingli
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Ashfield @ 2020-12-23 13:42 UTC (permalink / raw)
  To: Yu, Mingli; +Cc: meta-virtualization

On Tue, Dec 22, 2020 at 10:39 PM Yu, Mingli <mingli.yu@windriver.com> wrote:
>
> From: Mingli Yu <mingli.yu@windriver.com>
>
> There is build failure for containerd-docker as the below logic in
> containerd-docker recipe.
> do_compile_prepend() {
>         bberror "${PN} is depreciated and will be removed in the future"
>         bbfatal "use container-opencontainers for a working configuration"
> }
>
> So remove the containerd-docker recipe to avoid confusion.
>

As per some of my previous email, this is going to stay around for one
more release to go through the depreciation process.

And there's no confusion .. that message is very clear :D

Cheers,

bruce

> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
> ---
>  .../containerd/containerd-docker_git.bb       | 22 -------------------
>  1 file changed, 22 deletions(-)
>  delete mode 100644 recipes-containers/containerd/containerd-docker_git.bb
>
> diff --git a/recipes-containers/containerd/containerd-docker_git.bb b/recipes-containers/containerd/containerd-docker_git.bb
> deleted file mode 100644
> index 8d1a27a..0000000
> --- a/recipes-containers/containerd/containerd-docker_git.bb
> +++ /dev/null
> @@ -1,22 +0,0 @@
> -SRCREV = "3addd840653146c90a254301d6c3a663c7fd6429"
> -SRC_URI = "\
> -       git://github.com/docker/containerd.git;branch=v0.2.x;destsuffix=git/src/github.com/containerd/containerd \
> -       "
> -
> -
> -LIC_FILES_CHKSUM = "file://LICENSE.code;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
> -
> -include containerd.inc
> -
> -CONTAINERD_VERSION = "v0.2.x"
> -S = "${WORKDIR}/git/src/github.com/containerd/containerd"
> -
> -PROVIDES += "virtual/containerd"
> -RPROVIDES_${PN} = "virtual/containerd"
> -
> -DEPENDS += "btrfs-tools"
> -
> -do_compile_prepend() {
> -       bberror "${PN} is depreciated and will be removed in the future"
> -       bbfatal "use container-opencontainers for a working configuration"
> -}
> --
> 2.26.2
>
>
> 
>


-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [meta-virtualization] [PATCH] containerd-docker: remove the recipe
  2020-12-23 13:42 ` [meta-virtualization] " Bruce Ashfield
@ 2020-12-24  2:03   ` Yu, Mingli
  0 siblings, 0 replies; 3+ messages in thread
From: Yu, Mingli @ 2020-12-24  2:03 UTC (permalink / raw)
  To: Bruce Ashfield; +Cc: meta-virtualization



On 12/23/20 9:42 PM, Bruce Ashfield wrote:
> On Tue, Dec 22, 2020 at 10:39 PM Yu, Mingli <mingli.yu@windriver.com> wrote:
>>
>> From: Mingli Yu <mingli.yu@windriver.com>
>>
>> There is build failure for containerd-docker as the below logic in
>> containerd-docker recipe.
>> do_compile_prepend() {
>>          bberror "${PN} is depreciated and will be removed in the future"
>>          bbfatal "use container-opencontainers for a working configuration"
>> }
>>
>> So remove the containerd-docker recipe to avoid confusion.
>>
> 
> As per some of my previous email, this is going to stay around for one
> more release to go through the depreciation process.
> 
> And there's no confusion .. that message is very clear :D

Thanks Bruce for your explanation!
For the confusion, I mean the containerd-docker exists there, but cannot 
build actually.

Thanks,

> 
> Cheers,
> 
> bruce
> 
>> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
>> ---
>>   .../containerd/containerd-docker_git.bb       | 22 -------------------
>>   1 file changed, 22 deletions(-)
>>   delete mode 100644 recipes-containers/containerd/containerd-docker_git.bb
>>
>> diff --git a/recipes-containers/containerd/containerd-docker_git.bb b/recipes-containers/containerd/containerd-docker_git.bb
>> deleted file mode 100644
>> index 8d1a27a..0000000
>> --- a/recipes-containers/containerd/containerd-docker_git.bb
>> +++ /dev/null
>> @@ -1,22 +0,0 @@
>> -SRCREV = "3addd840653146c90a254301d6c3a663c7fd6429"
>> -SRC_URI = "\
>> -       git://github.com/docker/containerd.git;branch=v0.2.x;destsuffix=git/src/github.com/containerd/containerd \
>> -       "
>> -
>> -
>> -LIC_FILES_CHKSUM = "file://LICENSE.code;md5=aadc30f9c14d876ded7bedc0afd2d3d7"
>> -
>> -include containerd.inc
>> -
>> -CONTAINERD_VERSION = "v0.2.x"
>> -S = "${WORKDIR}/git/src/github.com/containerd/containerd"
>> -
>> -PROVIDES += "virtual/containerd"
>> -RPROVIDES_${PN} = "virtual/containerd"
>> -
>> -DEPENDS += "btrfs-tools"
>> -
>> -do_compile_prepend() {
>> -       bberror "${PN} is depreciated and will be removed in the future"
>> -       bbfatal "use container-opencontainers for a working configuration"
>> -}
>> --
>> 2.26.2
>>
>>
>> 
>>
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-12-24  2:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-23  3:37 [PATCH] containerd-docker: remove the recipe Yu, Mingli
2020-12-23 13:42 ` [meta-virtualization] " Bruce Ashfield
2020-12-24  2:03   ` Yu, Mingli

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.