From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lb0-f175.google.com (mail-lb0-f175.google.com [209.85.217.175]) by mail.openembedded.org (Postfix) with ESMTP id 5E7AB6D001 for ; Tue, 19 Nov 2013 18:17:55 +0000 (UTC) Received: by mail-lb0-f175.google.com with SMTP id x18so895342lbi.6 for ; Tue, 19 Nov 2013 10:17:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=b2yHqmP4afaQaejuwXuriYVMu9Ta52nQHStlpkjetPs=; b=R+SnK/7xbRXcFb7yxeNUgESNHgBLcnTeWZRa4sZzcA4QBOYpwJEnukEUlxC8juI6Gy L0dl9/jQ6EqtIhDTZnau2qQ+HRxvWa1oZVlGBIHEDYkWvP1KvrN6BbhvXB9puG6kUAKT MIA7MNVyxzCjkdsX0nT3+AW/Ye3UBJ96swvoe0HX473RxmIoa6d+zrG1uF0ez1gzPKIj Vdb6u6/SOUqnIpk1sZbbU7TzaO2ljg4tLpsTOy0Bb8Nu5oKJ8krpadOklhBo5opzh7ti rsdheFZHa05ZR82IKD/IlQ+j0TPCTR9HnAN7MKGq34ZgXMw0tf7LGtpNTpCtNXNfghHW 9P5A== MIME-Version: 1.0 X-Received: by 10.112.150.103 with SMTP id uh7mr2173665lbb.34.1384885075981; Tue, 19 Nov 2013 10:17:55 -0800 (PST) Received: by 10.112.14.200 with HTTP; Tue, 19 Nov 2013 10:17:55 -0800 (PST) In-Reply-To: References: <9f62e2e632692c5919a0de25a785d17d477a64b3.1381266484.git.bruce.ashfield@windriver.com> <20131119173725.GA13018@mcrowe.com> <1384883174.23724.116.camel@phil-desktop.brightsign> Date: Tue, 19 Nov 2013 13:17:55 -0500 Message-ID: From: Bruce Ashfield To: Phil Blundell Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 1/1] kernel: restore scripts in the sysroot X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Nov 2013 18:17:55 -0000 Content-Type: text/plain; charset=ISO-8859-1 Adding Khem. Khem .. see below. On Tue, Nov 19, 2013 at 12:54 PM, Bruce Ashfield wrote: > On Tue, Nov 19, 2013 at 12:46 PM, Phil Blundell wrote: >> On Tue, 2013-11-19 at 17:37 +0000, Mike Crowe wrote: >>> On Tuesday 08 October 2013 at 17:12:54 -0400, Bruce Ashfield wrote: >>> > When building against the sysroot, out of tree modules can require modpost >>> > and other utilities normally found in the kernel's scripts directory. For >>> > the kernel source in the staging dir, these scripts have been removed to >>> > avoid mixing archiectures when packaging kernel-dev (among other things). >>> > >>> > Rather than further complicate the kernel's install rule, or its packaging, >>> > we can restore the scripts by building them in the kernel staging directory >>> > after the sstate is installed, making them available to packages that need them. >>> > >>> > Signed-off-by: Bruce Ashfield >>> > --- >>> > meta/classes/kernel.bbclass | 11 +++++++++++ >>> > 1 file changed, 11 insertions(+) >>> > >>> > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass >>> > index 4acfb7e..d5fa801 100644 >>> > --- a/meta/classes/kernel.bbclass >>> > +++ b/meta/classes/kernel.bbclass >>> > @@ -292,6 +292,17 @@ kernel_do_install() { >>> > } >>> > do_install[prefuncs] += "package_get_auto_pr" >>> > >>> > + >>> > +SSTATEPOSTINSTFUNCS += "kernelscripts_sstate_postinst" >>> > +kernelscripts_sstate_postinst () { >>> > + if [ "${BB_CURRENTTASK}" = "populate_sysroot" -o "${BB_CURRENTTASK}" = "populate_sysroot_setscene" ]; then >>> > + ( >>> > + cd ${STAGING_KERNEL_DIR} >>> > + oe_runmake scripts >>> > + ) >>> > + fi >>> > +} >>> > + >>> > sysroot_stage_all_append() { >>> > sysroot_stage_dir ${D}${KERNEL_SRC_PATH} ${SYSROOT_DESTDIR}${KERNEL_SRC_PATH} >>> > } >>> >>> This sstate_postinst fails for me when the compiler isn't already present >>> in the sysroot. >>> >>> Also, I notice that the environment and parameters passed to oe_runmake are >>> not the same as those used by kernel_do_compile etc. >> >> Also note that module.bbclass already does "make scripts" before >> do_compile() so out-of-tree modules should already have access to all >> the files that they need. > > Ah, but they didn't. Otherwise we wouldn't have mucked about in the routines. > Khem was building out of the sysroot and the support scripts weren't present, > something which we were able to consistently reproduce. > > Perhaps the whole problem was just a misordering of the tasks. I'll take another > look. > > But yes, we need one way or the other .. not both. I'd prefer to not fiddle with > sstate, so I'll go back and see why the module.bbclass code wasn't working > for the reported error. Khem: I wasn't working from a bugzilla when making these changes, so I can't find your original reproducer for the missing recordmcount script. Do you recall what it was ? I'm revisiting this and would like to understand why the make scripts in module-base.bbclass wasn't properly restoring the support scripts for your build. I'm leaning towards reverting the whole mess, but without the reproducing case, I can't be sure that I'm not breaking you again. Bruce > > Bruce > > >> >> If we're going to make a policy decision that the kernel is responsible >> for making scripts then I guess that's fine (modulo the implementation >> problems that Mike describes) but in that case the code in >> module{-base}.bbclass is redundant and ought to be removed. >> >> p. >> >> >> _______________________________________________ >> Openembedded-core mailing list >> Openembedded-core@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-core > > > > -- > "Thou shalt not follow the NULL pointer, for chaos and madness await > thee at its end" -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"