All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: "Yu, Mingli" <mingli.yu@windriver.com>
Cc: meta-virtualization@yoctoproject.org
Subject: Re: [meta-openstack][PATCH] layer.conf: set PREFERRED_VERSION for python-networkx
Date: Wed, 10 Oct 2018 08:31:00 -0400	[thread overview]
Message-ID: <CADkTA4P_7bHiT265JP+pdpzgXV=awtSFeaq+=xC1iC86vBTfqg@mail.gmail.com> (raw)
In-Reply-To: <1539163886-138214-1-git-send-email-mingli.yu@windriver.com>

On Wed, Oct 10, 2018 at 5:31 AM <mingli.yu@windriver.com> wrote:
>
> From: Mingli Yu <Mingli.Yu@windriver.com>
>
> Only set PREFERRED_VERSION for python-networkx
> when the openstack distro is enabled

If we are introducing a distro feature for openstack, there needs to
be a warning
generated if the layer is included, but the distro feature is not set.

That preserves the existing behaviour (enabled by default) by letting the user
know what they must enable in their config to get openstack building and the
right versions.

We should also have a variable to inhibit the warning for those that want the
layer, and know they haven't enabled it.

See meta-virtualization for an example of how to do both.

Bruce

>
> Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com>
> ---
>  meta-openstack/conf/layer.conf | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-openstack/conf/layer.conf b/meta-openstack/conf/layer.conf
> index 126f37f..2dceb47 100644
> --- a/meta-openstack/conf/layer.conf
> +++ b/meta-openstack/conf/layer.conf
> @@ -32,7 +32,7 @@ PREFERRED_VERSION_python-sqlalchemy = "1.0.16"
>  PREFERRED_VERSION_python-eventlet = "0.20.0"
>  PREFERRED_VERSION_python-warlock = "1.2.0"
>  PREFERRED_VERSION_python-jsonschema = "2.6.0"
> -PREFERRED_VERSION_python-networkx = "1.11"
> +PREFERRED_VERSION_python-networkx = "${@bb.utils.contains('DISTRO_FEATURES', 'openstack', '1.11', '', d)}"
>  PREFERRED_VERSION_python-oslo.i18n = "3.17.0+gitAUTOINC+f2729cd36f"
>
>  LICENSE_PATH += "${LAYERDIR}/licenses"
> --
> 2.7.4
>


-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"


      reply	other threads:[~2018-10-10 12:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-10  9:31 [meta-openstack][PATCH] layer.conf: set PREFERRED_VERSION for python-networkx mingli.yu
2018-10-10 12:31 ` Bruce Ashfield [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADkTA4P_7bHiT265JP+pdpzgXV=awtSFeaq+=xC1iC86vBTfqg@mail.gmail.com' \
    --to=bruce.ashfield@gmail.com \
    --cc=meta-virtualization@yoctoproject.org \
    --cc=mingli.yu@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.