From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f65.google.com (mail-oi0-f65.google.com [209.85.218.65]) by mail.openembedded.org (Postfix) with ESMTP id B5C996FF73 for ; Tue, 22 Mar 2016 12:21:46 +0000 (UTC) Received: by mail-oi0-f65.google.com with SMTP id e22so11897346oib.0 for ; Tue, 22 Mar 2016 05:21:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=UoP9cUmw0zpjLQLFRu0XeMplYqju+lpyosDQ2tPW78g=; b=WqPmUJ/EgnRClh6GF0BYh2LrnoBNmAIoFJplBcDKIjgSOzonFOKiJriiZ+6t5wA95R mny5aFa26T3OeSlDhCnh4nyJrHHMX5wdYJoRTl9Wcwxh0LzPJZA7WhGcYb1U/zDCfZl9 xTLg13lyTjHT2ecyODOxN1Uh8s5mSwQaQZdL1XQRws5Y5fJyHfW9R3Pw+YBCUNaWp1K/ g9zqD+I+2fzIk7rdWLFiByVIV0zmUGRQo9Ep7mrDRWiPCKOqdVTZKA0MpnbcQSbrhvxR I13goxCJ9Zsb4AdfPFrB+ndR0gApMtYgxMP/9iu83MrvVrjmi4t8/zsToXelpAertHlO leBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=UoP9cUmw0zpjLQLFRu0XeMplYqju+lpyosDQ2tPW78g=; b=R1jroxVQN1dzBlpjEjNui7QGcvzMj8+0j6q2M/HC1ExT3GTPd0UPzq9qVReaf3Orfj 6aijbEhQf7k1DM0ACVSY+yGkrm8ATH7lTG8heeopS56wnPQECqXsGxqNJf2zb0CKUuiA aTcrmCiXBnLppZwV/YBQZ8drEZoqQpTijY8xm+jB64AsZXmMPuRbt823clYuqO284cfU e20yNK+cv1fqS/thxl3TEi1w4k8Bw9YD7wEdufMdd29LAc1xbJmdoMXfiTBjbSTKHWGB JoHCDRhNhp6f5Pim3CRSTXkBWvCOP+yg9UlfZv5r5lzIZ97j5wZ1cx6hP0Mns6ah0iQ1 01lA== X-Gm-Message-State: AD7BkJJhMREnH0TZYLBpZ2T29mZQNJ1jexiEVu7ZTvs1H2VC/n98qke/mwn9wyjYMx6VBzNSEDSMJZcc/AtgOg== MIME-Version: 1.0 X-Received: by 10.202.90.3 with SMTP id o3mr20053347oib.96.1458649306854; Tue, 22 Mar 2016 05:21:46 -0700 (PDT) Received: by 10.157.8.248 with HTTP; Tue, 22 Mar 2016 05:21:46 -0700 (PDT) In-Reply-To: References: Date: Tue, 22 Mar 2016 08:21:46 -0400 Message-ID: From: Bruce Ashfield To: Hongxu Jia Cc: Patches and discussions about the oe-core layer Subject: Re: [PATCH 02/16] kernel.bbclass: fix buildpath QA issue X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 12:21:47 -0000 Content-Type: multipart/alternative; boundary=001a113d5edcc99dc3052ea241e6 --001a113d5edcc99dc3052ea241e6 Content-Type: text/plain; charset=UTF-8 On Tue, Mar 22, 2016 at 8:12 AM, Hongxu Jia wrote: > Since CFLAGS CPPFLAGS CXXFLAGS has been unset, variable DEBUG_FLAGS could > not been passed to compiler, so we explicitly add DEBUG_FLAGS to CC to > replace build path with target path. > Can you be more explicit here ? What is typically contained in DEBUG_FLAGS ? The kernel builds its own compiler line and flags, so anything you are setting from this environment, should not be leaking into the kernel build. .. which leaves me wondering, what exactly is in DEBUG_FLAGS, and how is it actually fixing the QA issue ? Bruce > > [YOCTO #7058] > > Signed-off-by: Hongxu Jia > --- > meta/classes/kernel.bbclass | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass > index c3eab50..d357ccf 100644 > --- a/meta/classes/kernel.bbclass > +++ b/meta/classes/kernel.bbclass > @@ -207,7 +207,7 @@ kernel_do_compile() { > copy_initramfs > > use_alternate_initrd=CONFIG_INITRAMFS_SOURCE=${B}/usr/${INITRAMFS_IMAGE}-${MACHINE}.cpio > fi > - oe_runmake ${KERNEL_IMAGETYPE_FOR_MAKE} ${KERNEL_ALT_IMAGETYPE} > CC="${KERNEL_CC}" LD="${KERNEL_LD}" ${KERNEL_EXTRA_ARGS} > $use_alternate_initrd > + oe_runmake ${KERNEL_IMAGETYPE_FOR_MAKE} ${KERNEL_ALT_IMAGETYPE} > CC="${KERNEL_CC} ${DEBUG_FLAGS}" LD="${KERNEL_LD}" ${KERNEL_EXTRA_ARGS} > $use_alternate_initrd > if test "${KERNEL_IMAGETYPE_FOR_MAKE}.gz" = "${KERNEL_IMAGETYPE}"; > then > gzip -9c < "${KERNEL_IMAGETYPE_FOR_MAKE}" > > "${KERNEL_OUTPUT}" > fi > @@ -216,7 +216,7 @@ kernel_do_compile() { > do_compile_kernelmodules() { > unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE > if (grep -q -i -e '^CONFIG_MODULES=y$' ${B}/.config); then > - oe_runmake -C ${B} ${PARALLEL_MAKE} modules > CC="${KERNEL_CC}" LD="${KERNEL_LD}" ${KERNEL_EXTRA_ARGS} > + oe_runmake -C ${B} ${PARALLEL_MAKE} modules > CC="${KERNEL_CC} ${DEBUG_FLAGS}" LD="${KERNEL_LD}" ${KERNEL_EXTRA_ARGS} > > # Module.symvers gets updated during the > # building of the kernel modules. We need to > -- > 1.9.1 > > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" --001a113d5edcc99dc3052ea241e6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Tue, Mar 22, 2016 at 8:12 AM, Hongxu Jia <hongxu.jia@windriv= er.com> wrote:
Since CFLAGS= CPPFLAGS CXXFLAGS has been unset, variable DEBUG_FLAGS could
not been passed to compiler, so we explicitly add DEBUG_FLAGS to CC to
replace build path with target path.

Ca= n you be more explicit here ? What is typically contained in DEBUG_FLAGS ? = The
kernel builds its own compiler line and flags, so anything yo= u are setting from this
environment, should not be leaking into t= he kernel build.

.. which leaves me wondering, wha= t exactly is in DEBUG_FLAGS, and how is it
actually fixing the QA= issue ?

Bruce
=C2=A0

[YOCTO #7058]

Signed-off-by: Hongxu Jia <h= ongxu.jia@windriver.com>
---
=C2=A0meta/classes/kernel.bbclass | 4 ++--
=C2=A01 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index c3eab50..d357ccf 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -207,7 +207,7 @@ kernel_do_compile() {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 copy_initramfs
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 use_alternate_initr= d=3DCONFIG_INITRAMFS_SOURCE=3D${B}/usr/${INITRAMFS_IMAGE}-${MACHINE}.cpio =C2=A0 =C2=A0 =C2=A0 =C2=A0 fi
-=C2=A0 =C2=A0 =C2=A0 =C2=A0oe_runmake ${KERNEL_IMAGETYPE_FOR_MAKE} ${KERNE= L_ALT_IMAGETYPE} CC=3D"${KERNEL_CC}" LD=3D"${KERNEL_LD}"= ; ${KERNEL_EXTRA_ARGS} $use_alternate_initrd
+=C2=A0 =C2=A0 =C2=A0 =C2=A0oe_runmake ${KERNEL_IMAGETYPE_FOR_MAKE} ${KERNE= L_ALT_IMAGETYPE} CC=3D"${KERNEL_CC} ${DEBUG_FLAGS}" LD=3D"${= KERNEL_LD}" ${KERNEL_EXTRA_ARGS} $use_alternate_initrd
=C2=A0 =C2=A0 =C2=A0 =C2=A0 if test "${KERNEL_IMAGETYPE_FOR_MAKE}.gz&q= uot; =3D "${KERNEL_IMAGETYPE}"; then
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 gzip -9c < "= ;${KERNEL_IMAGETYPE_FOR_MAKE}" > "${KERNEL_OUTPUT}"
=C2=A0 =C2=A0 =C2=A0 =C2=A0 fi
@@ -216,7 +216,7 @@ kernel_do_compile() {
=C2=A0do_compile_kernelmodules() {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE<= br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (grep -q -i -e '^CONFIG_MODULES=3Dy$'= ; ${B}/.config); then
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0oe_runmake -C ${B} = ${PARALLEL_MAKE} modules CC=3D"${KERNEL_CC}" LD=3D"${KERNEL_= LD}" ${KERNEL_EXTRA_ARGS}
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0oe_runmake -C ${B} = ${PARALLEL_MAKE} modules CC=3D"${KERNEL_CC} ${DEBUG_FLAGS}" LD=3D= "${KERNEL_LD}" ${KERNEL_EXTRA_ARGS}

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # Module.symvers ge= ts updated during the
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # building of the k= ernel modules. We need to
--
1.9.1

--
_______________________________________________
Openembedded-core mailing list
Openembedded-co= re@lists.openembedded.org
http://lists.openembedded.org/mailma= n/listinfo/openembedded-core



--
"Thou shalt not follow the NULL point= er, for chaos and madness await thee at its end"
--001a113d5edcc99dc3052ea241e6--