Markus,

My comments about introducing the use case of the new recipe, how it was tested, etc, apply to this commit as well.

See inline for more questions.

On Sun, Oct 30, 2022 at 12:13 PM Markus Volk <f_l_k@t-online.de> wrote:
Signed-off-by: Markus Volk <f_l_k@t-online.de>
---
 ...ata-meson.build-fix-for-recent-meson.patch | 44 +++++++++++++++++++
 .../virt-viewer/virt-viewer_11.0.bb           | 30 +++++++++++++
 2 files changed, 74 insertions(+)
 create mode 100644 recipes-extended/virt-viewer/virt-viewer/0001-data-meson.build-fix-for-recent-meson.patch
 create mode 100644 recipes-extended/virt-viewer/virt-viewer_11.0.bb

diff --git a/recipes-extended/virt-viewer/virt-viewer/0001-data-meson.build-fix-for-recent-meson.patch b/recipes-extended/virt-viewer/virt-viewer/0001-data-meson.build-fix-for-recent-meson.patch
new file mode 100644
index 0000000..5a4fe77
--- /dev/null
+++ b/recipes-extended/virt-viewer/virt-viewer/0001-data-meson.build-fix-for-recent-meson.patch
@@ -0,0 +1,44 @@
+From b2d3cde0ff9816c468986f2d62c67d0713a4c49e Mon Sep 17 00:00:00 2001
+From: Markus Volk <f_l_k@t-online.de>
+Date: Sat, 29 Oct 2022 15:35:23 +0200
+Subject: [PATCH] data/meson.build: fix for recent meson
+
+Signed-off-by: Markus Volk <f_l_k@t-online.de>
+
+Patch-Status: Backport
Since this is a git based recipe, there's no need to stay on the release tag. Bumping the SRCREV to pickup a patch like this is preferable to carrying a patch as part of the recipe.
 
+
+---
+ data/meson.build | 3 ---
+ 1 file changed, 3 deletions(-)
+
+diff --git a/data/meson.build b/data/meson.build
+index d718491..4325108 100644
+--- a/data/meson.build
++++ b/data/meson.build
+@@ -2,7 +2,6 @@ if host_machine.system() != 'windows'
+   desktop = 'remote-viewer.desktop'
+
+   i18n.merge_file (
+-    desktop,
+     type: 'desktop',
+     input: desktop + '.in',
+     output: desktop,
+@@ -14,7 +13,6 @@ if host_machine.system() != 'windows'
+   mimetypes = 'virt-viewer-mime.xml'
+
+   i18n.merge_file (
+-    mimetypes,
+     type: 'xml',
+     input: mimetypes + '.in',
+     output: mimetypes,
+@@ -27,7 +25,6 @@ if host_machine.system() != 'windows'
+   metainfo = 'remote-viewer.appdata.xml'
+
+   i18n.merge_file (
+-    metainfo,
+     type: 'xml',
+     input: metainfo + '.in',
+     output: metainfo,
+--
+2.34.1
+
diff --git a/recipes-extended/virt-viewer/virt-viewer_11.0.bb b/recipes-extended/virt-viewer/virt-viewer_11.0.bb
new file mode 100644
index 0000000..a09f0cf
--- /dev/null
+++ b/recipes-extended/virt-viewer/virt-viewer_11.0.bb
@@ -0,0 +1,30 @@
+SUMMARY = "Virtual Machine Viewer"
+LICENSE = "GPL-2.0-only"
+LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552"
+
+# for librest support rest_0.7 would be needed
+DEPENDS = " \
+       desktop-file-utils-native \
+       glib-2.0 \
+       gtk+3 \
+       gtk-vnc \
+       libvirt \
+       libvirt-glib \
+       libxml2 \
+       spice-gtk \
+       spice-protocol \
+       vte \

These dependencies are the biggest "issue" with the recipe. meta-virtualization doesn't currently have a dependency on the layers that provide those packages. 

I'm always striving to keep our dependencies (in terms of layers) as small as possible. In particular, these dependencies imply that the target has support for graphics and some sort of desktop environment available.

To keep the dependency dynamic, we should check on an appropriate distro feature and raise a skiprecipe if the distro features aren't in place. See what we do with selinux/seccomp in a few other recipes. That allows us to not make the new layers as hard dependencies. If they do become hard dependencies of meta-virt, we need to update the layer.conf or we'll fail the yocto compatibility tests.

Cheers,

Bruce
 
+"
+
+SRC_URI = " \
+       git://gitlab.com/virt-viewer/virt-viewer.git;protocol=https;branch=master \
+       file://0001-data-meson.build-fix-for-recent-meson.patch \
+"
+
+SRCREV = "8d8923d259b79c7c9ad3560a49be81dc0f38b88b"
+S = "${WORKDIR}/git"
+
+inherit meson pkgconfig gtk-icon-cache mime mime-xdg gobject-introspection
+
+FILES:${PN} += "${datadir}"
+GIR_MESON_OPTION = ''
--
2.34.1


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#7666): https://lists.yoctoproject.org/g/meta-virtualization/message/7666
Mute This Topic: https://lists.yoctoproject.org/mt/94667263/1050810
Group Owner: meta-virtualization+owner@lists.yoctoproject.org
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
-=-=-=-=-=-=-=-=-=-=-=-



--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II