Just some minor improvements for the language:
On Fri, Oct 1, 2021 at 7:57 PM Nghia Le <nghialm78@gmail.com> wrote:
>
> Deadstore was detected by CodeCheck tool (ELISA group)
Hints:
- Use active instead of passive tense
- It is detected by "make clang-analyzer". The CodeChecker tool is
just the webUI frontend.
- Dead store is written as two words (with a space between dead and store).
So, make it:
The command "make clang-analyzer" detected a dead store.
>
> Removed demote_size and relevant assignment in function demote_size_show()
> to fix deadstore issue of which stored value to demote_size is never read
>
Hints:
- Use imperative form.
- ... and just some better English grammar.
So make it:
Remove demote_size and corresponding assignment in function demote_size_show()
to fix dead store, as demote_size is never read.
Also change deadstore to dead store in subject.
Other than that, it looks good to me.
Send a PATCH v2 here. Then, we check again and you can send the patch
out to the maintainers.
Lukas
> Signed-off-by: Nghia Le <nghialm78@gmail.com>
> ---
> mm/hugetlb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 993efa70bce4..ef00e6ad0f6a 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -3706,11 +3706,9 @@ static ssize_t demote_size_show(struct kobject *kobj,
> struct kobj_attribute *attr, char *buf)
> {
> struct hstate *h;
> - unsigned long demote_size;
> int nid;
>
> h = kobj_to_hstate(kobj, &nid);
> - demote_size = h->demote_order;
>
> return sysfs_emit(buf, "%lukB\n",
> (unsigned long)(PAGE_SIZE << h->demote_order) / SZ_1K);
> --
> 2.25.1
>