From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0189C282DD for ; Tue, 23 Apr 2019 12:07:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BF0AB206A3 for ; Tue, 23 Apr 2019 12:07:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bofh-nu.20150623.gappssmtp.com header.i=@bofh-nu.20150623.gappssmtp.com header.b="WCLx/JoA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727648AbfDWMH2 (ORCPT ); Tue, 23 Apr 2019 08:07:28 -0400 Received: from mail-oi1-f195.google.com ([209.85.167.195]:46262 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbfDWMH2 (ORCPT ); Tue, 23 Apr 2019 08:07:28 -0400 Received: by mail-oi1-f195.google.com with SMTP id l12so122551oie.13 for ; Tue, 23 Apr 2019 05:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bofh-nu.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=isFFMMRU6cHsTSPwIuIOa/2kOvZSvs51FTMYRhm3pDU=; b=WCLx/JoAklHXrI3SIRauq+e4cZ+093Cuw1UmcZZ3RI4kfzHMI0JUejfFomXpQd3DyV FoOmPgljloqhNv/s9NlFTr0rQFXe+5cGvMWYuIGtJrqSrgow/P8mHxPjFJGG70YYpOYn L0G2DnJOuhorRhaOoWUI0YyAmhb65i+GpTlpeEMv1/3L0T7no/JZSQPF0IqTKDCnZouX R2zstuaGQCzlzn/+BKxyMQua0Mj1chF9VjQqqe3AJSRG9DAgecfMEpZVg0JWlWBCXduS dltwr+o9zu4rgVZ5c98MN3cjTpGpMiBJTF31P7HE5u4NGeWpHMXtND7Ckv+c0zRmUj7f VUaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=isFFMMRU6cHsTSPwIuIOa/2kOvZSvs51FTMYRhm3pDU=; b=Kts/BDTe67IpgdolswqYZ4aZP3bcHxawxP8nkSNOJLopYpKNUbNr45o9qo9C6bezZi sOtYStU2tFLJ0Rk9Ik2J7Cf3aAMdXMMr7HsFPTrI+pK7BRj47MlWhum4iavYB36dejrB nnWiOJ4J/4uWz02h8m+vt5s0fIC03hGrqixgx4OVhA5UcWa8GnqDu4v5SqA+MR2IObTK IJzloNPEiLXRD40vh06KC9dHl3d3RSc7JvE1pz/NAQ4iz5cormJn8exjIcq6scaqGqi4 M30QNobOf2c0VbFvjp14cVtxgkuimFlEsmHQj3BmtPgCj/7qmVN05dAXFKwFUZr7Rf25 N4/g== X-Gm-Message-State: APjAAAV/dxPXaUPU7SYCegI84DOpi5HKn0zM7Um5oeWdZz2mFroM8dB5 ip0NaE88/NAxsDv3QFMcxxjFJ08TidhByYgUM2azeg== X-Google-Smtp-Source: APXvYqxhWVfPSnyc5qcTN5T2imLDbXr3MvmnjyOIhChWkWK8BWFdN2Gfn0c0iEw4z6p1VaOg6M2ePKyifcSZ70aaZHU= X-Received: by 2002:aca:e58d:: with SMTP id c135mr1562256oih.20.1556021247663; Tue, 23 Apr 2019 05:07:27 -0700 (PDT) MIME-Version: 1.0 References: <20190422222930.195053-1-posk@google.com> <20190422222930.195053-3-posk@google.com> In-Reply-To: <20190422222930.195053-3-posk@google.com> From: Lars Persson Date: Tue, 23 Apr 2019 14:07:16 +0200 Message-ID: Subject: Re: [PATCH 4.14 stable 2/5] net: IP defrag: encapsulate rbtree defrag code into callable functions To: Peter Oskolkov Cc: Greg Kroah-Hartman , stable@vger.kernel.org, linux-netdev , Peter Oskolkov , David Miller , Eric Dumazet , Sasha Levin , Captain Wiggum , Florian Westphal , Tom Herbert Content-Type: text/plain; charset="UTF-8" Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Apr 23, 2019 at 12:29 AM Peter Oskolkov wrote: > > [ Upstream commit c23f35d19db3b36ffb9e04b08f1d91565d15f84f ] > > This is a refactoring patch: without changing runtime behavior, > it moves rbtree-related code from IPv4-specific files/functions > into .h/.c defrag files shared with IPv6 defragmentation code. > > Signed-off-by: Peter Oskolkov > Cc: Eric Dumazet > Cc: Florian Westphal > Cc: Tom Herbert > Signed-off-by: David S. Miller > --- > include/net/inet_frag.h | 16 ++- > net/ipv4/inet_fragment.c | 293 +++++++++++++++++++++++++++++++++++++++ > net/ipv4/ip_fragment.c | 290 ++++---------------------------------- > 3 files changed, 335 insertions(+), 264 deletions(-) > Hi We get a compile error with gcc 8.2 after applying this patch: net/ipv4/ip_fragment.c: In function 'ip_frag_queue': net/ipv4/ip_fragment.c:390:1: error: label 'discard_qp' defined but not used [-Werror=unused-label] discard_qp: