From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH] drm/amdgpu: always reset asic when going into suspend Date: Tue, 15 Oct 2019 14:42:48 -0400 Message-ID: References: <20191015065002.18701-1-drake@endlessm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191015065002.18701-1-drake-6IF/jdPJHihWk0Htik3J/w@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Daniel Drake Cc: "Deucher, Alexander" , Chunming Zhou , Christian Koenig , amd-gfx list T24gVHVlLCBPY3QgMTUsIDIwMTkgYXQgMjo1MCBBTSBEYW5pZWwgRHJha2UgPGRyYWtlQGVuZGxl c3NtLmNvbT4gd3JvdGU6Cj4KPiBPbiBBc3VzIFVYNDM0REEgKFJ5emVuNyAzNzAwVSksIHVwb24g cmVzdW1lIGZyb20gczJpZGxlLCB0aGUgc2NyZWVuCj4gdHVybnMgb24gYWdhaW4gYW5kIHNob3dz IHRoZSBwcmUtc3VzcGVuZCBpbWFnZSwgYnV0IHRoZSBkaXNwbGF5IHJlbWFpbnMKPiBmcm96ZW4g ZnJvbSB0aGF0IHBvaW50IG9ud2FyZHMuCj4KPiBUaGUga2VybmVsIGxvZ3Mgc2hvdyBlcnJvcnM6 Cj4KPiAgW2RybV0gcHNwIGNvbW1hbmQgZmFpbGVkIGFuZCByZXNwb25zZSBzdGF0dXMgaXMgKDB4 NykKPiAgW2RybV0gRmVuY2UgZmFsbGJhY2sgdGltZXIgZXhwaXJlZCBvbiByaW5nIHNkbWEwCj4g IFtkcm1dIEZlbmNlIGZhbGxiYWNrIHRpbWVyIGV4cGlyZWQgb24gcmluZyBnZngKPiAgYW1kZ3B1 IDAwMDA6MDM6MDAuMDogW2RybTphbWRncHVfaWJfcmluZ190ZXN0c10gKkVSUk9SKiBJQiB0ZXN0 IGZhaWxlZCBvbiBnZnggKC0yMikuCj4gIFtkcm06cHJvY2Vzc19vbmVfd29ya10gKkVSUk9SKiBp YiByaW5nIHRlc3QgZmFpbGVkICgtMjIpLgo+Cj4gVGhpcyBjYW4gYWxzbyBiZSByZXByb2R1Y2Vk IHdpdGggcG1fdGVzdDoKPiAgIyBlY2hvIGRldmljZXMgPiAvc3lzL3Bvd2VyL3BtX3Rlc3QKPiAg IyBlY2hvIGZyZWV6ZSA+IC9zeXMvcG93ZXIvbWVtCj4KPiBUaGUgc2FtZSByZXByb2R1Y2VyIGNh dXNlcyB0aGUgc2FtZSBwcm9ibGVtIG9uIEFzdXMgWDUxMkRLIChSeXplbjUgMzUwMFUpCj4gZXZl biB0aG91Z2ggdGhhdCBtb2RlbCBpcyBub3JtYWxseSBhYmxlIHRvIHN1c3BlbmQgYW5kIHJlc3Vt ZSBPSyB2aWEgUzMuCj4KPiBFeHBlcmltZW50aW5nLCBJIG9ic2VydmVkIHRoYXQgdGhpcyBlcnJv ciBjb25kaXRpb24gY2FuIGJlIGludm9rZWQgb24KPiBhbnkgYW1kZ3B1IHByb2R1Y3QgYnkgZXhl Y3V0aW5nIGluIHN1Y2Nlc3Npb246Cj4KPiAgIGFtZGdwdV9kZXZpY2Vfc3VzcGVuZChkcm1fZGV2 LCB0cnVlLCB0cnVlKTsKPiAgIGFtZGdwdV9kZXZpY2VfcmVzdW1lKGRybV9kZXYsIHRydWUsIHRy dWUpOwo+Cj4gaS5lLiBpdCBhcHBlYXJzIHRoYXQgdGhlIHJlc3VtZSByb3V0aW5lIGlzIHVuYWJs ZSB0byBnZXQgdGhlIGRldmljZSBvdXQKPiBvZiBzdXNwZW5kZWQgc3RhdGUsIGV4Y2VwdCBmb3Ig dGhlIFMzIHN1c3BlbmQgY2FzZSB3aGVyZSBpdCBwcmVzdW1hYmx5IGhhcwo+IGEgYml0IG9mIGV4 dHJhIGhlbHAgZnJvbSB0aGUgZmlybXdhcmUgb3IgaGFyZHdhcmUuCj4KPiBIb3dldmVyLCBJIGFs c28gb2JzZXJ2ZWQgdGhhdCB0aGUgcnVudGltZSBzdXNwZW5kL3Jlc3VtZSByb3V0aW5lcyB3b3Jr Cj4gT0sgd2hlbiB0ZXN0ZWQgbGlrZSB0aGlzLCB3aGljaCBsZWFkIG1lIHRvIHRoZSBrZXkgZGlm ZmVyZW5jZSBpbiB0aGVzZQo+IHR3byBjYXNlczogdGhlIEFTSUMgcmVzZXQsIHdoaWNoIG9ubHkg aGFwcGVucyBpbiB0aGUgcnVudGltZSBzdXNwZW5kIHBhdGguCj4KPiBTaW5jZSBpdCB0YWtlcyBs ZXNzIHRoYW4gMW1zLCB3ZSBzaG91bGQgZG8gdGhlIEFTSUMgcmVzZXQgaW4gYWxsCj4gc3VzcGVu ZCBwYXRocywgZml4aW5nIHJlc3VtZSBmcm9tIHMyaWRsZSBvbiB0aGVzZSBwcm9kdWN0cy4KPgoK SXMgczJpZGxlIGFjdHVhbGx5IHBvd2VyaW5nIGRvd24gdGhlIEdQVT8gIERvIHlvdSBzZWUgYSBk aWZmZXJlbmNlIGluCnBvd2VyIHVzYWdlPyAgSSB0aGluayB5b3UgYXJlIGp1c3Qgd29ya2luZyBh cm91bmQgdGhlIGZhY3QgdGhhdCB0aGUKR1BVIG5ldmVyIGFjdHVhbGx5IGdldHMgcG93ZXJlZCBk b3duLiAgTGVhdmluZyB0aGUgR1BVIGluIHRoZSByZXNldApzdGF0ZSBwcm9iYWJseSB1c2VzIG1v cmUgcG93ZXIgdGhhbiBub3Qgc3VzcGVuZGluZyBpdCBpbiB0aGUgZmlyc3QKcGxhY2UuCgpBbGV4 Cgo+IExpbms6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEx MTgxMQo+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBEcmFrZSA8ZHJha2VAZW5kbGVzc20uY29tPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMgfCA5ICsr KysrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygt KQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZp Y2UuYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+IGluZGV4 IDVhMTkzOWRiZDRlMy4uN2Y0ODcwZTk3NGZiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQv YW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+IEBAIC0zMDgyLDE1ICszMDgyLDE2IEBAIGludCBhbWRn cHVfZGV2aWNlX3N1c3BlbmQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwgYm9vbCBzdXNwZW5kLCBi b29sIGZiY29uKQo+ICAgICAgICAgICovCj4gICAgICAgICBhbWRncHVfYm9fZXZpY3RfdnJhbShh ZGV2KTsKPgo+ICsgICAgICAgYW1kZ3B1X2FzaWNfcmVzZXQoYWRldik7Cj4gKyAgICAgICByID0g YW1kZ3B1X2FzaWNfcmVzZXQoYWRldik7Cj4gKyAgICAgICBpZiAocikKPiArICAgICAgICAgICAg ICAgRFJNX0VSUk9SKCJhbWRncHUgYXNpYyByZXNldCBmYWlsZWRcbiIpOwo+ICsKPiAgICAgICAg IHBjaV9zYXZlX3N0YXRlKGRldi0+cGRldik7Cj4gICAgICAgICBpZiAoc3VzcGVuZCkgewo+ICAg ICAgICAgICAgICAgICAvKiBTaHV0IGRvd24gdGhlIGRldmljZSAqLwo+ICAgICAgICAgICAgICAg ICBwY2lfZGlzYWJsZV9kZXZpY2UoZGV2LT5wZGV2KTsKPiAgICAgICAgICAgICAgICAgcGNpX3Nl dF9wb3dlcl9zdGF0ZShkZXYtPnBkZXYsIFBDSV9EM2hvdCk7Cj4gLSAgICAgICB9IGVsc2Ugewo+ IC0gICAgICAgICAgICAgICByID0gYW1kZ3B1X2FzaWNfcmVzZXQoYWRldik7Cj4gLSAgICAgICAg ICAgICAgIGlmIChyKQo+IC0gICAgICAgICAgICAgICAgICAgICAgIERSTV9FUlJPUigiYW1kZ3B1 IGFzaWMgcmVzZXQgZmFpbGVkXG4iKTsKPiAgICAgICAgIH0KPgo+ICAgICAgICAgcmV0dXJuIDA7 Cj4gLS0KPiAyLjIwLjEKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4gYW1kLWdmeCBtYWlsaW5nIGxpc3QKPiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v YW1kLWdmeApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwph bWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZng=