From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DD36C4332F for ; Tue, 8 Nov 2022 16:25:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234644AbiKHQZJ (ORCPT ); Tue, 8 Nov 2022 11:25:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232035AbiKHQZG (ORCPT ); Tue, 8 Nov 2022 11:25:06 -0500 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2848D1FFB4 for ; Tue, 8 Nov 2022 08:25:05 -0800 (PST) Received: by mail-oi1-x22a.google.com with SMTP id b124so16033087oia.4 for ; Tue, 08 Nov 2022 08:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=a+8Yf/sZNwiNDUj/OMYT77J47waMsvsoaujY8tR8y14=; b=EFa7PkfPRlnNLAkXTEiEnYgZ6Y/YaZgVL3Mejm9llw7t8k9z2FPghpxGNhbq6VFRz2 k7PwoEROsjYqFNWwtx5OsaxUU5VihVUmV33d3R8czegD4Rf9mz6bKtYLqY6LUL3yJ2kw qyM56Dyue5UAeC1R+nQWfRqk54qAo78RUOhkcKka8uYp35x5E655VZB55hwSxBXKGtsk x/YE+JhmfgoapqnX/pKbhmS+Sv7/WyGNIDFWvkvr1D7BohVGprfjMHJSclZc2dSIaVHN 4AHbgUQrN6Mgqb0OFic4NvD3QVYHX5cT6tVHFXkG7c4aH5c91EF6OIz/o4cQLVa0iZcd wneA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a+8Yf/sZNwiNDUj/OMYT77J47waMsvsoaujY8tR8y14=; b=2wDkxe0lEDU/Q85xycQWHw8aDgwZVrOumGW31yrnuQy8kBjlwXj8m4FrMyyF6Jg5K5 REubyPeh2N9Uq1R+EXpYciFZDUMl0zvx41w+AH+LNL3m0uJke5sz3LEoAg/SI6/wPoya jgryTYB00LPuGxCEVB2bcqTJHaDQ6OOUwhoiCd+Sg3dEMK1eFIcgIFy/7UH5l2aIR2ks JFhsr03cu4g0mdE4PRSYEos7UGpw0GgX7BOiE75VAZkIRkpncw7H4Pm5tVTK2eLNwzc4 33h9y/CP+fpluiWu+wz7zgfxcr7brFe8RY/zZ17buH0uTvgWImAkjzICV03sozcoliVT byjw== X-Gm-Message-State: ACrzQf3EVjzhysWkYafqVN8BbrQsZrM3ZqwKyxc9ta9B3DtmAClMf9kE hMxY0dGN9uvp/QjdbC6xfpVB4vYMQmwfHteCkr0= X-Google-Smtp-Source: AMsMyM6FnW3smzsc2vqX42JCVFSvKrKyc0iMu552UOAzqJ/Mwzlw4oMjND0EEJAJMN56tBl6uBS3XHec1Vjmj7CzLVM= X-Received: by 2002:aca:b655:0:b0:35a:4fb4:c3d2 with SMTP id g82-20020acab655000000b0035a4fb4c3d2mr16042060oif.96.1667924704519; Tue, 08 Nov 2022 08:25:04 -0800 (PST) MIME-Version: 1.0 References: <20221107143715.279841-1-carlos.bilbao@amd.com> In-Reply-To: <20221107143715.279841-1-carlos.bilbao@amd.com> From: Alex Deucher Date: Tue, 8 Nov 2022 11:24:52 -0500 Message-ID: Subject: Re: [PATCH] drm/amd/display: Amend descriptions within enum pipe_split_policy To: Carlos Bilbao Cc: harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, Xinhui.Pan@amd.com, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, alexander.deucher@amd.com, jun.lei@amd.com, christian.koenig@amd.com, bilbao@vt.edu Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 7, 2022 at 9:37 AM Carlos Bilbao wrote: > > Correct descriptions of two last fields of enum pipe_split_policy, updating > comments with proper field names. > > Signed-off-by: Carlos Bilbao Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/dc/dc.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h > index bfc5474c0f4c..277631a899d8 100644 > --- a/drivers/gpu/drm/amd/display/dc/dc.h > +++ b/drivers/gpu/drm/amd/display/dc/dc.h > @@ -457,15 +457,16 @@ enum pipe_split_policy { > MPC_SPLIT_DYNAMIC = 0, > > /** > - * @MPC_SPLIT_DYNAMIC: Avoid pipe split, which means that DC will not > + * @MPC_SPLIT_AVOID: Avoid pipe split, which means that DC will not > * try any sort of split optimization. > */ > MPC_SPLIT_AVOID = 1, > > /** > - * @MPC_SPLIT_DYNAMIC: With this option, DC will only try to optimize > - * the pipe utilization when using a single display; if the user > - * connects to a second display, DC will avoid pipe split. > + * @MPC_SPLIT_AVOID_MULT_DISP: With this option, DC will only try > + * to optimize the pipe utilization when using a single display; > + * if the user connects to a second display, DC will avoid pipe > + * split. > */ > MPC_SPLIT_AVOID_MULT_DISP = 2, > }; > -- > 2.34.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BCF69C433FE for ; Tue, 8 Nov 2022 16:25:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4BE7810E3C4; Tue, 8 Nov 2022 16:25:08 +0000 (UTC) Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8380710E3C4; Tue, 8 Nov 2022 16:25:05 +0000 (UTC) Received: by mail-oi1-x229.google.com with SMTP id h132so8155713oif.2; Tue, 08 Nov 2022 08:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=a+8Yf/sZNwiNDUj/OMYT77J47waMsvsoaujY8tR8y14=; b=EFa7PkfPRlnNLAkXTEiEnYgZ6Y/YaZgVL3Mejm9llw7t8k9z2FPghpxGNhbq6VFRz2 k7PwoEROsjYqFNWwtx5OsaxUU5VihVUmV33d3R8czegD4Rf9mz6bKtYLqY6LUL3yJ2kw qyM56Dyue5UAeC1R+nQWfRqk54qAo78RUOhkcKka8uYp35x5E655VZB55hwSxBXKGtsk x/YE+JhmfgoapqnX/pKbhmS+Sv7/WyGNIDFWvkvr1D7BohVGprfjMHJSclZc2dSIaVHN 4AHbgUQrN6Mgqb0OFic4NvD3QVYHX5cT6tVHFXkG7c4aH5c91EF6OIz/o4cQLVa0iZcd wneA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a+8Yf/sZNwiNDUj/OMYT77J47waMsvsoaujY8tR8y14=; b=x+2PxVCxTAiCrPGijX0BJOHkF4t8RfmqJdq/sdNrqlChHCRnXNNVNenyjFNLpM1aub yKZpBtKGBUiHdq7QM/djGg81NVE3/iHQ4KAE6xLqRJTEsOzcfscF8fptj4CWshNaZjQO IuYM69jZYHAZcix/ryzc+P5D1NCcNVDj2YMXi/Qg9aYy7iI5lQSEoayjT1IJqVoW3fDt PXYt//ynjfiIXcHYl344OX4UbjxkuBK0z6kHlUj9QXXCA2gyYcTSi5SXlP/b8KupYkq/ S7HtFYghfNYVoxZvZOTgJZakKuFlO+FBGQ0e1I5nU475tJA0DRqAE8Ngw5af43aJYDlb OBbw== X-Gm-Message-State: ACrzQf0n/Dbw1bsGPYXOQFVwpjY5WpVT1eIOCPtAMG0m/Sqje81bsyJh VBqMfRvWE6p8ey/91oLHDin/3dROoboqsD/+cmQ= X-Google-Smtp-Source: AMsMyM6FnW3smzsc2vqX42JCVFSvKrKyc0iMu552UOAzqJ/Mwzlw4oMjND0EEJAJMN56tBl6uBS3XHec1Vjmj7CzLVM= X-Received: by 2002:aca:b655:0:b0:35a:4fb4:c3d2 with SMTP id g82-20020acab655000000b0035a4fb4c3d2mr16042060oif.96.1667924704519; Tue, 08 Nov 2022 08:25:04 -0800 (PST) MIME-Version: 1.0 References: <20221107143715.279841-1-carlos.bilbao@amd.com> In-Reply-To: <20221107143715.279841-1-carlos.bilbao@amd.com> From: Alex Deucher Date: Tue, 8 Nov 2022 11:24:52 -0500 Message-ID: Subject: Re: [PATCH] drm/amd/display: Amend descriptions within enum pipe_split_policy To: Carlos Bilbao Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sunpeng.li@amd.com, Xinhui.Pan@amd.com, Rodrigo.Siqueira@amd.com, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, alexander.deucher@amd.com, jun.lei@amd.com, christian.koenig@amd.com, bilbao@vt.edu Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Nov 7, 2022 at 9:37 AM Carlos Bilbao wrote: > > Correct descriptions of two last fields of enum pipe_split_policy, updating > comments with proper field names. > > Signed-off-by: Carlos Bilbao Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/dc/dc.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h > index bfc5474c0f4c..277631a899d8 100644 > --- a/drivers/gpu/drm/amd/display/dc/dc.h > +++ b/drivers/gpu/drm/amd/display/dc/dc.h > @@ -457,15 +457,16 @@ enum pipe_split_policy { > MPC_SPLIT_DYNAMIC = 0, > > /** > - * @MPC_SPLIT_DYNAMIC: Avoid pipe split, which means that DC will not > + * @MPC_SPLIT_AVOID: Avoid pipe split, which means that DC will not > * try any sort of split optimization. > */ > MPC_SPLIT_AVOID = 1, > > /** > - * @MPC_SPLIT_DYNAMIC: With this option, DC will only try to optimize > - * the pipe utilization when using a single display; if the user > - * connects to a second display, DC will avoid pipe split. > + * @MPC_SPLIT_AVOID_MULT_DISP: With this option, DC will only try > + * to optimize the pipe utilization when using a single display; > + * if the user connects to a second display, DC will avoid pipe > + * split. > */ > MPC_SPLIT_AVOID_MULT_DISP = 2, > }; > -- > 2.34.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1FFEC4332F for ; Tue, 8 Nov 2022 16:25:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E20ED10E4C2; Tue, 8 Nov 2022 16:25:12 +0000 (UTC) Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8380710E3C4; Tue, 8 Nov 2022 16:25:05 +0000 (UTC) Received: by mail-oi1-x229.google.com with SMTP id h132so8155713oif.2; Tue, 08 Nov 2022 08:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=a+8Yf/sZNwiNDUj/OMYT77J47waMsvsoaujY8tR8y14=; b=EFa7PkfPRlnNLAkXTEiEnYgZ6Y/YaZgVL3Mejm9llw7t8k9z2FPghpxGNhbq6VFRz2 k7PwoEROsjYqFNWwtx5OsaxUU5VihVUmV33d3R8czegD4Rf9mz6bKtYLqY6LUL3yJ2kw qyM56Dyue5UAeC1R+nQWfRqk54qAo78RUOhkcKka8uYp35x5E655VZB55hwSxBXKGtsk x/YE+JhmfgoapqnX/pKbhmS+Sv7/WyGNIDFWvkvr1D7BohVGprfjMHJSclZc2dSIaVHN 4AHbgUQrN6Mgqb0OFic4NvD3QVYHX5cT6tVHFXkG7c4aH5c91EF6OIz/o4cQLVa0iZcd wneA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a+8Yf/sZNwiNDUj/OMYT77J47waMsvsoaujY8tR8y14=; b=x+2PxVCxTAiCrPGijX0BJOHkF4t8RfmqJdq/sdNrqlChHCRnXNNVNenyjFNLpM1aub yKZpBtKGBUiHdq7QM/djGg81NVE3/iHQ4KAE6xLqRJTEsOzcfscF8fptj4CWshNaZjQO IuYM69jZYHAZcix/ryzc+P5D1NCcNVDj2YMXi/Qg9aYy7iI5lQSEoayjT1IJqVoW3fDt PXYt//ynjfiIXcHYl344OX4UbjxkuBK0z6kHlUj9QXXCA2gyYcTSi5SXlP/b8KupYkq/ S7HtFYghfNYVoxZvZOTgJZakKuFlO+FBGQ0e1I5nU475tJA0DRqAE8Ngw5af43aJYDlb OBbw== X-Gm-Message-State: ACrzQf0n/Dbw1bsGPYXOQFVwpjY5WpVT1eIOCPtAMG0m/Sqje81bsyJh VBqMfRvWE6p8ey/91oLHDin/3dROoboqsD/+cmQ= X-Google-Smtp-Source: AMsMyM6FnW3smzsc2vqX42JCVFSvKrKyc0iMu552UOAzqJ/Mwzlw4oMjND0EEJAJMN56tBl6uBS3XHec1Vjmj7CzLVM= X-Received: by 2002:aca:b655:0:b0:35a:4fb4:c3d2 with SMTP id g82-20020acab655000000b0035a4fb4c3d2mr16042060oif.96.1667924704519; Tue, 08 Nov 2022 08:25:04 -0800 (PST) MIME-Version: 1.0 References: <20221107143715.279841-1-carlos.bilbao@amd.com> In-Reply-To: <20221107143715.279841-1-carlos.bilbao@amd.com> From: Alex Deucher Date: Tue, 8 Nov 2022 11:24:52 -0500 Message-ID: Subject: Re: [PATCH] drm/amd/display: Amend descriptions within enum pipe_split_policy To: Carlos Bilbao Content-Type: text/plain; charset="UTF-8" X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: sunpeng.li@amd.com, Xinhui.Pan@amd.com, Rodrigo.Siqueira@amd.com, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, alexander.deucher@amd.com, jun.lei@amd.com, harry.wentland@amd.com, christian.koenig@amd.com, bilbao@vt.edu Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Mon, Nov 7, 2022 at 9:37 AM Carlos Bilbao wrote: > > Correct descriptions of two last fields of enum pipe_split_policy, updating > comments with proper field names. > > Signed-off-by: Carlos Bilbao Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/display/dc/dc.h | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h > index bfc5474c0f4c..277631a899d8 100644 > --- a/drivers/gpu/drm/amd/display/dc/dc.h > +++ b/drivers/gpu/drm/amd/display/dc/dc.h > @@ -457,15 +457,16 @@ enum pipe_split_policy { > MPC_SPLIT_DYNAMIC = 0, > > /** > - * @MPC_SPLIT_DYNAMIC: Avoid pipe split, which means that DC will not > + * @MPC_SPLIT_AVOID: Avoid pipe split, which means that DC will not > * try any sort of split optimization. > */ > MPC_SPLIT_AVOID = 1, > > /** > - * @MPC_SPLIT_DYNAMIC: With this option, DC will only try to optimize > - * the pipe utilization when using a single display; if the user > - * connects to a second display, DC will avoid pipe split. > + * @MPC_SPLIT_AVOID_MULT_DISP: With this option, DC will only try > + * to optimize the pipe utilization when using a single display; > + * if the user connects to a second display, DC will avoid pipe > + * split. > */ > MPC_SPLIT_AVOID_MULT_DISP = 2, > }; > -- > 2.34.1 >