From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95501C2D0A3 for ; Mon, 9 Nov 2020 19:54:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31C41206B6 for ; Mon, 9 Nov 2020 19:54:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u5xWIKC8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730932AbgKITyY (ORCPT ); Mon, 9 Nov 2020 14:54:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730456AbgKITyY (ORCPT ); Mon, 9 Nov 2020 14:54:24 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A163C0613CF; Mon, 9 Nov 2020 11:54:23 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id w24so674122wmi.0; Mon, 09 Nov 2020 11:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=blMIJqfyn+uYrIFhsDadDE528X0wnbKqoGnhBSRDkeM=; b=u5xWIKC81MwGnxL3ZjOcHeoE1X2iT8RKWt/1qo7ewqCC7mQzZtP4agtlhLt+Xv3ruY Uqa330apvJSitaJJG0zCSGiyktUKXBfP6w/3IlF1Jo1NxBINNCIhYd1CXg1oOSeBq11R kB61Te1dsOTwoa2vpAV4dNXU6uJeazJ8yZGYMSse1eS2hLj6cuwfhl2JLj/gqEQzjCio 1QS4DSVw0MiI08NFaL36g858sQ/n61UPXXTxQyddILRnVaNCuzmHphfscz5avJZ+zOXI Ta9JOVzDO9+4V8XYpMsHhM71tpJzfa8fJatHcwX0HDHm+a32ST+bweskKKQgMYUppdBh qGJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=blMIJqfyn+uYrIFhsDadDE528X0wnbKqoGnhBSRDkeM=; b=CgC6Sm8ax5egTEf/mCSQrInHV3RW2SkpN/FcZSxksSI/BiLmHkECgQ8KSEIa1Qon0w QKWgK+zJ7zGSpL05NkblT/e1glI1BNCScfij6NmCxotVGlGCKgfOVdE86EBjrbDhyyne XEsAn45H0/C7o+9oHqXFOqzG5AonaBjFnjXIF/Bx2J+UEAiOlV0+lpxTdsI+h8ZE3Hub l2X8+7/+8OwbjV88E2mUGv1dN22yQsDbzVVPFymZvJntu6p/w2/WrGdTVcXikmECGxw+ Ifexx/SOqeB16HNFYPPuxipSVi2V3PkTfdM7hZJgvdI/ddez6RyqidY08CBKomIhLhHx wMHQ== X-Gm-Message-State: AOAM532WmwnOXlfTejmUbZEk8SLaRfLyxSid/neXFyYHqpNO3sy1se5g LDzrb1wybovdcxw8iX5hAG/38EAHSQOTK+Zwz+0= X-Google-Smtp-Source: ABdhPJwBfuZyATovbM1IuUQM7O9GPHy39nSVLi118te05KekkpRznL9TPLcotUXqnnlLAjOq/3YWZAYPQzHgpZpgxV0= X-Received: by 2002:a1c:1c3:: with SMTP id 186mr820881wmb.39.1604951662293; Mon, 09 Nov 2020 11:54:22 -0800 (PST) MIME-Version: 1.0 References: <20201106214949.2042120-1-lee.jones@linaro.org> <20201106214949.2042120-15-lee.jones@linaro.org> In-Reply-To: <20201106214949.2042120-15-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 9 Nov 2020 14:54:11 -0500 Message-ID: Subject: Re: [PATCH 14/19] drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' params To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , =?UTF-8?Q?Christian_K=C3=B6nig?= , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Maling list - DRI developers , Alex Deucher , linux-media Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 6, 2020 at 4:50 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:594: warning: Function parame= ter or member 'reg_addr' not described in 'amdgpu_device_indirect_rreg' > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:624: warning: Function parame= ter or member 'reg_addr' not described in 'amdgpu_device_indirect_rreg64' > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm= /amd/amdgpu/amdgpu_device.c > index 300fcade4a2b1..63374d12e00fe 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c > @@ -585,6 +585,7 @@ void amdgpu_mm_wdoorbell64(struct amdgpu_device *adev= , u32 index, u64 v) > * @adev: amdgpu_device pointer > * @pcie_index: mmio register offset > * @pcie_data: mmio register offset > + * @reg_addr: indirect register address to read from > * > * Returns the value of indirect register @reg_addr > */ > @@ -615,6 +616,7 @@ u32 amdgpu_device_indirect_rreg(struct amdgpu_device = *adev, > * @adev: amdgpu_device pointer > * @pcie_index: mmio register offset > * @pcie_data: mmio register offset > + * @reg_addr: indirect register address to read from > * > * Returns the value of indirect register @reg_addr > */ > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F948C5517A for ; Mon, 9 Nov 2020 19:54:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1708206D8 for ; Mon, 9 Nov 2020 19:54:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u5xWIKC8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1708206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D386389261; Mon, 9 Nov 2020 19:54:24 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BAC9891BF; Mon, 9 Nov 2020 19:54:23 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id v5so688267wmh.1; Mon, 09 Nov 2020 11:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=blMIJqfyn+uYrIFhsDadDE528X0wnbKqoGnhBSRDkeM=; b=u5xWIKC81MwGnxL3ZjOcHeoE1X2iT8RKWt/1qo7ewqCC7mQzZtP4agtlhLt+Xv3ruY Uqa330apvJSitaJJG0zCSGiyktUKXBfP6w/3IlF1Jo1NxBINNCIhYd1CXg1oOSeBq11R kB61Te1dsOTwoa2vpAV4dNXU6uJeazJ8yZGYMSse1eS2hLj6cuwfhl2JLj/gqEQzjCio 1QS4DSVw0MiI08NFaL36g858sQ/n61UPXXTxQyddILRnVaNCuzmHphfscz5avJZ+zOXI Ta9JOVzDO9+4V8XYpMsHhM71tpJzfa8fJatHcwX0HDHm+a32ST+bweskKKQgMYUppdBh qGJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=blMIJqfyn+uYrIFhsDadDE528X0wnbKqoGnhBSRDkeM=; b=ATh3PoSDXxqVjoQ3HZyXBd1eG8zBfFE21DKnpMwsKCBLFWc22ZbMDsIr5tAlixAIiY qxzUvqXve+XTNNN7hksnR2/Ws4yyBeE6F4VF6hnVz/F6xmn1RII1MnMPzUMrNhqAMAw/ zOhzSZ5EnkYp8VrXqYDcZPaVxcmhDuSnOlN9YFPpkF5TTuFHvl2iiuAklvZBfopbebus dZz/O0khd7rqE1bXTDHWToOPZB/RITcwZsrVS1519Gf7rvKoFv0tlsiiYf5T4q74Kra0 ICpJblDbk946CM80tZquzho7dqZJDH2GIW084Z8OcrmbKCNLi9DBicJdHRNGgXsHJ8eQ VjpQ== X-Gm-Message-State: AOAM531h6mbg/RzWamkioT2jjqU60Wa3FopYemK5inUSXLEf5joyiZDj Naka+7/JCaMiF7o4As/HfabHySFVEc5Vl5Mf+g1Qa8fQH0w= X-Google-Smtp-Source: ABdhPJwBfuZyATovbM1IuUQM7O9GPHy39nSVLi118te05KekkpRznL9TPLcotUXqnnlLAjOq/3YWZAYPQzHgpZpgxV0= X-Received: by 2002:a1c:1c3:: with SMTP id 186mr820881wmb.39.1604951662293; Mon, 09 Nov 2020 11:54:22 -0800 (PST) MIME-Version: 1.0 References: <20201106214949.2042120-1-lee.jones@linaro.org> <20201106214949.2042120-15-lee.jones@linaro.org> In-Reply-To: <20201106214949.2042120-15-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 9 Nov 2020 14:54:11 -0500 Message-ID: Subject: Re: [PATCH 14/19] drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' params To: Lee Jones X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , "moderated list:DMA BUFFER SHARING FRAMEWORK" , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-media Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gRnJpLCBOb3YgNiwgMjAyMCBhdCA0OjUwIFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+IHdyb3RlOgo+Cj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdh cm5pbmcocyk6Cj4KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5j OjU5NDogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAncmVnX2FkZHInIG5v dCBkZXNjcmliZWQgaW4gJ2FtZGdwdV9kZXZpY2VfaW5kaXJlY3RfcnJlZycKPiAgZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jOjYyNDogd2FybmluZzogRnVuY3Rpb24g cGFyYW1ldGVyIG9yIG1lbWJlciAncmVnX2FkZHInIG5vdCBkZXNjcmliZWQgaW4gJ2FtZGdwdV9k ZXZpY2VfaW5kaXJlY3RfcnJlZzY0Jwo+Cj4gQ2M6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRl dWNoZXJAYW1kLmNvbT4KPiBDYzogIkNocmlzdGlhbiBLw7ZuaWciIDxjaHJpc3RpYW4ua29lbmln QGFtZC5jb20+Cj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiBDYzogRGFu aWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+IENjOiBTdW1pdCBTZW13YWwgPHN1bWl0LnNl bXdhbEBsaW5hcm8ub3JnPgo+IENjOiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENj OiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIu a2VybmVsLm9yZwo+IENjOiBsaW5hcm8tbW0tc2lnQGxpc3RzLmxpbmFyby5vcmcKPiBTaWduZWQt b2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgoKQXBwbGllZC4gIFRoYW5r cyEKCkFsZXgKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZp Y2UuYyB8IDIgKysKPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+IGluZGV4IDMwMGZjYWRlNGEy YjEuLjYzMzc0ZDEyZTAwZmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2RldmljZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X2RldmljZS5jCj4gQEAgLTU4NSw2ICs1ODUsNyBAQCB2b2lkIGFtZGdwdV9tbV93ZG9vcmJl bGw2NChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgdTMyIGluZGV4LCB1NjQgdikKPiAgICog QGFkZXY6IGFtZGdwdV9kZXZpY2UgcG9pbnRlcgo+ICAgKiBAcGNpZV9pbmRleDogbW1pbyByZWdp c3RlciBvZmZzZXQKPiAgICogQHBjaWVfZGF0YTogbW1pbyByZWdpc3RlciBvZmZzZXQKPiArICog QHJlZ19hZGRyOiBpbmRpcmVjdCByZWdpc3RlciBhZGRyZXNzIHRvIHJlYWQgZnJvbQo+ICAgKgo+ ICAgKiBSZXR1cm5zIHRoZSB2YWx1ZSBvZiBpbmRpcmVjdCByZWdpc3RlciBAcmVnX2FkZHIKPiAg ICovCj4gQEAgLTYxNSw2ICs2MTYsNyBAQCB1MzIgYW1kZ3B1X2RldmljZV9pbmRpcmVjdF9ycmVn KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICAgKiBAYWRldjogYW1kZ3B1X2RldmljZSBw b2ludGVyCj4gICAqIEBwY2llX2luZGV4OiBtbWlvIHJlZ2lzdGVyIG9mZnNldAo+ICAgKiBAcGNp ZV9kYXRhOiBtbWlvIHJlZ2lzdGVyIG9mZnNldAo+ICsgKiBAcmVnX2FkZHI6IGluZGlyZWN0IHJl Z2lzdGVyIGFkZHJlc3MgdG8gcmVhZCBmcm9tCj4gICAqCj4gICAqIFJldHVybnMgdGhlIHZhbHVl IG9mIGluZGlyZWN0IHJlZ2lzdGVyIEByZWdfYWRkcgo+ICAgKi8KPiAtLQo+IDIuMjUuMQo+Cj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2 ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E25C388F7 for ; Mon, 9 Nov 2020 19:54:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 321CE206B6 for ; Mon, 9 Nov 2020 19:54:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="u5xWIKC8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 321CE206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 995AD8924C; Mon, 9 Nov 2020 19:54:24 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BAC9891BF; Mon, 9 Nov 2020 19:54:23 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id v5so688267wmh.1; Mon, 09 Nov 2020 11:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=blMIJqfyn+uYrIFhsDadDE528X0wnbKqoGnhBSRDkeM=; b=u5xWIKC81MwGnxL3ZjOcHeoE1X2iT8RKWt/1qo7ewqCC7mQzZtP4agtlhLt+Xv3ruY Uqa330apvJSitaJJG0zCSGiyktUKXBfP6w/3IlF1Jo1NxBINNCIhYd1CXg1oOSeBq11R kB61Te1dsOTwoa2vpAV4dNXU6uJeazJ8yZGYMSse1eS2hLj6cuwfhl2JLj/gqEQzjCio 1QS4DSVw0MiI08NFaL36g858sQ/n61UPXXTxQyddILRnVaNCuzmHphfscz5avJZ+zOXI Ta9JOVzDO9+4V8XYpMsHhM71tpJzfa8fJatHcwX0HDHm+a32ST+bweskKKQgMYUppdBh qGJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=blMIJqfyn+uYrIFhsDadDE528X0wnbKqoGnhBSRDkeM=; b=ATh3PoSDXxqVjoQ3HZyXBd1eG8zBfFE21DKnpMwsKCBLFWc22ZbMDsIr5tAlixAIiY qxzUvqXve+XTNNN7hksnR2/Ws4yyBeE6F4VF6hnVz/F6xmn1RII1MnMPzUMrNhqAMAw/ zOhzSZ5EnkYp8VrXqYDcZPaVxcmhDuSnOlN9YFPpkF5TTuFHvl2iiuAklvZBfopbebus dZz/O0khd7rqE1bXTDHWToOPZB/RITcwZsrVS1519Gf7rvKoFv0tlsiiYf5T4q74Kra0 ICpJblDbk946CM80tZquzho7dqZJDH2GIW084Z8OcrmbKCNLi9DBicJdHRNGgXsHJ8eQ VjpQ== X-Gm-Message-State: AOAM531h6mbg/RzWamkioT2jjqU60Wa3FopYemK5inUSXLEf5joyiZDj Naka+7/JCaMiF7o4As/HfabHySFVEc5Vl5Mf+g1Qa8fQH0w= X-Google-Smtp-Source: ABdhPJwBfuZyATovbM1IuUQM7O9GPHy39nSVLi118te05KekkpRznL9TPLcotUXqnnlLAjOq/3YWZAYPQzHgpZpgxV0= X-Received: by 2002:a1c:1c3:: with SMTP id 186mr820881wmb.39.1604951662293; Mon, 09 Nov 2020 11:54:22 -0800 (PST) MIME-Version: 1.0 References: <20201106214949.2042120-1-lee.jones@linaro.org> <20201106214949.2042120-15-lee.jones@linaro.org> In-Reply-To: <20201106214949.2042120-15-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 9 Nov 2020 14:54:11 -0500 Message-ID: Subject: Re: [PATCH 14/19] drm/amd/amdgpu/amdgpu_device: Provide documentation for 'reg_addr' params To: Lee Jones X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , "moderated list:DMA BUFFER SHARING FRAMEWORK" , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-media Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gRnJpLCBOb3YgNiwgMjAyMCBhdCA0OjUwIFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+IHdyb3RlOgo+Cj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdh cm5pbmcocyk6Cj4KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5j OjU5NDogd2FybmluZzogRnVuY3Rpb24gcGFyYW1ldGVyIG9yIG1lbWJlciAncmVnX2FkZHInIG5v dCBkZXNjcmliZWQgaW4gJ2FtZGdwdV9kZXZpY2VfaW5kaXJlY3RfcnJlZycKPiAgZHJpdmVycy9n cHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2RldmljZS5jOjYyNDogd2FybmluZzogRnVuY3Rpb24g cGFyYW1ldGVyIG9yIG1lbWJlciAncmVnX2FkZHInIG5vdCBkZXNjcmliZWQgaW4gJ2FtZGdwdV9k ZXZpY2VfaW5kaXJlY3RfcnJlZzY0Jwo+Cj4gQ2M6IEFsZXggRGV1Y2hlciA8YWxleGFuZGVyLmRl dWNoZXJAYW1kLmNvbT4KPiBDYzogIkNocmlzdGlhbiBLw7ZuaWciIDxjaHJpc3RpYW4ua29lbmln QGFtZC5jb20+Cj4gQ2M6IERhdmlkIEFpcmxpZSA8YWlybGllZEBsaW51eC5pZT4KPiBDYzogRGFu aWVsIFZldHRlciA8ZGFuaWVsQGZmd2xsLmNoPgo+IENjOiBTdW1pdCBTZW13YWwgPHN1bWl0LnNl bXdhbEBsaW5hcm8ub3JnPgo+IENjOiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENj OiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gQ2M6IGxpbnV4LW1lZGlhQHZnZXIu a2VybmVsLm9yZwo+IENjOiBsaW5hcm8tbW0tc2lnQGxpc3RzLmxpbmFyby5vcmcKPiBTaWduZWQt b2ZmLWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgoKQXBwbGllZC4gIFRoYW5r cyEKCkFsZXgKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZp Y2UuYyB8IDIgKysKPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKQo+Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYwo+IGluZGV4IDMwMGZjYWRlNGEy YjEuLjYzMzc0ZDEyZTAwZmUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1X2RldmljZS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X2RldmljZS5jCj4gQEAgLTU4NSw2ICs1ODUsNyBAQCB2b2lkIGFtZGdwdV9tbV93ZG9vcmJl bGw2NChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwgdTMyIGluZGV4LCB1NjQgdikKPiAgICog QGFkZXY6IGFtZGdwdV9kZXZpY2UgcG9pbnRlcgo+ICAgKiBAcGNpZV9pbmRleDogbW1pbyByZWdp c3RlciBvZmZzZXQKPiAgICogQHBjaWVfZGF0YTogbW1pbyByZWdpc3RlciBvZmZzZXQKPiArICog QHJlZ19hZGRyOiBpbmRpcmVjdCByZWdpc3RlciBhZGRyZXNzIHRvIHJlYWQgZnJvbQo+ICAgKgo+ ICAgKiBSZXR1cm5zIHRoZSB2YWx1ZSBvZiBpbmRpcmVjdCByZWdpc3RlciBAcmVnX2FkZHIKPiAg ICovCj4gQEAgLTYxNSw2ICs2MTYsNyBAQCB1MzIgYW1kZ3B1X2RldmljZV9pbmRpcmVjdF9ycmVn KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICAgKiBAYWRldjogYW1kZ3B1X2RldmljZSBw b2ludGVyCj4gICAqIEBwY2llX2luZGV4OiBtbWlvIHJlZ2lzdGVyIG9mZnNldAo+ICAgKiBAcGNp ZV9kYXRhOiBtbWlvIHJlZ2lzdGVyIG9mZnNldAo+ICsgKiBAcmVnX2FkZHI6IGluZGlyZWN0IHJl Z2lzdGVyIGFkZHJlc3MgdG8gcmVhZCBmcm9tCj4gICAqCj4gICAqIFJldHVybnMgdGhlIHZhbHVl IG9mIGluZGlyZWN0IHJlZ2lzdGVyIEByZWdfYWRkcgo+ICAgKi8KPiAtLQo+IDIuMjUuMQo+Cj4g X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2 ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGlu ZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=