All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: Prike Liang <Prike.Liang@amd.com>
Cc: Alexander.Deucher@amd.com, Yifan1.Zhang@amd.com,
	ray.huang@amd.com, aaron.liu@amd.com,
	amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/amdkfd: update gfx1037 Lx cache setting
Date: Thu, 20 Oct 2022 09:15:36 -0400	[thread overview]
Message-ID: <CADnq5_MBs7Cx9jGxBDNt0gv0ioT+N8jzKV3pRf2R2tfWzxZj8g@mail.gmail.com> (raw)
In-Reply-To: <20221020091515.2758445-2-Prike.Liang@amd.com>

Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

On Thu, Oct 20, 2022 at 5:15 AM Prike Liang <Prike.Liang@amd.com> wrote:
>
> Update the gfx1037 L1/L2/L3 cache setting.
>
> Signed-off-by: Prike Liang <Prike.Liang@amd.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 53 +++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index 960046e43b7a..6e699cb9971f 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -795,6 +795,55 @@ static struct kfd_gpu_cache_info yellow_carp_cache_info[] = {
>         },
>  };
>
> +static struct kfd_gpu_cache_info gfx1037_cache_info[] = {
> +       {
> +               /* TCP L1 Cache per CU */
> +               .cache_size = 16,
> +               .cache_level = 1,
> +               .flags = (CRAT_CACHE_FLAGS_ENABLED |
> +                               CRAT_CACHE_FLAGS_DATA_CACHE |
> +                               CRAT_CACHE_FLAGS_SIMD_CACHE),
> +               .num_cu_shared = 1,
> +       },
> +       {
> +               /* Scalar L1 Instruction Cache per SQC */
> +               .cache_size = 32,
> +               .cache_level = 1,
> +               .flags = (CRAT_CACHE_FLAGS_ENABLED |
> +                               CRAT_CACHE_FLAGS_INST_CACHE |
> +                               CRAT_CACHE_FLAGS_SIMD_CACHE),
> +               .num_cu_shared = 2,
> +       },
> +       {
> +               /* Scalar L1 Data Cache per SQC */
> +               .cache_size = 16,
> +               .cache_level = 1,
> +               .flags = (CRAT_CACHE_FLAGS_ENABLED |
> +                               CRAT_CACHE_FLAGS_DATA_CACHE |
> +                               CRAT_CACHE_FLAGS_SIMD_CACHE),
> +               .num_cu_shared = 2,
> +       },
> +       {
> +               /* GL1 Data Cache per SA */
> +               .cache_size = 128,
> +               .cache_level = 1,
> +               .flags = (CRAT_CACHE_FLAGS_ENABLED |
> +                               CRAT_CACHE_FLAGS_DATA_CACHE |
> +                               CRAT_CACHE_FLAGS_SIMD_CACHE),
> +               .num_cu_shared = 2,
> +       },
> +       {
> +               /* L2 Data Cache per GPU (Total Tex Cache) */
> +               .cache_size = 256,
> +               .cache_level = 2,
> +               .flags = (CRAT_CACHE_FLAGS_ENABLED |
> +                               CRAT_CACHE_FLAGS_DATA_CACHE |
> +                               CRAT_CACHE_FLAGS_SIMD_CACHE),
> +               .num_cu_shared = 2,
> +       },
> +};
> +
> +
>  static struct kfd_gpu_cache_info dummy_cache_info[] = {
>         {
>                 /* TCP L1 Cache per CU */
> @@ -1565,6 +1614,10 @@ static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev,
>                         pcache_info = yellow_carp_cache_info;
>                         num_of_cache_types = ARRAY_SIZE(yellow_carp_cache_info);
>                         break;
> +               case IP_VERSION(10, 3, 7):
> +                       pcache_info = gfx1037_cache_info;
> +                       num_of_cache_types = ARRAY_SIZE(gfx1037_cache_info);
> +                       break;
>                 case IP_VERSION(11, 0, 0):
>                 case IP_VERSION(11, 0, 1):
>                 case IP_VERSION(11, 0, 2):
> --
> 2.25.1
>

  reply	other threads:[~2022-10-20 13:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-20  9:15 [PATCH 1/2] drm/amdkfd: introduce dummy cache info for property asic Prike Liang
2022-10-20  9:15 ` [PATCH 2/2] drm/amdkfd: update gfx1037 Lx cache setting Prike Liang
2022-10-20 13:15   ` Alex Deucher [this message]
2022-10-20 16:02 ` [PATCH 1/2] drm/amdkfd: introduce dummy cache info for property asic Felix Kuehling
2022-10-21  1:50   ` Liang, Prike
2022-10-21  5:10     ` Felix Kuehling
2022-10-21 13:05       ` Liang, Prike
2022-10-21 20:53         ` Felix Kuehling
2022-10-24 13:11           ` Liang, Prike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADnq5_MBs7Cx9jGxBDNt0gv0ioT+N8jzKV3pRf2R2tfWzxZj8g@mail.gmail.com \
    --to=alexdeucher@gmail.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=Prike.Liang@amd.com \
    --cc=Yifan1.Zhang@amd.com \
    --cc=aaron.liu@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=ray.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.