All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: Evan Quan <evan.quan@amd.com>
Cc: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 3/3] drm/amd/powerplay: perform PG ungate prior to CG ungate
Date: Thu, 30 Apr 2020 09:24:08 -0400	[thread overview]
Message-ID: <CADnq5_MCX+ys00ezni7Ly6tNVhg=twryKticrj6qdJcpvqU2mw@mail.gmail.com> (raw)
In-Reply-To: <20200430064331.23502-3-evan.quan@amd.com>

On Thu, Apr 30, 2020 at 2:44 AM Evan Quan <evan.quan@amd.com> wrote:
>
> Since gfxoff should be disabled first before trying to access those
> GC registers.
>
> Change-Id: I5bf0fbe01fa05c89bbb392ef40e11c07edfee039
> Signed-off-by: Evan Quan <evan.quan@amd.com>

Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 6 +++---
>  drivers/gpu/drm/amd/powerplay/amdgpu_smu.c    | 6 +++---
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> index fdff3e1c5e95..96c91bb70df5 100644
> --- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> +++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
> @@ -322,12 +322,12 @@ static void pp_dpm_en_umd_pstate(struct pp_hwmgr  *hwmgr,
>                 if (*level & profile_mode_mask) {
>                         hwmgr->saved_dpm_level = hwmgr->dpm_level;
>                         hwmgr->en_umd_pstate = true;
> -                       amdgpu_device_ip_set_clockgating_state(hwmgr->adev,
> -                                               AMD_IP_BLOCK_TYPE_GFX,
> -                                               AMD_CG_STATE_UNGATE);
>                         amdgpu_device_ip_set_powergating_state(hwmgr->adev,
>                                         AMD_IP_BLOCK_TYPE_GFX,
>                                         AMD_PG_STATE_UNGATE);
> +                       amdgpu_device_ip_set_clockgating_state(hwmgr->adev,
> +                                               AMD_IP_BLOCK_TYPE_GFX,
> +                                               AMD_CG_STATE_UNGATE);
>                 }
>         } else {
>                 /* exit umd pstate, restore level, enable gfx cg*/
> diff --git a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> index 12810fd81d5d..e6252bcaa641 100644
> --- a/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> +++ b/drivers/gpu/drm/amd/powerplay/amdgpu_smu.c
> @@ -1780,12 +1780,12 @@ static int smu_enable_umd_pstate(void *handle,
>                 if (*level & profile_mode_mask) {
>                         smu_dpm_ctx->saved_dpm_level = smu_dpm_ctx->dpm_level;
>                         smu_dpm_ctx->enable_umd_pstate = true;
> -                       amdgpu_device_ip_set_clockgating_state(smu->adev,
> -                                                              AMD_IP_BLOCK_TYPE_GFX,
> -                                                              AMD_CG_STATE_UNGATE);
>                         amdgpu_device_ip_set_powergating_state(smu->adev,
>                                                                AMD_IP_BLOCK_TYPE_GFX,
>                                                                AMD_PG_STATE_UNGATE);
> +                       amdgpu_device_ip_set_clockgating_state(smu->adev,
> +                                                              AMD_IP_BLOCK_TYPE_GFX,
> +                                                              AMD_CG_STATE_UNGATE);
>                 }
>         } else {
>                 /* exit umd pstate, restore level, enable gfx cg*/
> --
> 2.26.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      reply	other threads:[~2020-04-30 13:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30  6:43 [PATCH 1/3] drm/amdgpu: disable MGCG/MGLS also on gfx CG ungate Evan Quan
2020-04-30  6:43 ` [PATCH 2/3] drm/amdgpu: drop unnecessary cancel_delayed_work_sync on PG ungate Evan Quan
2020-04-30  6:43 ` [PATCH 3/3] drm/amd/powerplay: perform PG ungate prior to CG ungate Evan Quan
2020-04-30 13:24   ` Alex Deucher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADnq5_MCX+ys00ezni7Ly6tNVhg=twryKticrj6qdJcpvqU2mw@mail.gmail.com' \
    --to=alexdeucher@gmail.com \
    --cc=Alexander.Deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=evan.quan@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.