From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965341AbdKQTwy (ORCPT ); Fri, 17 Nov 2017 14:52:54 -0500 Received: from mail-yw0-f171.google.com ([209.85.161.171]:36536 "EHLO mail-yw0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965179AbdKQTwq (ORCPT ); Fri, 17 Nov 2017 14:52:46 -0500 X-Google-Smtp-Source: AGs4zManIOp9NR8qCd32Eu2qZyS462JMMqyFxC2UlyBotqd/fzdH0v7199rqGwUKUakoNA/goFEF/IXvwzTznmKeHfE= MIME-Version: 1.0 In-Reply-To: <1510847412.31559.25.camel@perches.com> References: <1b2c63b7-319a-caab-6809-197784c179ef@amd.com> <1510847412.31559.25.camel@perches.com> From: Alex Deucher Date: Fri, 17 Nov 2017 14:52:45 -0500 Message-ID: Subject: Re: [PATCH 2/4] drm: amd: Fix line continuation formats To: Joe Perches Cc: Harry Wentland , LKML , Alex Deucher , David Airlie , amd-gfx list , =?UTF-8?Q?Christian_K=C3=B6nig?= , Maling list - DRI developers Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 16, 2017 at 10:50 AM, Joe Perches wrote: > On Thu, 2017-11-16 at 10:38 -0500, Harry Wentland wrote: >> On 2017-11-16 10:27 AM, Joe Perches wrote: >> > Line continuations with excess spacing causes unexpected output. > [] >> > @@ -872,9 +870,8 @@ static bool perform_clock_recovery_sequence( >> > if (retry_count >= LINK_TRAINING_MAX_CR_RETRY) { >> > ASSERT(0); >> > dm_logger_write(link->ctx->logger, LOG_ERROR, >> > - "%s: Link Training Error, could not \ >> > - get CR after %d tries. \ >> > - Possibly voltage swing issue", __func__, >> > + "%s: Link Training Error, could not get CR after %d tries. Possibly voltage swing issue", >> >> Would probably be good to add a '\n' here as well but that's not the main intention of this patch. > > About 1/4 of the dm_logger_write calls are missing > newlines and I think it should be a separate patch. > > I encourage you to fix them one day. > >> Reviewed-by: Harry Wentland > > cheers, Joe Applied. Thanks! Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH 2/4] drm: amd: Fix line continuation formats Date: Fri, 17 Nov 2017 14:52:45 -0500 Message-ID: References: <1b2c63b7-319a-caab-6809-197784c179ef@amd.com> <1510847412.31559.25.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1510847412.31559.25.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Joe Perches Cc: David Airlie , LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , Harry Wentland , =?UTF-8?Q?Christian_K=C3=B6nig?= List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMTYsIDIwMTcgYXQgMTA6NTAgQU0sIEpvZSBQZXJjaGVzIDxqb2VAcGVyY2hl cy5jb20+IHdyb3RlOgo+IE9uIFRodSwgMjAxNy0xMS0xNiBhdCAxMDozOCAtMDUwMCwgSGFycnkg V2VudGxhbmQgd3JvdGU6Cj4+IE9uIDIwMTctMTEtMTYgMTA6MjcgQU0sIEpvZSBQZXJjaGVzIHdy b3RlOgo+PiA+IExpbmUgY29udGludWF0aW9ucyB3aXRoIGV4Y2VzcyBzcGFjaW5nIGNhdXNlcyB1 bmV4cGVjdGVkIG91dHB1dC4KPiBbXQo+PiA+IEBAIC04NzIsOSArODcwLDggQEAgc3RhdGljIGJv b2wgcGVyZm9ybV9jbG9ja19yZWNvdmVyeV9zZXF1ZW5jZSgKPj4gPiAgICAgaWYgKHJldHJ5X2Nv dW50ID49IExJTktfVFJBSU5JTkdfTUFYX0NSX1JFVFJZKSB7Cj4+ID4gICAgICAgICAgICAgQVNT RVJUKDApOwo+PiA+ICAgICAgICAgICAgIGRtX2xvZ2dlcl93cml0ZShsaW5rLT5jdHgtPmxvZ2dl ciwgTE9HX0VSUk9SLAo+PiA+IC0gICAgICAgICAgICAgICAgICAgIiVzOiBMaW5rIFRyYWluaW5n IEVycm9yLCBjb3VsZCBub3QgXAo+PiA+IC0gICAgICAgICAgICAgICAgICAgIGdldCBDUiBhZnRl ciAlZCB0cmllcy4gXAo+PiA+IC0gICAgICAgICAgICAgICAgICAgUG9zc2libHkgdm9sdGFnZSBz d2luZyBpc3N1ZSIsIF9fZnVuY19fLAo+PiA+ICsgICAgICAgICAgICAgICAgICAgIiVzOiBMaW5r IFRyYWluaW5nIEVycm9yLCBjb3VsZCBub3QgZ2V0IENSIGFmdGVyICVkIHRyaWVzLiBQb3NzaWJs eSB2b2x0YWdlIHN3aW5nIGlzc3VlIiwKPj4KPj4gV291bGQgcHJvYmFibHkgYmUgZ29vZCB0byBh ZGQgYSAnXG4nIGhlcmUgYXMgd2VsbCBidXQgdGhhdCdzIG5vdCB0aGUgbWFpbiBpbnRlbnRpb24g b2YgdGhpcyBwYXRjaC4KPgo+IEFib3V0IDEvNCBvZiB0aGUgZG1fbG9nZ2VyX3dyaXRlIGNhbGxz IGFyZSBtaXNzaW5nCj4gbmV3bGluZXMgYW5kIEkgdGhpbmsgaXQgc2hvdWxkIGJlIGEgc2VwYXJh dGUgcGF0Y2guCj4KPiBJIGVuY291cmFnZSB5b3UgdG8gZml4IHRoZW0gb25lIGRheS4KPgo+PiBS ZXZpZXdlZC1ieTogSGFycnkgV2VudGxhbmQgPGhhcnJ5LndlbnRsYW5kQGFtZC5jb20+Cj4KPiBj aGVlcnMsIEpvZQoKQXBwbGllZC4gIFRoYW5rcyEKCkFsZXgKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9hbWQtZ2Z4Cg==