From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7FA3C55ABD for ; Tue, 10 Nov 2020 22:17:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58653206B2 for ; Tue, 10 Nov 2020 22:17:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AnT0B68f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732142AbgKJWR1 (ORCPT ); Tue, 10 Nov 2020 17:17:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727275AbgKJWR1 (ORCPT ); Tue, 10 Nov 2020 17:17:27 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9866C0613D1; Tue, 10 Nov 2020 14:17:26 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id 23so14403259wrc.8; Tue, 10 Nov 2020 14:17:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PybHYHD7oH2aLnG+yvTddEPZqr7VRvhfNzCANa+XKfA=; b=AnT0B68fsoy6LnsJzwe/Fm7jjXUzfkVseEBGHrDF8afef5eVu8t5Vc4WHB44H01snU Y0XxjtlSavsWQJ++9Q7cyNMhWTMUCQItMA1xUjro37jdTV1GN3Oi81zHV6/cufsj3hrh IbKlbsH8DnVVcNymAVVEOE4yAhcrgeMFMicm0ObvYEyOPNLwHhMoxAp893ou/pn9lkII riGVsX9X2H6Q3gGnUmc3HIu9VSXp88vjmHfYWlsUCEybqYt0eNc7Nv1H84cBIiCbYmbB Io9FqVA5KHeCT5mAPSrAlLl3ZoQpUTnhdd4q1T5VW47Ta+3f6INB3cihUIhZe6ZS8x6W 3PGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PybHYHD7oH2aLnG+yvTddEPZqr7VRvhfNzCANa+XKfA=; b=SMXMaRMziqBAclovM2b/SGZtm/F0d5l9SqCRQCFobp1gi4alvFGdC39rY/u5CbMAVe yu3Ercmu1o4/i+Lr5f/fdom06rrgy3p97KB1xYwLXznp/eh6V4FPJXqfHluq8UKYZSMz Nz9mXUu8zR+/EB82So59gUG9zDP6E2KaiS/rx2BaI6rY0uQ9kUMo2Y9EoQSji2OK9YQG jjQofT6QUaX+bLMsaW9PPy0ausxdYRMWWngJFMzbIfD5a+d4skj/I26Oq2XOPStG2g0k 3L/d52LSuOlQa0F5XflG23e07rg5oNv0s2BxIye2ifyssmBS5niR/t/Rp9ZXLE7sXehv Gl0g== X-Gm-Message-State: AOAM530fWyLq1yFU1X+oLKUtxc5IpX9uYU6neadyLDvgCHujkceILpNp PQQYO1KP2XRGvUDLPlSsN3vjYBU8Z4pOMmn1ObY= X-Google-Smtp-Source: ABdhPJxh2GeljpewW2T0ti487h5NvVsa43l5KqIELZfR5hDC7Aj0bILRpfkBVbdUXZQrjDANOnsCVpXmp8jNi1eT12o= X-Received: by 2002:adf:e9c9:: with SMTP id l9mr27815711wrn.124.1605046645534; Tue, 10 Nov 2020 14:17:25 -0800 (PST) MIME-Version: 1.0 References: <20201109211855.3340030-1-lee.jones@linaro.org> <20201109211855.3340030-12-lee.jones@linaro.org> In-Reply-To: <20201109211855.3340030-12-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 17:17:13 -0500 Message-ID: Subject: Re: [PATCH 11/20] drm/radeon/r600: Strip out set but unused 'tmp' variables To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , =?UTF-8?Q?Christian_K=C3=B6nig?= , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Maling list - DRI developers , Alex Deucher , linux-media Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 9, 2020 at 4:19 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/radeon/r600.c: In function =E2=80=98r600_pcie_gart_tlb_f= lush=E2=80=99: > drivers/gpu/drm/radeon/r600.c:1083:7: warning: variable =E2=80=98tmp=E2= =80=99 set but not used [-Wunused-but-set-variable] > drivers/gpu/drm/radeon/r600.c: At top level: > drivers/gpu/drm/radeon/r600.c: In function =E2=80=98r600_mmio_hdp_flush= =E2=80=99: > drivers/gpu/drm/radeon/r600.c:4393:7: warning: variable =E2=80=98tmp=E2= =80=99 set but not used [-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/r600.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.= c > index d9a33ca768f34..6e780b0109995 100644 > --- a/drivers/gpu/drm/radeon/r600.c > +++ b/drivers/gpu/drm/radeon/r600.c > @@ -1080,7 +1080,6 @@ void r600_pcie_gart_tlb_flush(struct radeon_device = *rdev) > if ((rdev->family >=3D CHIP_RV770) && (rdev->family <=3D CHIP_RV7= 40) && > !(rdev->flags & RADEON_IS_AGP)) { > void __iomem *ptr =3D (void *)rdev->gart.ptr; > - u32 tmp; > > /* r7xx hw bug. write to HDP_DEBUG1 followed by fb read > * rather than write to HDP_REG_COHERENCY_FLUSH_CNTL > @@ -1088,7 +1087,7 @@ void r600_pcie_gart_tlb_flush(struct radeon_device = *rdev) > * method for them. > */ > WREG32(HDP_DEBUG1, 0); > - tmp =3D readl((void __iomem *)ptr); > + readl((void __iomem *)ptr); > } else > WREG32(R_005480_HDP_MEM_COHERENCY_FLUSH_CNTL, 0x1); > > @@ -4390,10 +4389,9 @@ void r600_mmio_hdp_flush(struct radeon_device *rde= v) > if ((rdev->family >=3D CHIP_RV770) && (rdev->family <=3D CHIP_RV7= 40) && > rdev->vram_scratch.ptr && !(rdev->flags & RADEON_IS_AGP)) { > void __iomem *ptr =3D (void *)rdev->vram_scratch.ptr; > - u32 tmp; > > WREG32(HDP_DEBUG1, 0); > - tmp =3D readl((void __iomem *)ptr); > + readl((void __iomem *)ptr); > } else > WREG32(R_005480_HDP_MEM_COHERENCY_FLUSH_CNTL, 0x1); > } > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93E02C4742C for ; Tue, 10 Nov 2020 22:17:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2483C20674 for ; Tue, 10 Nov 2020 22:17:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AnT0B68f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2483C20674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6C75589CF7; Tue, 10 Nov 2020 22:17:28 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id CBF3489CF2; Tue, 10 Nov 2020 22:17:26 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id 33so14403342wrl.7; Tue, 10 Nov 2020 14:17:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PybHYHD7oH2aLnG+yvTddEPZqr7VRvhfNzCANa+XKfA=; b=AnT0B68fsoy6LnsJzwe/Fm7jjXUzfkVseEBGHrDF8afef5eVu8t5Vc4WHB44H01snU Y0XxjtlSavsWQJ++9Q7cyNMhWTMUCQItMA1xUjro37jdTV1GN3Oi81zHV6/cufsj3hrh IbKlbsH8DnVVcNymAVVEOE4yAhcrgeMFMicm0ObvYEyOPNLwHhMoxAp893ou/pn9lkII riGVsX9X2H6Q3gGnUmc3HIu9VSXp88vjmHfYWlsUCEybqYt0eNc7Nv1H84cBIiCbYmbB Io9FqVA5KHeCT5mAPSrAlLl3ZoQpUTnhdd4q1T5VW47Ta+3f6INB3cihUIhZe6ZS8x6W 3PGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PybHYHD7oH2aLnG+yvTddEPZqr7VRvhfNzCANa+XKfA=; b=MmRL+HXxHus5rGDAtOiKs1vVBvqhoXluzFaDIjE3pznzUSx3UInqFZN1zYWOXnT+IQ eQaQopBytd+6IOWoxB5td2yD6nPRWkUPfFeCgrEaLI3dKwzY/GOaSJepKf5P025CKCzL 5r85RQdtGRC9EbehMiwFD6BlIb/fR/dDOFMy1SnTg1vrRnFMSyvCKkOcXMVPgz3BOs7x XwNnKvpFalFyime5afXh9996gO3f3Q1q3vr8GH4u8fCWJ0G3d4lGlKdyO0c4fd8GVDjB OY+PtcQ4YsRgfjdtTsrCAPiL53N9eqmlInIYB3G/HG9udetdG+G6SdscfquvD9B/e7th u05Q== X-Gm-Message-State: AOAM530OYWApiEuAKXr3ADCQymrWoi9/7KeUTBKO0CylPqNm2eZKn31c +gNRaGZjzTCNMq8Q2oYO2LMwxNsIYj809TBBcr8= X-Google-Smtp-Source: ABdhPJxh2GeljpewW2T0ti487h5NvVsa43l5KqIELZfR5hDC7Aj0bILRpfkBVbdUXZQrjDANOnsCVpXmp8jNi1eT12o= X-Received: by 2002:adf:e9c9:: with SMTP id l9mr27815711wrn.124.1605046645534; Tue, 10 Nov 2020 14:17:25 -0800 (PST) MIME-Version: 1.0 References: <20201109211855.3340030-1-lee.jones@linaro.org> <20201109211855.3340030-12-lee.jones@linaro.org> In-Reply-To: <20201109211855.3340030-12-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 17:17:13 -0500 Message-ID: Subject: Re: [PATCH 11/20] drm/radeon/r600: Strip out set but unused 'tmp' variables To: Lee Jones X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , "moderated list:DMA BUFFER SHARING FRAMEWORK" , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-media Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCBOb3YgOSwgMjAyMCBhdCA0OjE5IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+IHdyb3RlOgo+Cj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdh cm5pbmcocyk6Cj4KPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yNjAwLmM6IEluIGZ1bmN0aW9u IOKAmHI2MDBfcGNpZV9nYXJ0X3RsYl9mbHVzaOKAmToKPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVv bi9yNjAwLmM6MTA4Mzo3OiB3YXJuaW5nOiB2YXJpYWJsZSDigJh0bXDigJkgc2V0IGJ1dCBub3Qg dXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVv bi9yNjAwLmM6IEF0IHRvcCBsZXZlbDoKPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yNjAwLmM6 IEluIGZ1bmN0aW9uIOKAmHI2MDBfbW1pb19oZHBfZmx1c2jigJk6Cj4gIGRyaXZlcnMvZ3B1L2Ry bS9yYWRlb24vcjYwMC5jOjQzOTM6Nzogd2FybmluZzogdmFyaWFibGUg4oCYdG1w4oCZIHNldCBi dXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4KPiBDYzogQWxleCBEZXVj aGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+IENjOiAiQ2hyaXN0aWFuIEvDtm5pZyIg PGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxp bnV4LmllPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IFN1bWl0 IFNlbXdhbCA8c3VtaXQuc2Vtd2FsQGxpbmFyby5vcmc+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzog bGludXgtbWVkaWFAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxpbmFyby1tbS1zaWdAbGlzdHMubGlu YXJvLm9yZwo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+ CgpBcHBsaWVkLiAgVGhhbmtzIQoKQWxleAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVv bi9yNjAwLmMgfCA2ICsrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCA0 IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcjYw MC5jIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yNjAwLmMKPiBpbmRleCBkOWEzM2NhNzY4ZjM0 Li42ZTc4MGIwMTA5OTk1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcjYw MC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yNjAwLmMKPiBAQCAtMTA4MCw3ICsx MDgwLDYgQEAgdm9pZCByNjAwX3BjaWVfZ2FydF90bGJfZmx1c2goc3RydWN0IHJhZGVvbl9kZXZp Y2UgKnJkZXYpCj4gICAgICAgICBpZiAoKHJkZXYtPmZhbWlseSA+PSBDSElQX1JWNzcwKSAmJiAo cmRldi0+ZmFtaWx5IDw9IENISVBfUlY3NDApICYmCj4gICAgICAgICAgICAgIShyZGV2LT5mbGFn cyAmIFJBREVPTl9JU19BR1ApKSB7Cj4gICAgICAgICAgICAgICAgIHZvaWQgX19pb21lbSAqcHRy ID0gKHZvaWQgKilyZGV2LT5nYXJ0LnB0cjsKPiAtICAgICAgICAgICAgICAgdTMyIHRtcDsKPgo+ ICAgICAgICAgICAgICAgICAvKiByN3h4IGh3IGJ1Zy4gIHdyaXRlIHRvIEhEUF9ERUJVRzEgZm9s bG93ZWQgYnkgZmIgcmVhZAo+ICAgICAgICAgICAgICAgICAgKiByYXRoZXIgdGhhbiB3cml0ZSB0 byBIRFBfUkVHX0NPSEVSRU5DWV9GTFVTSF9DTlRMCj4gQEAgLTEwODgsNyArMTA4Nyw3IEBAIHZv aWQgcjYwMF9wY2llX2dhcnRfdGxiX2ZsdXNoKHN0cnVjdCByYWRlb25fZGV2aWNlICpyZGV2KQo+ ICAgICAgICAgICAgICAgICAgKiBtZXRob2QgZm9yIHRoZW0uCj4gICAgICAgICAgICAgICAgICAq Lwo+ICAgICAgICAgICAgICAgICBXUkVHMzIoSERQX0RFQlVHMSwgMCk7Cj4gLSAgICAgICAgICAg ICAgIHRtcCA9IHJlYWRsKCh2b2lkIF9faW9tZW0gKilwdHIpOwo+ICsgICAgICAgICAgICAgICBy ZWFkbCgodm9pZCBfX2lvbWVtICopcHRyKTsKPiAgICAgICAgIH0gZWxzZQo+ICAgICAgICAgICAg ICAgICBXUkVHMzIoUl8wMDU0ODBfSERQX01FTV9DT0hFUkVOQ1lfRkxVU0hfQ05UTCwgMHgxKTsK Pgo+IEBAIC00MzkwLDEwICs0Mzg5LDkgQEAgdm9pZCByNjAwX21taW9faGRwX2ZsdXNoKHN0cnVj dCByYWRlb25fZGV2aWNlICpyZGV2KQo+ICAgICAgICAgaWYgKChyZGV2LT5mYW1pbHkgPj0gQ0hJ UF9SVjc3MCkgJiYgKHJkZXYtPmZhbWlseSA8PSBDSElQX1JWNzQwKSAmJgo+ICAgICAgICAgICAg IHJkZXYtPnZyYW1fc2NyYXRjaC5wdHIgJiYgIShyZGV2LT5mbGFncyAmIFJBREVPTl9JU19BR1Ap KSB7Cj4gICAgICAgICAgICAgICAgIHZvaWQgX19pb21lbSAqcHRyID0gKHZvaWQgKilyZGV2LT52 cmFtX3NjcmF0Y2gucHRyOwo+IC0gICAgICAgICAgICAgICB1MzIgdG1wOwo+Cj4gICAgICAgICAg ICAgICAgIFdSRUczMihIRFBfREVCVUcxLCAwKTsKPiAtICAgICAgICAgICAgICAgdG1wID0gcmVh ZGwoKHZvaWQgX19pb21lbSAqKXB0cik7Cj4gKyAgICAgICAgICAgICAgIHJlYWRsKCh2b2lkIF9f aW9tZW0gKilwdHIpOwo+ICAgICAgICAgfSBlbHNlCj4gICAgICAgICAgICAgICAgIFdSRUczMihS XzAwNTQ4MF9IRFBfTUVNX0NPSEVSRU5DWV9GTFVTSF9DTlRMLCAweDEpOwo+ICB9Cj4gLS0KPiAy LjI1LjEKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6115DC388F7 for ; Tue, 10 Nov 2020 22:17:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 039B720674 for ; Tue, 10 Nov 2020 22:17:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AnT0B68f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 039B720674 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6743D89CF2; Tue, 10 Nov 2020 22:17:27 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id CBF3489CF2; Tue, 10 Nov 2020 22:17:26 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id 33so14403342wrl.7; Tue, 10 Nov 2020 14:17:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=PybHYHD7oH2aLnG+yvTddEPZqr7VRvhfNzCANa+XKfA=; b=AnT0B68fsoy6LnsJzwe/Fm7jjXUzfkVseEBGHrDF8afef5eVu8t5Vc4WHB44H01snU Y0XxjtlSavsWQJ++9Q7cyNMhWTMUCQItMA1xUjro37jdTV1GN3Oi81zHV6/cufsj3hrh IbKlbsH8DnVVcNymAVVEOE4yAhcrgeMFMicm0ObvYEyOPNLwHhMoxAp893ou/pn9lkII riGVsX9X2H6Q3gGnUmc3HIu9VSXp88vjmHfYWlsUCEybqYt0eNc7Nv1H84cBIiCbYmbB Io9FqVA5KHeCT5mAPSrAlLl3ZoQpUTnhdd4q1T5VW47Ta+3f6INB3cihUIhZe6ZS8x6W 3PGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=PybHYHD7oH2aLnG+yvTddEPZqr7VRvhfNzCANa+XKfA=; b=MmRL+HXxHus5rGDAtOiKs1vVBvqhoXluzFaDIjE3pznzUSx3UInqFZN1zYWOXnT+IQ eQaQopBytd+6IOWoxB5td2yD6nPRWkUPfFeCgrEaLI3dKwzY/GOaSJepKf5P025CKCzL 5r85RQdtGRC9EbehMiwFD6BlIb/fR/dDOFMy1SnTg1vrRnFMSyvCKkOcXMVPgz3BOs7x XwNnKvpFalFyime5afXh9996gO3f3Q1q3vr8GH4u8fCWJ0G3d4lGlKdyO0c4fd8GVDjB OY+PtcQ4YsRgfjdtTsrCAPiL53N9eqmlInIYB3G/HG9udetdG+G6SdscfquvD9B/e7th u05Q== X-Gm-Message-State: AOAM530OYWApiEuAKXr3ADCQymrWoi9/7KeUTBKO0CylPqNm2eZKn31c +gNRaGZjzTCNMq8Q2oYO2LMwxNsIYj809TBBcr8= X-Google-Smtp-Source: ABdhPJxh2GeljpewW2T0ti487h5NvVsa43l5KqIELZfR5hDC7Aj0bILRpfkBVbdUXZQrjDANOnsCVpXmp8jNi1eT12o= X-Received: by 2002:adf:e9c9:: with SMTP id l9mr27815711wrn.124.1605046645534; Tue, 10 Nov 2020 14:17:25 -0800 (PST) MIME-Version: 1.0 References: <20201109211855.3340030-1-lee.jones@linaro.org> <20201109211855.3340030-12-lee.jones@linaro.org> In-Reply-To: <20201109211855.3340030-12-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 17:17:13 -0500 Message-ID: Subject: Re: [PATCH 11/20] drm/radeon/r600: Strip out set but unused 'tmp' variables To: Lee Jones X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , "moderated list:DMA BUFFER SHARING FRAMEWORK" , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= , linux-media Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gTW9uLCBOb3YgOSwgMjAyMCBhdCA0OjE5IFBNIExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+IHdyb3RlOgo+Cj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdh cm5pbmcocyk6Cj4KPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yNjAwLmM6IEluIGZ1bmN0aW9u IOKAmHI2MDBfcGNpZV9nYXJ0X3RsYl9mbHVzaOKAmToKPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVv bi9yNjAwLmM6MTA4Mzo3OiB3YXJuaW5nOiB2YXJpYWJsZSDigJh0bXDigJkgc2V0IGJ1dCBub3Qg dXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVv bi9yNjAwLmM6IEF0IHRvcCBsZXZlbDoKPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yNjAwLmM6 IEluIGZ1bmN0aW9uIOKAmHI2MDBfbW1pb19oZHBfZmx1c2jigJk6Cj4gIGRyaXZlcnMvZ3B1L2Ry bS9yYWRlb24vcjYwMC5jOjQzOTM6Nzogd2FybmluZzogdmFyaWFibGUg4oCYdG1w4oCZIHNldCBi dXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4KPiBDYzogQWxleCBEZXVj aGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgo+IENjOiAiQ2hyaXN0aWFuIEvDtm5pZyIg PGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxp bnV4LmllPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IFN1bWl0 IFNlbXdhbCA8c3VtaXQuc2Vtd2FsQGxpbmFyby5vcmc+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzog bGludXgtbWVkaWFAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGxpbmFyby1tbS1zaWdAbGlzdHMubGlu YXJvLm9yZwo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFyby5vcmc+ CgpBcHBsaWVkLiAgVGhhbmtzIQoKQWxleAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVv bi9yNjAwLmMgfCA2ICsrLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCA0 IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcjYw MC5jIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yNjAwLmMKPiBpbmRleCBkOWEzM2NhNzY4ZjM0 Li42ZTc4MGIwMTA5OTk1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vcjYw MC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yNjAwLmMKPiBAQCAtMTA4MCw3ICsx MDgwLDYgQEAgdm9pZCByNjAwX3BjaWVfZ2FydF90bGJfZmx1c2goc3RydWN0IHJhZGVvbl9kZXZp Y2UgKnJkZXYpCj4gICAgICAgICBpZiAoKHJkZXYtPmZhbWlseSA+PSBDSElQX1JWNzcwKSAmJiAo cmRldi0+ZmFtaWx5IDw9IENISVBfUlY3NDApICYmCj4gICAgICAgICAgICAgIShyZGV2LT5mbGFn cyAmIFJBREVPTl9JU19BR1ApKSB7Cj4gICAgICAgICAgICAgICAgIHZvaWQgX19pb21lbSAqcHRy ID0gKHZvaWQgKilyZGV2LT5nYXJ0LnB0cjsKPiAtICAgICAgICAgICAgICAgdTMyIHRtcDsKPgo+ ICAgICAgICAgICAgICAgICAvKiByN3h4IGh3IGJ1Zy4gIHdyaXRlIHRvIEhEUF9ERUJVRzEgZm9s bG93ZWQgYnkgZmIgcmVhZAo+ICAgICAgICAgICAgICAgICAgKiByYXRoZXIgdGhhbiB3cml0ZSB0 byBIRFBfUkVHX0NPSEVSRU5DWV9GTFVTSF9DTlRMCj4gQEAgLTEwODgsNyArMTA4Nyw3IEBAIHZv aWQgcjYwMF9wY2llX2dhcnRfdGxiX2ZsdXNoKHN0cnVjdCByYWRlb25fZGV2aWNlICpyZGV2KQo+ ICAgICAgICAgICAgICAgICAgKiBtZXRob2QgZm9yIHRoZW0uCj4gICAgICAgICAgICAgICAgICAq Lwo+ICAgICAgICAgICAgICAgICBXUkVHMzIoSERQX0RFQlVHMSwgMCk7Cj4gLSAgICAgICAgICAg ICAgIHRtcCA9IHJlYWRsKCh2b2lkIF9faW9tZW0gKilwdHIpOwo+ICsgICAgICAgICAgICAgICBy ZWFkbCgodm9pZCBfX2lvbWVtICopcHRyKTsKPiAgICAgICAgIH0gZWxzZQo+ICAgICAgICAgICAg ICAgICBXUkVHMzIoUl8wMDU0ODBfSERQX01FTV9DT0hFUkVOQ1lfRkxVU0hfQ05UTCwgMHgxKTsK Pgo+IEBAIC00MzkwLDEwICs0Mzg5LDkgQEAgdm9pZCByNjAwX21taW9faGRwX2ZsdXNoKHN0cnVj dCByYWRlb25fZGV2aWNlICpyZGV2KQo+ICAgICAgICAgaWYgKChyZGV2LT5mYW1pbHkgPj0gQ0hJ UF9SVjc3MCkgJiYgKHJkZXYtPmZhbWlseSA8PSBDSElQX1JWNzQwKSAmJgo+ICAgICAgICAgICAg IHJkZXYtPnZyYW1fc2NyYXRjaC5wdHIgJiYgIShyZGV2LT5mbGFncyAmIFJBREVPTl9JU19BR1Ap KSB7Cj4gICAgICAgICAgICAgICAgIHZvaWQgX19pb21lbSAqcHRyID0gKHZvaWQgKilyZGV2LT52 cmFtX3NjcmF0Y2gucHRyOwo+IC0gICAgICAgICAgICAgICB1MzIgdG1wOwo+Cj4gICAgICAgICAg ICAgICAgIFdSRUczMihIRFBfREVCVUcxLCAwKTsKPiAtICAgICAgICAgICAgICAgdG1wID0gcmVh ZGwoKHZvaWQgX19pb21lbSAqKXB0cik7Cj4gKyAgICAgICAgICAgICAgIHJlYWRsKCh2b2lkIF9f aW9tZW0gKilwdHIpOwo+ICAgICAgICAgfSBlbHNlCj4gICAgICAgICAgICAgICAgIFdSRUczMihS XzAwNTQ4MF9IRFBfTUVNX0NPSEVSRU5DWV9GTFVTSF9DTlRMLCAweDEpOwo+ICB9Cj4gLS0KPiAy LjI1LjEKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQt Z2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK