From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A674C64E7B for ; Mon, 30 Nov 2020 23:15:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDD1520725 for ; Mon, 30 Nov 2020 23:15:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D/a9sT7Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729614AbgK3XPG (ORCPT ); Mon, 30 Nov 2020 18:15:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726737AbgK3XPG (ORCPT ); Mon, 30 Nov 2020 18:15:06 -0500 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF731C0613CF for ; Mon, 30 Nov 2020 15:14:25 -0800 (PST) Received: by mail-oi1-x243.google.com with SMTP id w15so16086075oie.13 for ; Mon, 30 Nov 2020 15:14:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fiqCo1/lI2q1mRSdvAPLuR7qN8UC6kpdlJNW9jLd1So=; b=D/a9sT7QnDRknAcb/kqsN0U4b8shUkIGmqCsSQqBos1WqsXEgHYeUKUGdxEtN69qSi sFj7Hv+Ll2zQJCmcJAIGfIeL9E2kBLEfkrdnZNc52OuWC7dQJcVQAOChniIeEEhCT9Ia MnZEUHrQ91aemrIQKi47ZFvbtnMqwkH6g+8pAV71pqO3wtS/8MUfoybkcCiRa84IxDbI ONPlgY/pyJ7It74yoTQzkMx96X1beweGtCyxkgQGeQjYY+dZtD6+njFquPAJh/qcGN81 dHFY0nd5VCyuJoNICJMc9O3ffP5ukZT4FTDEZrmWLrBI8BLAOVxyQQ/grdSpQiWq7wX4 Cu7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fiqCo1/lI2q1mRSdvAPLuR7qN8UC6kpdlJNW9jLd1So=; b=LC7TK65cQQOUnANJik5wOIqePk8zYaa0twfPXZmvGgeXcK+jEtNuZTmx7HF5bhfBy1 slP3csLOOPTpBAT7LYciig35937z7pSel6t4zaY86YG7GSR7s8kc8JrOOQWX2W8yZkpE mONz7HbZdVV/2/WTizitVSH7oA/RhWZOerbqVk+7bdNpfzwGGw0V1xJhPXgfJiHUZtyh c1iBAOzRj2CeCONSYEiKIdzNA5yTneUs1CDe6kJEITZMEomFqpp3LIo6ouNjn5iXE9br cbbGaoSutJ32Lucl1gROET5qfNuCOZ68YcFf/tBWoqUYuQWnV6C9q0qLMLnNREqTae6P UBcQ== X-Gm-Message-State: AOAM531Eji3wbEMs/o27qA0DmrTwS1FUCEHA+Oa/Ek4/+QqnfyUax54y D+ISymh/D7c9SnREAczZCv5VHLDSqIYf0TWOTO/8KGz+ X-Google-Smtp-Source: ABdhPJxEaLWXFtxL3ijIBaGXZ22vZflmOE1jRdmPndYRMxiIVD5eI+WbIfWWBpqaHZENtarBXBDtoIDzoitjeT6W6xc= X-Received: by 2002:aca:4f53:: with SMTP id d80mr109224oib.120.1606778065481; Mon, 30 Nov 2020 15:14:25 -0800 (PST) MIME-Version: 1.0 References: <20201126134240.3214176-1-lee.jones@linaro.org> <20201126134240.3214176-4-lee.jones@linaro.org> In-Reply-To: <20201126134240.3214176-4-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 30 Nov 2020 18:14:14 -0500 Message-ID: Subject: Re: [PATCH 03/40] drm/amd/pm/powerplay/smumgr/ci_smumgr: Remove set but unused variable 'res' To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , Evan Quan , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 26, 2020 at 8:42 AM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/ci_smumgr.c: In functi= on =E2=80=98ci_thermal_setup_fan_table=E2=80=99: > drivers/gpu/drm/amd/amdgpu/../pm/powerplay/smumgr/ci_smumgr.c:2132:6: wa= rning: variable =E2=80=98res=E2=80=99 set but not used [-Wunused-but-set-va= riable] > > Cc: Evan Quan > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c b/driver= s/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c > index 329bf4d44bbce..c1d869b4c7a42 100644 > --- a/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c > +++ b/drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c > @@ -2129,7 +2129,6 @@ static int ci_thermal_setup_fan_table(struct pp_hwm= gr *hwmgr) > uint32_t t_diff1, t_diff2, pwm_diff1, pwm_diff2; > uint16_t fdo_min, slope1, slope2; > uint32_t reference_clock; > - int res; > uint64_t tmp64; > > if (!phm_cap_enabled(hwmgr->platform_descriptor.platformCaps, PHM= _PlatformCaps_MicrocodeFanControl)) > @@ -2191,7 +2190,7 @@ static int ci_thermal_setup_fan_table(struct pp_hwm= gr *hwmgr) > > fan_table.TempSrc =3D (uint8_t)PHM_READ_VFPF_INDIRECT_FIELD(hwmgr= ->device, CGS_IND_REG__SMC, CG_MULT_THERMAL_CTRL, TEMP_SEL); > > - res =3D ci_copy_bytes_to_smc(hwmgr, ci_data->fan_table_start, (ui= nt8_t *)&fan_table, (uint32_t)sizeof(fan_table), SMC_RAM_END); > + ci_copy_bytes_to_smc(hwmgr, ci_data->fan_table_start, (uint8_t *)= &fan_table, (uint32_t)sizeof(fan_table), SMC_RAM_END); > Should probably just return the error here. I'll fix it up. Thanks! Alex > return 0; > } > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E8BDC64E90 for ; Mon, 30 Nov 2020 23:14:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5440E2076C for ; Mon, 30 Nov 2020 23:14:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D/a9sT7Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5440E2076C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 43AE689CA2; Mon, 30 Nov 2020 23:14:27 +0000 (UTC) Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D5CC89C9A; Mon, 30 Nov 2020 23:14:26 +0000 (UTC) Received: by mail-oi1-x242.google.com with SMTP id k26so16161547oiw.0; Mon, 30 Nov 2020 15:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fiqCo1/lI2q1mRSdvAPLuR7qN8UC6kpdlJNW9jLd1So=; b=D/a9sT7QnDRknAcb/kqsN0U4b8shUkIGmqCsSQqBos1WqsXEgHYeUKUGdxEtN69qSi sFj7Hv+Ll2zQJCmcJAIGfIeL9E2kBLEfkrdnZNc52OuWC7dQJcVQAOChniIeEEhCT9Ia MnZEUHrQ91aemrIQKi47ZFvbtnMqwkH6g+8pAV71pqO3wtS/8MUfoybkcCiRa84IxDbI ONPlgY/pyJ7It74yoTQzkMx96X1beweGtCyxkgQGeQjYY+dZtD6+njFquPAJh/qcGN81 dHFY0nd5VCyuJoNICJMc9O3ffP5ukZT4FTDEZrmWLrBI8BLAOVxyQQ/grdSpQiWq7wX4 Cu7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fiqCo1/lI2q1mRSdvAPLuR7qN8UC6kpdlJNW9jLd1So=; b=i3aF50mRzPCVELzxOlhiGZ9X2N5olXNuuIVTnrfdPz5MwEL9BZAjB0KuXXSftqY/nQ 1kEY9uWiroMlGJ+bYj6x4Qtgl4zGcksbWHZfxMaOt0jwcNSZCtNvEGv7sVSDZzR/CxEv 3KPiWhRdHJ7qaGbgMgm/Yd4RZYioyChyuQsEcVsKoGUS5Cog6E6fMWMVkDOytcuIQSor sZ7goY8rKc8iLPtzrp6D0SeaGlk16Uxikll3jeiFOoESz6vFGrds+op+KzjPlpPHwNP5 Se2HcTJ6emsSfcJE7nFy4/aHl6rLMkwX7+qWbv/GOvaDL22tbfNqFTQsdsC9c308DgMy 1YqA== X-Gm-Message-State: AOAM5317HZvh+zSfv9gW3H7g+0blpQd7mEruzQs3ISiwpw8yEMdAqs7w iHmWdb+gFT2aB76jL5qJ9TQr6r5aWjTLyV8IeSc= X-Google-Smtp-Source: ABdhPJxEaLWXFtxL3ijIBaGXZ22vZflmOE1jRdmPndYRMxiIVD5eI+WbIfWWBpqaHZENtarBXBDtoIDzoitjeT6W6xc= X-Received: by 2002:aca:4f53:: with SMTP id d80mr109224oib.120.1606778065481; Mon, 30 Nov 2020 15:14:25 -0800 (PST) MIME-Version: 1.0 References: <20201126134240.3214176-1-lee.jones@linaro.org> <20201126134240.3214176-4-lee.jones@linaro.org> In-Reply-To: <20201126134240.3214176-4-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 30 Nov 2020 18:14:14 -0500 Message-ID: Subject: Re: [PATCH 03/40] drm/amd/pm/powerplay/smumgr/ci_smumgr: Remove set but unused variable 'res' To: Lee Jones X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , Evan Quan , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVGh1LCBOb3YgMjYsIDIwMjAgYXQgODo0MiBBTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3 YXJuaW5nKHMpOgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL3BtL3Bvd2VycGxh eS9zbXVtZ3IvY2lfc211bWdyLmM6IEluIGZ1bmN0aW9uIOKAmGNpX3RoZXJtYWxfc2V0dXBfZmFu X3RhYmxl4oCZOgo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS8uLi9wbS9wb3dlcnBsYXkv c211bWdyL2NpX3NtdW1nci5jOjIxMzI6Njogd2FybmluZzogdmFyaWFibGUg4oCYcmVz4oCZIHNl dCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4KPiBDYzogRXZhbiBR dWFuIDxldmFuLnF1YW5AYW1kLmNvbT4KPiBDYzogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1 Y2hlckBhbWQuY29tPgo+IENjOiAiQ2hyaXN0aWFuIEvDtm5pZyIgPGNocmlzdGlhbi5rb2VuaWdA YW1kLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYW5p ZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQtb2Zm LWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zbXVtZ3IvY2lfc211bWdyLmMgfCAzICstLQo+ICAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9wb3dlcnBsYXkvc211bWdyL2NpX3NtdW1nci5jIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9wb3dlcnBsYXkvc211bWdyL2NpX3NtdW1nci5jCj4gaW5k ZXggMzI5YmY0ZDQ0YmJjZS4uYzFkODY5YjRjN2E0MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zbXVtZ3IvY2lfc211bWdyLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zbXVtZ3IvY2lfc211bWdyLmMKPiBAQCAtMjEyOSw3 ICsyMTI5LDYgQEAgc3RhdGljIGludCBjaV90aGVybWFsX3NldHVwX2Zhbl90YWJsZShzdHJ1Y3Qg cHBfaHdtZ3IgKmh3bWdyKQo+ICAgICAgICAgdWludDMyX3QgdF9kaWZmMSwgdF9kaWZmMiwgcHdt X2RpZmYxLCBwd21fZGlmZjI7Cj4gICAgICAgICB1aW50MTZfdCBmZG9fbWluLCBzbG9wZTEsIHNs b3BlMjsKPiAgICAgICAgIHVpbnQzMl90IHJlZmVyZW5jZV9jbG9jazsKPiAtICAgICAgIGludCBy ZXM7Cj4gICAgICAgICB1aW50NjRfdCB0bXA2NDsKPgo+ICAgICAgICAgaWYgKCFwaG1fY2FwX2Vu YWJsZWQoaHdtZ3ItPnBsYXRmb3JtX2Rlc2NyaXB0b3IucGxhdGZvcm1DYXBzLCBQSE1fUGxhdGZv cm1DYXBzX01pY3JvY29kZUZhbkNvbnRyb2wpKQo+IEBAIC0yMTkxLDcgKzIxOTAsNyBAQCBzdGF0 aWMgaW50IGNpX3RoZXJtYWxfc2V0dXBfZmFuX3RhYmxlKHN0cnVjdCBwcF9od21nciAqaHdtZ3Ip Cj4KPiAgICAgICAgIGZhbl90YWJsZS5UZW1wU3JjID0gKHVpbnQ4X3QpUEhNX1JFQURfVkZQRl9J TkRJUkVDVF9GSUVMRChod21nci0+ZGV2aWNlLCBDR1NfSU5EX1JFR19fU01DLCBDR19NVUxUX1RI RVJNQUxfQ1RSTCwgVEVNUF9TRUwpOwo+Cj4gLSAgICAgICByZXMgPSBjaV9jb3B5X2J5dGVzX3Rv X3NtYyhod21nciwgY2lfZGF0YS0+ZmFuX3RhYmxlX3N0YXJ0LCAodWludDhfdCAqKSZmYW5fdGFi bGUsICh1aW50MzJfdClzaXplb2YoZmFuX3RhYmxlKSwgU01DX1JBTV9FTkQpOwo+ICsgICAgICAg Y2lfY29weV9ieXRlc190b19zbWMoaHdtZ3IsIGNpX2RhdGEtPmZhbl90YWJsZV9zdGFydCwgKHVp bnQ4X3QgKikmZmFuX3RhYmxlLCAodWludDMyX3Qpc2l6ZW9mKGZhbl90YWJsZSksIFNNQ19SQU1f RU5EKTsKPgoKU2hvdWxkIHByb2JhYmx5IGp1c3QgcmV0dXJuIHRoZSBlcnJvciBoZXJlLiAgSSds bCBmaXggaXQgdXAuICBUaGFua3MhCgpBbGV4Cgo+ICAgICAgICAgcmV0dXJuIDA7Cj4gIH0KPiAt LQo+IDIuMjUuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1C43C64E7B for ; Mon, 30 Nov 2020 23:14:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C9E82076E for ; Mon, 30 Nov 2020 23:14:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D/a9sT7Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C9E82076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB17389C9A; Mon, 30 Nov 2020 23:14:26 +0000 (UTC) Received: from mail-oi1-x242.google.com (mail-oi1-x242.google.com [IPv6:2607:f8b0:4864:20::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0D5CC89C9A; Mon, 30 Nov 2020 23:14:26 +0000 (UTC) Received: by mail-oi1-x242.google.com with SMTP id k26so16161547oiw.0; Mon, 30 Nov 2020 15:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=fiqCo1/lI2q1mRSdvAPLuR7qN8UC6kpdlJNW9jLd1So=; b=D/a9sT7QnDRknAcb/kqsN0U4b8shUkIGmqCsSQqBos1WqsXEgHYeUKUGdxEtN69qSi sFj7Hv+Ll2zQJCmcJAIGfIeL9E2kBLEfkrdnZNc52OuWC7dQJcVQAOChniIeEEhCT9Ia MnZEUHrQ91aemrIQKi47ZFvbtnMqwkH6g+8pAV71pqO3wtS/8MUfoybkcCiRa84IxDbI ONPlgY/pyJ7It74yoTQzkMx96X1beweGtCyxkgQGeQjYY+dZtD6+njFquPAJh/qcGN81 dHFY0nd5VCyuJoNICJMc9O3ffP5ukZT4FTDEZrmWLrBI8BLAOVxyQQ/grdSpQiWq7wX4 Cu7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=fiqCo1/lI2q1mRSdvAPLuR7qN8UC6kpdlJNW9jLd1So=; b=i3aF50mRzPCVELzxOlhiGZ9X2N5olXNuuIVTnrfdPz5MwEL9BZAjB0KuXXSftqY/nQ 1kEY9uWiroMlGJ+bYj6x4Qtgl4zGcksbWHZfxMaOt0jwcNSZCtNvEGv7sVSDZzR/CxEv 3KPiWhRdHJ7qaGbgMgm/Yd4RZYioyChyuQsEcVsKoGUS5Cog6E6fMWMVkDOytcuIQSor sZ7goY8rKc8iLPtzrp6D0SeaGlk16Uxikll3jeiFOoESz6vFGrds+op+KzjPlpPHwNP5 Se2HcTJ6emsSfcJE7nFy4/aHl6rLMkwX7+qWbv/GOvaDL22tbfNqFTQsdsC9c308DgMy 1YqA== X-Gm-Message-State: AOAM5317HZvh+zSfv9gW3H7g+0blpQd7mEruzQs3ISiwpw8yEMdAqs7w iHmWdb+gFT2aB76jL5qJ9TQr6r5aWjTLyV8IeSc= X-Google-Smtp-Source: ABdhPJxEaLWXFtxL3ijIBaGXZ22vZflmOE1jRdmPndYRMxiIVD5eI+WbIfWWBpqaHZENtarBXBDtoIDzoitjeT6W6xc= X-Received: by 2002:aca:4f53:: with SMTP id d80mr109224oib.120.1606778065481; Mon, 30 Nov 2020 15:14:25 -0800 (PST) MIME-Version: 1.0 References: <20201126134240.3214176-1-lee.jones@linaro.org> <20201126134240.3214176-4-lee.jones@linaro.org> In-Reply-To: <20201126134240.3214176-4-lee.jones@linaro.org> From: Alex Deucher Date: Mon, 30 Nov 2020 18:14:14 -0500 Message-ID: Subject: Re: [PATCH 03/40] drm/amd/pm/powerplay/smumgr/ci_smumgr: Remove set but unused variable 'res' To: Lee Jones X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , Evan Quan , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gVGh1LCBOb3YgMjYsIDIwMjAgYXQgODo0MiBBTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEZpeGVzIHRoZSBmb2xsb3dpbmcgVz0xIGtlcm5lbCBidWlsZCB3 YXJuaW5nKHMpOgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL3BtL3Bvd2VycGxh eS9zbXVtZ3IvY2lfc211bWdyLmM6IEluIGZ1bmN0aW9uIOKAmGNpX3RoZXJtYWxfc2V0dXBfZmFu X3RhYmxl4oCZOgo+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS8uLi9wbS9wb3dlcnBsYXkv c211bWdyL2NpX3NtdW1nci5jOjIxMzI6Njogd2FybmluZzogdmFyaWFibGUg4oCYcmVz4oCZIHNl dCBidXQgbm90IHVzZWQgWy1XdW51c2VkLWJ1dC1zZXQtdmFyaWFibGVdCj4KPiBDYzogRXZhbiBR dWFuIDxldmFuLnF1YW5AYW1kLmNvbT4KPiBDYzogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1 Y2hlckBhbWQuY29tPgo+IENjOiAiQ2hyaXN0aWFuIEvDtm5pZyIgPGNocmlzdGlhbi5rb2VuaWdA YW1kLmNvbT4KPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxpbnV4LmllPgo+IENjOiBEYW5p ZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gQ2M6IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBTaWduZWQtb2Zm LWJ5OiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zbXVtZ3IvY2lfc211bWdyLmMgfCAzICstLQo+ICAxIGZp bGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDIgZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9wb3dlcnBsYXkvc211bWdyL2NpX3NtdW1nci5jIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9wbS9wb3dlcnBsYXkvc211bWdyL2NpX3NtdW1nci5jCj4gaW5k ZXggMzI5YmY0ZDQ0YmJjZS4uYzFkODY5YjRjN2E0MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zbXVtZ3IvY2lfc211bWdyLmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vYW1kL3BtL3Bvd2VycGxheS9zbXVtZ3IvY2lfc211bWdyLmMKPiBAQCAtMjEyOSw3 ICsyMTI5LDYgQEAgc3RhdGljIGludCBjaV90aGVybWFsX3NldHVwX2Zhbl90YWJsZShzdHJ1Y3Qg cHBfaHdtZ3IgKmh3bWdyKQo+ICAgICAgICAgdWludDMyX3QgdF9kaWZmMSwgdF9kaWZmMiwgcHdt X2RpZmYxLCBwd21fZGlmZjI7Cj4gICAgICAgICB1aW50MTZfdCBmZG9fbWluLCBzbG9wZTEsIHNs b3BlMjsKPiAgICAgICAgIHVpbnQzMl90IHJlZmVyZW5jZV9jbG9jazsKPiAtICAgICAgIGludCBy ZXM7Cj4gICAgICAgICB1aW50NjRfdCB0bXA2NDsKPgo+ICAgICAgICAgaWYgKCFwaG1fY2FwX2Vu YWJsZWQoaHdtZ3ItPnBsYXRmb3JtX2Rlc2NyaXB0b3IucGxhdGZvcm1DYXBzLCBQSE1fUGxhdGZv cm1DYXBzX01pY3JvY29kZUZhbkNvbnRyb2wpKQo+IEBAIC0yMTkxLDcgKzIxOTAsNyBAQCBzdGF0 aWMgaW50IGNpX3RoZXJtYWxfc2V0dXBfZmFuX3RhYmxlKHN0cnVjdCBwcF9od21nciAqaHdtZ3Ip Cj4KPiAgICAgICAgIGZhbl90YWJsZS5UZW1wU3JjID0gKHVpbnQ4X3QpUEhNX1JFQURfVkZQRl9J TkRJUkVDVF9GSUVMRChod21nci0+ZGV2aWNlLCBDR1NfSU5EX1JFR19fU01DLCBDR19NVUxUX1RI RVJNQUxfQ1RSTCwgVEVNUF9TRUwpOwo+Cj4gLSAgICAgICByZXMgPSBjaV9jb3B5X2J5dGVzX3Rv X3NtYyhod21nciwgY2lfZGF0YS0+ZmFuX3RhYmxlX3N0YXJ0LCAodWludDhfdCAqKSZmYW5fdGFi bGUsICh1aW50MzJfdClzaXplb2YoZmFuX3RhYmxlKSwgU01DX1JBTV9FTkQpOwo+ICsgICAgICAg Y2lfY29weV9ieXRlc190b19zbWMoaHdtZ3IsIGNpX2RhdGEtPmZhbl90YWJsZV9zdGFydCwgKHVp bnQ4X3QgKikmZmFuX3RhYmxlLCAodWludDMyX3Qpc2l6ZW9mKGZhbl90YWJsZSksIFNNQ19SQU1f RU5EKTsKPgoKU2hvdWxkIHByb2JhYmx5IGp1c3QgcmV0dXJuIHRoZSBlcnJvciBoZXJlLiAgSSds bCBmaXggaXQgdXAuICBUaGFua3MhCgpBbGV4Cgo+ICAgICAgICAgcmV0dXJuIDA7Cj4gIH0KPiAt LQo+IDIuMjUuMQo+Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo=