From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 988F0C4320A for ; Thu, 5 Aug 2021 04:33:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74C0761029 for ; Thu, 5 Aug 2021 04:33:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236278AbhHEEdP (ORCPT ); Thu, 5 Aug 2021 00:33:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231373AbhHEEdO (ORCPT ); Thu, 5 Aug 2021 00:33:14 -0400 Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC6ACC061765; Wed, 4 Aug 2021 21:32:59 -0700 (PDT) Received: by mail-ot1-x32e.google.com with SMTP id g5-20020a9d6b050000b02904f21e977c3eso3919208otp.5; Wed, 04 Aug 2021 21:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WPmSYKxM3hDxf4j2HGMY4KEBqM5rWpME+JCZGt0gVjw=; b=d6lgTlgZ4XtRuTrGFwjnfu6FMANDeGYNkF3HVRgAEz3zNJWeXPay2/77o5xUFwchyy fZ+RxFE6PKyFPBCA/PrBqv7fb7Ru/8F66ANYljfjpCZek/EgK9BnwwHV0KtaiOXGOBHC awwvqO+5eU4YhGFJjXO4OaZpU6kBceP9x20lc/jksWMCQHnZ8orlDNKyp4wj86imwnCD 6YKPbF79Crl7D4d2jD8s0rV9wTcK0I3OjHVcLIxaFULDXF9ynJoOKulQ9ZfLCD/pGLv1 zFEDI6x2G+joB+ZOQckwYoiMZ1LQcX9rian6mNKcuPDevnN7/eoOCrSnqHj1w21TH/v7 BVog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WPmSYKxM3hDxf4j2HGMY4KEBqM5rWpME+JCZGt0gVjw=; b=OwLFiVGMaYs2wDyCqgFTesxXRTkK0RCB+Nax1y40ep8X1Fg880NTtYddXvGDPbozet iUIifVJRDjG3WwF1pFn426gFY27IK2m2wYYojXuumNpa8/7YcYVZpob4/8tFLPA4D/Ks dr7F0lP+Xi+/77TxrvYSyY8vE+r/0NGHyVe+PR30ikvPBtHcYIhT1AlHSp1ecoQss8AH LAtk869RYvpanRiYpLOyGQhbQVSz5zJykVbf2s9A/C52vGvQGZvwLUrPOIpjIq0L72UN 166rzXaaUl06WsMgLbyqba+gFbtXX1GPQGePJJ4NCkL9qHptOPt55y/ruvwRpWp7Z5/a SY0Q== X-Gm-Message-State: AOAM5309XmTxbcm8DhxlzklWmMnfVp3IJ7gSh9JqbpAo4F9055//+dF+ Uxbgx7j+xgdUVNz17VMbML1lMD+0ct0+e5Zid5k= X-Google-Smtp-Source: ABdhPJxVoTU6a30brhTf1IeElqkRglO5k+x+tHkN0DLsz3Nd4Duri9Cmng8GzMH9mtkqISPNR9a5gCNiMTCPSizufzw= X-Received: by 2002:a9d:70c3:: with SMTP id w3mr2216613otj.311.1628137979011; Wed, 04 Aug 2021 21:32:59 -0700 (PDT) MIME-Version: 1.0 References: <20210804015132.29617-1-islituo@gmail.com> In-Reply-To: From: Alex Deucher Date: Thu, 5 Aug 2021 00:32:47 -0400 Message-ID: Subject: Re: [PATCH] drm/amdgpu: drop redundant null-pointer checks in amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate() To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Tuo Li , "Deucher, Alexander" , xinhui pan , Dave Airlie , Daniel Vetter , Sumit Semwal , Dave Airlie , "Kuehling, Felix" , Oak Zeng , Nirmoy Das , Thomas Zimmermann , "Yang, Philip" , amd-gfx list , Maling list - DRI developers , LKML , linux-media , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Jia-Ju Bai , TOTE Robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! Alex On Wed, Aug 4, 2021 at 2:49 AM Christian K=C3=B6nig wrote: > > Am 04.08.21 um 03:51 schrieb Tuo Li: > > The varialbe gtt in the function amdgpu_ttm_tt_populate() and > > amdgpu_ttm_tt_unpopulate() is guaranteed to be not NULL in the context. > > Thus the null-pointer checks are redundant and can be dropped. > > > > Reported-by: TOTE Robot > > Signed-off-by: Tuo Li > > Reviewed-by: Christian K=C3=B6nig > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/= amd/amdgpu/amdgpu_ttm.c > > index 3a55f08e00e1..719539bd6c44 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > @@ -1121,7 +1121,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_devi= ce *bdev, > > struct amdgpu_ttm_tt *gtt =3D (void *)ttm; > > > > /* user pages are bound by amdgpu_ttm_tt_pin_userptr() */ > > - if (gtt && gtt->userptr) { > > + if (gtt->userptr) { > > ttm->sg =3D kzalloc(sizeof(struct sg_table), GFP_KERNEL); > > if (!ttm->sg) > > return -ENOMEM; > > @@ -1146,7 +1146,7 @@ static void amdgpu_ttm_tt_unpopulate(struct ttm_d= evice *bdev, > > struct amdgpu_ttm_tt *gtt =3D (void *)ttm; > > struct amdgpu_device *adev; > > > > - if (gtt && gtt->userptr) { > > + if (gtt->userptr) { > > amdgpu_ttm_tt_set_user_pages(ttm, NULL); > > kfree(ttm->sg); > > ttm->sg =3D NULL; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82903C4338F for ; Thu, 5 Aug 2021 04:33:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3557F61029 for ; Thu, 5 Aug 2021 04:33:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3557F61029 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 939B589E01; Thu, 5 Aug 2021 04:33:00 +0000 (UTC) Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) by gabe.freedesktop.org (Postfix) with ESMTPS id C3C8B89E01; Thu, 5 Aug 2021 04:32:59 +0000 (UTC) Received: by mail-ot1-x336.google.com with SMTP id o2-20020a9d22020000b0290462f0ab0800so3887995ota.11; Wed, 04 Aug 2021 21:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=WPmSYKxM3hDxf4j2HGMY4KEBqM5rWpME+JCZGt0gVjw=; b=d6lgTlgZ4XtRuTrGFwjnfu6FMANDeGYNkF3HVRgAEz3zNJWeXPay2/77o5xUFwchyy fZ+RxFE6PKyFPBCA/PrBqv7fb7Ru/8F66ANYljfjpCZek/EgK9BnwwHV0KtaiOXGOBHC awwvqO+5eU4YhGFJjXO4OaZpU6kBceP9x20lc/jksWMCQHnZ8orlDNKyp4wj86imwnCD 6YKPbF79Crl7D4d2jD8s0rV9wTcK0I3OjHVcLIxaFULDXF9ynJoOKulQ9ZfLCD/pGLv1 zFEDI6x2G+joB+ZOQckwYoiMZ1LQcX9rian6mNKcuPDevnN7/eoOCrSnqHj1w21TH/v7 BVog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WPmSYKxM3hDxf4j2HGMY4KEBqM5rWpME+JCZGt0gVjw=; b=lQQzjMORBMHxMXBSrntUCAwQriRgvp7Hu/isFVAZQ9Bkdd05TjidmpThzXqh61cAKZ Z2FR9OyflO/aQTOTtXod4a7Zg6huUbO6TVfd7DsDWmh3uYg73sEAGobd7ssKvyE3uNZf luSgL4I/wUWJDU6aEosY+pAqlbzDGaP0mp68om+ZxTHQTnnH0gFp9ekCTfmcjqidrZVK 1lBqi0qAlvFfoSZlqTux7F3CsTOn3jd7Lw7m9rK4MvOMg11Owqbj9DyKiPBr+UIaXldl CHx0hW/EqFUW8xiadI8DSUcQuffkZPvLepNeXWIf5BDXoPlTPvDVP2eR4clg4ouTuFXY X5Rw== X-Gm-Message-State: AOAM532j8qeZSzxHGTeDS7/eIwvm2QDasO6QAQROrU3JLfd+Hgv8pPct 97lmRemSdeqvrTTICAS6iYclToc91Zi1HhlacH0= X-Google-Smtp-Source: ABdhPJxVoTU6a30brhTf1IeElqkRglO5k+x+tHkN0DLsz3Nd4Duri9Cmng8GzMH9mtkqISPNR9a5gCNiMTCPSizufzw= X-Received: by 2002:a9d:70c3:: with SMTP id w3mr2216613otj.311.1628137979011; Wed, 04 Aug 2021 21:32:59 -0700 (PDT) MIME-Version: 1.0 References: <20210804015132.29617-1-islituo@gmail.com> In-Reply-To: From: Alex Deucher Date: Thu, 5 Aug 2021 00:32:47 -0400 Message-ID: Subject: Re: [PATCH] drm/amdgpu: drop redundant null-pointer checks in amdgpu_ttm_tt_populate() and amdgpu_ttm_tt_unpopulate() To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Tuo Li , "Deucher, Alexander" , xinhui pan , Dave Airlie , Daniel Vetter , Sumit Semwal , Dave Airlie , "Kuehling, Felix" , Oak Zeng , Nirmoy Das , Thomas Zimmermann , "Yang, Philip" , amd-gfx list , Maling list - DRI developers , LKML , linux-media , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Jia-Ju Bai , TOTE Robot Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Applied. Thanks! Alex On Wed, Aug 4, 2021 at 2:49 AM Christian K=C3=B6nig wrote: > > Am 04.08.21 um 03:51 schrieb Tuo Li: > > The varialbe gtt in the function amdgpu_ttm_tt_populate() and > > amdgpu_ttm_tt_unpopulate() is guaranteed to be not NULL in the context. > > Thus the null-pointer checks are redundant and can be dropped. > > > > Reported-by: TOTE Robot > > Signed-off-by: Tuo Li > > Reviewed-by: Christian K=C3=B6nig > > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/= amd/amdgpu/amdgpu_ttm.c > > index 3a55f08e00e1..719539bd6c44 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > @@ -1121,7 +1121,7 @@ static int amdgpu_ttm_tt_populate(struct ttm_devi= ce *bdev, > > struct amdgpu_ttm_tt *gtt =3D (void *)ttm; > > > > /* user pages are bound by amdgpu_ttm_tt_pin_userptr() */ > > - if (gtt && gtt->userptr) { > > + if (gtt->userptr) { > > ttm->sg =3D kzalloc(sizeof(struct sg_table), GFP_KERNEL); > > if (!ttm->sg) > > return -ENOMEM; > > @@ -1146,7 +1146,7 @@ static void amdgpu_ttm_tt_unpopulate(struct ttm_d= evice *bdev, > > struct amdgpu_ttm_tt *gtt =3D (void *)ttm; > > struct amdgpu_device *adev; > > > > - if (gtt && gtt->userptr) { > > + if (gtt->userptr) { > > amdgpu_ttm_tt_set_user_pages(ttm, NULL); > > kfree(ttm->sg); > > ttm->sg =3D NULL; >