From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ADECC433E6 for ; Mon, 22 Feb 2021 21:41:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 345BF64DFD for ; Mon, 22 Feb 2021 21:41:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231991AbhBVVlN (ORCPT ); Mon, 22 Feb 2021 16:41:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232001AbhBVVkV (ORCPT ); Mon, 22 Feb 2021 16:40:21 -0500 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC92AC06178B for ; Mon, 22 Feb 2021 13:39:40 -0800 (PST) Received: by mail-oi1-x230.google.com with SMTP id 12so12793148oij.6 for ; Mon, 22 Feb 2021 13:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=bpwLuoH4voXjwzIWIXFj730L/u03ILuA10nlROuAAPg=; b=RtSm4vGAQI/k15Zc+MhbWThYoVIHUBjRuiLTgwMzhNx9gW+mM8DVoSBXcJ6KwFyLl7 NADk5NS010JkZuflRXd5PV8s441E+xM5z1LqqW793M+o15pzmWBPJsh42ng0IF5HPS78 /X7OHqNoetoB66FJwwXIs21AF2rD68zJBzkFdA4Cnt0ZzpbmSt5atLW07DoekekBQJz5 Y07Kz+PG2nxYw0Eyr94zVgFwXyvZGoGj2CIrpTsnr2gvOpAflaryBTciwv+/z8z72cdY 0334AjBlMLr8s/oZTftypjnYuhuHl1HyofiulEBY8zKxtMi+nZXvgzTtL7NHqxZDQA0h ts2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bpwLuoH4voXjwzIWIXFj730L/u03ILuA10nlROuAAPg=; b=HXL+ruWr9PYCEnwByZAJLQXFvOL8cRIPVDdiIbSrNyc7LJlUP5GUvmyKPW4XI9J/8V +0hWDPIKnE7ROKvBTR3qdgROkvfwzsv+TkAQTwxTXKZLEswcpV7TWemUbq3wLZBSD1Y5 Q+R1zwxgXcoEBOtmmPlwravU9Psun5bArn7EWy74bLyQB/GdHUrldoztlYjZCyNfLvW9 5yEHMhZk8JVin1vpzJaFZFulgXcKK9PZk+pw1xuj7CCdzJyUMxa8Uehqf01ogtkjBmDm kq/ylF78lfWFH5gb1dWYnuwkblEidO+dcOAWjyXZrBToFikYv6pIaDgSXQPOBwy2D+pE sVcA== X-Gm-Message-State: AOAM530SmpibypEUPUMsUGWaKexP9BnAel99IQWRaVIJzjqboTPQUehC NvqSaafuJja2NqdKIzq+eMeV9tS3IfCiTLtUF2TcN2OU X-Google-Smtp-Source: ABdhPJz+XTEBh9rMRWrP+PL5NjbeiM01iVf+NigQOaTQ4Euq6MJtWEU8l9nuBVdXGl6KOkHStItZEKJQdkzgpo2u6Rk= X-Received: by 2002:aca:fccb:: with SMTP id a194mr7832287oii.5.1614029980194; Mon, 22 Feb 2021 13:39:40 -0800 (PST) MIME-Version: 1.0 References: <1613789706-100430-1-git-send-email-jiapeng.chong@linux.alibaba.com> In-Reply-To: From: Alex Deucher Date: Mon, 22 Feb 2021 16:39:29 -0500 Message-ID: Subject: Re: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion to bool To: "Quan, Evan" Cc: Jiapeng Chong , "Deucher, Alexander" , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "daniel@ffwll.ch" , "Koenig, Christian" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! Alex On Sun, Feb 21, 2021 at 10:15 PM Quan, Evan wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Reviewed-by: Evan Quan > > -----Original Message----- > From: amd-gfx On Behalf Of Jiapen= g Chong > Sent: Saturday, February 20, 2021 10:55 AM > To: Deucher, Alexander > Cc: Jiapeng Chong ; airlied@linux.ie; li= nux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; amd-gfx@lists.= freedesktop.org; daniel@ffwll.ch; Koenig, Christian > Subject: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversio= n to bool > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c:900:47-52: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gp= u/drm/amd/pm/swsmu/smu11/navi10_ppt.c > index cd7efa9..58028a7 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > @@ -897,7 +897,7 @@ static bool navi10_is_support_fine_grained_dpm(struct= smu_context *smu, enum smu > dpm_desc =3D &pptable->DpmDescriptor[clk_index]; > > /* 0 - Fine grained DPM, 1 - Discrete DPM */ > - return dpm_desc->SnapToDiscrete =3D=3D 0 ? true : false; > + return dpm_desc->SnapToDiscrete =3D=3D 0; > } > > static inline bool navi10_od_feature_is_supported(struct smu_11_0_overdr= ive_table *od_table, enum SMU_11_0_ODFEATURE_CAP cap) > -- > 1.8.3.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flists= .freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=3D04%7C01%7Cevan.q= uan%40amd.com%7C443a5df938954827326108d8d6582201%7C3dd8961fe4884e608e11a82d= 994e183d%7C0%7C0%7C637495021310885387%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wL= jAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=3D6E= TadiVbRBgbXfEbkXbxTX%2F1Ozg1wp3Nr9lHGF3SKHk%3D&reserved=3D0 > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99BF8C433E0 for ; Mon, 22 Feb 2021 21:39:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 377A664E25 for ; Mon, 22 Feb 2021 21:39:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 377A664E25 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C6A488830; Mon, 22 Feb 2021 21:39:41 +0000 (UTC) Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by gabe.freedesktop.org (Postfix) with ESMTPS id C143E88830; Mon, 22 Feb 2021 21:39:40 +0000 (UTC) Received: by mail-oi1-x22b.google.com with SMTP id o3so5845358oic.8; Mon, 22 Feb 2021 13:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=bpwLuoH4voXjwzIWIXFj730L/u03ILuA10nlROuAAPg=; b=RtSm4vGAQI/k15Zc+MhbWThYoVIHUBjRuiLTgwMzhNx9gW+mM8DVoSBXcJ6KwFyLl7 NADk5NS010JkZuflRXd5PV8s441E+xM5z1LqqW793M+o15pzmWBPJsh42ng0IF5HPS78 /X7OHqNoetoB66FJwwXIs21AF2rD68zJBzkFdA4Cnt0ZzpbmSt5atLW07DoekekBQJz5 Y07Kz+PG2nxYw0Eyr94zVgFwXyvZGoGj2CIrpTsnr2gvOpAflaryBTciwv+/z8z72cdY 0334AjBlMLr8s/oZTftypjnYuhuHl1HyofiulEBY8zKxtMi+nZXvgzTtL7NHqxZDQA0h ts2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bpwLuoH4voXjwzIWIXFj730L/u03ILuA10nlROuAAPg=; b=FRdU/p5tfN0mUZfkx8q9ffFK75zDmjkruTK9bozisLx/1SAwJw6v/Qod+BmIdVyON8 p3zdd2Hw6Klx+acwgIRGOfKJMDHVdFPK00BWTvVQDEtUXR6vR8A2K6AVc8cCXszYl1av xZO7jXj0Acixo8nKGE6GZ6pHuigo5hHk0SFwbt8QDHbsXWPM+ajRz8/GnlLWCVFtzmHb 7UdH+HNl+y17i/LkA6ZqpLKU+6kVnG5GjxbZMib0GyD5zePD6FuGNuEfXoo+K/dRmQUR Iw2/VlnsdpAn4Mv18938mWeB2AhPPQQ7qrLwM7aNCG4bqcHc7iTiyUq8ZYYI/3DoKCYp mgEA== X-Gm-Message-State: AOAM530hMlztqiDXJxXJH1zQsnhzHck8gVI5XOl13+HL+aYADrYsswAH Z31i/BC14N5YljGjpbSwfYOIrPhKY+mX5HkcNaU= X-Google-Smtp-Source: ABdhPJz+XTEBh9rMRWrP+PL5NjbeiM01iVf+NigQOaTQ4Euq6MJtWEU8l9nuBVdXGl6KOkHStItZEKJQdkzgpo2u6Rk= X-Received: by 2002:aca:fccb:: with SMTP id a194mr7832287oii.5.1614029980194; Mon, 22 Feb 2021 13:39:40 -0800 (PST) MIME-Version: 1.0 References: <1613789706-100430-1-git-send-email-jiapeng.chong@linux.alibaba.com> In-Reply-To: From: Alex Deucher Date: Mon, 22 Feb 2021 16:39:29 -0500 Message-ID: Subject: Re: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion to bool To: "Quan, Evan" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiapeng Chong , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , "Deucher, Alexander" , "Koenig, Christian" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Applied. Thanks! Alex On Sun, Feb 21, 2021 at 10:15 PM Quan, Evan wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Reviewed-by: Evan Quan > > -----Original Message----- > From: amd-gfx On Behalf Of Jiapeng Chong > Sent: Saturday, February 20, 2021 10:55 AM > To: Deucher, Alexander > Cc: Jiapeng Chong ; airlied@linux.ie; linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; daniel@ffwll.ch; Koenig, Christian > Subject: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion to bool > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c:900:47-52: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > index cd7efa9..58028a7 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > @@ -897,7 +897,7 @@ static bool navi10_is_support_fine_grained_dpm(struct smu_context *smu, enum smu > dpm_desc = &pptable->DpmDescriptor[clk_index]; > > /* 0 - Fine grained DPM, 1 - Discrete DPM */ > - return dpm_desc->SnapToDiscrete == 0 ? true : false; > + return dpm_desc->SnapToDiscrete == 0; > } > > static inline bool navi10_od_feature_is_supported(struct smu_11_0_overdrive_table *od_table, enum SMU_11_0_ODFEATURE_CAP cap) > -- > 1.8.3.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cevan.quan%40amd.com%7C443a5df938954827326108d8d6582201%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637495021310885387%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=6ETadiVbRBgbXfEbkXbxTX%2F1Ozg1wp3Nr9lHGF3SKHk%3D&reserved=0 > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1AF6C433E9 for ; Mon, 22 Feb 2021 21:39:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CB8164E02 for ; Mon, 22 Feb 2021 21:39:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CB8164E02 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 238B06E20E; Mon, 22 Feb 2021 21:39:42 +0000 (UTC) Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by gabe.freedesktop.org (Postfix) with ESMTPS id C143E88830; Mon, 22 Feb 2021 21:39:40 +0000 (UTC) Received: by mail-oi1-x22b.google.com with SMTP id o3so5845358oic.8; Mon, 22 Feb 2021 13:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=bpwLuoH4voXjwzIWIXFj730L/u03ILuA10nlROuAAPg=; b=RtSm4vGAQI/k15Zc+MhbWThYoVIHUBjRuiLTgwMzhNx9gW+mM8DVoSBXcJ6KwFyLl7 NADk5NS010JkZuflRXd5PV8s441E+xM5z1LqqW793M+o15pzmWBPJsh42ng0IF5HPS78 /X7OHqNoetoB66FJwwXIs21AF2rD68zJBzkFdA4Cnt0ZzpbmSt5atLW07DoekekBQJz5 Y07Kz+PG2nxYw0Eyr94zVgFwXyvZGoGj2CIrpTsnr2gvOpAflaryBTciwv+/z8z72cdY 0334AjBlMLr8s/oZTftypjnYuhuHl1HyofiulEBY8zKxtMi+nZXvgzTtL7NHqxZDQA0h ts2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=bpwLuoH4voXjwzIWIXFj730L/u03ILuA10nlROuAAPg=; b=FRdU/p5tfN0mUZfkx8q9ffFK75zDmjkruTK9bozisLx/1SAwJw6v/Qod+BmIdVyON8 p3zdd2Hw6Klx+acwgIRGOfKJMDHVdFPK00BWTvVQDEtUXR6vR8A2K6AVc8cCXszYl1av xZO7jXj0Acixo8nKGE6GZ6pHuigo5hHk0SFwbt8QDHbsXWPM+ajRz8/GnlLWCVFtzmHb 7UdH+HNl+y17i/LkA6ZqpLKU+6kVnG5GjxbZMib0GyD5zePD6FuGNuEfXoo+K/dRmQUR Iw2/VlnsdpAn4Mv18938mWeB2AhPPQQ7qrLwM7aNCG4bqcHc7iTiyUq8ZYYI/3DoKCYp mgEA== X-Gm-Message-State: AOAM530hMlztqiDXJxXJH1zQsnhzHck8gVI5XOl13+HL+aYADrYsswAH Z31i/BC14N5YljGjpbSwfYOIrPhKY+mX5HkcNaU= X-Google-Smtp-Source: ABdhPJz+XTEBh9rMRWrP+PL5NjbeiM01iVf+NigQOaTQ4Euq6MJtWEU8l9nuBVdXGl6KOkHStItZEKJQdkzgpo2u6Rk= X-Received: by 2002:aca:fccb:: with SMTP id a194mr7832287oii.5.1614029980194; Mon, 22 Feb 2021 13:39:40 -0800 (PST) MIME-Version: 1.0 References: <1613789706-100430-1-git-send-email-jiapeng.chong@linux.alibaba.com> In-Reply-To: From: Alex Deucher Date: Mon, 22 Feb 2021 16:39:29 -0500 Message-ID: Subject: Re: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion to bool To: "Quan, Evan" X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiapeng Chong , "airlied@linux.ie" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , "daniel@ffwll.ch" , "Deucher, Alexander" , "Koenig, Christian" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Applied. Thanks! Alex On Sun, Feb 21, 2021 at 10:15 PM Quan, Evan wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Reviewed-by: Evan Quan > > -----Original Message----- > From: amd-gfx On Behalf Of Jiapeng Chong > Sent: Saturday, February 20, 2021 10:55 AM > To: Deucher, Alexander > Cc: Jiapeng Chong ; airlied@linux.ie; linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; amd-gfx@lists.freedesktop.org; daniel@ffwll.ch; Koenig, Christian > Subject: [PATCH v2] drm/amdgpu/swsmu/navi1x: Remove unnecessary conversion to bool > > Fix the following coccicheck warnings: > > ./drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c:900:47-52: WARNING: > conversion to bool not needed here. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > index cd7efa9..58028a7 100644 > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c > @@ -897,7 +897,7 @@ static bool navi10_is_support_fine_grained_dpm(struct smu_context *smu, enum smu > dpm_desc = &pptable->DpmDescriptor[clk_index]; > > /* 0 - Fine grained DPM, 1 - Discrete DPM */ > - return dpm_desc->SnapToDiscrete == 0 ? true : false; > + return dpm_desc->SnapToDiscrete == 0; > } > > static inline bool navi10_od_feature_is_supported(struct smu_11_0_overdrive_table *od_table, enum SMU_11_0_ODFEATURE_CAP cap) > -- > 1.8.3.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7Cevan.quan%40amd.com%7C443a5df938954827326108d8d6582201%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637495021310885387%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=6ETadiVbRBgbXfEbkXbxTX%2F1Ozg1wp3Nr9lHGF3SKHk%3D&reserved=0 > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx