From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alex Deucher <alexdeucher@gmail.com>
Subject: Re: [PATCH 2/6] drm/radeon: ATOM Endian fix for
	atombios_crtc_program_pll()
Date: Wed, 13 Jul 2011 22:21:53 -0400
Message-ID: <CADnq5_M_CcU_CFCddKX8O-dWepH7y9UzZtc4WsytPOyawod4Lw@mail.gmail.com>
References: <1310538495.4968.92.camel@pasglop>
	<CADnq5_Om6yhCC3Jo0mcqmXWj=moBu6RV1c3=Hns9pmQOTcLqDg@mail.gmail.com>
	<1310593244.4968.263.camel@pasglop>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail-iy0-f177.google.com (mail-iy0-f177.google.com
	[209.85.210.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 7289D9E9CD
	for <dri-devel@lists.freedesktop.org>;
	Wed, 13 Jul 2011 19:21:54 -0700 (PDT)
Received: by iyn15 with SMTP id 15so7112508iyn.36
	for <dri-devel@lists.freedesktop.org>;
	Wed, 13 Jul 2011 19:21:54 -0700 (PDT)
In-Reply-To: <1310593244.4968.263.camel@pasglop>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: xorg-driver-ati@lists.x.org, dri-devel@lists.freedesktop.org, =?ISO-8859-1?Q?C=E9dric_Cano?= <ccano@interfaceconcept.com>
List-Id: dri-devel@lists.freedesktop.org

On Wed, Jul 13, 2011 at 5:40 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Wed, 2011-07-13 at 10:38 -0400, Alex Deucher wrote:
>
>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0case 6:
>> > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 args.v6.ulCrtcPclkFreq.u=
cCRTC =3D crtc_id;
>> > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 args.v6.ulCrtcPclkFreq.u=
lPixelClock =3D cpu_to_le32(clock / 10);
>> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 args.v6.ulDispEngClkFreq=
 =3D cpu_to_le32(crtc_id << 24 | clock / 10);
>>
>> For clarity (i can never remember op precedence), you might put:
>>
>> cpu_to_le32((crtc_id << 24) | (clock / 10));
>
> I can't either but I have a nice chart printed on my wall :-)
>
> I can respin if you really want but the above is correct.

That's fine as is then.

Alex

>
> Cheers,
> Ben.
>
>> Other than that,
>>
>> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>>
>>
>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0args.v6.ucRefDiv =3D re=
f_div;
>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0args.v6.usFbDiv =3D cpu=
_to_le16(fb_div);
>> > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0args.v6.ulFbDivDecFrac =
=3D cpu_to_le32(frac_fb_div * 100000);
>> >
>> >
>> >
>> >
>
>
>