From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 447C6ECE58C for ; Mon, 7 Oct 2019 15:57:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 15BD82067B for ; Mon, 7 Oct 2019 15:57:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GgcxoFlX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728614AbfJGP5l (ORCPT ); Mon, 7 Oct 2019 11:57:41 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:40127 "EHLO mail-wr1-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727791AbfJGP5k (ORCPT ); Mon, 7 Oct 2019 11:57:40 -0400 Received: by mail-wr1-f50.google.com with SMTP id h4so7234787wrv.7 for ; Mon, 07 Oct 2019 08:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pv3zbzHRa52jlg0ha3vzroZyZv2t03ZKCGOX1Q6sDuY=; b=GgcxoFlXi+10opvKk9r3xkS9Fe+6LhAhKpIdgDWee0bQNbfnkc15HaccnA/Xsrh7Jo FQbsk5iq02nE6EFzmTlg69Hx3XiQHMgUrCcGFy3YgnwUT91syhJHOGo+mAbJhA23dWhs f1S6dDl0S0i6+HuBLi6IDz6p5Y7KwCbOWHpFkL2LuzUvHdHqje1wbft7EhZ4NGOhRjep TwlZK2VbVksWFg6Nmd+glPEMdo8SlLAIXB6SELimT4miZ1AoaWR2QImtbUbifB8+2haW Wn2dEWLbQxRlaQ0IMhm4J/UjhcYNgsyQ62Xyi7Dm/oUzIJoFIQMrCj5fFuMQO8INimtq 39AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pv3zbzHRa52jlg0ha3vzroZyZv2t03ZKCGOX1Q6sDuY=; b=Vi0hh3UYfVSOgjAgbGcCU2E9kugIkFU4g1z9KOqwx7vfUnetsjLDdRLbol/91Qv/Lg S/7Wb2/Brpr0MBTbcSrL85y29KW5nhXO1R6bjRINHmRUenBC8RRhUaNjOPSMaW6UXStN oGQ/lXiIA/RCfQUbxPzZjMJtWqkE3OnwU0vUrzwUidJP6nwlOB+GH+ja1FmhrOy6KPCB zqiHVldFxO8FDPFbwMRBWgikgFFyrXXcfVbnyGMv9MswXQl/Ka3Np//t0N2yIn69U9pU ECa+NU7zaaG7hWlfMM69O58oOL/tQIqss3EMgNa7YnHYkOcZdEPW6XlOqyDg+E4Hribg 4qUg== X-Gm-Message-State: APjAAAX+CkKsDeu9HMaHgenExt3lQbyUTHI3TS9moCMlie/JoODNLOyW sBYba0OBaVY4pkUX9x3wQB7n6MYF3zL/cLqAPFo= X-Google-Smtp-Source: APXvYqw/4ecyBOzTC2pj7nSYubj1XPsTw7OxMpAZa1s6+UKfxUBqhUAlxlmmXQImS7B42KVKV9Jx8B87HepbEix+NQ0= X-Received: by 2002:adf:fc07:: with SMTP id i7mr8227762wrr.50.1570463858274; Mon, 07 Oct 2019 08:57:38 -0700 (PDT) MIME-Version: 1.0 References: <20191006105735.60708-1-yuehaibing@huawei.com> In-Reply-To: From: Alex Deucher Date: Mon, 7 Oct 2019 11:57:26 -0400 Message-ID: Subject: Re: [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync' To: Harry Wentland Cc: YueHaibing , "Wentland, Harry" , "Li, Sun peng (Leo)" , "Deucher, Alexander" , "Koenig, Christian" , "Zhou, David(ChunMing)" , "airlied@linux.ie" , "daniel@ffwll.ch" , "Lakha, Bhawanpreet" , "Koo, Anthony" , "Cyr, Aric" , "Harmanprit.Tatla@amd.com" , "bayan.zabihiyan@amd.com" , "Othman, Ahmad" , "Amini, Reza" , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 7, 2019 at 10:06 AM Harry Wentland wrote: > > On 2019-10-06 6:57 a.m., YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > > > rivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c: > > In function mod_freesync_get_settings: > > drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:984:24: > > warning: variable core_freesync set but not used [-Wunused-but-set-variable] > > > > It is not used since commit 98e6436d3af5 ("drm/amd/display: Refactor FreeSync module") > > > > Reported-by: Hulk Robot > > Signed-off-by: YueHaibing > > Reviewed-by: Harry Wentland > Applied. Thanks! Alex > Harry > > > --- > > drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > > index 9ce56a8..237dda7 100644 > > --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > > +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c > > @@ -981,13 +981,9 @@ void mod_freesync_get_settings(struct mod_freesync *mod_freesync, > > unsigned int *inserted_frames, > > unsigned int *inserted_duration_in_us) > > { > > - struct core_freesync *core_freesync = NULL; > > - > > if (mod_freesync == NULL) > > return; > > > > - core_freesync = MOD_FREESYNC_TO_CORE(mod_freesync); > > - > > if (vrr->supported) { > > *v_total_min = vrr->adjust.v_total_min; > > *v_total_max = vrr->adjust.v_total_max; > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync' Date: Mon, 7 Oct 2019 11:57:26 -0400 Message-ID: References: <20191006105735.60708-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Harry Wentland Cc: "Zhou, David(ChunMing)" , "Cyr, Aric" , "Harmanprit.Tatla-5C7GfCeVMHo@public.gmane.org" , "Li, Sun peng (Leo)" , "Lakha, Bhawanpreet" , YueHaibing , "Othman, Ahmad" , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "airlied-cv59FeDIM0c@public.gmane.org" , "Amini, Reza" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "daniel-/w4YWyX8dFk@public.gmane.org" , "bayan.zabihiyan-5C7GfCeVMHo@public.gmane.org" , "Deucher, Alexander" , "Wentland, Harry" , "Koenig, Christian" , "Koo, Anthony" List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBPY3QgNywgMjAxOSBhdCAxMDowNiBBTSBIYXJyeSBXZW50bGFuZCA8aHdlbnRsYW5A YW1kLmNvbT4gd3JvdGU6Cj4KPiBPbiAyMDE5LTEwLTA2IDY6NTcgYS5tLiwgWXVlSGFpYmluZyB3 cm90ZToKPiA+IEZpeGVzIGdjYyAnLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZScgd2FybmluZzoK PiA+Cj4gPiByaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1Ly4uL2Rpc3BsYXkvbW9kdWxlcy9mcmVl c3luYy9mcmVlc3luYy5jOgo+ID4gIEluIGZ1bmN0aW9uIG1vZF9mcmVlc3luY19nZXRfc2V0dGlu Z3M6Cj4gPiBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS8uLi9kaXNwbGF5L21vZHVsZXMvZnJl ZXN5bmMvZnJlZXN5bmMuYzo5ODQ6MjQ6Cj4gPiAgd2FybmluZzogdmFyaWFibGUgY29yZV9mcmVl c3luYyBzZXQgYnV0IG5vdCB1c2VkIFstV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlXQo+ID4KPiA+ IEl0IGlzIG5vdCB1c2VkIHNpbmNlIGNvbW1pdCA5OGU2NDM2ZDNhZjUgKCJkcm0vYW1kL2Rpc3Bs YXk6IFJlZmFjdG9yIEZyZWVTeW5jIG1vZHVsZSIpCj4gPgo+ID4gUmVwb3J0ZWQtYnk6IEh1bGsg Um9ib3QgPGh1bGtjaUBodWF3ZWkuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogWXVlSGFpYmluZyA8 eXVlaGFpYmluZ0BodWF3ZWkuY29tPgo+Cj4gUmV2aWV3ZWQtYnk6IEhhcnJ5IFdlbnRsYW5kIDxo YXJyeS53ZW50bGFuZEBhbWQuY29tPgo+CgpBcHBsaWVkLiAgVGhhbmtzIQoKQWxleAoKPiBIYXJy eQo+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvbW9kdWxlcy9mcmVl c3luYy9mcmVlc3luYy5jIHwgNCAtLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDQgZGVsZXRpb25z KC0pCj4gPgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9tb2R1 bGVzL2ZyZWVzeW5jL2ZyZWVzeW5jLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvbW9k dWxlcy9mcmVlc3luYy9mcmVlc3luYy5jCj4gPiBpbmRleCA5Y2U1NmE4Li4yMzdkZGE3IDEwMDY0 NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L21vZHVsZXMvZnJlZXN5bmMv ZnJlZXN5bmMuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L21vZHVsZXMv ZnJlZXN5bmMvZnJlZXN5bmMuYwo+ID4gQEAgLTk4MSwxMyArOTgxLDkgQEAgdm9pZCBtb2RfZnJl ZXN5bmNfZ2V0X3NldHRpbmdzKHN0cnVjdCBtb2RfZnJlZXN5bmMgKm1vZF9mcmVlc3luYywKPiA+ ICAgICAgICAgICAgICAgdW5zaWduZWQgaW50ICppbnNlcnRlZF9mcmFtZXMsCj4gPiAgICAgICAg ICAgICAgIHVuc2lnbmVkIGludCAqaW5zZXJ0ZWRfZHVyYXRpb25faW5fdXMpCj4gPiAgewo+ID4g LSAgICAgc3RydWN0IGNvcmVfZnJlZXN5bmMgKmNvcmVfZnJlZXN5bmMgPSBOVUxMOwo+ID4gLQo+ ID4gICAgICAgaWYgKG1vZF9mcmVlc3luYyA9PSBOVUxMKQo+ID4gICAgICAgICAgICAgICByZXR1 cm47Cj4gPgo+ID4gLSAgICAgY29yZV9mcmVlc3luYyA9IE1PRF9GUkVFU1lOQ19UT19DT1JFKG1v ZF9mcmVlc3luYyk7Cj4gPiAtCj4gPiAgICAgICBpZiAodnJyLT5zdXBwb3J0ZWQpIHsKPiA+ICAg ICAgICAgICAgICAgKnZfdG90YWxfbWluID0gdnJyLT5hZGp1c3Qudl90b3RhbF9taW47Cj4gPiAg ICAgICAgICAgICAgICp2X3RvdGFsX21heCA9IHZyci0+YWRqdXN0LnZfdG90YWxfbWF4Owo+ID4K PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGFtZC1n ZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxp c3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4