Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?

From: Alex Deucher <alexdeucher@gmail.com>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: "Sasha Levin" <sashal@kernel.org>,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	"David Airlie" <airlied@linux.ie>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	LKML <linux-kernel@vger.kernel.org>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Luben Tuikov" <luben.tuikov@amd.com>,
	1005005@bugs.debian.org,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Evan Quan" <evan.quan@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Dominique Dumont" <dod@debian.org>
Subject: Re: Regression from 3c196f056666 ("drm/amdgpu: always reset the asic in suspend (v2)") on suspend?
Date: Mon, 14 Feb 2022 16:52:27 -0500	[thread overview]
Message-ID: <CADnq5_MfR99OhjumQESCO7Oq+JVOHOVgyVQHX4FpGFDnPu6CyQ@mail.gmail.com> (raw)
In-Reply-To: <Ygf7KuWyc0d4HIFu@eldamar.lan>

On Sat, Feb 12, 2022 at 1:23 PM Salvatore Bonaccorso <carnil@debian.org> wrote:
>
> Hi Alex, hi all
>
> In Debian we got a regression report from Dominique Dumont, CC'ed in
> https://bugs.debian.org/1005005 that afer an update to 5.15.15 based
> kernel, his machine noe longer suspends correctly, after screen going
> black as usual it comes back. The Debian bug above contians a trace.
>
> Dominique confirmed that this issue persisted after updating to 5.16.7
> furthermore he bisected the issue and found
>
>         3c196f05666610912645c7c5d9107706003f67c3 is the first bad commit
>         commit 3c196f05666610912645c7c5d9107706003f67c3
>         Author: Alex Deucher <alexander.deucher@amd.com>
>         Date:   Fri Nov 12 11:25:30 2021 -0500
>
>             drm/amdgpu: always reset the asic in suspend (v2)
>
>             [ Upstream commit daf8de0874ab5b74b38a38726fdd3d07ef98a7ee ]
>
>             If the platform suspend happens to fail and the power rail
>             is not turned off, the GPU will be in an unknown state on
>             resume, so reset the asic so that it will be in a known
>             good state on resume even if the platform suspend failed.
>
>             v2: handle s0ix
>
>             Acked-by: Luben Tuikov <luben.tuikov@amd.com>
>             Acked-by: Evan Quan <evan.quan@amd.com>
>             Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
>             Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>          drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 5 ++++-
>          1 file changed, 4 insertions(+), 1 deletion(-)
>
> to be the first bad commit, see https://bugs.debian.org/1005005#34 .
>
> Does this ring any bell? Any idea on the problem?

Does the system actually suspend?  Putting the GPU into reset on
suspend shouldn't cause any problems since the power rail will
presumably be cut by the platform.  Is this system S0i3 or regular S3?
 Does this patch help by any chance?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e55a3aea418269266d84f426b3bd70794d3389c8

Alex

>
> Regards,
> Salvatore