From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 516C9C2D0C8 for ; Fri, 20 Dec 2019 19:40:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 272832146E for ; Fri, 20 Dec 2019 19:40:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CQjMpL4h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727514AbfLTTki (ORCPT ); Fri, 20 Dec 2019 14:40:38 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:51146 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727411AbfLTTkh (ORCPT ); Fri, 20 Dec 2019 14:40:37 -0500 Received: by mail-wm1-f67.google.com with SMTP id a5so10078549wmb.0 for ; Fri, 20 Dec 2019 11:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hdYNVeVJ9zG7uGLj2brLM5VkYYRU60Z3UwUXj26j7Y4=; b=CQjMpL4hpX1WnvIacGuyzDar6rEtOQ1Hzw1EWSkC5XHG14fswPnJF+1QV21ZfGULQA mo9Kz7hvURKWJsuf04nj3n1t675ntsjJiu6YgdNBoPx+1I1VLVA5sNxdGONzPvsomlcy UR35nKhJ3NFWeMAlJz/Nm17pxvMqiK3/R8cLZjLuwX6skmzUW6/NBiL2F2E609zQBP6l EnMNIw+vKToWzJCrnqHUKuW0T16VZaqdkAwBDK6jOZHj/wAb62pB9QGbeOGw3vzCBrQS jvsjALrM4HfNat7B+63vHH17sL5/w5yEgaPTkOdOdi4e1Ph+JDDG6mRaza3jnjxOT1nt 9TBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hdYNVeVJ9zG7uGLj2brLM5VkYYRU60Z3UwUXj26j7Y4=; b=bXWwet4XTukZ85YjRXGM7mSQ0N214nczAIFkAFQmiQ1m28KVk+pa36wsiaG+9Xt2pr +QwpNZTrIS4bqxssPS34BSgOpvYrKALoSz6NUf8XYzs3Yy+mykyL0gf1kKVKUFSEli5I MegFxlg/0xu4EDwYaLusGGLUCSV+syIowOe1SGtWhx34daF9ehXNJ7PWbhO02+YRoCat xXCHShZHNIlZu5bGUtzndCE1TFJI56zzr7hivuU8QVQ72QwdIhwMhSLHSNp75EHCFXH7 9X3xVWcoWxUxMbQkq2UBSmRo9RsXBHUiHjxzriMlLOrri77v8vIHowqvf4Iw3S1QEMlo fzDQ== X-Gm-Message-State: APjAAAV77Yc9XiLQwun/BNJOjoriu51j7rt0+snzd6vDkaeRskjbKqLC NQvwt+x5KAjzBOfljb7LR9ECbj4JqpQr9YXtq6h/kA== X-Google-Smtp-Source: APXvYqym0wfGn4MUh0Q5DxHRfhzWymg3X0lx1rvhD/+srbD8Wct7zzVCcUi8kXTeECHde0dGL3nXAC88Ujygt72NEnw= X-Received: by 2002:a1c:6404:: with SMTP id y4mr18312577wmb.143.1576870835379; Fri, 20 Dec 2019 11:40:35 -0800 (PST) MIME-Version: 1.0 References: <1576834568-82874-1-git-send-email-mafeng.ma@huawei.com> In-Reply-To: <1576834568-82874-1-git-send-email-mafeng.ma@huawei.com> From: Alex Deucher Date: Fri, 20 Dec 2019 14:40:23 -0500 Message-ID: Subject: Re: [PATCH] drm/amdgpu: Remove unneeded variable 'ret' in navi10_ih.c To: Ma Feng Cc: Alex Deucher , Christian Koenig , Chunming Zhou , David Airlie , Daniel Vetter , Maling list - DRI developers , amd-gfx list , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 20, 2019 at 10:10 AM Ma Feng wrote: > > Fixes coccicheck warning: > > drivers/gpu/drm/amd/amdgpu/navi10_ih.c:113:5-8: Unneeded variable: "ret". Return "0" on line 182 > > Reported-by: Hulk Robot > Signed-off-by: Ma Feng Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c > index 9af7356..f737ce4 100644 > --- a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c > +++ b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c > @@ -110,7 +110,6 @@ static uint32_t navi10_ih_rb_cntl(struct amdgpu_ih_ring *ih, uint32_t ih_rb_cntl > static int navi10_ih_irq_init(struct amdgpu_device *adev) > { > struct amdgpu_ih_ring *ih = &adev->irq.ih; > - int ret = 0; > u32 ih_rb_cntl, ih_doorbell_rtpr, ih_chicken; > u32 tmp; > > @@ -179,7 +178,7 @@ static int navi10_ih_irq_init(struct amdgpu_device *adev) > /* enable interrupts */ > navi10_ih_enable_interrupts(adev); > > - return ret; > + return 0; > } > > /** > -- > 2.6.2 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8CEC2D0D2 for ; Fri, 20 Dec 2019 19:40:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 060CA206D8 for ; Fri, 20 Dec 2019 19:40:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CQjMpL4h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 060CA206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 58CE36EC9D; Fri, 20 Dec 2019 19:40:38 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id CFC5C6E12A; Fri, 20 Dec 2019 19:40:36 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id p9so10086297wmc.2; Fri, 20 Dec 2019 11:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hdYNVeVJ9zG7uGLj2brLM5VkYYRU60Z3UwUXj26j7Y4=; b=CQjMpL4hpX1WnvIacGuyzDar6rEtOQ1Hzw1EWSkC5XHG14fswPnJF+1QV21ZfGULQA mo9Kz7hvURKWJsuf04nj3n1t675ntsjJiu6YgdNBoPx+1I1VLVA5sNxdGONzPvsomlcy UR35nKhJ3NFWeMAlJz/Nm17pxvMqiK3/R8cLZjLuwX6skmzUW6/NBiL2F2E609zQBP6l EnMNIw+vKToWzJCrnqHUKuW0T16VZaqdkAwBDK6jOZHj/wAb62pB9QGbeOGw3vzCBrQS jvsjALrM4HfNat7B+63vHH17sL5/w5yEgaPTkOdOdi4e1Ph+JDDG6mRaza3jnjxOT1nt 9TBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hdYNVeVJ9zG7uGLj2brLM5VkYYRU60Z3UwUXj26j7Y4=; b=Cf3lhe+/km6Pec0JF9H1eNRlLxMFOJ8oCe+G5+SOCTUPLCxoXaN1jPkC2cNhsh6OI3 7h+revaT7mE6D1g1+aw5Bw1eZHjTHwq+70B4Hpz2m+VUBkeWc094defzFJYuswy+HWa6 sSzlrRAun2FC7JeiGdVbjk/snTdGR1DyAcu0wr+lkMyuraGyY3Z6ShtXcf87fT8h2bNX ZIVe3zyzmjUsamD/wtVhgntpVoOxg8rcGBhT56lrcE2EjxYOZqZbkD1+7vyaHYk8jLob fDmE3KJUmhYooI6NOr8YccW6Sk4avE7/nQCIHTIuWBA3tAWqAC+Y9hIXyKtDgBxa8nZ+ NihQ== X-Gm-Message-State: APjAAAW7vBbbvC2NPPn/UR9n2FMnyohgd4fdQi4dHyb48X22oT8vcXfp C0HRIeVURAeEIPW484a6dzbCn5K55t+oWPKQI8o= X-Google-Smtp-Source: APXvYqym0wfGn4MUh0Q5DxHRfhzWymg3X0lx1rvhD/+srbD8Wct7zzVCcUi8kXTeECHde0dGL3nXAC88Ujygt72NEnw= X-Received: by 2002:a1c:6404:: with SMTP id y4mr18312577wmb.143.1576870835379; Fri, 20 Dec 2019 11:40:35 -0800 (PST) MIME-Version: 1.0 References: <1576834568-82874-1-git-send-email-mafeng.ma@huawei.com> In-Reply-To: <1576834568-82874-1-git-send-email-mafeng.ma@huawei.com> From: Alex Deucher Date: Fri, 20 Dec 2019 14:40:23 -0500 Message-ID: Subject: Re: [PATCH] drm/amdgpu: Remove unneeded variable 'ret' in navi10_ih.c To: Ma Feng X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , Christian Koenig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Dec 20, 2019 at 10:10 AM Ma Feng wrote: > > Fixes coccicheck warning: > > drivers/gpu/drm/amd/amdgpu/navi10_ih.c:113:5-8: Unneeded variable: "ret". Return "0" on line 182 > > Reported-by: Hulk Robot > Signed-off-by: Ma Feng Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c > index 9af7356..f737ce4 100644 > --- a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c > +++ b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c > @@ -110,7 +110,6 @@ static uint32_t navi10_ih_rb_cntl(struct amdgpu_ih_ring *ih, uint32_t ih_rb_cntl > static int navi10_ih_irq_init(struct amdgpu_device *adev) > { > struct amdgpu_ih_ring *ih = &adev->irq.ih; > - int ret = 0; > u32 ih_rb_cntl, ih_doorbell_rtpr, ih_chicken; > u32 tmp; > > @@ -179,7 +178,7 @@ static int navi10_ih_irq_init(struct amdgpu_device *adev) > /* enable interrupts */ > navi10_ih_enable_interrupts(adev); > > - return ret; > + return 0; > } > > /** > -- > 2.6.2 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0E8CC43603 for ; Fri, 20 Dec 2019 19:40:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95341206D8 for ; Fri, 20 Dec 2019 19:40:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CQjMpL4h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95341206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E5F06E12A; Fri, 20 Dec 2019 19:40:38 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id CFC5C6E12A; Fri, 20 Dec 2019 19:40:36 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id p9so10086297wmc.2; Fri, 20 Dec 2019 11:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hdYNVeVJ9zG7uGLj2brLM5VkYYRU60Z3UwUXj26j7Y4=; b=CQjMpL4hpX1WnvIacGuyzDar6rEtOQ1Hzw1EWSkC5XHG14fswPnJF+1QV21ZfGULQA mo9Kz7hvURKWJsuf04nj3n1t675ntsjJiu6YgdNBoPx+1I1VLVA5sNxdGONzPvsomlcy UR35nKhJ3NFWeMAlJz/Nm17pxvMqiK3/R8cLZjLuwX6skmzUW6/NBiL2F2E609zQBP6l EnMNIw+vKToWzJCrnqHUKuW0T16VZaqdkAwBDK6jOZHj/wAb62pB9QGbeOGw3vzCBrQS jvsjALrM4HfNat7B+63vHH17sL5/w5yEgaPTkOdOdi4e1Ph+JDDG6mRaza3jnjxOT1nt 9TBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hdYNVeVJ9zG7uGLj2brLM5VkYYRU60Z3UwUXj26j7Y4=; b=Cf3lhe+/km6Pec0JF9H1eNRlLxMFOJ8oCe+G5+SOCTUPLCxoXaN1jPkC2cNhsh6OI3 7h+revaT7mE6D1g1+aw5Bw1eZHjTHwq+70B4Hpz2m+VUBkeWc094defzFJYuswy+HWa6 sSzlrRAun2FC7JeiGdVbjk/snTdGR1DyAcu0wr+lkMyuraGyY3Z6ShtXcf87fT8h2bNX ZIVe3zyzmjUsamD/wtVhgntpVoOxg8rcGBhT56lrcE2EjxYOZqZbkD1+7vyaHYk8jLob fDmE3KJUmhYooI6NOr8YccW6Sk4avE7/nQCIHTIuWBA3tAWqAC+Y9hIXyKtDgBxa8nZ+ NihQ== X-Gm-Message-State: APjAAAW7vBbbvC2NPPn/UR9n2FMnyohgd4fdQi4dHyb48X22oT8vcXfp C0HRIeVURAeEIPW484a6dzbCn5K55t+oWPKQI8o= X-Google-Smtp-Source: APXvYqym0wfGn4MUh0Q5DxHRfhzWymg3X0lx1rvhD/+srbD8Wct7zzVCcUi8kXTeECHde0dGL3nXAC88Ujygt72NEnw= X-Received: by 2002:a1c:6404:: with SMTP id y4mr18312577wmb.143.1576870835379; Fri, 20 Dec 2019 11:40:35 -0800 (PST) MIME-Version: 1.0 References: <1576834568-82874-1-git-send-email-mafeng.ma@huawei.com> In-Reply-To: <1576834568-82874-1-git-send-email-mafeng.ma@huawei.com> From: Alex Deucher Date: Fri, 20 Dec 2019 14:40:23 -0500 Message-ID: Subject: Re: [PATCH] drm/amdgpu: Remove unneeded variable 'ret' in navi10_ih.c To: Ma Feng X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chunming Zhou , David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Daniel Vetter , Alex Deucher , Christian Koenig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Fri, Dec 20, 2019 at 10:10 AM Ma Feng wrote: > > Fixes coccicheck warning: > > drivers/gpu/drm/amd/amdgpu/navi10_ih.c:113:5-8: Unneeded variable: "ret". Return "0" on line 182 > > Reported-by: Hulk Robot > Signed-off-by: Ma Feng Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c > index 9af7356..f737ce4 100644 > --- a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c > +++ b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c > @@ -110,7 +110,6 @@ static uint32_t navi10_ih_rb_cntl(struct amdgpu_ih_ring *ih, uint32_t ih_rb_cntl > static int navi10_ih_irq_init(struct amdgpu_device *adev) > { > struct amdgpu_ih_ring *ih = &adev->irq.ih; > - int ret = 0; > u32 ih_rb_cntl, ih_doorbell_rtpr, ih_chicken; > u32 tmp; > > @@ -179,7 +178,7 @@ static int navi10_ih_irq_init(struct amdgpu_device *adev) > /* enable interrupts */ > navi10_ih_enable_interrupts(adev); > > - return ret; > + return 0; > } > > /** > -- > 2.6.2 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx