From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH 5/8] drm/amdgpu: cleanup coding style in amdgpu_vm_flush Date: Mon, 3 Apr 2017 15:18:57 -0400 Message-ID: References: <1491223199-28892-1-git-send-email-deathsimple@vodafone.de> <1491223199-28892-5-git-send-email-deathsimple@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1491223199-28892-5-git-send-email-deathsimple-ANTagKRnAhcb1SvskN2V4Q@public.gmane.org> List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: amd-gfx list T24gTW9uLCBBcHIgMywgMjAxNyBhdCA4OjM5IEFNLCBDaHJpc3RpYW4gS8O2bmlnIDxkZWF0aHNp bXBsZUB2b2RhZm9uZS5kZT4gd3JvdGU6Cj4gRnJvbTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0 aWFuLmtvZW5pZ0BhbWQuY29tPgo+Cj4gVGhlIGluZGVudGF0aW9uIHdhcyBvZiBpbiBtb3JlIHRo YW4gb25lIHBsYWNlLgoKY29tbWl0IG1lc3NhZ2UgaXMgdW5jbGVhciwgd2l0aCB0aGF0IGZpeGVk OgpSZXZpZXdlZC1ieTogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgoK Pgo+IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1k LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMgfCA4 OCArKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0 NSBpbnNlcnRpb25zKCspLCA0MyBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV92bS5jCj4gaW5kZXggNGZmZDIyNDQuLjg1ZTQ1YjMgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3ZtLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdm0uYwo+IEBAIC01OTcsNjAgKzU5Nyw2MiBAQCBpbnQg YW1kZ3B1X3ZtX2ZsdXNoKHN0cnVjdCBhbWRncHVfcmluZyAqcmluZywgc3RydWN0IGFtZGdwdV9q b2IgKmpvYikKPiAgICAgICAgICAgICAgICAgaWQtPmd3c19zaXplICE9IGpvYi0+Z3dzX3NpemUg fHwKPiAgICAgICAgICAgICAgICAgaWQtPm9hX2Jhc2UgIT0gam9iLT5vYV9iYXNlIHx8Cj4gICAg ICAgICAgICAgICAgIGlkLT5vYV9zaXplICE9IGpvYi0+b2Ffc2l6ZSk7Cj4gKyAgICAgICB1bnNp Z25lZCBwYXRjaF9vZmZzZXQgPSAwOwo+ICAgICAgICAgaW50IHI7Cj4KPiAtICAgICAgIGlmIChq b2ItPnZtX25lZWRzX2ZsdXNoIHx8IGdkc19zd2l0Y2hfbmVlZGVkIHx8Cj4gLSAgICAgICAgICAg ICAgIGFtZGdwdV92bV9oYWRfZ3B1X3Jlc2V0KGFkZXYsIGlkKSB8fAo+IC0gICAgICAgICAgICAg ICBhbWRncHVfdm1fcmluZ19oYXNfY29tcHV0ZV92bV9idWcocmluZykpIHsKPiAtICAgICAgICAg ICAgICAgdW5zaWduZWQgcGF0Y2hfb2Zmc2V0ID0gMDsKPiArICAgICAgIGlmICgham9iLT52bV9u ZWVkc19mbHVzaCAmJiAhZ2RzX3N3aXRjaF9uZWVkZWQgJiYKPiArICAgICAgICAgICAhYW1kZ3B1 X3ZtX2hhZF9ncHVfcmVzZXQoYWRldiwgaWQpICYmCj4gKyAgICAgICAgICAgIWFtZGdwdV92bV9y aW5nX2hhc19jb21wdXRlX3ZtX2J1ZyhyaW5nKSkKPiArICAgICAgICAgICAgICAgcmV0dXJuIDA7 Cj4KPiAtICAgICAgICAgICAgICAgaWYgKHJpbmctPmZ1bmNzLT5pbml0X2NvbmRfZXhlYykKPiAt ICAgICAgICAgICAgICAgICAgICAgICBwYXRjaF9vZmZzZXQgPSBhbWRncHVfcmluZ19pbml0X2Nv bmRfZXhlYyhyaW5nKTsKPgo+IC0gICAgICAgICAgICAgICBpZiAocmluZy0+ZnVuY3MtPmVtaXRf cGlwZWxpbmVfc3luYyAmJgo+IC0gICAgICAgICAgICAgICAgICAgICAgIChqb2ItPnZtX25lZWRz X2ZsdXNoIHx8IGdkc19zd2l0Y2hfbmVlZGVkIHx8Cj4gLSAgICAgICAgICAgICAgICAgICAgICAg YW1kZ3B1X3ZtX3JpbmdfaGFzX2NvbXB1dGVfdm1fYnVnKHJpbmcpKSkKPiAtICAgICAgICAgICAg ICAgICAgICAgICBhbWRncHVfcmluZ19lbWl0X3BpcGVsaW5lX3N5bmMocmluZyk7Cj4gKyAgICAg ICBpZiAocmluZy0+ZnVuY3MtPmluaXRfY29uZF9leGVjKQo+ICsgICAgICAgICAgICAgICBwYXRj aF9vZmZzZXQgPSBhbWRncHVfcmluZ19pbml0X2NvbmRfZXhlYyhyaW5nKTsKPgo+IC0gICAgICAg ICAgICAgICBpZiAocmluZy0+ZnVuY3MtPmVtaXRfdm1fZmx1c2ggJiYgKGpvYi0+dm1fbmVlZHNf Zmx1c2ggfHwKPiAtICAgICAgICAgICAgICAgICAgICAgICBhbWRncHVfdm1faGFkX2dwdV9yZXNl dChhZGV2LCBpZCkpKSB7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IGZlbmNlICpm ZW5jZTsKPiAtICAgICAgICAgICAgICAgICAgICAgICB1NjQgcGRfYWRkciA9IGFtZGdwdV92bV9h ZGp1c3RfbWNfYWRkcihhZGV2LCBqb2ItPnZtX3BkX2FkZHIpOwo+ICsgICAgICAgaWYgKHJpbmct PmZ1bmNzLT5lbWl0X3BpcGVsaW5lX3N5bmMgJiYKPiArICAgICAgICAgICAoam9iLT52bV9uZWVk c19mbHVzaCB8fCBnZHNfc3dpdGNoX25lZWRlZCB8fAo+ICsgICAgICAgICAgICBhbWRncHVfdm1f cmluZ19oYXNfY29tcHV0ZV92bV9idWcocmluZykpKQo+ICsgICAgICAgICAgICAgICBhbWRncHVf cmluZ19lbWl0X3BpcGVsaW5lX3N5bmMocmluZyk7Cj4KPiAtICAgICAgICAgICAgICAgICAgICAg ICB0cmFjZV9hbWRncHVfdm1fZmx1c2gocGRfYWRkciwgcmluZy0+aWR4LCBqb2ItPnZtX2lkKTsK PiAtICAgICAgICAgICAgICAgICAgICAgICBhbWRncHVfcmluZ19lbWl0X3ZtX2ZsdXNoKHJpbmcs IGpvYi0+dm1faWQsIHBkX2FkZHIpOwo+ICsgICAgICAgaWYgKHJpbmctPmZ1bmNzLT5lbWl0X3Zt X2ZsdXNoICYmCj4gKyAgICAgICAgICAgKGpvYi0+dm1fbmVlZHNfZmx1c2ggfHwgYW1kZ3B1X3Zt X2hhZF9ncHVfcmVzZXQoYWRldiwgaWQpKSkgewo+Cj4gLSAgICAgICAgICAgICAgICAgICAgICAg ciA9IGFtZGdwdV9mZW5jZV9lbWl0KHJpbmcsICZmZW5jZSk7Cj4gLSAgICAgICAgICAgICAgICAg ICAgICAgaWYgKHIpCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gcjsK PiArICAgICAgICAgICAgICAgdTY0IHBkX2FkZHIgPSBhbWRncHVfdm1fYWRqdXN0X21jX2FkZHIo YWRldiwgam9iLT52bV9wZF9hZGRyKTsKPiArICAgICAgICAgICAgICAgc3RydWN0IGZlbmNlICpm ZW5jZTsKPgo+IC0gICAgICAgICAgICAgICAgICAgICAgIG11dGV4X2xvY2soJmFkZXYtPnZtX21h bmFnZXIubG9jayk7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgZmVuY2VfcHV0KGlkLT5sYXN0 X2ZsdXNoKTsKPiAtICAgICAgICAgICAgICAgICAgICAgICBpZC0+bGFzdF9mbHVzaCA9IGZlbmNl Owo+IC0gICAgICAgICAgICAgICAgICAgICAgIG11dGV4X3VubG9jaygmYWRldi0+dm1fbWFuYWdl ci5sb2NrKTsKPiAtICAgICAgICAgICAgICAgfQo+ICsgICAgICAgICAgICAgICB0cmFjZV9hbWRn cHVfdm1fZmx1c2gocGRfYWRkciwgcmluZy0+aWR4LCBqb2ItPnZtX2lkKTsKPiArICAgICAgICAg ICAgICAgYW1kZ3B1X3JpbmdfZW1pdF92bV9mbHVzaChyaW5nLCBqb2ItPnZtX2lkLCBwZF9hZGRy KTsKPgo+IC0gICAgICAgICAgICAgICBpZiAoZ2RzX3N3aXRjaF9uZWVkZWQpIHsKPiAtICAgICAg ICAgICAgICAgICAgICAgICBpZC0+Z2RzX2Jhc2UgPSBqb2ItPmdkc19iYXNlOwo+IC0gICAgICAg ICAgICAgICAgICAgICAgIGlkLT5nZHNfc2l6ZSA9IGpvYi0+Z2RzX3NpemU7Cj4gLSAgICAgICAg ICAgICAgICAgICAgICAgaWQtPmd3c19iYXNlID0gam9iLT5nd3NfYmFzZTsKPiAtICAgICAgICAg ICAgICAgICAgICAgICBpZC0+Z3dzX3NpemUgPSBqb2ItPmd3c19zaXplOwo+IC0gICAgICAgICAg ICAgICAgICAgICAgIGlkLT5vYV9iYXNlID0gam9iLT5vYV9iYXNlOwo+IC0gICAgICAgICAgICAg ICAgICAgICAgIGlkLT5vYV9zaXplID0gam9iLT5vYV9zaXplOwo+IC0gICAgICAgICAgICAgICAg ICAgICAgIGFtZGdwdV9yaW5nX2VtaXRfZ2RzX3N3aXRjaChyaW5nLCBqb2ItPnZtX2lkLAo+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgam9i LT5nZHNfYmFzZSwgam9iLT5nZHNfc2l6ZSwKPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGpvYi0+Z3dzX2Jhc2UsIGpvYi0+Z3dzX3NpemUs Cj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBqb2ItPm9hX2Jhc2UsIGpvYi0+b2Ffc2l6ZSk7Cj4gLSAgICAgICAgICAgICAgIH0KPiArICAg ICAgICAgICAgICAgciA9IGFtZGdwdV9mZW5jZV9lbWl0KHJpbmcsICZmZW5jZSk7Cj4gKyAgICAg ICAgICAgICAgIGlmIChyKQo+ICsgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiByOwo+Cj4g LSAgICAgICAgICAgICAgIGlmIChyaW5nLT5mdW5jcy0+cGF0Y2hfY29uZF9leGVjKQo+IC0gICAg ICAgICAgICAgICAgICAgICAgIGFtZGdwdV9yaW5nX3BhdGNoX2NvbmRfZXhlYyhyaW5nLCBwYXRj aF9vZmZzZXQpOwo+ICsgICAgICAgICAgICAgICBtdXRleF9sb2NrKCZhZGV2LT52bV9tYW5hZ2Vy LmxvY2spOwo+ICsgICAgICAgICAgICAgICBmZW5jZV9wdXQoaWQtPmxhc3RfZmx1c2gpOwo+ICsg ICAgICAgICAgICAgICBpZC0+bGFzdF9mbHVzaCA9IGZlbmNlOwo+ICsgICAgICAgICAgICAgICBt dXRleF91bmxvY2soJmFkZXYtPnZtX21hbmFnZXIubG9jayk7Cj4gKyAgICAgICB9Cj4KPiAtICAg ICAgICAgICAgICAgLyogdGhlIGRvdWJsZSBTV0lUQ0hfQlVGRkVSIGhlcmUgKmNhbm5vdCogYmUg c2tpcHBlZCBieSBDT05EX0VYRUMgKi8KPiAtICAgICAgICAgICAgICAgaWYgKHJpbmctPmZ1bmNz LT5lbWl0X3N3aXRjaF9idWZmZXIpIHsKPiAtICAgICAgICAgICAgICAgICAgICAgICBhbWRncHVf cmluZ19lbWl0X3N3aXRjaF9idWZmZXIocmluZyk7Cj4gLSAgICAgICAgICAgICAgICAgICAgICAg YW1kZ3B1X3JpbmdfZW1pdF9zd2l0Y2hfYnVmZmVyKHJpbmcpOwo+IC0gICAgICAgICAgICAgICB9 Cj4gKyAgICAgICBpZiAoZ2RzX3N3aXRjaF9uZWVkZWQpIHsKPiArICAgICAgICAgICAgICAgaWQt Pmdkc19iYXNlID0gam9iLT5nZHNfYmFzZTsKPiArICAgICAgICAgICAgICAgaWQtPmdkc19zaXpl ID0gam9iLT5nZHNfc2l6ZTsKPiArICAgICAgICAgICAgICAgaWQtPmd3c19iYXNlID0gam9iLT5n d3NfYmFzZTsKPiArICAgICAgICAgICAgICAgaWQtPmd3c19zaXplID0gam9iLT5nd3Nfc2l6ZTsK PiArICAgICAgICAgICAgICAgaWQtPm9hX2Jhc2UgPSBqb2ItPm9hX2Jhc2U7Cj4gKyAgICAgICAg ICAgICAgIGlkLT5vYV9zaXplID0gam9iLT5vYV9zaXplOwo+ICsgICAgICAgICAgICAgICBhbWRn cHVfcmluZ19lbWl0X2dkc19zd2l0Y2gocmluZywgam9iLT52bV9pZCwgam9iLT5nZHNfYmFzZSwK PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGpvYi0+Z2RzX3Np emUsIGpvYi0+Z3dzX2Jhc2UsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBqb2ItPmd3c19zaXplLCBqb2ItPm9hX2Jhc2UsCj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBqb2ItPm9hX3NpemUpOwo+ICsgICAgICAgfQo+ICsK PiArICAgICAgIGlmIChyaW5nLT5mdW5jcy0+cGF0Y2hfY29uZF9leGVjKQo+ICsgICAgICAgICAg ICAgICBhbWRncHVfcmluZ19wYXRjaF9jb25kX2V4ZWMocmluZywgcGF0Y2hfb2Zmc2V0KTsKPiAr Cj4gKyAgICAgICAvKiB0aGUgZG91YmxlIFNXSVRDSF9CVUZGRVIgaGVyZSAqY2Fubm90KiBiZSBz a2lwcGVkIGJ5IENPTkRfRVhFQyAqLwo+ICsgICAgICAgaWYgKHJpbmctPmZ1bmNzLT5lbWl0X3N3 aXRjaF9idWZmZXIpIHsKPiArICAgICAgICAgICAgICAgYW1kZ3B1X3JpbmdfZW1pdF9zd2l0Y2hf YnVmZmVyKHJpbmcpOwo+ICsgICAgICAgICAgICAgICBhbWRncHVfcmluZ19lbWl0X3N3aXRjaF9i dWZmZXIocmluZyk7Cj4gICAgICAgICB9Cj4gICAgICAgICByZXR1cm4gMDsKPiAgfQo+IC0tCj4g Mi41LjAKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gYW1kLWdmeCBtYWlsaW5nIGxpc3QKPiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1h aWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK