From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E342C433F5 for ; Tue, 22 Feb 2022 16:45:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234307AbiBVQqI (ORCPT ); Tue, 22 Feb 2022 11:46:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234300AbiBVQqG (ORCPT ); Tue, 22 Feb 2022 11:46:06 -0500 Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 964E2169384 for ; Tue, 22 Feb 2022 08:45:39 -0800 (PST) Received: by mail-oi1-x234.google.com with SMTP id p15so15163522oip.3 for ; Tue, 22 Feb 2022 08:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BiTH8veyolAI3Fepio67cDwgp9/0CZ3ZhBAQz6LqnXY=; b=o9AqQK8vBGSclCZstinXzJr/iSF4gKn9SY1VD0v03lJOgZhg/TbvHXacMT2HI0Cdp0 ZQlUL0FxT7zbB6Yo+hzPu5gJInHxSpcfa+k/RvUZk3mvGozvNkmQakypRGQ0bVkZq4V/ eLCqSr/u2AaGTvOkV1rePJXaSwekinAbv4CnNoS8XqFizsM4kuew4ogDXF73CkjQ0Uv3 Rsg9F2rr8BKQ+Ra9qbmAdBf2uZqcByZq2ONVULsZMPg3gfgzkF431xnoNDvNkxwcsIw5 ge2PkzhdPY3oBY9ORAVM3R+r2q5Kcb+Dg2bmSYDfrd50VU4JkKf1SOemRFTxRvlauqP6 4hVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BiTH8veyolAI3Fepio67cDwgp9/0CZ3ZhBAQz6LqnXY=; b=Wz0jglspei+bBY65l6zP6VEtYWHA4s2MYNavrXO4nVeqX722oBn6OXE00l3M6EPVkY DaFihddH/so9kgqmT5xArdqOowH7+G8BdkewaNwOMBAaG1MGWsSuWlmrsAuksUqBF+l8 DvJQdYNYGm3h+K7pX4swH73jp4QfqBUsgyQNlX/MTtZ+LIYjdOQlBsAqt8LQPOxLHj4n I5+yL3DhOfElSwc7alhe8LJ9jZ0TLiavh0QDjR4MQZLeHsMwh1203aHgIF+8/W+8gKCL ieWhqP2zFVBV8f3hjDn44tEB7Wq1WPq8ROqtrlsenYIigLtLOrpXhQYriPyRVkYJ1F82 Hp2w== X-Gm-Message-State: AOAM531xk0QKIobKGVMc3FbszFESo56tDLvUgD00oz5IaADu4T5o9mPu cAYo15apib/O/9XF8cezP7qHYCHj8rWm+UqDVQ0= X-Google-Smtp-Source: ABdhPJxqwvD5NzKUsaokv4n4oD8Uxf1FQmBrb++b2A1mClgdQG0AwdkWuKSKXDyX0LdCNwThLofQKm8bAl6EQiccVYw= X-Received: by 2002:aca:ab4c:0:b0:2d4:7c7d:606e with SMTP id u73-20020acaab4c000000b002d47c7d606emr2408438oie.132.1645548338864; Tue, 22 Feb 2022 08:45:38 -0800 (PST) MIME-Version: 1.0 References: <20220222131701.356117-1-maira.canal@usp.br> <20220222131701.356117-11-maira.canal@usp.br> In-Reply-To: <20220222131701.356117-11-maira.canal@usp.br> From: Alex Deucher Date: Tue, 22 Feb 2022 11:45:27 -0500 Message-ID: Subject: Re: [PATCH 10/10] drm/amd/display: Turn global functions into static functions To: =?UTF-8?B?TWHDrXJhIENhbmFs?= Cc: "Deucher, Alexander" , Christian Koenig , xinhui pan , Hawking Zhang , John Clements , Tao Zhou , "Chai, Thomas" , "Tuikov, Luben" , "Stanley.Yang" , Dennis Li , "Joshi, Mukul" , "Wentland, Harry" , "Leo (Sunpeng) Li" , "Siqueira, Rodrigo" , Anthony Koo , Magali Lemes , LKML , Maling list - DRI developers , mwen@igalia.com, amd-gfx list , Isabella Basso Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 22, 2022 at 8:18 AM Ma=C3=ADra Canal wrote= : > > Turn previously global functions into static functions to avoid > -Wmissing-prototype warnings, such as: > > drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50= :20: > warning: no previous prototype for function 'to_dal_irq_source_dcn30' > [-Wmissing-prototypes] > enum dc_irq_source to_dal_irq_source_dcn30( > ^ > drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50= :1: > note: declare 'static' if the function is not intended to be used outside > of this translation unit > enum dc_irq_source to_dal_irq_source_dcn30( > ^ > static > 1 warning generated. > > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:= 488:6: > warning: no previous prototype for function > 'dcn316_clk_mgr_helper_populate_bw_params' [-Wmissing-prototypes] > void dcn316_clk_mgr_helper_populate_bw_params( > ^ > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:= 488:1: > note: declare 'static' if the function is not intended to be used outside > of this translation unit > void dcn316_clk_mgr_helper_populate_bw_params( > ^ > static > 1 warning generated. > > Signed-off-by: Ma=C3=ADra Canal > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > .../drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c | 3 ++- > .../gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c | 2 +- > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 2 +- > drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- > drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c | 2 +- > drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c | 2 +- > 8 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/= gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index c9ca328d34e3..a99b92526b55 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -6362,7 +6362,7 @@ static bool is_freesync_video_mode(const struct drm= _display_mode *mode, > return true; > } > > -struct dc_stream_state * > +static struct dc_stream_state * > create_stream_for_sink(struct amdgpu_dm_connector *aconnector, > const struct drm_display_mode *drm_mode, > const struct dm_connector_state *dm_state, > @@ -10189,7 +10189,7 @@ static void set_freesync_fixed_config(struct dm_c= rtc_state *dm_new_crtc_state) { > dm_new_crtc_state->freesync_config.fixed_refresh_in_uhz =3D res; > } > > -int dm_update_crtc_state(struct amdgpu_display_manager *dm, > +static int dm_update_crtc_state(struct amdgpu_display_manager *dm, > struct drm_atomic_state *state, > struct drm_crtc *crtc, > struct drm_crtc_state *old_crtc_state, > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c = b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > index 389b0cb37995..05573f073b21 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > @@ -213,7 +213,7 @@ static bool validate_dsc_caps_on_connector(struct amd= gpu_dm_connector *aconnecto > return true; > } > > -bool retrieve_downstream_port_device(struct amdgpu_dm_connector *aconnec= tor) > +static bool retrieve_downstream_port_device(struct amdgpu_dm_connector *= aconnector) > { > union dp_downstream_port_present ds_port_present; > > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbi= os_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_s= mu.c > index 06bab24d8e27..450eaead4f20 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.= c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.= c > @@ -101,7 +101,8 @@ static uint32_t rv1_smu_wait_for_response(struct clk_= mgr_internal *clk_mgr, unsi > return res_val; > } > > -int rv1_vbios_smu_send_msg_with_param(struct clk_mgr_internal *clk_mgr, = unsigned int msg_id, unsigned int param) > +static int rv1_vbios_smu_send_msg_with_param(struct clk_mgr_internal *cl= k_mgr, > + unsigned int msg_id, unsigned int param) > { > uint32_t result; > > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr= .c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c > index ffd3d5cb9871..02a59adff90d 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c > @@ -485,7 +485,7 @@ static unsigned int find_clk_for_voltage( > return clock; > } > > -void dcn316_clk_mgr_helper_populate_bw_params( > +static void dcn316_clk_mgr_helper_populate_bw_params( > struct clk_mgr_internal *clk_mgr, > struct integrated_info *bios_info, > const DpmClocks_316_t *clock_table) > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c b= /drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > index fd6497fd2dc5..128614dff108 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > @@ -111,7 +111,7 @@ static uint32_t dcn316_smu_wait_for_response(struct c= lk_mgr_internal *clk_mgr, u > return res_val; > } > > -int dcn316_smu_send_msg_with_param( > +static int dcn316_smu_send_msg_with_param( > struct clk_mgr_internal *clk_mgr, > unsigned int msg_id, unsigned int param) > { > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/= gpu/drm/amd/display/dc/core/dc_resource.c > index 19b56f9acf84..29ab67f42d92 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c > @@ -1622,7 +1622,7 @@ bool dc_add_all_planes_for_stream( > return add_all_planes_for_stream(dc, stream, &set, 1, context); > } > > -bool is_timing_changed(struct dc_stream_state *cur_stream, > +static bool is_timing_changed(struct dc_stream_state *cur_stream, > struct dc_stream_state *new_stream) > { > if (cur_stream =3D=3D NULL) This function is actually used elsewhere. I've dropped this hunk, but applied the rest. Thanks! Alex > diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c= b/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c > index c4b067d01895..93c31111500b 100644 > --- a/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c > +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c > @@ -40,7 +40,7 @@ > > #include "ivsrcid/dcn/irqsrcs_dcn_1_0.h" > > -enum dc_irq_source to_dal_irq_source_dcn20( > +static enum dc_irq_source to_dal_irq_source_dcn20( > struct irq_service *irq_service, > uint32_t src_id, > uint32_t ext_id) > diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c= b/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c > index 0b68c08fac3f..ac0c6a62d17b 100644 > --- a/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c > +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c > @@ -47,7 +47,7 @@ > > #include "ivsrcid/dcn/irqsrcs_dcn_1_0.h" > > -enum dc_irq_source to_dal_irq_source_dcn30( > +static enum dc_irq_source to_dal_irq_source_dcn30( > struct irq_service *irq_service, > uint32_t src_id, > uint32_t ext_id) > -- > 2.35.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35EF8C433F5 for ; Tue, 22 Feb 2022 16:45:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3075F10E8FF; Tue, 22 Feb 2022 16:45:41 +0000 (UTC) Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FBE810E8E5; Tue, 22 Feb 2022 16:45:39 +0000 (UTC) Received: by mail-oi1-x236.google.com with SMTP id ay7so15129026oib.8; Tue, 22 Feb 2022 08:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BiTH8veyolAI3Fepio67cDwgp9/0CZ3ZhBAQz6LqnXY=; b=o9AqQK8vBGSclCZstinXzJr/iSF4gKn9SY1VD0v03lJOgZhg/TbvHXacMT2HI0Cdp0 ZQlUL0FxT7zbB6Yo+hzPu5gJInHxSpcfa+k/RvUZk3mvGozvNkmQakypRGQ0bVkZq4V/ eLCqSr/u2AaGTvOkV1rePJXaSwekinAbv4CnNoS8XqFizsM4kuew4ogDXF73CkjQ0Uv3 Rsg9F2rr8BKQ+Ra9qbmAdBf2uZqcByZq2ONVULsZMPg3gfgzkF431xnoNDvNkxwcsIw5 ge2PkzhdPY3oBY9ORAVM3R+r2q5Kcb+Dg2bmSYDfrd50VU4JkKf1SOemRFTxRvlauqP6 4hVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BiTH8veyolAI3Fepio67cDwgp9/0CZ3ZhBAQz6LqnXY=; b=AlfeFPUI/dif4o6+hsERoYUIVtcg0yp4Rn8BXwLkG8CY/hHSB2uixTjAPdJz6P/BCD j9+G0KtBx4MVMDT5NKXgwAvFxSMHiwb+1ROktRVDf0oayh81dMT4F4rFcoBFLJ0NJ2Ya z/7sUWgJEvE1HPcVqpC9qiM+L9io4zG0HUwnOIzT7RG7jk4caMLAedEytwm8fCf8p9EV Vnii6HtuTTfGjZe5NJyXHksXd6K8eenfaf/Tz0VWD8A28qm1GuJpDnS+40Rdl3PP7anX u/WHpSFuBz3qTF0ucBWG5SyX0KoiEpwHxi4o0ZYSunRiS5QmwCjUill3msrzrujSK7az gLYA== X-Gm-Message-State: AOAM531UZOt238EJ56QvDmPPDBtVa7+S5UsU6MujEJBmTQxZfQ3ek1Ew JGkX1QLHhSyAcahtcAKVh4z2tQ0ow+mFS1TGyGQ= X-Google-Smtp-Source: ABdhPJxqwvD5NzKUsaokv4n4oD8Uxf1FQmBrb++b2A1mClgdQG0AwdkWuKSKXDyX0LdCNwThLofQKm8bAl6EQiccVYw= X-Received: by 2002:aca:ab4c:0:b0:2d4:7c7d:606e with SMTP id u73-20020acaab4c000000b002d47c7d606emr2408438oie.132.1645548338864; Tue, 22 Feb 2022 08:45:38 -0800 (PST) MIME-Version: 1.0 References: <20220222131701.356117-1-maira.canal@usp.br> <20220222131701.356117-11-maira.canal@usp.br> In-Reply-To: <20220222131701.356117-11-maira.canal@usp.br> From: Alex Deucher Date: Tue, 22 Feb 2022 11:45:27 -0500 Message-ID: Subject: Re: [PATCH 10/10] drm/amd/display: Turn global functions into static functions To: =?UTF-8?B?TWHDrXJhIENhbmFs?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Tuikov, Luben" , Tao Zhou , Anthony Koo , "Joshi, Mukul" , "Leo \(Sunpeng\) Li" , xinhui pan , "Siqueira, Rodrigo" , LKML , Maling list - DRI developers , mwen@igalia.com, "Chai, Thomas" , "Stanley.Yang" , amd-gfx list , Magali Lemes , "Deucher, Alexander" , Isabella Basso , John Clements , Christian Koenig , Dennis Li , Hawking Zhang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Feb 22, 2022 at 8:18 AM Ma=C3=ADra Canal wrote= : > > Turn previously global functions into static functions to avoid > -Wmissing-prototype warnings, such as: > > drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50= :20: > warning: no previous prototype for function 'to_dal_irq_source_dcn30' > [-Wmissing-prototypes] > enum dc_irq_source to_dal_irq_source_dcn30( > ^ > drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50= :1: > note: declare 'static' if the function is not intended to be used outside > of this translation unit > enum dc_irq_source to_dal_irq_source_dcn30( > ^ > static > 1 warning generated. > > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:= 488:6: > warning: no previous prototype for function > 'dcn316_clk_mgr_helper_populate_bw_params' [-Wmissing-prototypes] > void dcn316_clk_mgr_helper_populate_bw_params( > ^ > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:= 488:1: > note: declare 'static' if the function is not intended to be used outside > of this translation unit > void dcn316_clk_mgr_helper_populate_bw_params( > ^ > static > 1 warning generated. > > Signed-off-by: Ma=C3=ADra Canal > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > .../drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c | 3 ++- > .../gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c | 2 +- > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 2 +- > drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- > drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c | 2 +- > drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c | 2 +- > 8 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/= gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index c9ca328d34e3..a99b92526b55 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -6362,7 +6362,7 @@ static bool is_freesync_video_mode(const struct drm= _display_mode *mode, > return true; > } > > -struct dc_stream_state * > +static struct dc_stream_state * > create_stream_for_sink(struct amdgpu_dm_connector *aconnector, > const struct drm_display_mode *drm_mode, > const struct dm_connector_state *dm_state, > @@ -10189,7 +10189,7 @@ static void set_freesync_fixed_config(struct dm_c= rtc_state *dm_new_crtc_state) { > dm_new_crtc_state->freesync_config.fixed_refresh_in_uhz =3D res; > } > > -int dm_update_crtc_state(struct amdgpu_display_manager *dm, > +static int dm_update_crtc_state(struct amdgpu_display_manager *dm, > struct drm_atomic_state *state, > struct drm_crtc *crtc, > struct drm_crtc_state *old_crtc_state, > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c = b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > index 389b0cb37995..05573f073b21 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > @@ -213,7 +213,7 @@ static bool validate_dsc_caps_on_connector(struct amd= gpu_dm_connector *aconnecto > return true; > } > > -bool retrieve_downstream_port_device(struct amdgpu_dm_connector *aconnec= tor) > +static bool retrieve_downstream_port_device(struct amdgpu_dm_connector *= aconnector) > { > union dp_downstream_port_present ds_port_present; > > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbi= os_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_s= mu.c > index 06bab24d8e27..450eaead4f20 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.= c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.= c > @@ -101,7 +101,8 @@ static uint32_t rv1_smu_wait_for_response(struct clk_= mgr_internal *clk_mgr, unsi > return res_val; > } > > -int rv1_vbios_smu_send_msg_with_param(struct clk_mgr_internal *clk_mgr, = unsigned int msg_id, unsigned int param) > +static int rv1_vbios_smu_send_msg_with_param(struct clk_mgr_internal *cl= k_mgr, > + unsigned int msg_id, unsigned int param) > { > uint32_t result; > > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr= .c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c > index ffd3d5cb9871..02a59adff90d 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c > @@ -485,7 +485,7 @@ static unsigned int find_clk_for_voltage( > return clock; > } > > -void dcn316_clk_mgr_helper_populate_bw_params( > +static void dcn316_clk_mgr_helper_populate_bw_params( > struct clk_mgr_internal *clk_mgr, > struct integrated_info *bios_info, > const DpmClocks_316_t *clock_table) > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c b= /drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > index fd6497fd2dc5..128614dff108 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > @@ -111,7 +111,7 @@ static uint32_t dcn316_smu_wait_for_response(struct c= lk_mgr_internal *clk_mgr, u > return res_val; > } > > -int dcn316_smu_send_msg_with_param( > +static int dcn316_smu_send_msg_with_param( > struct clk_mgr_internal *clk_mgr, > unsigned int msg_id, unsigned int param) > { > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/= gpu/drm/amd/display/dc/core/dc_resource.c > index 19b56f9acf84..29ab67f42d92 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c > @@ -1622,7 +1622,7 @@ bool dc_add_all_planes_for_stream( > return add_all_planes_for_stream(dc, stream, &set, 1, context); > } > > -bool is_timing_changed(struct dc_stream_state *cur_stream, > +static bool is_timing_changed(struct dc_stream_state *cur_stream, > struct dc_stream_state *new_stream) > { > if (cur_stream =3D=3D NULL) This function is actually used elsewhere. I've dropped this hunk, but applied the rest. Thanks! Alex > diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c= b/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c > index c4b067d01895..93c31111500b 100644 > --- a/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c > +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c > @@ -40,7 +40,7 @@ > > #include "ivsrcid/dcn/irqsrcs_dcn_1_0.h" > > -enum dc_irq_source to_dal_irq_source_dcn20( > +static enum dc_irq_source to_dal_irq_source_dcn20( > struct irq_service *irq_service, > uint32_t src_id, > uint32_t ext_id) > diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c= b/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c > index 0b68c08fac3f..ac0c6a62d17b 100644 > --- a/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c > +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c > @@ -47,7 +47,7 @@ > > #include "ivsrcid/dcn/irqsrcs_dcn_1_0.h" > > -enum dc_irq_source to_dal_irq_source_dcn30( > +static enum dc_irq_source to_dal_irq_source_dcn30( > struct irq_service *irq_service, > uint32_t src_id, > uint32_t ext_id) > -- > 2.35.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DCB2C433EF for ; Tue, 22 Feb 2022 16:45:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F7F710E8E5; Tue, 22 Feb 2022 16:45:40 +0000 (UTC) Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FBE810E8E5; Tue, 22 Feb 2022 16:45:39 +0000 (UTC) Received: by mail-oi1-x236.google.com with SMTP id ay7so15129026oib.8; Tue, 22 Feb 2022 08:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=BiTH8veyolAI3Fepio67cDwgp9/0CZ3ZhBAQz6LqnXY=; b=o9AqQK8vBGSclCZstinXzJr/iSF4gKn9SY1VD0v03lJOgZhg/TbvHXacMT2HI0Cdp0 ZQlUL0FxT7zbB6Yo+hzPu5gJInHxSpcfa+k/RvUZk3mvGozvNkmQakypRGQ0bVkZq4V/ eLCqSr/u2AaGTvOkV1rePJXaSwekinAbv4CnNoS8XqFizsM4kuew4ogDXF73CkjQ0Uv3 Rsg9F2rr8BKQ+Ra9qbmAdBf2uZqcByZq2ONVULsZMPg3gfgzkF431xnoNDvNkxwcsIw5 ge2PkzhdPY3oBY9ORAVM3R+r2q5Kcb+Dg2bmSYDfrd50VU4JkKf1SOemRFTxRvlauqP6 4hVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BiTH8veyolAI3Fepio67cDwgp9/0CZ3ZhBAQz6LqnXY=; b=AlfeFPUI/dif4o6+hsERoYUIVtcg0yp4Rn8BXwLkG8CY/hHSB2uixTjAPdJz6P/BCD j9+G0KtBx4MVMDT5NKXgwAvFxSMHiwb+1ROktRVDf0oayh81dMT4F4rFcoBFLJ0NJ2Ya z/7sUWgJEvE1HPcVqpC9qiM+L9io4zG0HUwnOIzT7RG7jk4caMLAedEytwm8fCf8p9EV Vnii6HtuTTfGjZe5NJyXHksXd6K8eenfaf/Tz0VWD8A28qm1GuJpDnS+40Rdl3PP7anX u/WHpSFuBz3qTF0ucBWG5SyX0KoiEpwHxi4o0ZYSunRiS5QmwCjUill3msrzrujSK7az gLYA== X-Gm-Message-State: AOAM531UZOt238EJ56QvDmPPDBtVa7+S5UsU6MujEJBmTQxZfQ3ek1Ew JGkX1QLHhSyAcahtcAKVh4z2tQ0ow+mFS1TGyGQ= X-Google-Smtp-Source: ABdhPJxqwvD5NzKUsaokv4n4oD8Uxf1FQmBrb++b2A1mClgdQG0AwdkWuKSKXDyX0LdCNwThLofQKm8bAl6EQiccVYw= X-Received: by 2002:aca:ab4c:0:b0:2d4:7c7d:606e with SMTP id u73-20020acaab4c000000b002d47c7d606emr2408438oie.132.1645548338864; Tue, 22 Feb 2022 08:45:38 -0800 (PST) MIME-Version: 1.0 References: <20220222131701.356117-1-maira.canal@usp.br> <20220222131701.356117-11-maira.canal@usp.br> In-Reply-To: <20220222131701.356117-11-maira.canal@usp.br> From: Alex Deucher Date: Tue, 22 Feb 2022 11:45:27 -0500 Message-ID: Subject: Re: [PATCH 10/10] drm/amd/display: Turn global functions into static functions To: =?UTF-8?B?TWHDrXJhIENhbmFs?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Tuikov, Luben" , Tao Zhou , Anthony Koo , "Joshi, Mukul" , "Leo \(Sunpeng\) Li" , "Wentland, Harry" , xinhui pan , "Siqueira, Rodrigo" , LKML , Maling list - DRI developers , mwen@igalia.com, "Chai, Thomas" , "Stanley.Yang" , amd-gfx list , Magali Lemes , "Deucher, Alexander" , Isabella Basso , John Clements , Christian Koenig , Dennis Li , Hawking Zhang Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" On Tue, Feb 22, 2022 at 8:18 AM Ma=C3=ADra Canal wrote= : > > Turn previously global functions into static functions to avoid > -Wmissing-prototype warnings, such as: > > drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50= :20: > warning: no previous prototype for function 'to_dal_irq_source_dcn30' > [-Wmissing-prototypes] > enum dc_irq_source to_dal_irq_source_dcn30( > ^ > drivers/gpu/drm/amd/amdgpu/../display/dc/irq/dcn30/irq_service_dcn30.c:50= :1: > note: declare 'static' if the function is not intended to be used outside > of this translation unit > enum dc_irq_source to_dal_irq_source_dcn30( > ^ > static > 1 warning generated. > > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:= 488:6: > warning: no previous prototype for function > 'dcn316_clk_mgr_helper_populate_bw_params' [-Wmissing-prototypes] > void dcn316_clk_mgr_helper_populate_bw_params( > ^ > drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c:= 488:1: > note: declare 'static' if the function is not intended to be used outside > of this translation unit > void dcn316_clk_mgr_helper_populate_bw_params( > ^ > static > 1 warning generated. > > Signed-off-by: Ma=C3=ADra Canal > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > .../drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.c | 3 ++- > .../gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c | 2 +- > drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c | 2 +- > drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- > drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c | 2 +- > drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c | 2 +- > 8 files changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/= gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index c9ca328d34e3..a99b92526b55 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -6362,7 +6362,7 @@ static bool is_freesync_video_mode(const struct drm= _display_mode *mode, > return true; > } > > -struct dc_stream_state * > +static struct dc_stream_state * > create_stream_for_sink(struct amdgpu_dm_connector *aconnector, > const struct drm_display_mode *drm_mode, > const struct dm_connector_state *dm_state, > @@ -10189,7 +10189,7 @@ static void set_freesync_fixed_config(struct dm_c= rtc_state *dm_new_crtc_state) { > dm_new_crtc_state->freesync_config.fixed_refresh_in_uhz =3D res; > } > > -int dm_update_crtc_state(struct amdgpu_display_manager *dm, > +static int dm_update_crtc_state(struct amdgpu_display_manager *dm, > struct drm_atomic_state *state, > struct drm_crtc *crtc, > struct drm_crtc_state *old_crtc_state, > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c = b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > index 389b0cb37995..05573f073b21 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > @@ -213,7 +213,7 @@ static bool validate_dsc_caps_on_connector(struct amd= gpu_dm_connector *aconnecto > return true; > } > > -bool retrieve_downstream_port_device(struct amdgpu_dm_connector *aconnec= tor) > +static bool retrieve_downstream_port_device(struct amdgpu_dm_connector *= aconnector) > { > union dp_downstream_port_present ds_port_present; > > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbi= os_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_s= mu.c > index 06bab24d8e27..450eaead4f20 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.= c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn10/rv1_clk_mgr_vbios_smu.= c > @@ -101,7 +101,8 @@ static uint32_t rv1_smu_wait_for_response(struct clk_= mgr_internal *clk_mgr, unsi > return res_val; > } > > -int rv1_vbios_smu_send_msg_with_param(struct clk_mgr_internal *clk_mgr, = unsigned int msg_id, unsigned int param) > +static int rv1_vbios_smu_send_msg_with_param(struct clk_mgr_internal *cl= k_mgr, > + unsigned int msg_id, unsigned int param) > { > uint32_t result; > > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr= .c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c > index ffd3d5cb9871..02a59adff90d 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_clk_mgr.c > @@ -485,7 +485,7 @@ static unsigned int find_clk_for_voltage( > return clock; > } > > -void dcn316_clk_mgr_helper_populate_bw_params( > +static void dcn316_clk_mgr_helper_populate_bw_params( > struct clk_mgr_internal *clk_mgr, > struct integrated_info *bios_info, > const DpmClocks_316_t *clock_table) > diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c b= /drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > index fd6497fd2dc5..128614dff108 100644 > --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn316/dcn316_smu.c > @@ -111,7 +111,7 @@ static uint32_t dcn316_smu_wait_for_response(struct c= lk_mgr_internal *clk_mgr, u > return res_val; > } > > -int dcn316_smu_send_msg_with_param( > +static int dcn316_smu_send_msg_with_param( > struct clk_mgr_internal *clk_mgr, > unsigned int msg_id, unsigned int param) > { > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/= gpu/drm/amd/display/dc/core/dc_resource.c > index 19b56f9acf84..29ab67f42d92 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c > @@ -1622,7 +1622,7 @@ bool dc_add_all_planes_for_stream( > return add_all_planes_for_stream(dc, stream, &set, 1, context); > } > > -bool is_timing_changed(struct dc_stream_state *cur_stream, > +static bool is_timing_changed(struct dc_stream_state *cur_stream, > struct dc_stream_state *new_stream) > { > if (cur_stream =3D=3D NULL) This function is actually used elsewhere. I've dropped this hunk, but applied the rest. Thanks! Alex > diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c= b/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c > index c4b067d01895..93c31111500b 100644 > --- a/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c > +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn20/irq_service_dcn20.c > @@ -40,7 +40,7 @@ > > #include "ivsrcid/dcn/irqsrcs_dcn_1_0.h" > > -enum dc_irq_source to_dal_irq_source_dcn20( > +static enum dc_irq_source to_dal_irq_source_dcn20( > struct irq_service *irq_service, > uint32_t src_id, > uint32_t ext_id) > diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c= b/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c > index 0b68c08fac3f..ac0c6a62d17b 100644 > --- a/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c > +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c > @@ -47,7 +47,7 @@ > > #include "ivsrcid/dcn/irqsrcs_dcn_1_0.h" > > -enum dc_irq_source to_dal_irq_source_dcn30( > +static enum dc_irq_source to_dal_irq_source_dcn30( > struct irq_service *irq_service, > uint32_t src_id, > uint32_t ext_id) > -- > 2.35.1 >