From: Alex Deucher <alexdeucher@gmail.com>
To: Mark Yacoub <markyacoub@chromium.org>
Cc: "Christian König" <ckoenig.leichtzumerken@gmail.com>,
"Michel Dänzer" <michel@daenzer.net>,
"amd-gfx list" <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB
Date: Wed, 2 Jun 2021 12:21:29 -0400 [thread overview]
Message-ID: <CADnq5_MoB7F0u719DR7Ho_wmXM6FmxA5yRwYchES_rMQOg7TYQ@mail.gmail.com> (raw)
In-Reply-To: <CAJUqKUq8oshLvTaLfz6mR4qYY_B7RedXCqqOu56nG7rB6vYBRw@mail.gmail.com>
Applied. Thanks!
Alex
On Wed, Jun 2, 2021 at 10:56 AM Mark Yacoub <markyacoub@chromium.org> wrote:
>
> lgtm. Thanks!
>
> > On Wed, Jun 2, 2021 at 5:56 AM Christian König <ckoenig.leichtzumerken@gmail.com> wrote:
> >>
> >>
> >>
> >> Am 02.06.21 um 11:53 schrieb Michel Dänzer:
> >> > From: Michel Dänzer <mdaenzer@redhat.com>
> >> >
> >> > drm_err meant broken user space could spam dmesg.
> >> >
> >> > Fixes: f258907fdd835e "drm/amdgpu: Verify bo size can fit framebuffer
> >> > size on init."
> >> > Signed-off-by: Michel Dänzer <mdaenzer@redhat.com>
> >>
> >> Reviewed-by: Christian König <christian.koenig@amd.com>
> >>
> >> > ---
> >> > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ++--
> >> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >> >
> >> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> >> > index 8170e24ce37d..2a4cd7d377bf 100644
> >> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> >> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> >> > @@ -1058,7 +1058,7 @@ int amdgpu_display_gem_fb_init(struct drm_device *dev,
> >> >
> >> > return 0;
> >> > err:
> >> > - drm_err(dev, "Failed to init gem fb: %d\n", ret);
> >> > + drm_dbg_kms(dev, "Failed to init gem fb: %d\n", ret);
> >> > rfb->base.obj[0] = NULL;
> >> > return ret;
> >> > }
> >> > @@ -1096,7 +1096,7 @@ int amdgpu_display_gem_fb_verify_and_init(
> >> >
> >> > return 0;
> >> > err:
> >> > - drm_err(dev, "Failed to verify and init gem fb: %d\n", ret);
> >> > + drm_dbg_kms(dev, "Failed to verify and init gem fb: %d\n", ret);
> >> > rfb->base.obj[0] = NULL;
> >> > return ret;
> >> > }
> >>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-06-02 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-02 9:53 [PATCH] drm/amdgpu: Use drm_dbg_kms for reporting failure to get a GEM FB Michel Dänzer
2021-06-02 9:56 ` Christian König
2021-06-02 14:44 ` Mark Yacoub
2021-06-02 14:45 ` Mark Yacoub
2021-06-02 16:21 ` Alex Deucher [this message]
2021-06-03 7:48 ` Michel Dänzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_MoB7F0u719DR7Ho_wmXM6FmxA5yRwYchES_rMQOg7TYQ@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=markyacoub@chromium.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.