From: Alex Deucher <alexdeucher@gmail.com>
To: "Ji, Ruili" <ruili.ji@amd.com>
Cc: Alex Sierra <alex.sierra@amd.com>,
"Kuehling, Felix" <felix.kuehling@amd.com>,
Ruili Ji <ruiliji2@amd.com>, Aaron Liu <aaron.liu@amd.com>,
amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdkfd: To flush tlb for MMHUB of GFX9 series
Date: Tue, 21 Jun 2022 10:33:42 -0400 [thread overview]
Message-ID: <CADnq5_MqPmkR5z2xPTU7bTBfvLKm_XbZWHQQ6PPYx2wi4ZB3QA@mail.gmail.com> (raw)
In-Reply-To: <20220621022550.492588-1-ruili.ji@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
On Mon, Jun 20, 2022 at 10:26 PM Ji, Ruili <ruili.ji@amd.com> wrote:
>
> From: Ruili Ji <ruiliji2@amd.com>
>
> amdgpu: [mmhub0] no-retry page fault (src_id:0 ring:40 vmid:8 pasid:32769, for process test_basic pid 3305 thread test_basic pid 3305)
> amdgpu: in page starting at address 0x00007ff990003000 from IH client 0x12 (VMC)
> amdgpu: VM_L2_PROTECTION_FAULT_STATUS:0x00840051
> amdgpu: Faulty UTCL2 client ID: MP1 (0x0)
> amdgpu: MORE_FAULTS: 0x1
> amdgpu: WALKER_ERROR: 0x0
> amdgpu: PERMISSION_FAULTS: 0x5
> amdgpu: MAPPING_ERROR: 0x0
> amdgpu: RW: 0x1
>
> When memory is allocated by kfd, no one triggers the tlb flush for MMHUB0.
> There is page fault from MMHUB0.
>
> Signed-off-by: Ruili Ji <ruiliji2@amd.com>
> Change-Id: I97786f02849dd047703d6e8feff53916b307715c
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> index 1d0c9762ebfb..12fc822c0a92 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
> @@ -739,7 +739,8 @@ int amdgpu_amdkfd_flush_gpu_tlb_pasid(struct amdgpu_device *adev,
> {
> bool all_hub = false;
>
> - if (adev->family == AMDGPU_FAMILY_AI)
> + if (adev->family == AMDGPU_FAMILY_AI
> + || adev->family == AMDGPU_FAMILY_RV)
> all_hub = true;
>
> return amdgpu_gmc_flush_gpu_tlb_pasid(adev, pasid, flush_type, all_hub);
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-06-21 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-21 2:25 [PATCH] drm/amdkfd: To flush tlb for MMHUB of GFX9 series Ji, Ruili
2022-06-21 14:33 ` Alex Deucher [this message]
2022-06-21 16:50 ` philip yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_MqPmkR5z2xPTU7bTBfvLKm_XbZWHQQ6PPYx2wi4ZB3QA@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=aaron.liu@amd.com \
--cc=alex.sierra@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=felix.kuehling@amd.com \
--cc=ruili.ji@amd.com \
--cc=ruiliji2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.