From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A142C433FE for ; Tue, 15 Mar 2022 15:57:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CF6910E543; Tue, 15 Mar 2022 15:57:51 +0000 (UTC) Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5559588F0A; Tue, 15 Mar 2022 15:57:49 +0000 (UTC) Received: by mail-oi1-x234.google.com with SMTP id b188so21230033oia.13; Tue, 15 Mar 2022 08:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=jWnJoZKYShfYZipEE6ZCups7oAda7ot4SH+dHzTQHvg=; b=fWZD7fYBKrcCLLP36Nsix3PjhWakA2JV8NQtlNg4YC5dHtEVTEgCNhRv9ea6+TfccJ YdBc28ZgNOawCJhwAf+JMUmVLxx9UzQUWduiLBqCxddul/AlsE/jrVVlzEWqBt/Vhj+W y5X0OlnmJxwZ2cf7KIimGb1FjZiSc2JiV+7LNM16p2ounNFovSMPObuRi0A/xfQytnhm VkvUgJMiJZvsM9vMv8K6S50gVe7EXkordHNPIMvGCkALaNljmzOQaTdkbTiuB1us6Ezh ioRra7dygf4u8Mi2UXKUX3GmzFyhA78I/6ndcoJMwRyhbGKYCqBE0nBr22MP03u2+CTZ kHzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jWnJoZKYShfYZipEE6ZCups7oAda7ot4SH+dHzTQHvg=; b=bM6nmR2Qpe4mqQNmCj9zuaBO3maF/WW5y+mWUxn0WEkG5oNlv/PZmT3wOFtWB00kW/ 6EFiAzSLMcnW5aXIkBK+G1gQm1QGzLzgOT68s55qTmwrbC/20rvLrTp6ebXwIOCgHd/M +/KTr4YJ3OHDyU7p7TrkVzmm8K+HqxQbFHzzwTjklqYfOwjWEvrpyCsULgB7wBwVKWtc CFtXZnOYqtHPz3TfsTI8DJ+wRjFWEt6e6GqoeQDrsXHU/p74s4pAYp5YKsT1Km9Ozg0H DdKVaUkQs6gDlzlAjnSIBXmGSDmnUJb/9xIJFEvC8TwZtpgEtRW7E+Llx4Y9Ntx9hg1/ zkGA== X-Gm-Message-State: AOAM5331W/l5rQF0CSr4tT3biXlHo4sWnj8iA6lL4+R84U4kxt0b+g6T gTHH1xnHI0QCEAi/xovQxqtwCWlopz5rakLuXNU= X-Google-Smtp-Source: ABdhPJzRWyNdb48ClfOoM3rFiYP5LZ+gMeALH0ALX+N/qMsoETxcqvdDM36JHPdV/k5IHMOIZBkaVcnXhWMecct2ek8= X-Received: by 2002:a05:6808:df1:b0:2ec:b193:ad6c with SMTP id g49-20020a0568080df100b002ecb193ad6cmr1864355oic.200.1647359868626; Tue, 15 Mar 2022 08:57:48 -0700 (PDT) MIME-Version: 1.0 References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> <20220218100403.7028-3-ville.syrjala@linux.intel.com> <2d51f77d-4067-ca23-3005-87cd72e1a397@amd.com> In-Reply-To: <2d51f77d-4067-ca23-3005-87cd72e1a397@amd.com> From: Alex Deucher Date: Tue, 15 Mar 2022 11:57:37 -0400 Message-ID: Subject: Re: [PATCH 02/22] drm/amdgpu: Remove pointless on stack mode copies To: Harry Wentland Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Intel Graphics Development , Rodrigo Siqueira , amd-gfx list , Nikola Cornij , Aurabindo Pillai , Maling list - DRI developers , Alex Deucher Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Applied. Thanks! Alex On Fri, Feb 18, 2022 at 11:28 AM Harry Wentland wr= ote: > > > > On 2022-02-18 05:03, Ville Syrjala wrote: > > From: Ville Syrj=C3=A4l=C3=A4 > > > > These on stack copies of the modes appear to be pointless. > > Just look at the originals directly. > > > > Cc: Harry Wentland > > Cc: Leo Li > > Cc: Rodrigo Siqueira > > Cc: Alex Deucher > > Cc: amd-gfx@lists.freedesktop.org > > Cc: Nikola Cornij > > Cc: Aurabindo Pillai > > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 > > Reviewed-by: Harry Wentland > > Harry > > > --- > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 32 +++++++++---------- > > 1 file changed, 16 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/driver= s/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > index 21dba337dab0..65aab0d086b6 100644 > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > @@ -10139,27 +10139,27 @@ static bool > > is_timing_unchanged_for_freesync(struct drm_crtc_state *old_crtc_state= , > > struct drm_crtc_state *new_crtc_state) > > { > > - struct drm_display_mode old_mode, new_mode; > > + const struct drm_display_mode *old_mode, *new_mode; > > > > if (!old_crtc_state || !new_crtc_state) > > return false; > > > > - old_mode =3D old_crtc_state->mode; > > - new_mode =3D new_crtc_state->mode; > > + old_mode =3D &old_crtc_state->mode; > > + new_mode =3D &new_crtc_state->mode; > > > > - if (old_mode.clock =3D=3D new_mode.clock && > > - old_mode.hdisplay =3D=3D new_mode.hdisplay && > > - old_mode.vdisplay =3D=3D new_mode.vdisplay && > > - old_mode.htotal =3D=3D new_mode.htotal && > > - old_mode.vtotal !=3D new_mode.vtotal && > > - old_mode.hsync_start =3D=3D new_mode.hsync_start && > > - old_mode.vsync_start !=3D new_mode.vsync_start && > > - old_mode.hsync_end =3D=3D new_mode.hsync_end && > > - old_mode.vsync_end !=3D new_mode.vsync_end && > > - old_mode.hskew =3D=3D new_mode.hskew && > > - old_mode.vscan =3D=3D new_mode.vscan && > > - (old_mode.vsync_end - old_mode.vsync_start) =3D=3D > > - (new_mode.vsync_end - new_mode.vsync_start)) > > + if (old_mode->clock =3D=3D new_mode->clock && > > + old_mode->hdisplay =3D=3D new_mode->hdisplay && > > + old_mode->vdisplay =3D=3D new_mode->vdisplay && > > + old_mode->htotal =3D=3D new_mode->htotal && > > + old_mode->vtotal !=3D new_mode->vtotal && > > + old_mode->hsync_start =3D=3D new_mode->hsync_start && > > + old_mode->vsync_start !=3D new_mode->vsync_start && > > + old_mode->hsync_end =3D=3D new_mode->hsync_end && > > + old_mode->vsync_end !=3D new_mode->vsync_end && > > + old_mode->hskew =3D=3D new_mode->hskew && > > + old_mode->vscan =3D=3D new_mode->vscan && > > + (old_mode->vsync_end - old_mode->vsync_start) =3D=3D > > + (new_mode->vsync_end - new_mode->vsync_start)) > > return true; > > > > return false; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 852ABC433EF for ; Tue, 15 Mar 2022 15:57:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1378B10E52E; Tue, 15 Mar 2022 15:57:51 +0000 (UTC) Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5559588F0A; Tue, 15 Mar 2022 15:57:49 +0000 (UTC) Received: by mail-oi1-x234.google.com with SMTP id b188so21230033oia.13; Tue, 15 Mar 2022 08:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=jWnJoZKYShfYZipEE6ZCups7oAda7ot4SH+dHzTQHvg=; b=fWZD7fYBKrcCLLP36Nsix3PjhWakA2JV8NQtlNg4YC5dHtEVTEgCNhRv9ea6+TfccJ YdBc28ZgNOawCJhwAf+JMUmVLxx9UzQUWduiLBqCxddul/AlsE/jrVVlzEWqBt/Vhj+W y5X0OlnmJxwZ2cf7KIimGb1FjZiSc2JiV+7LNM16p2ounNFovSMPObuRi0A/xfQytnhm VkvUgJMiJZvsM9vMv8K6S50gVe7EXkordHNPIMvGCkALaNljmzOQaTdkbTiuB1us6Ezh ioRra7dygf4u8Mi2UXKUX3GmzFyhA78I/6ndcoJMwRyhbGKYCqBE0nBr22MP03u2+CTZ kHzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jWnJoZKYShfYZipEE6ZCups7oAda7ot4SH+dHzTQHvg=; b=bM6nmR2Qpe4mqQNmCj9zuaBO3maF/WW5y+mWUxn0WEkG5oNlv/PZmT3wOFtWB00kW/ 6EFiAzSLMcnW5aXIkBK+G1gQm1QGzLzgOT68s55qTmwrbC/20rvLrTp6ebXwIOCgHd/M +/KTr4YJ3OHDyU7p7TrkVzmm8K+HqxQbFHzzwTjklqYfOwjWEvrpyCsULgB7wBwVKWtc CFtXZnOYqtHPz3TfsTI8DJ+wRjFWEt6e6GqoeQDrsXHU/p74s4pAYp5YKsT1Km9Ozg0H DdKVaUkQs6gDlzlAjnSIBXmGSDmnUJb/9xIJFEvC8TwZtpgEtRW7E+Llx4Y9Ntx9hg1/ zkGA== X-Gm-Message-State: AOAM5331W/l5rQF0CSr4tT3biXlHo4sWnj8iA6lL4+R84U4kxt0b+g6T gTHH1xnHI0QCEAi/xovQxqtwCWlopz5rakLuXNU= X-Google-Smtp-Source: ABdhPJzRWyNdb48ClfOoM3rFiYP5LZ+gMeALH0ALX+N/qMsoETxcqvdDM36JHPdV/k5IHMOIZBkaVcnXhWMecct2ek8= X-Received: by 2002:a05:6808:df1:b0:2ec:b193:ad6c with SMTP id g49-20020a0568080df100b002ecb193ad6cmr1864355oic.200.1647359868626; Tue, 15 Mar 2022 08:57:48 -0700 (PDT) MIME-Version: 1.0 References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> <20220218100403.7028-3-ville.syrjala@linux.intel.com> <2d51f77d-4067-ca23-3005-87cd72e1a397@amd.com> In-Reply-To: <2d51f77d-4067-ca23-3005-87cd72e1a397@amd.com> From: Alex Deucher Date: Tue, 15 Mar 2022 11:57:37 -0400 Message-ID: To: Harry Wentland Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [Intel-gfx] [PATCH 02/22] drm/amdgpu: Remove pointless on stack mode copies X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Intel Graphics Development , Rodrigo Siqueira , amd-gfx list , Nikola Cornij , Aurabindo Pillai , Maling list - DRI developers , Alex Deucher Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Applied. Thanks! Alex On Fri, Feb 18, 2022 at 11:28 AM Harry Wentland wr= ote: > > > > On 2022-02-18 05:03, Ville Syrjala wrote: > > From: Ville Syrj=C3=A4l=C3=A4 > > > > These on stack copies of the modes appear to be pointless. > > Just look at the originals directly. > > > > Cc: Harry Wentland > > Cc: Leo Li > > Cc: Rodrigo Siqueira > > Cc: Alex Deucher > > Cc: amd-gfx@lists.freedesktop.org > > Cc: Nikola Cornij > > Cc: Aurabindo Pillai > > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 > > Reviewed-by: Harry Wentland > > Harry > > > --- > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 32 +++++++++---------- > > 1 file changed, 16 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/driver= s/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > index 21dba337dab0..65aab0d086b6 100644 > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > @@ -10139,27 +10139,27 @@ static bool > > is_timing_unchanged_for_freesync(struct drm_crtc_state *old_crtc_state= , > > struct drm_crtc_state *new_crtc_state) > > { > > - struct drm_display_mode old_mode, new_mode; > > + const struct drm_display_mode *old_mode, *new_mode; > > > > if (!old_crtc_state || !new_crtc_state) > > return false; > > > > - old_mode =3D old_crtc_state->mode; > > - new_mode =3D new_crtc_state->mode; > > + old_mode =3D &old_crtc_state->mode; > > + new_mode =3D &new_crtc_state->mode; > > > > - if (old_mode.clock =3D=3D new_mode.clock && > > - old_mode.hdisplay =3D=3D new_mode.hdisplay && > > - old_mode.vdisplay =3D=3D new_mode.vdisplay && > > - old_mode.htotal =3D=3D new_mode.htotal && > > - old_mode.vtotal !=3D new_mode.vtotal && > > - old_mode.hsync_start =3D=3D new_mode.hsync_start && > > - old_mode.vsync_start !=3D new_mode.vsync_start && > > - old_mode.hsync_end =3D=3D new_mode.hsync_end && > > - old_mode.vsync_end !=3D new_mode.vsync_end && > > - old_mode.hskew =3D=3D new_mode.hskew && > > - old_mode.vscan =3D=3D new_mode.vscan && > > - (old_mode.vsync_end - old_mode.vsync_start) =3D=3D > > - (new_mode.vsync_end - new_mode.vsync_start)) > > + if (old_mode->clock =3D=3D new_mode->clock && > > + old_mode->hdisplay =3D=3D new_mode->hdisplay && > > + old_mode->vdisplay =3D=3D new_mode->vdisplay && > > + old_mode->htotal =3D=3D new_mode->htotal && > > + old_mode->vtotal !=3D new_mode->vtotal && > > + old_mode->hsync_start =3D=3D new_mode->hsync_start && > > + old_mode->vsync_start !=3D new_mode->vsync_start && > > + old_mode->hsync_end =3D=3D new_mode->hsync_end && > > + old_mode->vsync_end !=3D new_mode->vsync_end && > > + old_mode->hskew =3D=3D new_mode->hskew && > > + old_mode->vscan =3D=3D new_mode->vscan && > > + (old_mode->vsync_end - old_mode->vsync_start) =3D=3D > > + (new_mode->vsync_end - new_mode->vsync_start)) > > return true; > > > > return false; > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A50DC433F5 for ; Tue, 15 Mar 2022 15:57:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E3D988F0A; Tue, 15 Mar 2022 15:57:50 +0000 (UTC) Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5559588F0A; Tue, 15 Mar 2022 15:57:49 +0000 (UTC) Received: by mail-oi1-x234.google.com with SMTP id b188so21230033oia.13; Tue, 15 Mar 2022 08:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=jWnJoZKYShfYZipEE6ZCups7oAda7ot4SH+dHzTQHvg=; b=fWZD7fYBKrcCLLP36Nsix3PjhWakA2JV8NQtlNg4YC5dHtEVTEgCNhRv9ea6+TfccJ YdBc28ZgNOawCJhwAf+JMUmVLxx9UzQUWduiLBqCxddul/AlsE/jrVVlzEWqBt/Vhj+W y5X0OlnmJxwZ2cf7KIimGb1FjZiSc2JiV+7LNM16p2ounNFovSMPObuRi0A/xfQytnhm VkvUgJMiJZvsM9vMv8K6S50gVe7EXkordHNPIMvGCkALaNljmzOQaTdkbTiuB1us6Ezh ioRra7dygf4u8Mi2UXKUX3GmzFyhA78I/6ndcoJMwRyhbGKYCqBE0nBr22MP03u2+CTZ kHzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jWnJoZKYShfYZipEE6ZCups7oAda7ot4SH+dHzTQHvg=; b=bM6nmR2Qpe4mqQNmCj9zuaBO3maF/WW5y+mWUxn0WEkG5oNlv/PZmT3wOFtWB00kW/ 6EFiAzSLMcnW5aXIkBK+G1gQm1QGzLzgOT68s55qTmwrbC/20rvLrTp6ebXwIOCgHd/M +/KTr4YJ3OHDyU7p7TrkVzmm8K+HqxQbFHzzwTjklqYfOwjWEvrpyCsULgB7wBwVKWtc CFtXZnOYqtHPz3TfsTI8DJ+wRjFWEt6e6GqoeQDrsXHU/p74s4pAYp5YKsT1Km9Ozg0H DdKVaUkQs6gDlzlAjnSIBXmGSDmnUJb/9xIJFEvC8TwZtpgEtRW7E+Llx4Y9Ntx9hg1/ zkGA== X-Gm-Message-State: AOAM5331W/l5rQF0CSr4tT3biXlHo4sWnj8iA6lL4+R84U4kxt0b+g6T gTHH1xnHI0QCEAi/xovQxqtwCWlopz5rakLuXNU= X-Google-Smtp-Source: ABdhPJzRWyNdb48ClfOoM3rFiYP5LZ+gMeALH0ALX+N/qMsoETxcqvdDM36JHPdV/k5IHMOIZBkaVcnXhWMecct2ek8= X-Received: by 2002:a05:6808:df1:b0:2ec:b193:ad6c with SMTP id g49-20020a0568080df100b002ecb193ad6cmr1864355oic.200.1647359868626; Tue, 15 Mar 2022 08:57:48 -0700 (PDT) MIME-Version: 1.0 References: <20220218100403.7028-1-ville.syrjala@linux.intel.com> <20220218100403.7028-3-ville.syrjala@linux.intel.com> <2d51f77d-4067-ca23-3005-87cd72e1a397@amd.com> In-Reply-To: <2d51f77d-4067-ca23-3005-87cd72e1a397@amd.com> From: Alex Deucher Date: Tue, 15 Mar 2022 11:57:37 -0400 Message-ID: Subject: Re: [PATCH 02/22] drm/amdgpu: Remove pointless on stack mode copies To: Harry Wentland Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Leo Li , Intel Graphics Development , Rodrigo Siqueira , amd-gfx list , Nikola Cornij , Aurabindo Pillai , Maling list - DRI developers , Alex Deucher , Ville Syrjala Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Applied. Thanks! Alex On Fri, Feb 18, 2022 at 11:28 AM Harry Wentland wr= ote: > > > > On 2022-02-18 05:03, Ville Syrjala wrote: > > From: Ville Syrj=C3=A4l=C3=A4 > > > > These on stack copies of the modes appear to be pointless. > > Just look at the originals directly. > > > > Cc: Harry Wentland > > Cc: Leo Li > > Cc: Rodrigo Siqueira > > Cc: Alex Deucher > > Cc: amd-gfx@lists.freedesktop.org > > Cc: Nikola Cornij > > Cc: Aurabindo Pillai > > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 > > Reviewed-by: Harry Wentland > > Harry > > > --- > > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 32 +++++++++---------- > > 1 file changed, 16 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/driver= s/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > index 21dba337dab0..65aab0d086b6 100644 > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > > @@ -10139,27 +10139,27 @@ static bool > > is_timing_unchanged_for_freesync(struct drm_crtc_state *old_crtc_state= , > > struct drm_crtc_state *new_crtc_state) > > { > > - struct drm_display_mode old_mode, new_mode; > > + const struct drm_display_mode *old_mode, *new_mode; > > > > if (!old_crtc_state || !new_crtc_state) > > return false; > > > > - old_mode =3D old_crtc_state->mode; > > - new_mode =3D new_crtc_state->mode; > > + old_mode =3D &old_crtc_state->mode; > > + new_mode =3D &new_crtc_state->mode; > > > > - if (old_mode.clock =3D=3D new_mode.clock && > > - old_mode.hdisplay =3D=3D new_mode.hdisplay && > > - old_mode.vdisplay =3D=3D new_mode.vdisplay && > > - old_mode.htotal =3D=3D new_mode.htotal && > > - old_mode.vtotal !=3D new_mode.vtotal && > > - old_mode.hsync_start =3D=3D new_mode.hsync_start && > > - old_mode.vsync_start !=3D new_mode.vsync_start && > > - old_mode.hsync_end =3D=3D new_mode.hsync_end && > > - old_mode.vsync_end !=3D new_mode.vsync_end && > > - old_mode.hskew =3D=3D new_mode.hskew && > > - old_mode.vscan =3D=3D new_mode.vscan && > > - (old_mode.vsync_end - old_mode.vsync_start) =3D=3D > > - (new_mode.vsync_end - new_mode.vsync_start)) > > + if (old_mode->clock =3D=3D new_mode->clock && > > + old_mode->hdisplay =3D=3D new_mode->hdisplay && > > + old_mode->vdisplay =3D=3D new_mode->vdisplay && > > + old_mode->htotal =3D=3D new_mode->htotal && > > + old_mode->vtotal !=3D new_mode->vtotal && > > + old_mode->hsync_start =3D=3D new_mode->hsync_start && > > + old_mode->vsync_start !=3D new_mode->vsync_start && > > + old_mode->hsync_end =3D=3D new_mode->hsync_end && > > + old_mode->vsync_end !=3D new_mode->vsync_end && > > + old_mode->hskew =3D=3D new_mode->hskew && > > + old_mode->vscan =3D=3D new_mode->vscan && > > + (old_mode->vsync_end - old_mode->vsync_start) =3D=3D > > + (new_mode->vsync_end - new_mode->vsync_start)) > > return true; > > > > return false; >