Re: [PATCH] drm/amdgpu: Remove pci address checks from acpi_vfct_bios

[Alex Deucher <alexdeucher@gmail.com>]

On Mon, Mar 18, 2024 at 4:47 AM Kurt Kartaltepe <kkartaltepe@gmail.com> wrote:
>
> These checks prevent using amdgpu with the pcie=assign-busses parameter
> which will re-address devices from their acpi values.
>
> Signed-off-by: Kurt Kartaltepe <kkartaltepe@gmail.com>

This will likely break multi-GPU functionality.  The BDF values are
how the sbios/driver differentiates between the VFCT images.  If you
have multiple GPUs in the system, the driver won't be able to figure
out which one goes with which GPU an you may end up assigning the
wrong image to the wrong device.

Alex


> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> index 618e469e3622..932ce13ad232 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> @@ -386,9 +386,6 @@ static bool amdgpu_acpi_vfct_bios(struct amdgpu_device *adev)
>                 }
>
>                 if (vhdr->ImageLength &&
> -                   vhdr->PCIBus == adev->pdev->bus->number &&
> -                   vhdr->PCIDevice == PCI_SLOT(adev->pdev->devfn) &&
> -                   vhdr->PCIFunction == PCI_FUNC(adev->pdev->devfn) &&
>                     vhdr->VendorID == adev->pdev->vendor &&
>                     vhdr->DeviceID == adev->pdev->device) {
>                         adev->bios = kmemdup(&vbios->VbiosContent,
> --
> 2.44.0
>