From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH 1/8] drm/amd/pp: Refine code for smu7 in powerplay Date: Fri, 9 Mar 2018 12:06:51 -0500 Message-ID: References: <1520419570-28831-1-git-send-email-Rex.Zhu@amd.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0484989343==" Return-path: In-Reply-To: List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Zhu, Rex" Cc: amd-gfx list --===============0484989343== Content-Type: multipart/alternative; boundary="001a1143bb868dd7bb0566fdd17d" --001a1143bb868dd7bb0566fdd17d Content-Type: text/plain; charset="UTF-8" Nice cleanup. Patch is: Reviewed-by: Alex Deucher On Fri, Mar 9, 2018 at 5:55 AM, Zhu, Rex wrote: > Hi Alex, > > > The avfs btc state is only used in driver and not interact with HW. > > and we only need to know whether this feature is supported or not by HW. > > so delete the complex define of avfs btc state and simplify related code. > > Please review the attached patch. > > > Best Regards > > Rex > > ------------------------------ > *From:* Alex Deucher > *Sent:* Thursday, March 8, 2018 1:12 AM > *To:* Zhu, Rex > *Cc:* amd-gfx list > *Subject:* Re: [PATCH 1/8] drm/amd/pp: Refine code for smu7 in powerplay > > On Wed, Mar 7, 2018 at 5:46 AM, Rex Zhu wrote: > > 1. Add avfs_support in hwmgr to avoid to visit smu backend struct in > > hwmgr.so do not need to include smu7_smumgr.h under hwmgr folder. > > 2. simplify the list of enum AVFS_BTC_STATUS > > > > Change-Id: I04c769972deff797229339f3ccb1c442b35768a2 > > Signed-off-by: Rex Zhu > > --- > > drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 14 > ++------------ > > drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 2 +- > > drivers/gpu/drm/amd/powerplay/inc/smumgr.h | 10 +--------- > > drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c | 4 +++- > > drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 4 +++- > > 5 files changed, 10 insertions(+), 24 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c > b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c > > index d4d1d2e..da25e7f 100644 > > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c > > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c > > @@ -40,7 +40,6 @@ > > > > #include "hwmgr.h" > > #include "smu7_hwmgr.h" > > -#include "smu7_smumgr.h" > > #include "smu_ucode_xfer_vi.h" > > #include "smu7_powertune.h" > > #include "smu7_dyn_defaults.h" > > @@ -1353,12 +1352,7 @@ static int smu7_enable_dpm_tasks(struct pp_hwmgr > *hwmgr) > > > > static int smu7_avfs_control(struct pp_hwmgr *hwmgr, bool enable) > > { > > - struct smu7_smumgr *smu_data = (struct smu7_smumgr > *)(hwmgr->smu_backend); > > - > > - if (smu_data == NULL) > > - return -EINVAL; > > - > > - if (smu_data->avfs.avfs_btc_status == AVFS_BTC_NOTSUPPORTED) > > + if (!hwmgr->avfs_supported) > > return 0; > > > > if (enable) { > > @@ -1382,13 +1376,9 @@ static int smu7_avfs_control(struct pp_hwmgr > *hwmgr, bool enable) > > > > static int smu7_update_avfs(struct pp_hwmgr *hwmgr) > > { > > - struct smu7_smumgr *smu_data = (struct smu7_smumgr > *)(hwmgr->smu_backend); > > struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend); > > > > - if (smu_data == NULL) > > - return -EINVAL; > > - > > - if (smu_data->avfs.avfs_btc_status == AVFS_BTC_NOTSUPPORTED) > > + if (!hwmgr->avfs_supported) > > return 0; > > > > if (data->need_update_smu7_dpm_table & DPMTABLE_OD_UPDATE_VDDC) > { > > diff --git a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h > b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h > > index b151ad85..312fbc3 100644 > > --- a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h > > +++ b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h > > @@ -748,7 +748,7 @@ struct pp_hwmgr { > > struct pp_power_state *uvd_ps; > > struct amd_pp_display_configuration display_config; > > uint32_t feature_mask; > > - > > + bool avfs_supported; > > /* UMD Pstate */ > > bool en_umd_pstate; > > uint32_t power_profile_mode; > > diff --git a/drivers/gpu/drm/amd/powerplay/inc/smumgr.h > b/drivers/gpu/drm/amd/powerplay/inc/smumgr.h > > index 9bba0a0..f0ef02a 100644 > > --- a/drivers/gpu/drm/amd/powerplay/inc/smumgr.h > > +++ b/drivers/gpu/drm/amd/powerplay/inc/smumgr.h > > @@ -28,23 +28,15 @@ > > > > enum AVFS_BTC_STATUS { > > AVFS_BTC_BOOT = 0, > > - AVFS_BTC_BOOT_STARTEDSMU, > > AVFS_LOAD_VIRUS, > > AVFS_BTC_VIRUS_LOADED, > > AVFS_BTC_VIRUS_FAIL, > > AVFS_BTC_COMPLETED_PREVIOUSLY, > > AVFS_BTC_ENABLEAVFS, > > - AVFS_BTC_STARTED, > > AVFS_BTC_FAILED, > > - AVFS_BTC_RESTOREVFT_FAILED, > > - AVFS_BTC_SAVEVFT_FAILED, > > AVFS_BTC_DPMTABLESETUP_FAILED, > > - AVFS_BTC_COMPLETED_UNSAVED, > > - AVFS_BTC_COMPLETED_SAVED, > > - AVFS_BTC_COMPLETED_RESTORED, > > AVFS_BTC_DISABLED, > > - AVFS_BTC_NOTSUPPORTED, > > - AVFS_BTC_SMUMSG_ERROR > > + AVFS_BTC_NOTSUPPORTED > > }; > > This isn't used to interact with the hw anywhere is it? If so, this > will break that. It should probably be split out as a separate patch > since it's not really directly related to the rest of this patch. > With those addresses this patch is: > Reviewed-by: Alex Deucher > > > > > enum SMU_TABLE { > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c > b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c > > index 0b2b5d1..573c9be 100644 > > --- a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c > > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c > > @@ -360,8 +360,10 @@ static bool fiji_is_hw_avfs_present(struct pp_hwmgr > *hwmgr) > > > > if (!atomctrl_read_efuse(hwmgr->device, AVFS_EN_LSB, > AVFS_EN_MSB, > > mask, &efuse)) { > > - if (efuse) > > + if (efuse) { > > + hwmgr->avfs_supported = true; > > return true; > > + } > > } > > return false; > > } > > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c > b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c > > index 632d1ca..1075ec1 100644 > > --- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c > > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c > > @@ -357,8 +357,10 @@ static bool polaris10_is_hw_avfs_present(struct > pp_hwmgr *hwmgr) > > > > efuse = cgs_read_ind_register(hwmgr->device, CGS_IND_REG__SMC, > ixSMU_EFUSE_0 + (49*4)); > > efuse &= 0x00000001; > > - if (efuse) > > + if (efuse) { > > + hwmgr->avfs_supported = true; > > return true; > > + } > > > > return false; > > } > > -- > > 1.9.1 > > > > _______________________________________________ > > amd-gfx mailing list > > amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > amd-gfx Info Page - freedesktop.org > > lists.freedesktop.org > Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following > form. Use of all freedesktop.org lists is subject to our Code of ... > > --001a1143bb868dd7bb0566fdd17d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Nice cleanup.=C2=A0 Patch is:
Reviewed-by: A= lex Deucher <alexander.deuc= her-5C7GfCeVMHo@public.gmane.org>

On Fri, Mar 9, 2018 at 5:55 AM, Zhu, Rex <Rex.Zhu-5C7GfCeVMHo@public.gmane.org> wrote:

Hi Alex,


The avfs btc state is only used i= n driver and not interact with HW.

and we only need to know whether this feature = is supported or not by HW.

so delete the complex define of a= vfs btc state and simplify related code.

Please review the attached patch.=


Best Regards

Rex


From: = Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Sent: Thursday, March 8, 2018 1:12 AM
To: Zhu, Rex
Cc: amd-gfx list
Subject: Re: [PATCH 1/8] drm/amd/pp: Refine code for smu7 in powerpl= ay
=C2=A0
On Wed= , Mar 7, 2018 at 5:46 AM, Rex Zhu <Rex.Zhu-5C7GfCeVMHo@public.gmane.org> wrote:
> 1. Add avfs_support in hwmgr to avoid to visit smu backend struct in >=C2=A0=C2=A0=C2=A0 hwmgr.so do not need to include smu7_smumgr.h under = hwmgr folder.
> 2. simplify the list of enum AVFS_BTC_STATUS
>
> Change-Id: I04c769972deff797229339f3ccb1c442b35768a2
> Signed-off-by: Rex Zhu <Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
> ---
>=C2=A0 drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 14 ++------------
>=C2=A0 drivers/gpu/drm/amd/powerplay/inc/hwmgr.h=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 = 2 +-
>=C2=A0 drivers/gpu/drm/amd/powerplay/inc/smumgr.h=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 | 10 +-----= ----
>=C2=A0 drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 |=C2=A0 4 +++-
>=C2=A0 drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c |= =C2=A0 4 +++-
>=C2=A0 5 files changed, 10 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/d= rivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> index d4d1d2e..da25e7f 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c
> @@ -40,7 +40,6 @@
>
>=C2=A0 #include "hwmgr.h"
>=C2=A0 #include "smu7_hwmgr.h"
> -#include "smu7_smumgr.h"
>=C2=A0 #include "smu_ucode_xfer_vi.h"
>=C2=A0 #include "smu7_powertune.h"
>=C2=A0 #include "smu7_dyn_defaults.h"
> @@ -1353,12 +1352,7 @@ static int smu7_enable_dpm_tasks(struct pp_hwmg= r *hwmgr)
>
>=C2=A0 static int smu7_avfs_control(struct pp_hwmgr *hwmgr, bool enable= )
>=C2=A0 {
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct smu7_smumgr *smu_data =3D= (struct smu7_smumgr *)(hwmgr->smu_backend);
> -
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (smu_data =3D=3D NULL)
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 return -EINVAL;
> -
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (smu_data->avfs.avfs_btc_<= wbr>status =3D=3D AVFS_BTC_NOTSUPPORTED)
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!hwmgr->avfs_supported) >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 return 0;
>
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (enable) {
> @@ -1382,13 +1376,9 @@ static int smu7_avfs_control(struct pp_hwmgr *h= wmgr, bool enable)
>
>=C2=A0 static int smu7_update_avfs(struct pp_hwmgr *hwmgr)
>=C2=A0 {
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct smu7_smumgr *smu_data =3D= (struct smu7_smumgr *)(hwmgr->smu_backend);
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct smu7_hwmgr *dat= a =3D (struct smu7_hwmgr *)(hwmgr->backend);
>
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (smu_data =3D=3D NULL)
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 return -EINVAL;
> -
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (smu_data->avfs.avfs_btc_<= wbr>status =3D=3D AVFS_BTC_NOTSUPPORTED)
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!hwmgr->avfs_supported) >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 return 0;
>
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (data->need_upda= te_smu7_dpm_table & DPMTABLE_OD_UPDATE_VDDC) {
> diff --git a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h b/drivers/= gpu/drm/amd/powerplay/inc/hwmgr.h
> index b151ad85..312fbc3 100644
> --- a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
> +++ b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
> @@ -748,7 +748,7 @@ struct pp_hwmgr {
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct pp_power_state= =C2=A0=C2=A0=C2=A0 *uvd_ps;
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 struct amd_pp_display_= configuration display_config;
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uint32_t feature_mask;=
> -
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool avfs_supported;
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 /* UMD Pstate */
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 bool en_umd_pstate; >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 uint32_t power_profile= _mode;
> diff --git a/drivers/gpu/drm/amd/powerplay/inc/smumgr.h b/drivers= /gpu/drm/amd/powerplay/inc/smumgr.h
> index 9bba0a0..f0ef02a 100644
> --- a/drivers/gpu/drm/amd/powerplay/inc/smumgr.h
> +++ b/drivers/gpu/drm/amd/powerplay/inc/smumgr.h
> @@ -28,23 +28,15 @@
>
>=C2=A0 enum AVFS_BTC_STATUS {
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_BOOT =3D 0, > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_BOOT_STARTEDSMU,
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_LOAD_VIRUS,
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_VIRUS_LOADED,=
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_VIRUS_FAIL, >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_COMPLETED_PRE= VIOUSLY,
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_ENABLEAVFS, > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_STARTED,
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_FAILED,
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_RESTOREVFT_FAILED,
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_SAVEVFT_FAILED,
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_DPMTABLESETUP= _FAILED,
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_COMPLETED_UNSAVED,
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_COMPLETED_SAVED,
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_COMPLETED_RESTORED,
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_DISABLED,
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_NOTSUPPORTED,
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_SMUMSG_ERROR
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 AVFS_BTC_NOTSUPPORTED
>=C2=A0 };

This isn't used to interact with the hw anywhere is it?=C2=A0 If so, th= is
will break that.=C2=A0 It should probably be split out as a separate patch<= br> since it's not really directly related to the rest of this patch.
With those addresses this patch is:
Reviewed-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>

>
>=C2=A0 enum SMU_TABLE {
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c b= /drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c
> index 0b2b5d1..573c9be 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c
> @@ -360,8 +360,10 @@ static bool fiji_is_hw_avfs_present(struct pp_hwm= gr *hwmgr)
>
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (!atomctrl_read_efu= se(hwmgr->device, AVFS_EN_LSB, AVFS_EN_MSB,
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= mask, &efuse)) {
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 if (efuse)
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 if (efuse) {
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 hwmgr->a= vfs_supported =3D true;
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= return true;
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 }
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return false;
>=C2=A0 }
> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_= smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.= c
> index 632d1ca..1075ec1 100644
> --- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.= c
> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.= c
> @@ -357,8 +357,10 @@ static bool polaris10_is_hw_avfs_present(str= uct pp_hwmgr *hwmgr)
>
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 efuse =3D cgs_read_ind= _register(hwmgr->device, CGS_IND_REG__SMC, ixSMU_EFUSE_0 + (49*4));=
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 efuse &=3D 0x00000= 001;
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (efuse)
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (efuse) {
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 hwmgr->avfs_supported =3D true;
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0 return true;
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 }
>
>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return false;
>=C2=A0 }
> --
> 1.9.1
>
> _______________________________________________
> amd-gfx mailing list
> amd= -gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following f= orm. Use of all freede= sktop.org lists is subject to our Code of ...


--001a1143bb868dd7bb0566fdd17d-- --===============0484989343== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBt YWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg== --===============0484989343==--