From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21325C2D0ED for ; Fri, 27 Mar 2020 14:16:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC23F20658 for ; Fri, 27 Mar 2020 14:16:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="inBI3zIM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727606AbgC0OQP (ORCPT ); Fri, 27 Mar 2020 10:16:15 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:39024 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727115AbgC0OQO (ORCPT ); Fri, 27 Mar 2020 10:16:14 -0400 Received: by mail-wr1-f66.google.com with SMTP id p10so11589431wrt.6; Fri, 27 Mar 2020 07:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9wNt2gai8dRVSKQAlV2TOplqX3mifpAWTobUqLn101c=; b=inBI3zIMOQoWlxqDdeGv06GRSPaAjKkg26RelATkUJiHTcP9LZQnSO/ULU1nW/atKk GKf6/AVfYIuDEf5LyNTh33Tp39tDTnVLptNWdPYKqdZR9wn6MHdCwLJaIGX4oKWqUIUQ /J0Sq4xc09A5xL4LU1ZpBdePsC1fztREX3HVdk7Y6dBuDQ34vFmYc8s8v4v09jI6Cb1k c735gWJCGxyrXyhVtCL0BVi9Q/t9Q2jcXKwDZZrU6N6oS0DhJS8EOvpFdzvjJ3OvqvMe xv8OKLs9MFOkQLrsj7FElzDPCHR4BuBZiWvpsmhGIro1hJKXXmCLsDfS/GPcN9NMsQlJ H/9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9wNt2gai8dRVSKQAlV2TOplqX3mifpAWTobUqLn101c=; b=Y5aYPCSCC4waSpz7OZPzd6NquDjL/BBNYXLvd8nJlQ1feD0VSQNKfyXyYRWO2WcJw5 QgX9zw+JxS9JvbObXM86hUYiR06HECKh/2QxVkQmD9NjPt8tOrOLWb1O64n4S/R6f66I O0eTRoM8BbRJhGdcvktJByVRH6CDfqvi5tZis8kCEXgF2kSToS42YU5un0P5GBQnfh/e dVnIO5TGtJgbgeJ7S0UKoY7klKzSBRGaa7p41KVKFSZHos1eUNHlC5hXdLZuxsICeMhr C50Y1ZWdMl6DwZ+CRXhgdKER5qQmOtrT2SMB0Up5yWmTP9PhIjXcmFmEE6lXgT67uQFT uSUA== X-Gm-Message-State: ANhLgQ0+A9EGT1iA7gQoQvmu2dRljZRHlP/i3zByAbcNQ8HhkU2rUZgj kWiLJ+WpkJSBEXAwA2Zd7Sxjl1/8TKSqSIZo/5s= X-Google-Smtp-Source: ADFU+vv/Vh/Usi3RX7zJFDIxkoX6XlRPz6qGaxO2o50FKhqyLTNRGqCUFnkaHDBaoZdAfcbG/1I2SUpXx72SUWSdNGo= X-Received: by 2002:a5d:6187:: with SMTP id j7mr15924936wru.419.1585318572316; Fri, 27 Mar 2020 07:16:12 -0700 (PDT) MIME-Version: 1.0 References: <20200327082446.18480-1-m.szyprowski@samsung.com> <64025801-10f0-9f28-17b2-2c04d4308ac5@samsung.com> In-Reply-To: From: Alex Deucher Date: Fri, 27 Mar 2020 10:16:01 -0400 Message-ID: Subject: Re: [PATCH] drm/prime: fix extracting of the DMA addresses from a scatterlist To: Shane Francis Cc: Marek Szyprowski , linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , David Airlie , LKML , "for 3.8" , "Michael J . Ruhl" , Maling list - DRI developers , Thomas Zimmermann , Alex Deucher Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 27, 2020 at 6:25 AM Shane Francis wrote: > > Hello Marek, > > On Fri, Mar 27, 2020 at 9:00 AM Marek Szyprowski > wrote: > > > I have tested the above patch against my original issues with amdgpu > > > and radeon drivers and everything is still working as expected. > > > > > > Sorry I missed this in my original patches. > > > > No problem. Thanks for testing! > > > > Best regards > > -- > > Marek Szyprowski, PhD > > Samsung R&D Institute Poland > > > Just a thought. > > Would it be worth adding some comments to the code to explain why this > is needed, reading > the thread around my original patches and the DMA-API documentation it > is not instantly > clear why you would be mapping the pages in this way. > > Would probably prevent someone in the future making the same mistake I > did while updating > this code. With a comment similar to the commit messaged added to this function, this patch is: Reviewed-by: Alex Deucher Thanks! Alex From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D15C2D0EC for ; Fri, 27 Mar 2020 14:16:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78A472073B for ; Fri, 27 Mar 2020 14:16:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="inBI3zIM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78A472073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E206B6EA3C; Fri, 27 Mar 2020 14:16:14 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id B09286EA3C for ; Fri, 27 Mar 2020 14:16:13 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id m11so5699059wrx.10 for ; Fri, 27 Mar 2020 07:16:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9wNt2gai8dRVSKQAlV2TOplqX3mifpAWTobUqLn101c=; b=inBI3zIMOQoWlxqDdeGv06GRSPaAjKkg26RelATkUJiHTcP9LZQnSO/ULU1nW/atKk GKf6/AVfYIuDEf5LyNTh33Tp39tDTnVLptNWdPYKqdZR9wn6MHdCwLJaIGX4oKWqUIUQ /J0Sq4xc09A5xL4LU1ZpBdePsC1fztREX3HVdk7Y6dBuDQ34vFmYc8s8v4v09jI6Cb1k c735gWJCGxyrXyhVtCL0BVi9Q/t9Q2jcXKwDZZrU6N6oS0DhJS8EOvpFdzvjJ3OvqvMe xv8OKLs9MFOkQLrsj7FElzDPCHR4BuBZiWvpsmhGIro1hJKXXmCLsDfS/GPcN9NMsQlJ H/9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9wNt2gai8dRVSKQAlV2TOplqX3mifpAWTobUqLn101c=; b=kASOKQL32RS3VXL0au6LWBG4VQfwoblo8wXPVxX/uthTtMfqiJEcIwVne8HBJjLXw5 Z4tKR1bN8Y6TlQtryjtCsJizodpflc1VjlXYvzaIhbEDBWF2YYMuDL4JiQU2NpmQ+XNQ IN3dhD9zFeWg0ty5Wnh0XOAYwCql5Go+eL0uDzGoqQotAAIorM7zH49jWuuRPJ+47KC3 Wmc2gigXryXMJBU+K6q+zFPAsP15Tctwzva6QTX8u6Tq3Hwh9Z0XtB7peN+/n1+YStkZ J3Fi58Dm6UmKINBeBiyEdQ4LjeR/xIKOxzIEJqDLpo+LXrwMQbAjOAZTHBs30e99hqAJ IcNA== X-Gm-Message-State: ANhLgQ38m0FdyvnAivrD7m5Z/lcctSUMmcIpnPqJE+iUWO9kXvOVuQdH aRdPrLIQ3F0Gkxu2G30ZE5kEnOESuCgml4eC6xQ= X-Google-Smtp-Source: ADFU+vv/Vh/Usi3RX7zJFDIxkoX6XlRPz6qGaxO2o50FKhqyLTNRGqCUFnkaHDBaoZdAfcbG/1I2SUpXx72SUWSdNGo= X-Received: by 2002:a5d:6187:: with SMTP id j7mr15924936wru.419.1585318572316; Fri, 27 Mar 2020 07:16:12 -0700 (PDT) MIME-Version: 1.0 References: <20200327082446.18480-1-m.szyprowski@samsung.com> <64025801-10f0-9f28-17b2-2c04d4308ac5@samsung.com> In-Reply-To: From: Alex Deucher Date: Fri, 27 Mar 2020 10:16:01 -0400 Message-ID: Subject: Re: [PATCH] drm/prime: fix extracting of the DMA addresses from a scatterlist To: Shane Francis X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Bartlomiej Zolnierkiewicz , David Airlie , LKML , "for 3.8" , "Michael J . Ruhl" , Maling list - DRI developers , Thomas Zimmermann , Alex Deucher , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Mar 27, 2020 at 6:25 AM Shane Francis wrote: > > Hello Marek, > > On Fri, Mar 27, 2020 at 9:00 AM Marek Szyprowski > wrote: > > > I have tested the above patch against my original issues with amdgpu > > > and radeon drivers and everything is still working as expected. > > > > > > Sorry I missed this in my original patches. > > > > No problem. Thanks for testing! > > > > Best regards > > -- > > Marek Szyprowski, PhD > > Samsung R&D Institute Poland > > > Just a thought. > > Would it be worth adding some comments to the code to explain why this > is needed, reading > the thread around my original patches and the DMA-API documentation it > is not instantly > clear why you would be mapping the pages in this way. > > Would probably prevent someone in the future making the same mistake I > did while updating > this code. With a comment similar to the commit messaged added to this function, this patch is: Reviewed-by: Alex Deucher Thanks! Alex _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel