From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH 01/14] drm/radeon: consolidate r600 uvd initialization and startup code. Date: Mon, 21 Mar 2016 11:49:50 -0400 Message-ID: References: <1458316719-30104-1-git-send-email-jglisse@redhat.com> <1458316719-30104-2-git-send-email-jglisse@redhat.com> <56EC3086.6090801@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-yw0-x243.google.com (mail-yw0-x243.google.com [IPv6:2607:f8b0:4002:c05::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B40F6E063 for ; Mon, 21 Mar 2016 15:49:52 +0000 (UTC) Received: by mail-yw0-x243.google.com with SMTP id d21so7871394ywe.2 for ; Mon, 21 Mar 2016 08:49:52 -0700 (PDT) In-Reply-To: <56EC3086.6090801@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Alex Deucher , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXIgMTgsIDIwMTYgYXQgMTI6NDQgUE0sIENocmlzdGlhbiBLw7ZuaWcKPGNocmlz dGlhbi5rb2VuaWdAYW1kLmNvbT4gd3JvdGU6Cj4gQW0gMTguMDMuMjAxNiB1bSAxNjo1OCBzY2hy aWViIErDqXLDtG1lIEdsaXNzZToKPj4KPj4gRnJvbTogSsOpcm9tZSBHbGlzc2UgPGpnbGlzc2VA cmVkaGF0LmNvbT4KPj4KPj4gVGhpcyBtYXRjaCB0aGUgZXhhY3Qgc2FtZSBjb250cm9sIGZsb3cg YXMgZXhpc3RpbmcgY29kZS4gSXQganVzdAo+PiB1c2UgZ290byBpbnN0ZWFkIG9mIG11bHRpcGxl IGxldmVscyBvZiBpZi9lbHNlLiBJdCBhbHNvIGNsYXJpZnkKPj4gZWFybHkgaW5pdGlhbGl6YXRp b24gZmFpbHVyZXMgYnkgY2xlYXJpbmcgcmRldi0+aGFzX3V2ZCBkb2luZyBzbwo+PiBkb2VzIG5v dCBjaGFuZ2UgZW5kIHJlc3VsdCBmcm9tIGhhcmR3YXJlIHBvaW50IG9mIHZpZXcsIGl0IG9ubHkK Pj4gYXZvaWRzIHByaW50aW5nIG1vcmUgZXJyb3IgbWVzc2FnZXMgZG93biB0aGUgbGluZSBhbmQg dGh1cyBvbmx5Cj4+IHRoZSBvcmlnaW5hbCBlcnJvciBpcyByZXBvcnRlZC4KPj4KPj4gU2lnbmVk LW9mZi1ieTogSsOpcsO0bWUgR2xpc3NlIDxqZ2xpc3NlQHJlZGhhdC5jb20+Cj4+IENjOiBBbGV4 IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4+IENjOiBDaHJpc3RpYW4gS8O2 bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4KPgo+IFBhdGNoZXMgIzcgYW5kICMxMS0j MTQgYXJlIFJldmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmlnCj4gPGNocmlzdGlhbi5rb2VuaWdA YW1kLmNvbT4KPgo+IFBhdGNoZXMgIzEtIzYgYW5kICM4LSMxMCBhcmUgQWNrZWQtYnk6IENocmlz dGlhbiBLw7ZuaWcKPiA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+CgpBcHBsaWVkLiAgdGhh bmtzIQoKQWxleAoKPiBUaGFua3MsCj4gQ2hyaXN0aWFuLgo+Cj4KPj4gLS0tCj4+ICAgZHJpdmVy cy9ncHUvZHJtL3JhZGVvbi9yNjAwLmMgfCA5OQo+PiArKysrKysrKysrKysrKysrKysrKysrKysr KysrKystLS0tLS0tLS0tLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDcwIGluc2VydGlvbnMoKyks IDI5IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVv bi9yNjAwLmMgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3I2MDAuYwo+PiBpbmRleCBmODZhYjY5 Li4yNGZhOTgyIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3I2MDAuYwo+ PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3I2MDAuYwo+PiBAQCAtMzAzNSw2ICszMDM1 LDczIEBAIHZvaWQgcjYwMF9jbGVhcl9zdXJmYWNlX3JlZyhzdHJ1Y3QgcmFkZW9uX2RldmljZQo+ PiAqcmRldiwgaW50IHJlZykKPj4gICAgICAgICAvKiBGSVhNRTogaW1wbGVtZW50ICovCj4+ICAg fQo+PiAgICtzdGF0aWMgdm9pZCByNjAwX3V2ZF9pbml0KHN0cnVjdCByYWRlb25fZGV2aWNlICpy ZGV2KQo+PiArewo+PiArICAgICAgIGludCByOwo+PiArCj4+ICsgICAgICAgaWYgKCFyZGV2LT5o YXNfdXZkKQo+PiArICAgICAgICAgICAgICAgcmV0dXJuOwo+PiArCj4+ICsgICAgICAgciA9IHJh ZGVvbl91dmRfaW5pdChyZGV2KTsKPj4gKyAgICAgICBpZiAocikgewo+PiArICAgICAgICAgICAg ICAgZGV2X2VycihyZGV2LT5kZXYsICJmYWlsZWQgVVZEICglZCkgaW5pdC5cbiIsIHIpOwo+PiAr ICAgICAgICAgICAgICAgLyoKPj4gKyAgICAgICAgICAgICAgICAqIEF0IHRoaXMgcG9pbnQgcmRl di0+dXZkLnZjcHVfYm8gaXMgTlVMTCB3aGljaCB0cmlja2xlcwo+PiBkb3duCj4+ICsgICAgICAg ICAgICAgICAgKiB0byBlYXJseSBmYWlscyB1dmRfdjFfMF9yZXN1bWUoKSBhbmQgdGh1cyBub3Ro aW5nCj4+IGhhcHBlbnMKPj4gKyAgICAgICAgICAgICAgICAqIHRoZXJlLiBTbyBpdCBpcyBwb2lu dGxlc3MgdG8gdHJ5IHRvIGdvIHRocm91Z2ggdGhhdAo+PiBjb2RlCj4+ICsgICAgICAgICAgICAg ICAgKiBoZW5jZSB3aHkgd2UgZGlzYWJsZSB1dmQgaGVyZS4KPj4gKyAgICAgICAgICAgICAgICAq Lwo+PiArICAgICAgICAgICAgICAgcmRldi0+aGFzX3V2ZCA9IDA7Cj4+ICsgICAgICAgICAgICAg ICByZXR1cm47Cj4+ICsgICAgICAgfQo+PiArICAgICAgIHJkZXYtPnJpbmdbUjYwMF9SSU5HX1RZ UEVfVVZEX0lOREVYXS5yaW5nX29iaiA9IE5VTEw7Cj4+ICsgICAgICAgcjYwMF9yaW5nX2luaXQo cmRldiwgJnJkZXYtPnJpbmdbUjYwMF9SSU5HX1RZUEVfVVZEX0lOREVYXSwgNDA5Nik7Cj4+ICt9 Cj4+ICsKPj4gK3N0YXRpYyB2b2lkIHI2MDBfdXZkX3N0YXJ0KHN0cnVjdCByYWRlb25fZGV2aWNl ICpyZGV2KQo+PiArewo+PiArICAgICAgIGludCByOwo+PiArCj4+ICsgICAgICAgaWYgKCFyZGV2 LT5oYXNfdXZkKQo+PiArICAgICAgICAgICAgICAgcmV0dXJuOwo+PiArCj4+ICsgICAgICAgciA9 IHV2ZF92MV8wX3Jlc3VtZShyZGV2KTsKPj4gKyAgICAgICBpZiAocikgewo+PiArICAgICAgICAg ICAgICAgZGV2X2VycihyZGV2LT5kZXYsICJmYWlsZWQgVVZEIHJlc3VtZSAoJWQpLlxuIiwgcik7 Cj4+ICsgICAgICAgICAgICAgICBnb3RvIGVycm9yOwo+PiArICAgICAgIH0KPj4gKyAgICAgICBy ID0gcmFkZW9uX2ZlbmNlX2RyaXZlcl9zdGFydF9yaW5nKHJkZXYsCj4+IFI2MDBfUklOR19UWVBF X1VWRF9JTkRFWCk7Cj4+ICsgICAgICAgaWYgKHIpIHsKPj4gKyAgICAgICAgICAgICAgIGRldl9l cnIocmRldi0+ZGV2LCAiZmFpbGVkIGluaXRpYWxpemluZyBVVkQgZmVuY2VzCj4+ICglZCkuXG4i LCByKTsKPj4gKyAgICAgICAgICAgICAgIGdvdG8gZXJyb3I7Cj4+ICsgICAgICAgfQo+PiArICAg ICAgIHJldHVybjsKPj4gKwo+PiArZXJyb3I6Cj4+ICsgICAgICAgcmRldi0+cmluZ1tSNjAwX1JJ TkdfVFlQRV9VVkRfSU5ERVhdLnJpbmdfc2l6ZSA9IDA7Cj4+ICt9Cj4+ICsKPj4gK3N0YXRpYyB2 b2lkIHI2MDBfdXZkX3Jlc3VtZShzdHJ1Y3QgcmFkZW9uX2RldmljZSAqcmRldikKPj4gK3sKPj4g KyAgICAgICBzdHJ1Y3QgcmFkZW9uX3JpbmcgKnJpbmc7Cj4+ICsgICAgICAgaW50IHI7Cj4+ICsK Pj4gKyAgICAgICBpZiAoIXJkZXYtPmhhc191dmQgfHwKPj4gIXJkZXYtPnJpbmdbUjYwMF9SSU5H X1RZUEVfVVZEX0lOREVYXS5yaW5nX3NpemUpCj4+ICsgICAgICAgICAgICAgICByZXR1cm47Cj4+ ICsKPj4gKyAgICAgICByaW5nID0gJnJkZXYtPnJpbmdbUjYwMF9SSU5HX1RZUEVfVVZEX0lOREVY XTsKPj4gKyAgICAgICByID0gcmFkZW9uX3JpbmdfaW5pdChyZGV2LCByaW5nLCByaW5nLT5yaW5n X3NpemUsIDAsCj4+IFJBREVPTl9DUF9QQUNLRVQyKTsKPj4gKyAgICAgICBpZiAocikgewo+PiAr ICAgICAgICAgICAgICAgZGV2X2VycihyZGV2LT5kZXYsICJmYWlsZWQgaW5pdGlhbGl6aW5nIFVW RCByaW5nICglZCkuXG4iLAo+PiByKTsKPj4gKyAgICAgICAgICAgICAgIHJldHVybjsKPj4gKyAg ICAgICB9Cj4+ICsgICAgICAgciA9IHV2ZF92MV8wX2luaXQocmRldik7Cj4+ICsgICAgICAgaWYg KHIpIHsKPj4gKyAgICAgICAgICAgICAgIGRldl9lcnIocmRldi0+ZGV2LCAiZmFpbGVkIGluaXRp YWxpemluZyBVVkQgKCVkKS5cbiIsIHIpOwo+PiArICAgICAgICAgICAgICAgcmV0dXJuOwo+PiAr ICAgICAgIH0KPj4gK30KPj4gKwo+PiAgIHN0YXRpYyBpbnQgcjYwMF9zdGFydHVwKHN0cnVjdCBy YWRlb25fZGV2aWNlICpyZGV2KQo+PiAgIHsKPj4gICAgICAgICBzdHJ1Y3QgcmFkZW9uX3Jpbmcg KnJpbmc7Cj4+IEBAIC0zMDcwLDE3ICszMTM3LDcgQEAgc3RhdGljIGludCByNjAwX3N0YXJ0dXAo c3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYpCj4+ICAgICAgICAgICAgICAgICByZXR1cm4gcjsK Pj4gICAgICAgICB9Cj4+ICAgLSAgICAgaWYgKHJkZXYtPmhhc191dmQpIHsKPj4gLSAgICAgICAg ICAgICAgIHIgPSB1dmRfdjFfMF9yZXN1bWUocmRldik7Cj4+IC0gICAgICAgICAgICAgICBpZiAo IXIpIHsKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgciA9IHJhZGVvbl9mZW5jZV9kcml2ZXJf c3RhcnRfcmluZyhyZGV2LAo+PiBSNjAwX1JJTkdfVFlQRV9VVkRfSU5ERVgpOwo+PiAtICAgICAg ICAgICAgICAgICAgICAgICBpZiAocikgewo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGRldl9lcnIocmRldi0+ZGV2LCAiZmFpbGVkIGluaXRpYWxpemluZwo+PiBVVkQgZmVuY2Vz ICglZCkuXG4iLCByKTsKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgfQo+PiAtICAgICAgICAg ICAgICAgfQo+PiAtICAgICAgICAgICAgICAgaWYgKHIpCj4+IC0gICAgICAgICAgICAgICAgICAg ICAgIHJkZXYtPnJpbmdbUjYwMF9SSU5HX1RZUEVfVVZEX0lOREVYXS5yaW5nX3NpemUgPQo+PiAw Owo+PiAtICAgICAgIH0KPj4gKyAgICAgICByNjAwX3V2ZF9zdGFydChyZGV2KTsKPj4gICAgICAg ICAvKiBFbmFibGUgSVJRICovCj4+ICAgICAgICAgaWYgKCFyZGV2LT5pcnEuaW5zdGFsbGVkKSB7 Cj4+IEBAIC0zMTEwLDE3ICszMTY3LDcgQEAgc3RhdGljIGludCByNjAwX3N0YXJ0dXAoc3RydWN0 IHJhZGVvbl9kZXZpY2UgKnJkZXYpCj4+ICAgICAgICAgaWYgKHIpCj4+ICAgICAgICAgICAgICAg ICByZXR1cm4gcjsKPj4gICAtICAgICBpZiAocmRldi0+aGFzX3V2ZCkgewo+PiAtICAgICAgICAg ICAgICAgcmluZyA9ICZyZGV2LT5yaW5nW1I2MDBfUklOR19UWVBFX1VWRF9JTkRFWF07Cj4+IC0g ICAgICAgICAgICAgICBpZiAocmluZy0+cmluZ19zaXplKSB7Cj4+IC0gICAgICAgICAgICAgICAg ICAgICAgIHIgPSByYWRlb25fcmluZ19pbml0KHJkZXYsIHJpbmcsIHJpbmctPnJpbmdfc2l6ZSwK Pj4gMCwKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUkFE RU9OX0NQX1BBQ0tFVDIpOwo+PiAtICAgICAgICAgICAgICAgICAgICAgICBpZiAoIXIpCj4+IC0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgciA9IHV2ZF92MV8wX2luaXQocmRldik7Cj4+ IC0gICAgICAgICAgICAgICAgICAgICAgIGlmIChyKQo+PiAtICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIERSTV9FUlJPUigicmFkZW9uOiBmYWlsZWQgaW5pdGlhbGl6aW5nIFVWRAo+PiAo JWQpLlxuIiwgcik7Cj4+IC0gICAgICAgICAgICAgICB9Cj4+IC0gICAgICAgfQo+PiArICAgICAg IHI2MDBfdXZkX3Jlc3VtZShyZGV2KTsKPj4gICAgICAgICByID0gcmFkZW9uX2liX3Bvb2xfaW5p dChyZGV2KTsKPj4gICAgICAgICBpZiAocikgewo+PiBAQCAtMzI2NCwxMyArMzMxMSw3IEBAIGlu dCByNjAwX2luaXQoc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYpCj4+ICAgICAgICAgcmRldi0+ cmluZ1tSQURFT05fUklOR19UWVBFX0dGWF9JTkRFWF0ucmluZ19vYmogPSBOVUxMOwo+PiAgICAg ICAgIHI2MDBfcmluZ19pbml0KHJkZXYsICZyZGV2LT5yaW5nW1JBREVPTl9SSU5HX1RZUEVfR0ZY X0lOREVYXSwgMTAyNAo+PiAqIDEwMjQpOwo+PiAgIC0gICAgIGlmIChyZGV2LT5oYXNfdXZkKSB7 Cj4+IC0gICAgICAgICAgICAgICByID0gcmFkZW9uX3V2ZF9pbml0KHJkZXYpOwo+PiAtICAgICAg ICAgICAgICAgaWYgKCFyKSB7Cj4+IC0gICAgICAgICAgICAgICAgICAgICAgIHJkZXYtPnJpbmdb UjYwMF9SSU5HX1RZUEVfVVZEX0lOREVYXS5yaW5nX29iaiA9Cj4+IE5VTEw7Cj4+IC0gICAgICAg ICAgICAgICAgICAgICAgIHI2MDBfcmluZ19pbml0KHJkZXYsCj4+ICZyZGV2LT5yaW5nW1I2MDBf UklOR19UWVBFX1VWRF9JTkRFWF0sIDQwOTYpOwo+PiAtICAgICAgICAgICAgICAgfQo+PiAtICAg ICAgIH0KPj4gKyAgICAgICByNjAwX3V2ZF9pbml0KHJkZXYpOwo+PiAgICAgICAgIHJkZXYtPmlo LnJpbmdfb2JqID0gTlVMTDsKPj4gICAgICAgICByNjAwX2loX3JpbmdfaW5pdChyZGV2LCA2NCAq IDEwMjQpOwo+Cj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==