From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex Deucher Subject: Re: [PATCH v2 1/3] drm/amd: be quiet when no SAD block is found Date: Fri, 13 Sep 2019 16:51:20 -0400 Message-ID: References: <20190904111152.266d5176@endymion> <20190904111248.61dfdd68@endymion> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Harry Wentland Cc: David Airlie , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" , "Deucher, Alexander" , "Koenig, Christian" , Jean Delvare List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBTZXAgNCwgMjAxOSBhdCA5OjE4IEFNIEhhcnJ5IFdlbnRsYW5kIDxod2VudGxhbkBh bWQuY29tPiB3cm90ZToKPgo+IE9uIDIwMTktMDktMDQgNToxMiBhLm0uLCBKZWFuIERlbHZhcmUg d3JvdGU6Cj4gPiBJdCBpcyBmaW5lIGZvciBkaXNwbGF5cyB3aXRob3V0IGF1ZGlvIGZ1bmN0aW9u YWxpdHkgdG8gbm90IHByb3ZpZGUKPiA+IGFueSBTQUQgYmxvY2sgaW4gdGhlaXIgRURJRC4gRG8g bm90IGxvZyBhbiBlcnJvciBpbiB0aGF0IGNhc2UsCj4gPiBqdXN0IHJldHVybiBxdWlldGx5Lgo+ ID4KPiA+IFRoaXMgZml4ZXMgaGFsZiBvZiBidWcgZmRvIzEwNzgyNToKPiA+IGh0dHBzOi8vYnVn cy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNzgyNQo+ID4KPiA+IFNpZ25lZC1v ZmYtYnk6IEplYW4gRGVsdmFyZSA8amRlbHZhcmVAc3VzZS5kZT4KPiA+IENjOiBBbGV4IERldWNo ZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gPiBDYzogIkNocmlzdGlhbiBLw7ZuaWci IDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4gPiBDYzogIkRhdmlkIChDaHVuTWluZykgWmhv dSIgPERhdmlkMS5aaG91QGFtZC5jb20+Cj4gPiBDYzogRGF2aWQgQWlybGllIDxhaXJsaWVkQGxp bnV4LmllPgo+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiA+IENjOiBI YXJyeSBXZW50bGFuZCA8aGFycnkud2VudGxhbmRAYW1kLmNvbT4KPiA+IENjOiBMZW8gTGkgPHN1 bnBlbmcubGlAYW1kLmNvbT4KPgo+IFJldmlld2VkLWJ5OiBIYXJyeSBXZW50bGFuZCA8aGFycnku d2VudGxhbmRAYW1kLmNvbT4KClBhdGNoZXMgMSBhbmQgMiBhcHBsaWVkLgoKVGhhbmtzIQoKQWxl eAoKPgo+IEhhcnJ5Cj4KPiA+IC0tLQo+ID4gTm8gY2hhbmdlIHNpbmNlIHYxLgo+ID4KPiA+ICBk cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2VfdjEwXzAuYyAgICAgICAgICAgICAgICAgICAg fCAgICA0ICsrLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2VfdjExXzAuYyAg ICAgICAgICAgICAgICAgICAgfCAgICA0ICsrLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Ft ZGdwdS9kY2VfdjZfMC5jICAgICAgICAgICAgICAgICAgICAgfCAgICA0ICsrLS0KPiA+ICBkcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2VfdjhfMC5jICAgICAgICAgICAgICAgICAgICAgfCAg ICA0ICsrLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdw dV9kbV9oZWxwZXJzLmMgfCAgICA3ICsrKy0tLS0KPiA+ICA1IGZpbGVzIGNoYW5nZWQsIDExIGlu c2VydGlvbnMoKyksIDEyIGRlbGV0aW9ucygtKQo+ID4KPiA+IC0tLSBsaW51eC01LjIub3JpZy9k cml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2VfdjEwXzAuYyAgICAgMjAxOS0wNy0wOCAwMDo0 MTo1Ni4wMDAwMDAwMDAgKzAyMDAKPiA+ICsrKyBsaW51eC01LjIvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvZGNlX3YxMF8wLmMgIDIwMTktMDgtMzAgMTQ6Mjg6NDYuMDgxNjgyMjIzICswMjAw Cj4gPiBAQCAtMTM0NSwxMCArMTM0NSwxMCBAQCBzdGF0aWMgdm9pZCBkY2VfdjEwXzBfYXVkaW9f d3JpdGVfc2FkX3JlCj4gPiAgICAgICB9Cj4gPgo+ID4gICAgICAgc2FkX2NvdW50ID0gZHJtX2Vk aWRfdG9fc2FkKGFtZGdwdV9jb25uZWN0b3JfZWRpZChjb25uZWN0b3IpLCAmc2Fkcyk7Cj4gPiAt ICAgICBpZiAoc2FkX2NvdW50IDw9IDApIHsKPiA+ICsgICAgIGlmIChzYWRfY291bnQgPCAwKQo+ ID4gICAgICAgICAgICAgICBEUk1fRVJST1IoIkNvdWxkbid0IHJlYWQgU0FEczogJWRcbiIsIHNh ZF9jb3VudCk7Cj4gPiArICAgICBpZiAoc2FkX2NvdW50IDw9IDApCj4gPiAgICAgICAgICAgICAg IHJldHVybjsKPiA+IC0gICAgIH0KPiA+ICAgICAgIEJVR19PTighc2Fkcyk7Cj4gPgo+ID4gICAg ICAgZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUoZWxkX3JlZ190b190eXBlKTsgaSsrKSB7Cj4g PiAtLS0gbGludXgtNS4yLm9yaWcvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3YxMV8w LmMgICAgIDIwMTktMDctMDggMDA6NDE6NTYuMDAwMDAwMDAwICswMjAwCj4gPiArKysgbGludXgt NS4yL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2RjZV92MTFfMC5jICAyMDE5LTA4LTMwIDE0 OjI5OjI3LjI3NjIwNTMxMCArMDIwMAo+ID4gQEAgLTEzNzEsMTAgKzEzNzEsMTAgQEAgc3RhdGlj IHZvaWQgZGNlX3YxMV8wX2F1ZGlvX3dyaXRlX3NhZF9yZQo+ID4gICAgICAgfQo+ID4KPiA+ICAg ICAgIHNhZF9jb3VudCA9IGRybV9lZGlkX3RvX3NhZChhbWRncHVfY29ubmVjdG9yX2VkaWQoY29u bmVjdG9yKSwgJnNhZHMpOwo+ID4gLSAgICAgaWYgKHNhZF9jb3VudCA8PSAwKSB7Cj4gPiArICAg ICBpZiAoc2FkX2NvdW50IDwgMCkKPiA+ICAgICAgICAgICAgICAgRFJNX0VSUk9SKCJDb3VsZG4n dCByZWFkIFNBRHM6ICVkXG4iLCBzYWRfY291bnQpOwo+ID4gKyAgICAgaWYgKHNhZF9jb3VudCA8 PSAwKQo+ID4gICAgICAgICAgICAgICByZXR1cm47Cj4gPiAtICAgICB9Cj4gPiAgICAgICBCVUdf T04oIXNhZHMpOwo+ID4KPiA+ICAgICAgIGZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKGVsZF9y ZWdfdG9fdHlwZSk7IGkrKykgewo+ID4gLS0tIGxpbnV4LTUuMi5vcmlnL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2RjZV92Nl8wLmMgICAgICAyMDE5LTA3LTA4IDAwOjQxOjU2LjAwMDAwMDAw MCArMDIwMAo+ID4gKysrIGxpbnV4LTUuMi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2Vf djZfMC5jICAgMjAxOS0wOC0zMCAxNzo1ODo1My42MTM5NTM0NTggKzAyMDAKPiA+IEBAIC0xMjQ4 LDEwICsxMjQ4LDEwIEBAIHN0YXRpYyB2b2lkIGRjZV92Nl8wX2F1ZGlvX3dyaXRlX3NhZF9yZWcK PiA+ICAgICAgIH0KPiA+Cj4gPiAgICAgICBzYWRfY291bnQgPSBkcm1fZWRpZF90b19zYWQoYW1k Z3B1X2Nvbm5lY3Rvcl9lZGlkKGNvbm5lY3RvciksICZzYWRzKTsKPiA+IC0gICAgIGlmIChzYWRf Y291bnQgPD0gMCkgewo+ID4gKyAgICAgaWYgKHNhZF9jb3VudCA8IDApCj4gPiAgICAgICAgICAg ICAgIERSTV9FUlJPUigiQ291bGRuJ3QgcmVhZCBTQURzOiAlZFxuIiwgc2FkX2NvdW50KTsKPiA+ ICsgICAgIGlmIChzYWRfY291bnQgPD0gMCkKPiA+ICAgICAgICAgICAgICAgcmV0dXJuOwo+ID4g LSAgICAgfQo+ID4KPiA+ICAgICAgIGZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKGVsZF9yZWdf dG9fdHlwZSk7IGkrKykgewo+ID4gICAgICAgICAgICAgICB1MzIgdG1wID0gMDsKPiA+IC0tLSBs aW51eC01LjIub3JpZy9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9kY2VfdjhfMC5jICAgICAg MjAxOS0wNy0wOCAwMDo0MTo1Ni4wMDAwMDAwMDAgKzAyMDAKPiA+ICsrKyBsaW51eC01LjIvZHJp dmVycy9ncHUvZHJtL2FtZC9hbWRncHUvZGNlX3Y4XzAuYyAgIDIwMTktMDgtMzAgMTQ6Mjk6MDEu OTQ4ODgzNzA4ICswMjAwCj4gPiBAQCAtMTI5OCwxMCArMTI5OCwxMCBAQCBzdGF0aWMgdm9pZCBk Y2VfdjhfMF9hdWRpb193cml0ZV9zYWRfcmVnCj4gPiAgICAgICB9Cj4gPgo+ID4gICAgICAgc2Fk X2NvdW50ID0gZHJtX2VkaWRfdG9fc2FkKGFtZGdwdV9jb25uZWN0b3JfZWRpZChjb25uZWN0b3Ip LCAmc2Fkcyk7Cj4gPiAtICAgICBpZiAoc2FkX2NvdW50IDw9IDApIHsKPiA+ICsgICAgIGlmIChz YWRfY291bnQgPCAwKQo+ID4gICAgICAgICAgICAgICBEUk1fRVJST1IoIkNvdWxkbid0IHJlYWQg U0FEczogJWRcbiIsIHNhZF9jb3VudCk7Cj4gPiArICAgICBpZiAoc2FkX2NvdW50IDw9IDApCj4g PiAgICAgICAgICAgICAgIHJldHVybjsKPiA+IC0gICAgIH0KPiA+ICAgICAgIEJVR19PTighc2Fk cyk7Cj4gPgo+ID4gICAgICAgZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUoZWxkX3JlZ190b190 eXBlKTsgaSsrKSB7Cj4gPiAtLS0gbGludXgtNS4yLm9yaWcvZHJpdmVycy9ncHUvZHJtL2FtZC9k aXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG1faGVscGVycy5jICAyMDE5LTA3LTA4IDAwOjQxOjU2 LjAwMDAwMDAwMCArMDIwMAo+ID4gKysrIGxpbnV4LTUuMi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rp c3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbV9oZWxwZXJzLmMgICAgICAgMjAxOS0wOC0zMCAxNDoz MTowMy4wODY0MjE5MTAgKzAyMDAKPiA+IEBAIC05OCwxMSArOTgsMTAgQEAgZW51bSBkY19lZGlk X3N0YXR1cyBkbV9oZWxwZXJzX3BhcnNlX2VkaQo+ID4gICAgICAgICAgICAgICAgICAgICAgIChz dHJ1Y3QgZWRpZCAqKSBlZGlkLT5yYXdfZWRpZCk7Cj4gPgo+ID4gICAgICAgc2FkX2NvdW50ID0g ZHJtX2VkaWRfdG9fc2FkKChzdHJ1Y3QgZWRpZCAqKSBlZGlkLT5yYXdfZWRpZCwgJnNhZHMpOwo+ ID4gLSAgICAgaWYgKHNhZF9jb3VudCA8PSAwKSB7Cj4gPiAtICAgICAgICAgICAgIERSTV9JTkZP KCJTQURzIGNvdW50IGlzOiAlZCwgZG9uJ3QgbmVlZCB0byByZWFkIGl0XG4iLAo+ID4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgc2FkX2NvdW50KTsKPiA+ICsgICAgIGlmIChzYWRfY291 bnQgPCAwKQo+ID4gKyAgICAgICAgICAgICBEUk1fRVJST1IoIkNvdWxkbid0IHJlYWQgU0FEczog JWRcbiIsIHNhZF9jb3VudCk7Cj4gPiArICAgICBpZiAoc2FkX2NvdW50IDw9IDApCj4gPiAgICAg ICAgICAgICAgIHJldHVybiByZXN1bHQ7Cj4gPiAtICAgICB9Cj4gPgo+ID4gICAgICAgZWRpZF9j YXBzLT5hdWRpb19tb2RlX2NvdW50ID0gc2FkX2NvdW50IDwgRENfTUFYX0FVRElPX0RFU0NfQ09V TlQgPyBzYWRfY291bnQgOiBEQ19NQVhfQVVESU9fREVTQ19DT1VOVDsKPiA+ICAgICAgIGZvciAo aSA9IDA7IGkgPCBlZGlkX2NhcHMtPmF1ZGlvX21vZGVfY291bnQ7ICsraSkgewo+ID4KPiBfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGFtZC1nZnggbWFp bGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs