From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CC80C33CA3 for ; Sat, 11 Jan 2020 00:17:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53AFE2064C for ; Sat, 11 Jan 2020 00:17:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GxMN/mux" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53AFE2064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1D31D6E1E5; Sat, 11 Jan 2020 00:17:58 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id C74656E1E5; Sat, 11 Jan 2020 00:17:56 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id u2so3772990wmc.3; Fri, 10 Jan 2020 16:17:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ze59xLiTAJSzDVkiY1kAM7m1KT/ayX5lzJy7k2zz1E0=; b=GxMN/muxILuh6Mz1cqljfmEh6ATU8zHhpSLeFdPf9z5VzMmxKflDSh8snUzIDyHljN IjqtNjSJTZvVY5RLH4+Ku9paOmAlM5Yk44CUe3yDKDEbMu0XIUbU+xsZwaFloA4MzLyQ XJn+KxK9ASSmWYNU1ynfwWkaaHymwYUpzSP4JdS6GzMUcJ2WejqjSjKtWaSDrtkxwnqT Z4AWLUulce+1i32IGezvPV/B1OCQIFRZzRA8Vv9MndgTuekyFF7jODqRfHdQ3eFi0YHg zYzsNYAdLXoDDDAKOXySrGRDz5y5c5xaCt+OXbtw5qC5JdCzf/cgnqysc55JQP1LDzYP UEog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ze59xLiTAJSzDVkiY1kAM7m1KT/ayX5lzJy7k2zz1E0=; b=SvYWssAF+DQK8V28TuRUaqC27oAPvp/6b3AJv76nocGaHtYPrSQkgA/gbgJyII6yFO dGY75+kWskMIWmYbgaAXQwFLhE9G6LIMQF3TX6AKv1I2fVCX7b71R0xps5RCjHh4ddSm GYmdsaCgBkHZBepCX7+p7GFJa+tamYAPlGa1Hn6XHm6AtF6AwDgIFUSfsmXDi37hwUcd iOOCWp1xkHRiCs42gwacJ+V5MqO6EXQTKnfkoFTr/Mzy9u7yY+e8507xUQLkJrlmvegr JZRtge3WWt9todSMDvM6UKp41ylHgXW0F2YT27WUP27IyAIkK36tp/Dd7/JQ8Pm/LiGf SQeA== X-Gm-Message-State: APjAAAV1p9tOaPeEz6Q4Igkd7/9f/CMC8DUszkHVUOK9lkeLTZgrzKAa XoQE9dKf827/njT8RlmEUfwwjmVc+XR9hmEfbeI= X-Google-Smtp-Source: APXvYqwjQjxv8G5Ads8QwxDVEai740q8qo4sFItXY/qwf3UdJyZiqRhV1s470G2PuGznsF7/7eniM0daOmayO59vUv8= X-Received: by 2002:a1c:486:: with SMTP id 128mr7008543wme.163.1578701875402; Fri, 10 Jan 2020 16:17:55 -0800 (PST) MIME-Version: 1.0 References: <20200109152028.28260-1-mario.kleiner.de@gmail.com> <20200109152028.28260-2-mario.kleiner.de@gmail.com> In-Reply-To: From: Alex Deucher Date: Fri, 10 Jan 2020 19:17:42 -0500 Message-ID: Subject: Re: [PATCH 1/2] drm/amd/display: Reorder detect_edp_sink_caps before link settings read. To: Harry Wentland X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mario.kleiner.de@gmail.de, amd-gfx list , Maling list - DRI developers , Martin Leung , "Deucher, Alexander" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Applied. Thanks! Alex On Thu, Jan 9, 2020 at 1:41 PM Harry Wentland wrote: > > On 2020-01-09 10:20 a.m., Mario Kleiner wrote: > > read_current_link_settings_on_detect() on eDP 1.4+ may use the > > edp_supported_link_rates table which is set up by > > detect_edp_sink_caps(), so that function needs to be called first. > > > > Signed-off-by: Mario Kleiner > > Cc: Martin Leung > > Reviewed-by: Harry Wentland > > This also fixes our assumption that retrieve_link_cap is the first DPCD > reads we perform during detection. > > Harry > > > --- > > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > > index cef8c1ba9797..5ea4a1675259 100644 > > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c > > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > > @@ -817,8 +817,8 @@ static bool dc_link_detect_helper(struct dc_link *link, > > } > > > > case SIGNAL_TYPE_EDP: { > > - read_current_link_settings_on_detect(link); > > detect_edp_sink_caps(link); > > + read_current_link_settings_on_detect(link); > > sink_caps.transaction_type = DDC_TRANSACTION_TYPE_I2C_OVER_AUX; > > sink_caps.signal = SIGNAL_TYPE_EDP; > > break; > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFEABC282DD for ; Sat, 11 Jan 2020 00:17:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A27D02064C for ; Sat, 11 Jan 2020 00:17:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GxMN/mux" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A27D02064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2BF316E1E8; Sat, 11 Jan 2020 00:17:58 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id C74656E1E5; Sat, 11 Jan 2020 00:17:56 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id u2so3772990wmc.3; Fri, 10 Jan 2020 16:17:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ze59xLiTAJSzDVkiY1kAM7m1KT/ayX5lzJy7k2zz1E0=; b=GxMN/muxILuh6Mz1cqljfmEh6ATU8zHhpSLeFdPf9z5VzMmxKflDSh8snUzIDyHljN IjqtNjSJTZvVY5RLH4+Ku9paOmAlM5Yk44CUe3yDKDEbMu0XIUbU+xsZwaFloA4MzLyQ XJn+KxK9ASSmWYNU1ynfwWkaaHymwYUpzSP4JdS6GzMUcJ2WejqjSjKtWaSDrtkxwnqT Z4AWLUulce+1i32IGezvPV/B1OCQIFRZzRA8Vv9MndgTuekyFF7jODqRfHdQ3eFi0YHg zYzsNYAdLXoDDDAKOXySrGRDz5y5c5xaCt+OXbtw5qC5JdCzf/cgnqysc55JQP1LDzYP UEog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ze59xLiTAJSzDVkiY1kAM7m1KT/ayX5lzJy7k2zz1E0=; b=SvYWssAF+DQK8V28TuRUaqC27oAPvp/6b3AJv76nocGaHtYPrSQkgA/gbgJyII6yFO dGY75+kWskMIWmYbgaAXQwFLhE9G6LIMQF3TX6AKv1I2fVCX7b71R0xps5RCjHh4ddSm GYmdsaCgBkHZBepCX7+p7GFJa+tamYAPlGa1Hn6XHm6AtF6AwDgIFUSfsmXDi37hwUcd iOOCWp1xkHRiCs42gwacJ+V5MqO6EXQTKnfkoFTr/Mzy9u7yY+e8507xUQLkJrlmvegr JZRtge3WWt9todSMDvM6UKp41ylHgXW0F2YT27WUP27IyAIkK36tp/Dd7/JQ8Pm/LiGf SQeA== X-Gm-Message-State: APjAAAV1p9tOaPeEz6Q4Igkd7/9f/CMC8DUszkHVUOK9lkeLTZgrzKAa XoQE9dKf827/njT8RlmEUfwwjmVc+XR9hmEfbeI= X-Google-Smtp-Source: APXvYqwjQjxv8G5Ads8QwxDVEai740q8qo4sFItXY/qwf3UdJyZiqRhV1s470G2PuGznsF7/7eniM0daOmayO59vUv8= X-Received: by 2002:a1c:486:: with SMTP id 128mr7008543wme.163.1578701875402; Fri, 10 Jan 2020 16:17:55 -0800 (PST) MIME-Version: 1.0 References: <20200109152028.28260-1-mario.kleiner.de@gmail.com> <20200109152028.28260-2-mario.kleiner.de@gmail.com> In-Reply-To: From: Alex Deucher Date: Fri, 10 Jan 2020 19:17:42 -0500 Message-ID: Subject: Re: [PATCH 1/2] drm/amd/display: Reorder detect_edp_sink_caps before link settings read. To: Harry Wentland X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mario.kleiner.de@gmail.de, Mario Kleiner , amd-gfx list , Maling list - DRI developers , Martin Leung , "Deucher, Alexander" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Applied. Thanks! Alex On Thu, Jan 9, 2020 at 1:41 PM Harry Wentland wrote: > > On 2020-01-09 10:20 a.m., Mario Kleiner wrote: > > read_current_link_settings_on_detect() on eDP 1.4+ may use the > > edp_supported_link_rates table which is set up by > > detect_edp_sink_caps(), so that function needs to be called first. > > > > Signed-off-by: Mario Kleiner > > Cc: Martin Leung > > Reviewed-by: Harry Wentland > > This also fixes our assumption that retrieve_link_cap is the first DPCD > reads we perform during detection. > > Harry > > > --- > > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > > index cef8c1ba9797..5ea4a1675259 100644 > > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c > > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > > @@ -817,8 +817,8 @@ static bool dc_link_detect_helper(struct dc_link *link, > > } > > > > case SIGNAL_TYPE_EDP: { > > - read_current_link_settings_on_detect(link); > > detect_edp_sink_caps(link); > > + read_current_link_settings_on_detect(link); > > sink_caps.transaction_type = DDC_TRANSACTION_TYPE_I2C_OVER_AUX; > > sink_caps.signal = SIGNAL_TYPE_EDP; > > break; > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx