From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D8DC433DF for ; Wed, 29 Jul 2020 13:49:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D5AB22CE3 for ; Wed, 29 Jul 2020 13:49:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kyntGUky" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726799AbgG2Nty (ORCPT ); Wed, 29 Jul 2020 09:49:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726054AbgG2Ntx (ORCPT ); Wed, 29 Jul 2020 09:49:53 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C463AC061794 for ; Wed, 29 Jul 2020 06:49:52 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id y3so21721708wrl.4 for ; Wed, 29 Jul 2020 06:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Et5z1sZLk52/qbAVghdHR+awPZijgneg8JJ3iKi6Rk8=; b=kyntGUkyFBHeFFulXmAK7oxUUkHGYZm466Zwno9ogC+/uNaltAeVLdoGuDUWI2FhBv /5e9KVb8f5DIKK9utWXmQ+6oX/j4pajp9xcjuyoIxCB7EYNM2lzQLmQinPyI+L76Ork4 I87E5McdibOS8eYKSE6Do5hYP5MlPH6oHVoLsloXyRa7Ot+awzgAbWVkc63iedz5xHyz TrQRxVy7TmyU33DKkbKJ8SK51km7qA6LuVaYvsoaSSBqgwNqIR13NPAsdhlikegwL5Vw iBsQLiAwD9wjdRES/NsnSjhyuEeF6stpWTGFfdB9oZJ/FTJ+aojYfTPhWAzmy1zQnPob my8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Et5z1sZLk52/qbAVghdHR+awPZijgneg8JJ3iKi6Rk8=; b=BGnUiTI208Jjj1hlkqgpvuX3VEAHru6I4p6vAvtqBbMcGySgHfQjuUSfqonj64EaXL aYiho5iZpxJ/Xust5pymwtAKtTR2LI3rnOgrAF8h2zBhVqekIyOJC6Zdz+oMJg0RjIh9 Mz0BgOfjmc+zIbUdrY/1+mezvse5YwaHlj2sPcG5cnTg7RdhPZUimZMGyCro2QL0MfQy 9jC4FcdFR2H2fky5wy52Bm4ibsm1Xl1b7F8d7tD8lDofBueR2mCh+FGVuw6Sy6rFRQ9X DTl1p0OH6k/tOdtt1doOvapylDXzksKHM81yF5EZ1T0PfgCxh+1NXVnbhHO2562lXlZ9 KANg== X-Gm-Message-State: AOAM532MFBM6ReasqYdryfO464NdkRpfmYuMi4je3fUOUPLdZMFcZh7C H+TO6RAdPJjCpElV3X2IA1FADViMaL8xoIh7aQ0= X-Google-Smtp-Source: ABdhPJywk6ijppdcoRlKnHHdOxSHVkyV9Agq0nu+FKodR1k6hExLtTGKd/4Lw5IfpryQJdNh1ud1q0KhoQPyi1x1Q0w= X-Received: by 2002:adf:a351:: with SMTP id d17mr29291191wrb.111.1596030591452; Wed, 29 Jul 2020 06:49:51 -0700 (PDT) MIME-Version: 1.0 References: <20200728192924.441570-1-yepeilin.cs@gmail.com> <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> In-Reply-To: <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> From: Alex Deucher Date: Wed, 29 Jul 2020 09:49:40 -0400 Message-ID: Subject: Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl() To: Christian Koenig Cc: Peilin Ye , Alex Deucher , David Airlie , Daniel Vetter , Leo Liu , Arnd Bergmann , Greg Kroah-Hartman , Felix Kuehling , LKML , amd-gfx list , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Hans de Goede , Trek , Maling list - DRI developers , Thomas Zimmermann , Evan Quan , linux-kernel-mentees@lists.linuxfoundation.org, Nicholas Kazlauskas , Dan Carpenter , Xiaojie Yuan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 29, 2020 at 4:11 AM Christian K=C3=B6nig wrote: > > Am 28.07.20 um 21:29 schrieb Peilin Ye: > > Compiler leaves a 4-byte hole near the end of `dev_info`, causing > > amdgpu_info_ioctl() to copy uninitialized kernel stack memory to usersp= ace > > when `size` is greater than 356. > > > > In 2015 we tried to fix this issue by doing `=3D {};` on `dev_info`, wh= ich > > unfortunately does not initialize that 4-byte hole. Fix it by using > > memset() instead. > > > > Cc: stable@vger.kernel.org > > Fixes: c193fa91b918 ("drm/amdgpu: information leak in amdgpu_info_ioctl= ()") > > Fixes: d38ceaf99ed0 ("drm/amdgpu: add core driver (v4)") > > Suggested-by: Dan Carpenter > > Signed-off-by: Peilin Ye > > Reviewed-by: Christian K=C3=B6nig > > I can't count how many of those we have fixed over the years. > > At some point we should probably document that using "=3D {}" or "=3D { 0= }" > in the kernel is a really bad idea and should be avoided. Moreover, it seems like different compilers seem to behave relatively differently with these and we often get reports of warnings with these on clang. When in doubt, memset. Alex > > Thanks, > Christian. > > > --- > > $ pahole -C "drm_amdgpu_info_device" drivers/gpu/drm/amd/amdgpu/amdgpu_= kms.o > > struct drm_amdgpu_info_device { > > __u32 device_id; /* 0 4 *= / > > __u32 chip_rev; /* 4 4 *= / > > __u32 external_rev; /* 8 4 *= / > > __u32 pci_rev; /* 12 4 *= / > > __u32 family; /* 16 4 *= / > > __u32 num_shader_engines; /* 20 4 *= / > > __u32 num_shader_arrays_per_engine; /* 24= 4 */ > > __u32 gpu_counter_freq; /* 28 4 *= / > > __u64 max_engine_clock; /* 32 8 *= / > > __u64 max_memory_clock; /* 40 8 *= / > > __u32 cu_active_number; /* 48 4 *= / > > __u32 cu_ao_mask; /* 52 4 *= / > > __u32 cu_bitmap[4][4]; /* 56 64 *= / > > /* --- cacheline 1 boundary (64 bytes) was 56 bytes ago --- */ > > __u32 enabled_rb_pipes_mask; /* 120 4 = */ > > __u32 num_rb_pipes; /* 124 4 *= / > > /* --- cacheline 2 boundary (128 bytes) --- */ > > __u32 num_hw_gfx_contexts; /* 128 4 *= / > > __u32 _pad; /* 132 4 *= / > > __u64 ids_flags; /* 136 8 *= / > > __u64 virtual_address_offset; /* 144 8= */ > > __u64 virtual_address_max; /* 152 8 *= / > > __u32 virtual_address_alignment; /* 160 = 4 */ > > __u32 pte_fragment_size; /* 164 4 *= / > > __u32 gart_page_size; /* 168 4 *= / > > __u32 ce_ram_size; /* 172 4 *= / > > __u32 vram_type; /* 176 4 *= / > > __u32 vram_bit_width; /* 180 4 *= / > > __u32 vce_harvest_config; /* 184 4 *= / > > __u32 gc_double_offchip_lds_buf; /* 188 = 4 */ > > /* --- cacheline 3 boundary (192 bytes) --- */ > > __u64 prim_buf_gpu_addr; /* 192 8 *= / > > __u64 pos_buf_gpu_addr; /* 200 8 *= / > > __u64 cntl_sb_buf_gpu_addr; /* 208 8 *= / > > __u64 param_buf_gpu_addr; /* 216 8 *= / > > __u32 prim_buf_size; /* 224 4 *= / > > __u32 pos_buf_size; /* 228 4 *= / > > __u32 cntl_sb_buf_size; /* 232 4 *= / > > __u32 param_buf_size; /* 236 4 *= / > > __u32 wave_front_size; /* 240 4 *= / > > __u32 num_shader_visible_vgprs; /* 244 = 4 */ > > __u32 num_cu_per_sh; /* 248 4 *= / > > __u32 num_tcc_blocks; /* 252 4 *= / > > /* --- cacheline 4 boundary (256 bytes) --- */ > > __u32 gs_vgt_table_depth; /* 256 4 *= / > > __u32 gs_prim_buffer_depth; /* 260 4 *= / > > __u32 max_gs_waves_per_vgt; /* 264 4 *= / > > __u32 _pad1; /* 268 4 *= / > > __u32 cu_ao_bitmap[4][4]; /* 272 64 *= / > > /* --- cacheline 5 boundary (320 bytes) was 16 bytes ago --- */ > > __u64 high_va_offset; /* 336 8 *= / > > __u64 high_va_max; /* 344 8 *= / > > __u32 pa_sc_tile_steering_override; /* 352= 4 */ > > > > /* XXX 4 bytes hole, try to pack */ > > > > __u64 tcc_disabled_mask; /* 360 8 *= / > > > > /* size: 368, cachelines: 6, members: 49 */ > > /* sum members: 364, holes: 1, sum holes: 4 */ > > /* last cacheline: 48 bytes */ > > }; > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/= amd/amdgpu/amdgpu_kms.c > > index a8c47aecd342..0047da06041f 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c > > @@ -707,9 +707,10 @@ static int amdgpu_info_ioctl(struct drm_device *de= v, void *data, struct drm_file > > return n ? -EFAULT : 0; > > } > > case AMDGPU_INFO_DEV_INFO: { > > - struct drm_amdgpu_info_device dev_info =3D {}; > > + struct drm_amdgpu_info_device dev_info; > > uint64_t vm_size; > > > > + memset(&dev_info, 0, sizeof(dev_info)); > > dev_info.device_id =3D dev->pdev->device; > > dev_info.chip_rev =3D adev->rev_id; > > dev_info.external_rev =3D adev->external_rev_id; > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42A23C433E0 for ; Wed, 29 Jul 2020 13:49:57 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 08D7922D00 for ; Wed, 29 Jul 2020 13:49:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kyntGUky" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 08D7922D00 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-kernel-mentees-bounces@lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id CB9C68671E; Wed, 29 Jul 2020 13:49:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id p5xFT6LzpWpI; Wed, 29 Jul 2020 13:49:55 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by fraxinus.osuosl.org (Postfix) with ESMTP id D13BD86702; Wed, 29 Jul 2020 13:49:55 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id B6DF2C0050; Wed, 29 Jul 2020 13:49:55 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id C0A8BC004D for ; Wed, 29 Jul 2020 13:49:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id ACCB588231 for ; Wed, 29 Jul 2020 13:49:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oixQrLLTT0cF for ; Wed, 29 Jul 2020 13:49:53 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by whitealder.osuosl.org (Postfix) with ESMTPS id 104F4881EC for ; Wed, 29 Jul 2020 13:49:53 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id b6so21711239wrs.11 for ; Wed, 29 Jul 2020 06:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Et5z1sZLk52/qbAVghdHR+awPZijgneg8JJ3iKi6Rk8=; b=kyntGUkyFBHeFFulXmAK7oxUUkHGYZm466Zwno9ogC+/uNaltAeVLdoGuDUWI2FhBv /5e9KVb8f5DIKK9utWXmQ+6oX/j4pajp9xcjuyoIxCB7EYNM2lzQLmQinPyI+L76Ork4 I87E5McdibOS8eYKSE6Do5hYP5MlPH6oHVoLsloXyRa7Ot+awzgAbWVkc63iedz5xHyz TrQRxVy7TmyU33DKkbKJ8SK51km7qA6LuVaYvsoaSSBqgwNqIR13NPAsdhlikegwL5Vw iBsQLiAwD9wjdRES/NsnSjhyuEeF6stpWTGFfdB9oZJ/FTJ+aojYfTPhWAzmy1zQnPob my8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Et5z1sZLk52/qbAVghdHR+awPZijgneg8JJ3iKi6Rk8=; b=UOQjDUtpZ6IzS5AV3e994J5PADrDgAF0UOkSvxrsiaZWT7ZctG/2cs3Wp7zKnMkGpz PsG/8N5znciwFI61Svz8wGtNlrc97rfG9ss96s01epBYsvLv0JwLX3tIYVOiJBBg87v9 fpdA7aylRamDoeI9lQs7DeUNwDCtzinUiX9CETAa5JbBmbwGhHxhobz6lYVFkl1Qoigz +rTeWSdkrAUwOOqOGsck2hcdTQbBYCARkliM5q/NDxsI5eFig9ChAzKbjMtaB8CP5ggp 2LxY7rE7sHtHqj6IQFi6xGPa168PCsvakM8yNbt+erI/CpCAp5WY3XSqY8z3HslLipzw UKZw== X-Gm-Message-State: AOAM530fnyAbaBboMXcoC186tS3ESEu1vdwqob1tUJV/bdCx9OtUyuq8 Bo+qP4Dhfsym4MGkXpKFxuDQOFdqyAfXGYHrkng= X-Google-Smtp-Source: ABdhPJywk6ijppdcoRlKnHHdOxSHVkyV9Agq0nu+FKodR1k6hExLtTGKd/4Lw5IfpryQJdNh1ud1q0KhoQPyi1x1Q0w= X-Received: by 2002:adf:a351:: with SMTP id d17mr29291191wrb.111.1596030591452; Wed, 29 Jul 2020 06:49:51 -0700 (PDT) MIME-Version: 1.0 References: <20200728192924.441570-1-yepeilin.cs@gmail.com> <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> In-Reply-To: <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> From: Alex Deucher Date: Wed, 29 Jul 2020 09:49:40 -0400 Message-ID: To: Christian Koenig Cc: Xiaojie Yuan , Thomas Zimmermann , Arnd Bergmann , David Airlie , Felix Kuehling , LKML , amd-gfx list , Nicholas Kazlauskas , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Hans de Goede , Trek , Maling list - DRI developers , Daniel Vetter , Alex Deucher , Evan Quan , Leo Liu , Peilin Ye , Dan Carpenter , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl() X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" T24gV2VkLCBKdWwgMjksIDIwMjAgYXQgNDoxMSBBTSBDaHJpc3RpYW4gS8O2bmlnCjxja29lbmln LmxlaWNodHp1bWVya2VuQGdtYWlsLmNvbT4gd3JvdGU6Cj4KPiBBbSAyOC4wNy4yMCB1bSAyMToy OSBzY2hyaWViIFBlaWxpbiBZZToKPiA+IENvbXBpbGVyIGxlYXZlcyBhIDQtYnl0ZSBob2xlIG5l YXIgdGhlIGVuZCBvZiBgZGV2X2luZm9gLCBjYXVzaW5nCj4gPiBhbWRncHVfaW5mb19pb2N0bCgp IHRvIGNvcHkgdW5pbml0aWFsaXplZCBrZXJuZWwgc3RhY2sgbWVtb3J5IHRvIHVzZXJzcGFjZQo+ ID4gd2hlbiBgc2l6ZWAgaXMgZ3JlYXRlciB0aGFuIDM1Ni4KPiA+Cj4gPiBJbiAyMDE1IHdlIHRy aWVkIHRvIGZpeCB0aGlzIGlzc3VlIGJ5IGRvaW5nIGA9IHt9O2Agb24gYGRldl9pbmZvYCwgd2hp Y2gKPiA+IHVuZm9ydHVuYXRlbHkgZG9lcyBub3QgaW5pdGlhbGl6ZSB0aGF0IDQtYnl0ZSBob2xl LiBGaXggaXQgYnkgdXNpbmcKPiA+IG1lbXNldCgpIGluc3RlYWQuCj4gPgo+ID4gQ2M6IHN0YWJs ZUB2Z2VyLmtlcm5lbC5vcmcKPiA+IEZpeGVzOiBjMTkzZmE5MWI5MTggKCJkcm0vYW1kZ3B1OiBp bmZvcm1hdGlvbiBsZWFrIGluIGFtZGdwdV9pbmZvX2lvY3RsKCkiKQo+ID4gRml4ZXM6IGQzOGNl YWY5OWVkMCAoImRybS9hbWRncHU6IGFkZCBjb3JlIGRyaXZlciAodjQpIikKPiA+IFN1Z2dlc3Rl ZC1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgo+ID4gU2lnbmVk LW9mZi1ieTogUGVpbGluIFllIDx5ZXBlaWxpbi5jc0BnbWFpbC5jb20+Cj4KPiBSZXZpZXdlZC1i eTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+Cj4gSSBjYW4n dCBjb3VudCBob3cgbWFueSBvZiB0aG9zZSB3ZSBoYXZlIGZpeGVkIG92ZXIgdGhlIHllYXJzLgo+ Cj4gQXQgc29tZSBwb2ludCB3ZSBzaG91bGQgcHJvYmFibHkgZG9jdW1lbnQgdGhhdCB1c2luZyAi PSB7fSIgb3IgIj0geyAwIH0iCj4gaW4gdGhlIGtlcm5lbCBpcyBhIHJlYWxseSBiYWQgaWRlYSBh bmQgc2hvdWxkIGJlIGF2b2lkZWQuCgpNb3Jlb3ZlciwgaXQgc2VlbXMgbGlrZSBkaWZmZXJlbnQg Y29tcGlsZXJzIHNlZW0gdG8gYmVoYXZlIHJlbGF0aXZlbHkKZGlmZmVyZW50bHkgd2l0aCB0aGVz ZSBhbmQgd2Ugb2Z0ZW4gZ2V0IHJlcG9ydHMgb2Ygd2FybmluZ3Mgd2l0aCB0aGVzZQpvbiBjbGFu Zy4gIFdoZW4gaW4gZG91YnQsIG1lbXNldC4KCkFsZXgKCj4KPiBUaGFua3MsCj4gQ2hyaXN0aWFu Lgo+Cj4gPiAtLS0KPiA+ICQgcGFob2xlIC1DICJkcm1fYW1kZ3B1X2luZm9fZGV2aWNlIiBkcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLm8KPiA+IHN0cnVjdCBkcm1fYW1kZ3B1 X2luZm9fZGV2aWNlIHsKPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGRldmlj ZV9pZDsgICAgICAgICAgICAvKiAgICAgMCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAg ICAgICAgICAgICAgICAgY2hpcF9yZXY7ICAgICAgICAgICAgIC8qICAgICA0ICAgICA0ICovCj4g PiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBleHRlcm5hbF9yZXY7ICAgICAgICAg LyogICAgIDggICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIHBj aV9yZXY7ICAgICAgICAgICAgICAvKiAgICAxMiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAg ICAgICAgICAgICAgICAgICAgZmFtaWx5OyAgICAgICAgICAgICAgIC8qICAgIDE2ICAgICA0ICov Cj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBudW1fc2hhZGVyX2VuZ2luZXM7 ICAgLyogICAgMjAgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAg IG51bV9zaGFkZXJfYXJyYXlzX3Blcl9lbmdpbmU7IC8qICAgIDI0ICAgICA0ICovCj4gPiAgICAg ICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBncHVfY291bnRlcl9mcmVxOyAgICAgLyogICAg MjggICAgIDQgKi8KPiA+ICAgICAgIF9fdTY0ICAgICAgICAgICAgICAgICAgICAgIG1heF9lbmdp bmVfY2xvY2s7ICAgICAvKiAgICAzMiAgICAgOCAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAg ICAgICAgICAgICAgbWF4X21lbW9yeV9jbG9jazsgICAgIC8qICAgIDQwICAgICA4ICovCj4gPiAg ICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBjdV9hY3RpdmVfbnVtYmVyOyAgICAgLyog ICAgNDggICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGN1X2Fv X21hc2s7ICAgICAgICAgICAvKiAgICA1MiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAg ICAgICAgICAgICAgICAgY3VfYml0bWFwWzRdWzRdOyAgICAgIC8qICAgIDU2ICAgIDY0ICovCj4g PiAgICAgICAvKiAtLS0gY2FjaGVsaW5lIDEgYm91bmRhcnkgKDY0IGJ5dGVzKSB3YXMgNTYgYnl0 ZXMgYWdvIC0tLSAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZW5hYmxl ZF9yYl9waXBlc19tYXNrOyAvKiAgIDEyMCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAg ICAgICAgICAgICAgICAgbnVtX3JiX3BpcGVzOyAgICAgICAgIC8qICAgMTI0ICAgICA0ICovCj4g PiAgICAgICAvKiAtLS0gY2FjaGVsaW5lIDIgYm91bmRhcnkgKDEyOCBieXRlcykgLS0tICovCj4g PiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBudW1faHdfZ2Z4X2NvbnRleHRzOyAg LyogICAxMjggICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIF9w YWQ7ICAgICAgICAgICAgICAgICAvKiAgIDEzMiAgICAgNCAqLwo+ID4gICAgICAgX191NjQgICAg ICAgICAgICAgICAgICAgICAgaWRzX2ZsYWdzOyAgICAgICAgICAgIC8qICAgMTM2ICAgICA4ICov Cj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAgICAgICB2aXJ0dWFsX2FkZHJlc3Nfb2Zm c2V0OyAvKiAgIDE0NCAgICAgOCAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAgICAgICAgICAg ICAgdmlydHVhbF9hZGRyZXNzX21heDsgIC8qICAgMTUyICAgICA4ICovCj4gPiAgICAgICBfX3Uz MiAgICAgICAgICAgICAgICAgICAgICB2aXJ0dWFsX2FkZHJlc3NfYWxpZ25tZW50OyAvKiAgIDE2 MCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgcHRlX2ZyYWdt ZW50X3NpemU7ICAgIC8qICAgMTY0ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICBnYXJ0X3BhZ2Vfc2l6ZTsgICAgICAgLyogICAxNjggICAgIDQgKi8KPiA+ICAg ICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGNlX3JhbV9zaXplOyAgICAgICAgICAvKiAg IDE3MiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgdnJhbV90 eXBlOyAgICAgICAgICAgIC8qICAgMTc2ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAg ICAgICAgICAgICAgICB2cmFtX2JpdF93aWR0aDsgICAgICAgLyogICAxODAgICAgIDQgKi8KPiA+ ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIHZjZV9oYXJ2ZXN0X2NvbmZpZzsgICAv KiAgIDE4NCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZ2Nf ZG91YmxlX29mZmNoaXBfbGRzX2J1ZjsgLyogICAxODggICAgIDQgKi8KPiA+ICAgICAgIC8qIC0t LSBjYWNoZWxpbmUgMyBib3VuZGFyeSAoMTkyIGJ5dGVzKSAtLS0gKi8KPiA+ICAgICAgIF9fdTY0 ICAgICAgICAgICAgICAgICAgICAgIHByaW1fYnVmX2dwdV9hZGRyOyAgICAvKiAgIDE5MiAgICAg OCAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAgICAgICAgICAgICAgcG9zX2J1Zl9ncHVfYWRk cjsgICAgIC8qICAgMjAwICAgICA4ICovCj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAg ICAgICBjbnRsX3NiX2J1Zl9ncHVfYWRkcjsgLyogICAyMDggICAgIDggKi8KPiA+ICAgICAgIF9f dTY0ICAgICAgICAgICAgICAgICAgICAgIHBhcmFtX2J1Zl9ncHVfYWRkcjsgICAvKiAgIDIxNiAg ICAgOCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgcHJpbV9idWZfc2l6 ZTsgICAgICAgIC8qICAgMjI0ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAg ICAgICAgICBwb3NfYnVmX3NpemU7ICAgICAgICAgLyogICAyMjggICAgIDQgKi8KPiA+ICAgICAg IF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGNudGxfc2JfYnVmX3NpemU7ICAgICAvKiAgIDIz MiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgcGFyYW1fYnVm X3NpemU7ICAgICAgIC8qICAgMjM2ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICB3YXZlX2Zyb250X3NpemU7ICAgICAgLyogICAyNDAgICAgIDQgKi8KPiA+ICAg ICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG51bV9zaGFkZXJfdmlzaWJsZV92Z3Byczsg LyogICAyNDQgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG51 bV9jdV9wZXJfc2g7ICAgICAgICAvKiAgIDI0OCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAg ICAgICAgICAgICAgICAgICAgbnVtX3RjY19ibG9ja3M7ICAgICAgIC8qICAgMjUyICAgICA0ICov Cj4gPiAgICAgICAvKiAtLS0gY2FjaGVsaW5lIDQgYm91bmRhcnkgKDI1NiBieXRlcykgLS0tICov Cj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBnc192Z3RfdGFibGVfZGVwdGg7 ICAgLyogICAyNTYgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAg IGdzX3ByaW1fYnVmZmVyX2RlcHRoOyAvKiAgIDI2MCAgICAgNCAqLwo+ID4gICAgICAgX191MzIg ICAgICAgICAgICAgICAgICAgICAgbWF4X2dzX3dhdmVzX3Blcl92Z3Q7IC8qICAgMjY0ICAgICA0 ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBfcGFkMTsgICAgICAgICAg ICAgICAgLyogICAyNjggICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAg ICAgIGN1X2FvX2JpdG1hcFs0XVs0XTsgICAvKiAgIDI3MiAgICA2NCAqLwo+ID4gICAgICAgLyog LS0tIGNhY2hlbGluZSA1IGJvdW5kYXJ5ICgzMjAgYnl0ZXMpIHdhcyAxNiBieXRlcyBhZ28gLS0t ICovCj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAgICAgICBoaWdoX3ZhX29mZnNldDsg ICAgICAgLyogICAzMzYgICAgIDggKi8KPiA+ICAgICAgIF9fdTY0ICAgICAgICAgICAgICAgICAg ICAgIGhpZ2hfdmFfbWF4OyAgICAgICAgICAvKiAgIDM0NCAgICAgOCAqLwo+ID4gICAgICAgX191 MzIgICAgICAgICAgICAgICAgICAgICAgcGFfc2NfdGlsZV9zdGVlcmluZ19vdmVycmlkZTsgLyog ICAzNTIgICAgIDQgKi8KPiA+Cj4gPiAgICAgICAvKiBYWFggNCBieXRlcyBob2xlLCB0cnkgdG8g cGFjayAqLwo+ID4KPiA+ICAgICAgIF9fdTY0ICAgICAgICAgICAgICAgICAgICAgIHRjY19kaXNh YmxlZF9tYXNrOyAgICAvKiAgIDM2MCAgICAgOCAqLwo+ID4KPiA+ICAgICAgIC8qIHNpemU6IDM2 OCwgY2FjaGVsaW5lczogNiwgbWVtYmVyczogNDkgKi8KPiA+ICAgICAgIC8qIHN1bSBtZW1iZXJz OiAzNjQsIGhvbGVzOiAxLCBzdW0gaG9sZXM6IDQgKi8KPiA+ICAgICAgIC8qIGxhc3QgY2FjaGVs aW5lOiA0OCBieXRlcyAqLwo+ID4gfTsKPiA+Cj4gPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9rbXMuYyB8IDMgKystCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X2ttcy5jCj4gPiBpbmRleCBhOGM0N2FlY2QzNDIuLjAwNDdkYTA2MDQxZiAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9rbXMuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5jCj4gPiBAQCAtNzA3LDkgKzcw NywxMCBAQCBzdGF0aWMgaW50IGFtZGdwdV9pbmZvX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIHZvaWQgKmRhdGEsIHN0cnVjdCBkcm1fZmlsZQo+ID4gICAgICAgICAgICAgICByZXR1cm4g biA/IC1FRkFVTFQgOiAwOwo+ID4gICAgICAgfQo+ID4gICAgICAgY2FzZSBBTURHUFVfSU5GT19E RVZfSU5GTzogewo+ID4gLSAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2FtZGdwdV9pbmZvX2Rldmlj ZSBkZXZfaW5mbyA9IHt9Owo+ID4gKyAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2FtZGdwdV9pbmZv X2RldmljZSBkZXZfaW5mbzsKPiA+ICAgICAgICAgICAgICAgdWludDY0X3Qgdm1fc2l6ZTsKPiA+ Cj4gPiArICAgICAgICAgICAgIG1lbXNldCgmZGV2X2luZm8sIDAsIHNpemVvZihkZXZfaW5mbykp Owo+ID4gICAgICAgICAgICAgICBkZXZfaW5mby5kZXZpY2VfaWQgPSBkZXYtPnBkZXYtPmRldmlj ZTsKPiA+ICAgICAgICAgICAgICAgZGV2X2luZm8uY2hpcF9yZXYgPSBhZGV2LT5yZXZfaWQ7Cj4g PiAgICAgICAgICAgICAgIGRldl9pbmZvLmV4dGVybmFsX3JldiA9IGFkZXYtPmV4dGVybmFsX3Jl dl9pZDsKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gYW1kLWdmeCBtYWlsaW5nIGxpc3QKPiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1rZXJu ZWwtbWVudGVlcyBtYWlsaW5nIGxpc3QKTGludXgta2VybmVsLW1lbnRlZXNAbGlzdHMubGludXhm b3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1rZXJuZWwtbWVudGVlcwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 385D8C433E3 for ; Wed, 29 Jul 2020 13:49:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A50F22CE3 for ; Wed, 29 Jul 2020 13:49:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kyntGUky" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A50F22CE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1C956E520; Wed, 29 Jul 2020 13:49:54 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5E126E51B; Wed, 29 Jul 2020 13:49:52 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id r2so16631173wrs.8; Wed, 29 Jul 2020 06:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Et5z1sZLk52/qbAVghdHR+awPZijgneg8JJ3iKi6Rk8=; b=kyntGUkyFBHeFFulXmAK7oxUUkHGYZm466Zwno9ogC+/uNaltAeVLdoGuDUWI2FhBv /5e9KVb8f5DIKK9utWXmQ+6oX/j4pajp9xcjuyoIxCB7EYNM2lzQLmQinPyI+L76Ork4 I87E5McdibOS8eYKSE6Do5hYP5MlPH6oHVoLsloXyRa7Ot+awzgAbWVkc63iedz5xHyz TrQRxVy7TmyU33DKkbKJ8SK51km7qA6LuVaYvsoaSSBqgwNqIR13NPAsdhlikegwL5Vw iBsQLiAwD9wjdRES/NsnSjhyuEeF6stpWTGFfdB9oZJ/FTJ+aojYfTPhWAzmy1zQnPob my8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Et5z1sZLk52/qbAVghdHR+awPZijgneg8JJ3iKi6Rk8=; b=HJoK+MIzNjp3iiWcbvp/okY7YrkfDFdEh976VE3r5zadNIyo8nVmmJLKNpJkYI/6HR MmMm5ck14dMlzpGPeXPk1mVTbFTVNoPUA2IT9DPlT7dR80OhZ/hOoy9zGfzrRJBtgwvk ZB8MKUAjDKEhcVxInwijRGxySFxeSOEHfNhcnQUjsqXmjRLKAq6iqeKqGv5YxYl909Wd T5YgkIJX66owxloMSV9nJD1z/83u8tKoz7JjYtefs2qD+BSaH0CGDVOYeHz+Nb9xWmvA Gu9BMMMftLauEJX4jrdpXd2Gxts2aczzboMzAZZRgVIgL5+Ae5hSm9rXqL/L2VqypZyK t/sg== X-Gm-Message-State: AOAM5300yRBFwMBuC0JuE+vXggEO8TwTdEPiH3ZKnJA9RO9Ic2ezqOlT 4XJ8VzQf+Gf70OSTLbCJYTgljg1dM/uqZ73QNcc= X-Google-Smtp-Source: ABdhPJywk6ijppdcoRlKnHHdOxSHVkyV9Agq0nu+FKodR1k6hExLtTGKd/4Lw5IfpryQJdNh1ud1q0KhoQPyi1x1Q0w= X-Received: by 2002:adf:a351:: with SMTP id d17mr29291191wrb.111.1596030591452; Wed, 29 Jul 2020 06:49:51 -0700 (PDT) MIME-Version: 1.0 References: <20200728192924.441570-1-yepeilin.cs@gmail.com> <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> In-Reply-To: <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> From: Alex Deucher Date: Wed, 29 Jul 2020 09:49:40 -0400 Message-ID: Subject: Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl() To: Christian Koenig X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiaojie Yuan , Thomas Zimmermann , Arnd Bergmann , David Airlie , Greg Kroah-Hartman , Felix Kuehling , LKML , amd-gfx list , Nicholas Kazlauskas , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Hans de Goede , Trek , Maling list - DRI developers , Alex Deucher , Evan Quan , Leo Liu , Peilin Ye , Dan Carpenter , linux-kernel-mentees@lists.linuxfoundation.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCBKdWwgMjksIDIwMjAgYXQgNDoxMSBBTSBDaHJpc3RpYW4gS8O2bmlnCjxja29lbmln LmxlaWNodHp1bWVya2VuQGdtYWlsLmNvbT4gd3JvdGU6Cj4KPiBBbSAyOC4wNy4yMCB1bSAyMToy OSBzY2hyaWViIFBlaWxpbiBZZToKPiA+IENvbXBpbGVyIGxlYXZlcyBhIDQtYnl0ZSBob2xlIG5l YXIgdGhlIGVuZCBvZiBgZGV2X2luZm9gLCBjYXVzaW5nCj4gPiBhbWRncHVfaW5mb19pb2N0bCgp IHRvIGNvcHkgdW5pbml0aWFsaXplZCBrZXJuZWwgc3RhY2sgbWVtb3J5IHRvIHVzZXJzcGFjZQo+ ID4gd2hlbiBgc2l6ZWAgaXMgZ3JlYXRlciB0aGFuIDM1Ni4KPiA+Cj4gPiBJbiAyMDE1IHdlIHRy aWVkIHRvIGZpeCB0aGlzIGlzc3VlIGJ5IGRvaW5nIGA9IHt9O2Agb24gYGRldl9pbmZvYCwgd2hp Y2gKPiA+IHVuZm9ydHVuYXRlbHkgZG9lcyBub3QgaW5pdGlhbGl6ZSB0aGF0IDQtYnl0ZSBob2xl LiBGaXggaXQgYnkgdXNpbmcKPiA+IG1lbXNldCgpIGluc3RlYWQuCj4gPgo+ID4gQ2M6IHN0YWJs ZUB2Z2VyLmtlcm5lbC5vcmcKPiA+IEZpeGVzOiBjMTkzZmE5MWI5MTggKCJkcm0vYW1kZ3B1OiBp bmZvcm1hdGlvbiBsZWFrIGluIGFtZGdwdV9pbmZvX2lvY3RsKCkiKQo+ID4gRml4ZXM6IGQzOGNl YWY5OWVkMCAoImRybS9hbWRncHU6IGFkZCBjb3JlIGRyaXZlciAodjQpIikKPiA+IFN1Z2dlc3Rl ZC1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgo+ID4gU2lnbmVk LW9mZi1ieTogUGVpbGluIFllIDx5ZXBlaWxpbi5jc0BnbWFpbC5jb20+Cj4KPiBSZXZpZXdlZC1i eTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+Cj4gSSBjYW4n dCBjb3VudCBob3cgbWFueSBvZiB0aG9zZSB3ZSBoYXZlIGZpeGVkIG92ZXIgdGhlIHllYXJzLgo+ Cj4gQXQgc29tZSBwb2ludCB3ZSBzaG91bGQgcHJvYmFibHkgZG9jdW1lbnQgdGhhdCB1c2luZyAi PSB7fSIgb3IgIj0geyAwIH0iCj4gaW4gdGhlIGtlcm5lbCBpcyBhIHJlYWxseSBiYWQgaWRlYSBh bmQgc2hvdWxkIGJlIGF2b2lkZWQuCgpNb3Jlb3ZlciwgaXQgc2VlbXMgbGlrZSBkaWZmZXJlbnQg Y29tcGlsZXJzIHNlZW0gdG8gYmVoYXZlIHJlbGF0aXZlbHkKZGlmZmVyZW50bHkgd2l0aCB0aGVz ZSBhbmQgd2Ugb2Z0ZW4gZ2V0IHJlcG9ydHMgb2Ygd2FybmluZ3Mgd2l0aCB0aGVzZQpvbiBjbGFu Zy4gIFdoZW4gaW4gZG91YnQsIG1lbXNldC4KCkFsZXgKCj4KPiBUaGFua3MsCj4gQ2hyaXN0aWFu Lgo+Cj4gPiAtLS0KPiA+ICQgcGFob2xlIC1DICJkcm1fYW1kZ3B1X2luZm9fZGV2aWNlIiBkcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLm8KPiA+IHN0cnVjdCBkcm1fYW1kZ3B1 X2luZm9fZGV2aWNlIHsKPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGRldmlj ZV9pZDsgICAgICAgICAgICAvKiAgICAgMCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAg ICAgICAgICAgICAgICAgY2hpcF9yZXY7ICAgICAgICAgICAgIC8qICAgICA0ICAgICA0ICovCj4g PiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBleHRlcm5hbF9yZXY7ICAgICAgICAg LyogICAgIDggICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIHBj aV9yZXY7ICAgICAgICAgICAgICAvKiAgICAxMiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAg ICAgICAgICAgICAgICAgICAgZmFtaWx5OyAgICAgICAgICAgICAgIC8qICAgIDE2ICAgICA0ICov Cj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBudW1fc2hhZGVyX2VuZ2luZXM7 ICAgLyogICAgMjAgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAg IG51bV9zaGFkZXJfYXJyYXlzX3Blcl9lbmdpbmU7IC8qICAgIDI0ICAgICA0ICovCj4gPiAgICAg ICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBncHVfY291bnRlcl9mcmVxOyAgICAgLyogICAg MjggICAgIDQgKi8KPiA+ICAgICAgIF9fdTY0ICAgICAgICAgICAgICAgICAgICAgIG1heF9lbmdp bmVfY2xvY2s7ICAgICAvKiAgICAzMiAgICAgOCAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAg ICAgICAgICAgICAgbWF4X21lbW9yeV9jbG9jazsgICAgIC8qICAgIDQwICAgICA4ICovCj4gPiAg ICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBjdV9hY3RpdmVfbnVtYmVyOyAgICAgLyog ICAgNDggICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGN1X2Fv X21hc2s7ICAgICAgICAgICAvKiAgICA1MiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAg ICAgICAgICAgICAgICAgY3VfYml0bWFwWzRdWzRdOyAgICAgIC8qICAgIDU2ICAgIDY0ICovCj4g PiAgICAgICAvKiAtLS0gY2FjaGVsaW5lIDEgYm91bmRhcnkgKDY0IGJ5dGVzKSB3YXMgNTYgYnl0 ZXMgYWdvIC0tLSAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZW5hYmxl ZF9yYl9waXBlc19tYXNrOyAvKiAgIDEyMCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAg ICAgICAgICAgICAgICAgbnVtX3JiX3BpcGVzOyAgICAgICAgIC8qICAgMTI0ICAgICA0ICovCj4g PiAgICAgICAvKiAtLS0gY2FjaGVsaW5lIDIgYm91bmRhcnkgKDEyOCBieXRlcykgLS0tICovCj4g PiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBudW1faHdfZ2Z4X2NvbnRleHRzOyAg LyogICAxMjggICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIF9w YWQ7ICAgICAgICAgICAgICAgICAvKiAgIDEzMiAgICAgNCAqLwo+ID4gICAgICAgX191NjQgICAg ICAgICAgICAgICAgICAgICAgaWRzX2ZsYWdzOyAgICAgICAgICAgIC8qICAgMTM2ICAgICA4ICov Cj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAgICAgICB2aXJ0dWFsX2FkZHJlc3Nfb2Zm c2V0OyAvKiAgIDE0NCAgICAgOCAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAgICAgICAgICAg ICAgdmlydHVhbF9hZGRyZXNzX21heDsgIC8qICAgMTUyICAgICA4ICovCj4gPiAgICAgICBfX3Uz MiAgICAgICAgICAgICAgICAgICAgICB2aXJ0dWFsX2FkZHJlc3NfYWxpZ25tZW50OyAvKiAgIDE2 MCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgcHRlX2ZyYWdt ZW50X3NpemU7ICAgIC8qICAgMTY0ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICBnYXJ0X3BhZ2Vfc2l6ZTsgICAgICAgLyogICAxNjggICAgIDQgKi8KPiA+ICAg ICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGNlX3JhbV9zaXplOyAgICAgICAgICAvKiAg IDE3MiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgdnJhbV90 eXBlOyAgICAgICAgICAgIC8qICAgMTc2ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAg ICAgICAgICAgICAgICB2cmFtX2JpdF93aWR0aDsgICAgICAgLyogICAxODAgICAgIDQgKi8KPiA+ ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIHZjZV9oYXJ2ZXN0X2NvbmZpZzsgICAv KiAgIDE4NCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZ2Nf ZG91YmxlX29mZmNoaXBfbGRzX2J1ZjsgLyogICAxODggICAgIDQgKi8KPiA+ICAgICAgIC8qIC0t LSBjYWNoZWxpbmUgMyBib3VuZGFyeSAoMTkyIGJ5dGVzKSAtLS0gKi8KPiA+ICAgICAgIF9fdTY0 ICAgICAgICAgICAgICAgICAgICAgIHByaW1fYnVmX2dwdV9hZGRyOyAgICAvKiAgIDE5MiAgICAg OCAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAgICAgICAgICAgICAgcG9zX2J1Zl9ncHVfYWRk cjsgICAgIC8qICAgMjAwICAgICA4ICovCj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAg ICAgICBjbnRsX3NiX2J1Zl9ncHVfYWRkcjsgLyogICAyMDggICAgIDggKi8KPiA+ICAgICAgIF9f dTY0ICAgICAgICAgICAgICAgICAgICAgIHBhcmFtX2J1Zl9ncHVfYWRkcjsgICAvKiAgIDIxNiAg ICAgOCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgcHJpbV9idWZfc2l6 ZTsgICAgICAgIC8qICAgMjI0ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAg ICAgICAgICBwb3NfYnVmX3NpemU7ICAgICAgICAgLyogICAyMjggICAgIDQgKi8KPiA+ICAgICAg IF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGNudGxfc2JfYnVmX3NpemU7ICAgICAvKiAgIDIz MiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgcGFyYW1fYnVm X3NpemU7ICAgICAgIC8qICAgMjM2ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICB3YXZlX2Zyb250X3NpemU7ICAgICAgLyogICAyNDAgICAgIDQgKi8KPiA+ICAg ICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG51bV9zaGFkZXJfdmlzaWJsZV92Z3Byczsg LyogICAyNDQgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG51 bV9jdV9wZXJfc2g7ICAgICAgICAvKiAgIDI0OCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAg ICAgICAgICAgICAgICAgICAgbnVtX3RjY19ibG9ja3M7ICAgICAgIC8qICAgMjUyICAgICA0ICov Cj4gPiAgICAgICAvKiAtLS0gY2FjaGVsaW5lIDQgYm91bmRhcnkgKDI1NiBieXRlcykgLS0tICov Cj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBnc192Z3RfdGFibGVfZGVwdGg7 ICAgLyogICAyNTYgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAg IGdzX3ByaW1fYnVmZmVyX2RlcHRoOyAvKiAgIDI2MCAgICAgNCAqLwo+ID4gICAgICAgX191MzIg ICAgICAgICAgICAgICAgICAgICAgbWF4X2dzX3dhdmVzX3Blcl92Z3Q7IC8qICAgMjY0ICAgICA0 ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBfcGFkMTsgICAgICAgICAg ICAgICAgLyogICAyNjggICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAg ICAgIGN1X2FvX2JpdG1hcFs0XVs0XTsgICAvKiAgIDI3MiAgICA2NCAqLwo+ID4gICAgICAgLyog LS0tIGNhY2hlbGluZSA1IGJvdW5kYXJ5ICgzMjAgYnl0ZXMpIHdhcyAxNiBieXRlcyBhZ28gLS0t ICovCj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAgICAgICBoaWdoX3ZhX29mZnNldDsg ICAgICAgLyogICAzMzYgICAgIDggKi8KPiA+ICAgICAgIF9fdTY0ICAgICAgICAgICAgICAgICAg ICAgIGhpZ2hfdmFfbWF4OyAgICAgICAgICAvKiAgIDM0NCAgICAgOCAqLwo+ID4gICAgICAgX191 MzIgICAgICAgICAgICAgICAgICAgICAgcGFfc2NfdGlsZV9zdGVlcmluZ19vdmVycmlkZTsgLyog ICAzNTIgICAgIDQgKi8KPiA+Cj4gPiAgICAgICAvKiBYWFggNCBieXRlcyBob2xlLCB0cnkgdG8g cGFjayAqLwo+ID4KPiA+ICAgICAgIF9fdTY0ICAgICAgICAgICAgICAgICAgICAgIHRjY19kaXNh YmxlZF9tYXNrOyAgICAvKiAgIDM2MCAgICAgOCAqLwo+ID4KPiA+ICAgICAgIC8qIHNpemU6IDM2 OCwgY2FjaGVsaW5lczogNiwgbWVtYmVyczogNDkgKi8KPiA+ICAgICAgIC8qIHN1bSBtZW1iZXJz OiAzNjQsIGhvbGVzOiAxLCBzdW0gaG9sZXM6IDQgKi8KPiA+ICAgICAgIC8qIGxhc3QgY2FjaGVs aW5lOiA0OCBieXRlcyAqLwo+ID4gfTsKPiA+Cj4gPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9rbXMuYyB8IDMgKystCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X2ttcy5jCj4gPiBpbmRleCBhOGM0N2FlY2QzNDIuLjAwNDdkYTA2MDQxZiAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9rbXMuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5jCj4gPiBAQCAtNzA3LDkgKzcw NywxMCBAQCBzdGF0aWMgaW50IGFtZGdwdV9pbmZvX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIHZvaWQgKmRhdGEsIHN0cnVjdCBkcm1fZmlsZQo+ID4gICAgICAgICAgICAgICByZXR1cm4g biA/IC1FRkFVTFQgOiAwOwo+ID4gICAgICAgfQo+ID4gICAgICAgY2FzZSBBTURHUFVfSU5GT19E RVZfSU5GTzogewo+ID4gLSAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2FtZGdwdV9pbmZvX2Rldmlj ZSBkZXZfaW5mbyA9IHt9Owo+ID4gKyAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2FtZGdwdV9pbmZv X2RldmljZSBkZXZfaW5mbzsKPiA+ICAgICAgICAgICAgICAgdWludDY0X3Qgdm1fc2l6ZTsKPiA+ Cj4gPiArICAgICAgICAgICAgIG1lbXNldCgmZGV2X2luZm8sIDAsIHNpemVvZihkZXZfaW5mbykp Owo+ID4gICAgICAgICAgICAgICBkZXZfaW5mby5kZXZpY2VfaWQgPSBkZXYtPnBkZXYtPmRldmlj ZTsKPiA+ICAgICAgICAgICAgICAgZGV2X2luZm8uY2hpcF9yZXYgPSBhZGV2LT5yZXZfaWQ7Cj4g PiAgICAgICAgICAgICAgIGRldl9pbmZvLmV4dGVybmFsX3JldiA9IGFkZXYtPmV4dGVybmFsX3Jl dl9pZDsKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gYW1kLWdmeCBtYWlsaW5nIGxpc3QKPiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwg bWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BF8DC433E0 for ; Wed, 29 Jul 2020 13:49:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E5FE22BEB for ; Wed, 29 Jul 2020 13:49:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kyntGUky" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E5FE22BEB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1B6176E51B; Wed, 29 Jul 2020 13:49:54 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5E126E51B; Wed, 29 Jul 2020 13:49:52 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id r2so16631173wrs.8; Wed, 29 Jul 2020 06:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Et5z1sZLk52/qbAVghdHR+awPZijgneg8JJ3iKi6Rk8=; b=kyntGUkyFBHeFFulXmAK7oxUUkHGYZm466Zwno9ogC+/uNaltAeVLdoGuDUWI2FhBv /5e9KVb8f5DIKK9utWXmQ+6oX/j4pajp9xcjuyoIxCB7EYNM2lzQLmQinPyI+L76Ork4 I87E5McdibOS8eYKSE6Do5hYP5MlPH6oHVoLsloXyRa7Ot+awzgAbWVkc63iedz5xHyz TrQRxVy7TmyU33DKkbKJ8SK51km7qA6LuVaYvsoaSSBqgwNqIR13NPAsdhlikegwL5Vw iBsQLiAwD9wjdRES/NsnSjhyuEeF6stpWTGFfdB9oZJ/FTJ+aojYfTPhWAzmy1zQnPob my8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Et5z1sZLk52/qbAVghdHR+awPZijgneg8JJ3iKi6Rk8=; b=HJoK+MIzNjp3iiWcbvp/okY7YrkfDFdEh976VE3r5zadNIyo8nVmmJLKNpJkYI/6HR MmMm5ck14dMlzpGPeXPk1mVTbFTVNoPUA2IT9DPlT7dR80OhZ/hOoy9zGfzrRJBtgwvk ZB8MKUAjDKEhcVxInwijRGxySFxeSOEHfNhcnQUjsqXmjRLKAq6iqeKqGv5YxYl909Wd T5YgkIJX66owxloMSV9nJD1z/83u8tKoz7JjYtefs2qD+BSaH0CGDVOYeHz+Nb9xWmvA Gu9BMMMftLauEJX4jrdpXd2Gxts2aczzboMzAZZRgVIgL5+Ae5hSm9rXqL/L2VqypZyK t/sg== X-Gm-Message-State: AOAM5300yRBFwMBuC0JuE+vXggEO8TwTdEPiH3ZKnJA9RO9Ic2ezqOlT 4XJ8VzQf+Gf70OSTLbCJYTgljg1dM/uqZ73QNcc= X-Google-Smtp-Source: ABdhPJywk6ijppdcoRlKnHHdOxSHVkyV9Agq0nu+FKodR1k6hExLtTGKd/4Lw5IfpryQJdNh1ud1q0KhoQPyi1x1Q0w= X-Received: by 2002:adf:a351:: with SMTP id d17mr29291191wrb.111.1596030591452; Wed, 29 Jul 2020 06:49:51 -0700 (PDT) MIME-Version: 1.0 References: <20200728192924.441570-1-yepeilin.cs@gmail.com> <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> In-Reply-To: <30b2a31f-77c2-56c1-ecde-875c6eea99d5@gmail.com> From: Alex Deucher Date: Wed, 29 Jul 2020 09:49:40 -0400 Message-ID: Subject: Re: [Linux-kernel-mentees] [PATCH] drm/amdgpu: Prevent kernel-infoleak in amdgpu_info_ioctl() To: Christian Koenig X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Xiaojie Yuan , Thomas Zimmermann , Arnd Bergmann , David Airlie , Greg Kroah-Hartman , Felix Kuehling , LKML , amd-gfx list , Nicholas Kazlauskas , =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= , Hans de Goede , Trek , Maling list - DRI developers , Daniel Vetter , Alex Deucher , Evan Quan , Leo Liu , Peilin Ye , Dan Carpenter , linux-kernel-mentees@lists.linuxfoundation.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gV2VkLCBKdWwgMjksIDIwMjAgYXQgNDoxMSBBTSBDaHJpc3RpYW4gS8O2bmlnCjxja29lbmln LmxlaWNodHp1bWVya2VuQGdtYWlsLmNvbT4gd3JvdGU6Cj4KPiBBbSAyOC4wNy4yMCB1bSAyMToy OSBzY2hyaWViIFBlaWxpbiBZZToKPiA+IENvbXBpbGVyIGxlYXZlcyBhIDQtYnl0ZSBob2xlIG5l YXIgdGhlIGVuZCBvZiBgZGV2X2luZm9gLCBjYXVzaW5nCj4gPiBhbWRncHVfaW5mb19pb2N0bCgp IHRvIGNvcHkgdW5pbml0aWFsaXplZCBrZXJuZWwgc3RhY2sgbWVtb3J5IHRvIHVzZXJzcGFjZQo+ ID4gd2hlbiBgc2l6ZWAgaXMgZ3JlYXRlciB0aGFuIDM1Ni4KPiA+Cj4gPiBJbiAyMDE1IHdlIHRy aWVkIHRvIGZpeCB0aGlzIGlzc3VlIGJ5IGRvaW5nIGA9IHt9O2Agb24gYGRldl9pbmZvYCwgd2hp Y2gKPiA+IHVuZm9ydHVuYXRlbHkgZG9lcyBub3QgaW5pdGlhbGl6ZSB0aGF0IDQtYnl0ZSBob2xl LiBGaXggaXQgYnkgdXNpbmcKPiA+IG1lbXNldCgpIGluc3RlYWQuCj4gPgo+ID4gQ2M6IHN0YWJs ZUB2Z2VyLmtlcm5lbC5vcmcKPiA+IEZpeGVzOiBjMTkzZmE5MWI5MTggKCJkcm0vYW1kZ3B1OiBp bmZvcm1hdGlvbiBsZWFrIGluIGFtZGdwdV9pbmZvX2lvY3RsKCkiKQo+ID4gRml4ZXM6IGQzOGNl YWY5OWVkMCAoImRybS9hbWRncHU6IGFkZCBjb3JlIGRyaXZlciAodjQpIikKPiA+IFN1Z2dlc3Rl ZC1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgo+ID4gU2lnbmVk LW9mZi1ieTogUGVpbGluIFllIDx5ZXBlaWxpbi5jc0BnbWFpbC5jb20+Cj4KPiBSZXZpZXdlZC1i eTogQ2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+Cj4gSSBjYW4n dCBjb3VudCBob3cgbWFueSBvZiB0aG9zZSB3ZSBoYXZlIGZpeGVkIG92ZXIgdGhlIHllYXJzLgo+ Cj4gQXQgc29tZSBwb2ludCB3ZSBzaG91bGQgcHJvYmFibHkgZG9jdW1lbnQgdGhhdCB1c2luZyAi PSB7fSIgb3IgIj0geyAwIH0iCj4gaW4gdGhlIGtlcm5lbCBpcyBhIHJlYWxseSBiYWQgaWRlYSBh bmQgc2hvdWxkIGJlIGF2b2lkZWQuCgpNb3Jlb3ZlciwgaXQgc2VlbXMgbGlrZSBkaWZmZXJlbnQg Y29tcGlsZXJzIHNlZW0gdG8gYmVoYXZlIHJlbGF0aXZlbHkKZGlmZmVyZW50bHkgd2l0aCB0aGVz ZSBhbmQgd2Ugb2Z0ZW4gZ2V0IHJlcG9ydHMgb2Ygd2FybmluZ3Mgd2l0aCB0aGVzZQpvbiBjbGFu Zy4gIFdoZW4gaW4gZG91YnQsIG1lbXNldC4KCkFsZXgKCj4KPiBUaGFua3MsCj4gQ2hyaXN0aWFu Lgo+Cj4gPiAtLS0KPiA+ICQgcGFob2xlIC1DICJkcm1fYW1kZ3B1X2luZm9fZGV2aWNlIiBkcml2 ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfa21zLm8KPiA+IHN0cnVjdCBkcm1fYW1kZ3B1 X2luZm9fZGV2aWNlIHsKPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGRldmlj ZV9pZDsgICAgICAgICAgICAvKiAgICAgMCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAg ICAgICAgICAgICAgICAgY2hpcF9yZXY7ICAgICAgICAgICAgIC8qICAgICA0ICAgICA0ICovCj4g PiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBleHRlcm5hbF9yZXY7ICAgICAgICAg LyogICAgIDggICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIHBj aV9yZXY7ICAgICAgICAgICAgICAvKiAgICAxMiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAg ICAgICAgICAgICAgICAgICAgZmFtaWx5OyAgICAgICAgICAgICAgIC8qICAgIDE2ICAgICA0ICov Cj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBudW1fc2hhZGVyX2VuZ2luZXM7 ICAgLyogICAgMjAgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAg IG51bV9zaGFkZXJfYXJyYXlzX3Blcl9lbmdpbmU7IC8qICAgIDI0ICAgICA0ICovCj4gPiAgICAg ICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBncHVfY291bnRlcl9mcmVxOyAgICAgLyogICAg MjggICAgIDQgKi8KPiA+ICAgICAgIF9fdTY0ICAgICAgICAgICAgICAgICAgICAgIG1heF9lbmdp bmVfY2xvY2s7ICAgICAvKiAgICAzMiAgICAgOCAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAg ICAgICAgICAgICAgbWF4X21lbW9yeV9jbG9jazsgICAgIC8qICAgIDQwICAgICA4ICovCj4gPiAg ICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBjdV9hY3RpdmVfbnVtYmVyOyAgICAgLyog ICAgNDggICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGN1X2Fv X21hc2s7ICAgICAgICAgICAvKiAgICA1MiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAg ICAgICAgICAgICAgICAgY3VfYml0bWFwWzRdWzRdOyAgICAgIC8qICAgIDU2ICAgIDY0ICovCj4g PiAgICAgICAvKiAtLS0gY2FjaGVsaW5lIDEgYm91bmRhcnkgKDY0IGJ5dGVzKSB3YXMgNTYgYnl0 ZXMgYWdvIC0tLSAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZW5hYmxl ZF9yYl9waXBlc19tYXNrOyAvKiAgIDEyMCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAg ICAgICAgICAgICAgICAgbnVtX3JiX3BpcGVzOyAgICAgICAgIC8qICAgMTI0ICAgICA0ICovCj4g PiAgICAgICAvKiAtLS0gY2FjaGVsaW5lIDIgYm91bmRhcnkgKDEyOCBieXRlcykgLS0tICovCj4g PiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBudW1faHdfZ2Z4X2NvbnRleHRzOyAg LyogICAxMjggICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIF9w YWQ7ICAgICAgICAgICAgICAgICAvKiAgIDEzMiAgICAgNCAqLwo+ID4gICAgICAgX191NjQgICAg ICAgICAgICAgICAgICAgICAgaWRzX2ZsYWdzOyAgICAgICAgICAgIC8qICAgMTM2ICAgICA4ICov Cj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAgICAgICB2aXJ0dWFsX2FkZHJlc3Nfb2Zm c2V0OyAvKiAgIDE0NCAgICAgOCAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAgICAgICAgICAg ICAgdmlydHVhbF9hZGRyZXNzX21heDsgIC8qICAgMTUyICAgICA4ICovCj4gPiAgICAgICBfX3Uz MiAgICAgICAgICAgICAgICAgICAgICB2aXJ0dWFsX2FkZHJlc3NfYWxpZ25tZW50OyAvKiAgIDE2 MCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgcHRlX2ZyYWdt ZW50X3NpemU7ICAgIC8qICAgMTY0ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICBnYXJ0X3BhZ2Vfc2l6ZTsgICAgICAgLyogICAxNjggICAgIDQgKi8KPiA+ICAg ICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGNlX3JhbV9zaXplOyAgICAgICAgICAvKiAg IDE3MiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgdnJhbV90 eXBlOyAgICAgICAgICAgIC8qICAgMTc2ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAg ICAgICAgICAgICAgICB2cmFtX2JpdF93aWR0aDsgICAgICAgLyogICAxODAgICAgIDQgKi8KPiA+ ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIHZjZV9oYXJ2ZXN0X2NvbmZpZzsgICAv KiAgIDE4NCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgZ2Nf ZG91YmxlX29mZmNoaXBfbGRzX2J1ZjsgLyogICAxODggICAgIDQgKi8KPiA+ICAgICAgIC8qIC0t LSBjYWNoZWxpbmUgMyBib3VuZGFyeSAoMTkyIGJ5dGVzKSAtLS0gKi8KPiA+ICAgICAgIF9fdTY0 ICAgICAgICAgICAgICAgICAgICAgIHByaW1fYnVmX2dwdV9hZGRyOyAgICAvKiAgIDE5MiAgICAg OCAqLwo+ID4gICAgICAgX191NjQgICAgICAgICAgICAgICAgICAgICAgcG9zX2J1Zl9ncHVfYWRk cjsgICAgIC8qICAgMjAwICAgICA4ICovCj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAg ICAgICBjbnRsX3NiX2J1Zl9ncHVfYWRkcjsgLyogICAyMDggICAgIDggKi8KPiA+ICAgICAgIF9f dTY0ICAgICAgICAgICAgICAgICAgICAgIHBhcmFtX2J1Zl9ncHVfYWRkcjsgICAvKiAgIDIxNiAg ICAgOCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgcHJpbV9idWZfc2l6 ZTsgICAgICAgIC8qICAgMjI0ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAg ICAgICAgICBwb3NfYnVmX3NpemU7ICAgICAgICAgLyogICAyMjggICAgIDQgKi8KPiA+ICAgICAg IF9fdTMyICAgICAgICAgICAgICAgICAgICAgIGNudGxfc2JfYnVmX3NpemU7ICAgICAvKiAgIDIz MiAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAgICAgICAgICAgICAgICAgICAgcGFyYW1fYnVm X3NpemU7ICAgICAgIC8qICAgMjM2ICAgICA0ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAg ICAgICAgICAgICB3YXZlX2Zyb250X3NpemU7ICAgICAgLyogICAyNDAgICAgIDQgKi8KPiA+ICAg ICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG51bV9zaGFkZXJfdmlzaWJsZV92Z3Byczsg LyogICAyNDQgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAgIG51 bV9jdV9wZXJfc2g7ICAgICAgICAvKiAgIDI0OCAgICAgNCAqLwo+ID4gICAgICAgX191MzIgICAg ICAgICAgICAgICAgICAgICAgbnVtX3RjY19ibG9ja3M7ICAgICAgIC8qICAgMjUyICAgICA0ICov Cj4gPiAgICAgICAvKiAtLS0gY2FjaGVsaW5lIDQgYm91bmRhcnkgKDI1NiBieXRlcykgLS0tICov Cj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBnc192Z3RfdGFibGVfZGVwdGg7 ICAgLyogICAyNTYgICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAgICAg IGdzX3ByaW1fYnVmZmVyX2RlcHRoOyAvKiAgIDI2MCAgICAgNCAqLwo+ID4gICAgICAgX191MzIg ICAgICAgICAgICAgICAgICAgICAgbWF4X2dzX3dhdmVzX3Blcl92Z3Q7IC8qICAgMjY0ICAgICA0 ICovCj4gPiAgICAgICBfX3UzMiAgICAgICAgICAgICAgICAgICAgICBfcGFkMTsgICAgICAgICAg ICAgICAgLyogICAyNjggICAgIDQgKi8KPiA+ICAgICAgIF9fdTMyICAgICAgICAgICAgICAgICAg ICAgIGN1X2FvX2JpdG1hcFs0XVs0XTsgICAvKiAgIDI3MiAgICA2NCAqLwo+ID4gICAgICAgLyog LS0tIGNhY2hlbGluZSA1IGJvdW5kYXJ5ICgzMjAgYnl0ZXMpIHdhcyAxNiBieXRlcyBhZ28gLS0t ICovCj4gPiAgICAgICBfX3U2NCAgICAgICAgICAgICAgICAgICAgICBoaWdoX3ZhX29mZnNldDsg ICAgICAgLyogICAzMzYgICAgIDggKi8KPiA+ICAgICAgIF9fdTY0ICAgICAgICAgICAgICAgICAg ICAgIGhpZ2hfdmFfbWF4OyAgICAgICAgICAvKiAgIDM0NCAgICAgOCAqLwo+ID4gICAgICAgX191 MzIgICAgICAgICAgICAgICAgICAgICAgcGFfc2NfdGlsZV9zdGVlcmluZ19vdmVycmlkZTsgLyog ICAzNTIgICAgIDQgKi8KPiA+Cj4gPiAgICAgICAvKiBYWFggNCBieXRlcyBob2xlLCB0cnkgdG8g cGFjayAqLwo+ID4KPiA+ICAgICAgIF9fdTY0ICAgICAgICAgICAgICAgICAgICAgIHRjY19kaXNh YmxlZF9tYXNrOyAgICAvKiAgIDM2MCAgICAgOCAqLwo+ID4KPiA+ICAgICAgIC8qIHNpemU6IDM2 OCwgY2FjaGVsaW5lczogNiwgbWVtYmVyczogNDkgKi8KPiA+ICAgICAgIC8qIHN1bSBtZW1iZXJz OiAzNjQsIGhvbGVzOiAxLCBzdW0gaG9sZXM6IDQgKi8KPiA+ICAgICAgIC8qIGxhc3QgY2FjaGVs aW5lOiA0OCBieXRlcyAqLwo+ID4gfTsKPiA+Cj4gPiAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9rbXMuYyB8IDMgKystCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X2ttcy5jCj4gPiBpbmRleCBhOGM0N2FlY2QzNDIuLjAwNDdkYTA2MDQxZiAxMDA2NDQKPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9rbXMuYwo+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X2ttcy5jCj4gPiBAQCAtNzA3LDkgKzcw NywxMCBAQCBzdGF0aWMgaW50IGFtZGdwdV9pbmZvX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIHZvaWQgKmRhdGEsIHN0cnVjdCBkcm1fZmlsZQo+ID4gICAgICAgICAgICAgICByZXR1cm4g biA/IC1FRkFVTFQgOiAwOwo+ID4gICAgICAgfQo+ID4gICAgICAgY2FzZSBBTURHUFVfSU5GT19E RVZfSU5GTzogewo+ID4gLSAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2FtZGdwdV9pbmZvX2Rldmlj ZSBkZXZfaW5mbyA9IHt9Owo+ID4gKyAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2FtZGdwdV9pbmZv X2RldmljZSBkZXZfaW5mbzsKPiA+ICAgICAgICAgICAgICAgdWludDY0X3Qgdm1fc2l6ZTsKPiA+ Cj4gPiArICAgICAgICAgICAgIG1lbXNldCgmZGV2X2luZm8sIDAsIHNpemVvZihkZXZfaW5mbykp Owo+ID4gICAgICAgICAgICAgICBkZXZfaW5mby5kZXZpY2VfaWQgPSBkZXYtPnBkZXYtPmRldmlj ZTsKPiA+ICAgICAgICAgICAgICAgZGV2X2luZm8uY2hpcF9yZXYgPSBhZGV2LT5yZXZfaWQ7Cj4g PiAgICAgICAgICAgICAgIGRldl9pbmZvLmV4dGVybmFsX3JldiA9IGFkZXYtPmV4dGVybmFsX3Jl dl9pZDsKPgo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Cj4gYW1kLWdmeCBtYWlsaW5nIGxpc3QKPiBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeApf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1h aWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngK