From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BA46C4743D for ; Fri, 4 Jun 2021 21:00:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E281661403 for ; Fri, 4 Jun 2021 21:00:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230451AbhFDVCY (ORCPT ); Fri, 4 Jun 2021 17:02:24 -0400 Received: from mail-oi1-f174.google.com ([209.85.167.174]:34677 "EHLO mail-oi1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229982AbhFDVCX (ORCPT ); Fri, 4 Jun 2021 17:02:23 -0400 Received: by mail-oi1-f174.google.com with SMTP id u11so11057339oiv.1 for ; Fri, 04 Jun 2021 14:00:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=hcL1duf2cmVS2FFozNPUZ6B5aiW4MPId9J+rVmkQUYk=; b=Y3QUX1ZAvnl/3ato47zA/tKEluRFWys/uYy3LhRgHryxJy2v3HpkGSBbNRtRMeFYv/ ygX8EevDFP1KKbg1U2360M0YCC720fLNFdPjNlRkeqlJs1HSqOFPDZRYpiLcy+j2K5+D 3vcB/6sobewdj640tdMhp4agMFL8k3XJzAE8zJS75Z/gEBQ2vhZeg4dzDb54oBcKxnHt OSPTZ0/CaLJlC0rZRtm9tWghIbGTcd8B3KSN+0oTMRrkqzTwqmrIEaOQLT2vgDfkfTeE hWPaCj0fH+m2+XE5/THM8CXTNPd73SeWW9RO1wE1eLKtsGrmDRR9bNZ3AV0cZj2ZZ173 RY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hcL1duf2cmVS2FFozNPUZ6B5aiW4MPId9J+rVmkQUYk=; b=QDpQcjbVEgN7eA9dJFqEhesqJ4attGKF0xMyLDpu5YGxhSPzHvGHV4wj8fjUBPEXvK VyJ2Ea7DCTDYwSyp5hzkKMrom+jWN7E0/a55E2pxKok/WpCxgAnwY/C1dDObw1+f8P8B qamDlLhCQhJzJ1vsLQyJbSHd2oaWh0/0yGyoqxA6qo+dZ3Bf3Zb1siLC7a4Ejg/6xuMq edcyEITbPQ0sa3+UduA6ovYH0as3BqjftirtirWDB5pz4D9fNngx7SDyvw7zoLpbfrEs wpYNgVAQYI/JIBT/S57ko/ymfatTBibhLEM0+GguGaM32ej877m20gGQDi5WtWsM0+TI +UNA== X-Gm-Message-State: AOAM533LfT21uPDIbhEGPDUgJefZFzCw5WOuA+bmSKZulUyawbtaHg+9 5CbRnUxnjiZFl7Hp7PPv25tBsdsBHs2+LcLwREw= X-Google-Smtp-Source: ABdhPJw4eES4VW3g/ubIWR4XRCfecTT650bw+GiTjrYM4m9lJI5z15zWHzNxpYjZfQXlqa9fMW8UX3Esa/xQxythEUs= X-Received: by 2002:a05:6808:206:: with SMTP id l6mr11541621oie.5.1622840361985; Fri, 04 Jun 2021 13:59:21 -0700 (PDT) MIME-Version: 1.0 References: <20210603160928.3854180-1-Liam.Howlett@Oracle.com> <4d2e62c7-af4c-b977-a05c-97b664b532b3@gmail.com> In-Reply-To: <4d2e62c7-af4c-b977-a05c-97b664b532b3@gmail.com> From: Alex Deucher Date: Fri, 4 Jun 2021 16:59:10 -0400 Message-ID: Subject: Re: [PATCH] drm/amdgpu: Use vma_lookup() in amdgpu_ttm_tt_get_user_pages() To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Liam Howlett , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , David Airlie Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 4, 2021 at 7:11 AM Christian K=C3=B6nig wrote: > > Am 03.06.21 um 18:09 schrieb Liam Howlett: > > Use vma_lookup() to find the VMA at a specific address. As vma_lookup(= ) > > will return NULL if the address is not within any VMA, the start addres= s > > no longer needs to be validated. > > > > Signed-off-by: Liam R. Howlett > > Reviewed-by: Christian K=C3=B6nig > I'm fine to have this go through whatever tree makes sense. Acked-by: Alex Deucher > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/= amd/amdgpu/amdgpu_ttm.c > > index 7cb7ffdd1900..dfb5ca3f8da8 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > @@ -680,9 +680,9 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *= bo, struct page **pages) > > return -ESRCH; > > > > mmap_read_lock(mm); > > - vma =3D find_vma(mm, start); > > + vma =3D vma_lookup(mm, start); > > mmap_read_unlock(mm); > > - if (unlikely(!vma || start < vma->vm_start)) { > > + if (unlikely(!vma)) { > > r =3D -EFAULT; > > goto out_putmm; > > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DATE_IN_PAST_06_12, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61581C47082 for ; Sat, 5 Jun 2021 06:24:27 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0876461246 for ; Sat, 5 Jun 2021 06:24:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0876461246 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9E5146B006C; Sat, 5 Jun 2021 02:24:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9945B6B006E; Sat, 5 Jun 2021 02:24:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 80E806B0070; Sat, 5 Jun 2021 02:24:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 4B3756B006C for ; Sat, 5 Jun 2021 02:24:26 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EA74175AA for ; Sat, 5 Jun 2021 06:24:25 +0000 (UTC) X-FDA: 78218680890.30.76DA9BA Received: from mail-oi1-f173.google.com (mail-oi1-f173.google.com [209.85.167.173]) by imf24.hostedemail.com (Postfix) with ESMTP id 3B16AA000924 for ; Sat, 5 Jun 2021 06:24:23 +0000 (UTC) Received: by mail-oi1-f173.google.com with SMTP id c3so12060804oic.8 for ; Fri, 04 Jun 2021 23:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=hcL1duf2cmVS2FFozNPUZ6B5aiW4MPId9J+rVmkQUYk=; b=Y3QUX1ZAvnl/3ato47zA/tKEluRFWys/uYy3LhRgHryxJy2v3HpkGSBbNRtRMeFYv/ ygX8EevDFP1KKbg1U2360M0YCC720fLNFdPjNlRkeqlJs1HSqOFPDZRYpiLcy+j2K5+D 3vcB/6sobewdj640tdMhp4agMFL8k3XJzAE8zJS75Z/gEBQ2vhZeg4dzDb54oBcKxnHt OSPTZ0/CaLJlC0rZRtm9tWghIbGTcd8B3KSN+0oTMRrkqzTwqmrIEaOQLT2vgDfkfTeE hWPaCj0fH+m2+XE5/THM8CXTNPd73SeWW9RO1wE1eLKtsGrmDRR9bNZ3AV0cZj2ZZ173 RY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hcL1duf2cmVS2FFozNPUZ6B5aiW4MPId9J+rVmkQUYk=; b=bpgoqIxrtaY3BlmNzxJZkxLqNyMC6r4zElOEkAOxb/EqqfsqKg0Xta2Mn7X07giMU5 NnPx2wnyUvXKq6buO3DWP6EjL/1rZpcTdgXPAvjCaOKkhQVwWu7kfuLKunmehUhDbtZ1 9mK3Sa3v2C38G96xS/MmyR85gBacuaa5xVQozxlU2iXqPt8zvhJ0QAsUJTae3dwt/wV/ 8KcgPKKOVslEVYVi4hsAqRNWmu/70iDBq7KbCCA1yJZYgzqFXxNxwBeCGHJCKwaSHn3U 3s5hhbrz+/gEHtngpSat2k8459DRnQQWotiYKqnGXeweDjxqOLZdvsbgK0tSOjB24rHp tQww== X-Gm-Message-State: AOAM533I/SVIleUiLFcw34FzKM9OSRaAnOAjRtnfr/hKhnxJp/G08LTd P3RWvJIoEeERKRrfRVHwsgVVK8nVG1CyeltpzQ4V1gKR X-Google-Smtp-Source: ABdhPJw4eES4VW3g/ubIWR4XRCfecTT650bw+GiTjrYM4m9lJI5z15zWHzNxpYjZfQXlqa9fMW8UX3Esa/xQxythEUs= X-Received: by 2002:a05:6808:206:: with SMTP id l6mr11541621oie.5.1622840361985; Fri, 04 Jun 2021 13:59:21 -0700 (PDT) MIME-Version: 1.0 References: <20210603160928.3854180-1-Liam.Howlett@Oracle.com> <4d2e62c7-af4c-b977-a05c-97b664b532b3@gmail.com> In-Reply-To: <4d2e62c7-af4c-b977-a05c-97b664b532b3@gmail.com> From: Alex Deucher Date: Fri, 4 Jun 2021 16:59:10 -0400 Message-ID: Subject: Re: [PATCH] drm/amdgpu: Use vma_lookup() in amdgpu_ttm_tt_get_user_pages() To: =?UTF-8?Q?Christian_K=C3=B6nig?= Cc: Liam Howlett , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "amd-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , David Airlie Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=Y3QUX1ZA; spf=pass (imf24.hostedemail.com: domain of alexdeucher@gmail.com designates 209.85.167.173 as permitted sender) smtp.mailfrom=alexdeucher@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 3B16AA000924 X-Stat-Signature: gq6jkw5ex8paamb1yhdxffpwpfdpybnw X-HE-Tag: 1622874263-629161 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 4, 2021 at 7:11 AM Christian K=C3=B6nig wrote: > > Am 03.06.21 um 18:09 schrieb Liam Howlett: > > Use vma_lookup() to find the VMA at a specific address. As vma_lookup(= ) > > will return NULL if the address is not within any VMA, the start addres= s > > no longer needs to be validated. > > > > Signed-off-by: Liam R. Howlett > > Reviewed-by: Christian K=C3=B6nig > I'm fine to have this go through whatever tree makes sense. Acked-by: Alex Deucher > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/= amd/amdgpu/amdgpu_ttm.c > > index 7cb7ffdd1900..dfb5ca3f8da8 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > @@ -680,9 +680,9 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *= bo, struct page **pages) > > return -ESRCH; > > > > mmap_read_lock(mm); > > - vma =3D find_vma(mm, start); > > + vma =3D vma_lookup(mm, start); > > mmap_read_unlock(mm); > > - if (unlikely(!vma || start < vma->vm_start)) { > > + if (unlikely(!vma)) { > > r =3D -EFAULT; > > goto out_putmm; > > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B44F6C4743C for ; Fri, 4 Jun 2021 20:59:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 845BB61404 for ; Fri, 4 Jun 2021 20:59:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 845BB61404 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F92A6EDFF; Fri, 4 Jun 2021 20:59:25 +0000 (UTC) Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0AF06EB1F; Fri, 4 Jun 2021 20:59:22 +0000 (UTC) Received: by mail-oi1-x22a.google.com with SMTP id x196so10631138oif.10; Fri, 04 Jun 2021 13:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=hcL1duf2cmVS2FFozNPUZ6B5aiW4MPId9J+rVmkQUYk=; b=Y3QUX1ZAvnl/3ato47zA/tKEluRFWys/uYy3LhRgHryxJy2v3HpkGSBbNRtRMeFYv/ ygX8EevDFP1KKbg1U2360M0YCC720fLNFdPjNlRkeqlJs1HSqOFPDZRYpiLcy+j2K5+D 3vcB/6sobewdj640tdMhp4agMFL8k3XJzAE8zJS75Z/gEBQ2vhZeg4dzDb54oBcKxnHt OSPTZ0/CaLJlC0rZRtm9tWghIbGTcd8B3KSN+0oTMRrkqzTwqmrIEaOQLT2vgDfkfTeE hWPaCj0fH+m2+XE5/THM8CXTNPd73SeWW9RO1wE1eLKtsGrmDRR9bNZ3AV0cZj2ZZ173 RY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hcL1duf2cmVS2FFozNPUZ6B5aiW4MPId9J+rVmkQUYk=; b=A+h+rLspNZxQ3HCxycHKsX5buCu0t6N8jyl8pAH9pdAP9jIVkJ/l2OVjG4BDLbXGzS SH5+2WX7czZid/D3PWqls4UIcBoAFZM2fmUaQP0KKUXa3EdpFEOcYqvwTDD14dWfTcJP JWUlKKGUZSbyB3PdWXdWS531qdb62lb4seZAaLA6PL2q+rQ3C+XwuAgGHrD1APC77Mws lktc/v7ziP+UGEgYsPw17az3H3THb3Ihu2IZuNOuAGfjHGGAL8kHRC9Gw/bVNkSQwH5U lObbM31jacoCGtPEJ5O6kFk3AXaDZFjTbnRDOTJVpgWVnlbaUtMcltVbSoaRTJ6oL6e+ 7ZGQ== X-Gm-Message-State: AOAM532M4yyGlzOLjP+80lfmzudi2Cv0YrD6iP8spb7Z8AgvYYgo4+gV bSytNESTLrEa5PZbA/o3Chtz5mYj7mK4/xXJuYc= X-Google-Smtp-Source: ABdhPJw4eES4VW3g/ubIWR4XRCfecTT650bw+GiTjrYM4m9lJI5z15zWHzNxpYjZfQXlqa9fMW8UX3Esa/xQxythEUs= X-Received: by 2002:a05:6808:206:: with SMTP id l6mr11541621oie.5.1622840361985; Fri, 04 Jun 2021 13:59:21 -0700 (PDT) MIME-Version: 1.0 References: <20210603160928.3854180-1-Liam.Howlett@Oracle.com> <4d2e62c7-af4c-b977-a05c-97b664b532b3@gmail.com> In-Reply-To: <4d2e62c7-af4c-b977-a05c-97b664b532b3@gmail.com> From: Alex Deucher Date: Fri, 4 Jun 2021 16:59:10 -0400 Message-ID: Subject: Re: [PATCH] drm/amdgpu: Use vma_lookup() in amdgpu_ttm_tt_get_user_pages() To: =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "amd-gfx@lists.freedesktop.org" , Liam Howlett , Andrew Morton Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 4, 2021 at 7:11 AM Christian K=C3=B6nig wrote: > > Am 03.06.21 um 18:09 schrieb Liam Howlett: > > Use vma_lookup() to find the VMA at a specific address. As vma_lookup(= ) > > will return NULL if the address is not within any VMA, the start addres= s > > no longer needs to be validated. > > > > Signed-off-by: Liam R. Howlett > > Reviewed-by: Christian K=C3=B6nig > I'm fine to have this go through whatever tree makes sense. Acked-by: Alex Deucher > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/= amd/amdgpu/amdgpu_ttm.c > > index 7cb7ffdd1900..dfb5ca3f8da8 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > > @@ -680,9 +680,9 @@ int amdgpu_ttm_tt_get_user_pages(struct amdgpu_bo *= bo, struct page **pages) > > return -ESRCH; > > > > mmap_read_lock(mm); > > - vma =3D find_vma(mm, start); > > + vma =3D vma_lookup(mm, start); > > mmap_read_unlock(mm); > > - if (unlikely(!vma || start < vma->vm_start)) { > > + if (unlikely(!vma)) { > > r =3D -EFAULT; > > goto out_putmm; > > } > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 462B4C4743D for ; Fri, 4 Jun 2021 20:59:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0698A61404 for ; Fri, 4 Jun 2021 20:59:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0698A61404 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B73FE6EB1F; Fri, 4 Jun 2021 20:59:24 +0000 (UTC) Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by gabe.freedesktop.org (Postfix) with ESMTPS id E0AF06EB1F; Fri, 4 Jun 2021 20:59:22 +0000 (UTC) Received: by mail-oi1-x22a.google.com with SMTP id x196so10631138oif.10; Fri, 04 Jun 2021 13:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=hcL1duf2cmVS2FFozNPUZ6B5aiW4MPId9J+rVmkQUYk=; b=Y3QUX1ZAvnl/3ato47zA/tKEluRFWys/uYy3LhRgHryxJy2v3HpkGSBbNRtRMeFYv/ ygX8EevDFP1KKbg1U2360M0YCC720fLNFdPjNlRkeqlJs1HSqOFPDZRYpiLcy+j2K5+D 3vcB/6sobewdj640tdMhp4agMFL8k3XJzAE8zJS75Z/gEBQ2vhZeg4dzDb54oBcKxnHt OSPTZ0/CaLJlC0rZRtm9tWghIbGTcd8B3KSN+0oTMRrkqzTwqmrIEaOQLT2vgDfkfTeE hWPaCj0fH+m2+XE5/THM8CXTNPd73SeWW9RO1wE1eLKtsGrmDRR9bNZ3AV0cZj2ZZ173 RY9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=hcL1duf2cmVS2FFozNPUZ6B5aiW4MPId9J+rVmkQUYk=; b=A+h+rLspNZxQ3HCxycHKsX5buCu0t6N8jyl8pAH9pdAP9jIVkJ/l2OVjG4BDLbXGzS SH5+2WX7czZid/D3PWqls4UIcBoAFZM2fmUaQP0KKUXa3EdpFEOcYqvwTDD14dWfTcJP JWUlKKGUZSbyB3PdWXdWS531qdb62lb4seZAaLA6PL2q+rQ3C+XwuAgGHrD1APC77Mws lktc/v7ziP+UGEgYsPw17az3H3THb3Ihu2IZuNOuAGfjHGGAL8kHRC9Gw/bVNkSQwH5U lObbM31jacoCGtPEJ5O6kFk3AXaDZFjTbnRDOTJVpgWVnlbaUtMcltVbSoaRTJ6oL6e+ 7ZGQ== X-Gm-Message-State: AOAM532M4yyGlzOLjP+80lfmzudi2Cv0YrD6iP8spb7Z8AgvYYgo4+gV bSytNESTLrEa5PZbA/o3Chtz5mYj7mK4/xXJuYc= X-Google-Smtp-Source: ABdhPJw4eES4VW3g/ubIWR4XRCfecTT650bw+GiTjrYM4m9lJI5z15zWHzNxpYjZfQXlqa9fMW8UX3Esa/xQxythEUs= X-Received: by 2002:a05:6808:206:: with SMTP id l6mr11541621oie.5.1622840361985; Fri, 04 Jun 2021 13:59:21 -0700 (PDT) MIME-Version: 1.0 References: <20210603160928.3854180-1-Liam.Howlett@Oracle.com> <4d2e62c7-af4c-b977-a05c-97b664b532b3@gmail.com> In-Reply-To: <4d2e62c7-af4c-b977-a05c-97b664b532b3@gmail.com> From: Alex Deucher Date: Fri, 4 Jun 2021 16:59:10 -0400 Message-ID: Subject: Re: [PATCH] drm/amdgpu: Use vma_lookup() in amdgpu_ttm_tt_get_user_pages() To: =?UTF-8?Q?Christian_K=C3=B6nig?= X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "amd-gfx@lists.freedesktop.org" , Liam Howlett , Andrew Morton Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gRnJpLCBKdW4gNCwgMjAyMSBhdCA3OjExIEFNIENocmlzdGlhbiBLw7ZuaWcKPGNrb2VuaWcu bGVpY2h0enVtZXJrZW5AZ21haWwuY29tPiB3cm90ZToKPgo+IEFtIDAzLjA2LjIxIHVtIDE4OjA5 IHNjaHJpZWIgTGlhbSBIb3dsZXR0Ogo+ID4gVXNlIHZtYV9sb29rdXAoKSB0byBmaW5kIHRoZSBW TUEgYXQgYSBzcGVjaWZpYyBhZGRyZXNzLiAgQXMgdm1hX2xvb2t1cCgpCj4gPiB3aWxsIHJldHVy biBOVUxMIGlmIHRoZSBhZGRyZXNzIGlzIG5vdCB3aXRoaW4gYW55IFZNQSwgdGhlIHN0YXJ0IGFk ZHJlc3MKPiA+IG5vIGxvbmdlciBuZWVkcyB0byBiZSB2YWxpZGF0ZWQuCj4gPgo+ID4gU2lnbmVk LW9mZi1ieTogTGlhbSBSLiBIb3dsZXR0IDxMaWFtLkhvd2xldHRAT3JhY2xlLmNvbT4KPgo+IFJl dmlld2VkLWJ5OiBDaHJpc3RpYW4gS8O2bmlnIDxjaHJpc3RpYW4ua29lbmlnQGFtZC5jb20+Cj4K CkknbSBmaW5lIHRvIGhhdmUgdGhpcyBnbyB0aHJvdWdoIHdoYXRldmVyIHRyZWUgbWFrZXMgc2Vu c2UuCgpBY2tlZC1ieTogQWxleCBEZXVjaGVyIDxhbGV4YW5kZXIuZGV1Y2hlckBhbWQuY29tPgoK PiA+IC0tLQo+ID4gICBkcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdHRtLmMgfCA0 ICsrLS0KPiA+ICAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKPiA+Cj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1 X3R0bS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3R0bS5jCj4gPiBpbmRl eCA3Y2I3ZmZkZDE5MDAuLmRmYjVjYTNmOGRhOCAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV90dG0uYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2Ft ZC9hbWRncHUvYW1kZ3B1X3R0bS5jCj4gPiBAQCAtNjgwLDkgKzY4MCw5IEBAIGludCBhbWRncHVf dHRtX3R0X2dldF91c2VyX3BhZ2VzKHN0cnVjdCBhbWRncHVfYm8gKmJvLCBzdHJ1Y3QgcGFnZSAq KnBhZ2VzKQo+ID4gICAgICAgICAgICAgICByZXR1cm4gLUVTUkNIOwo+ID4KPiA+ICAgICAgIG1t YXBfcmVhZF9sb2NrKG1tKTsKPiA+IC0gICAgIHZtYSA9IGZpbmRfdm1hKG1tLCBzdGFydCk7Cj4g PiArICAgICB2bWEgPSB2bWFfbG9va3VwKG1tLCBzdGFydCk7Cj4gPiAgICAgICBtbWFwX3JlYWRf dW5sb2NrKG1tKTsKPiA+IC0gICAgIGlmICh1bmxpa2VseSghdm1hIHx8IHN0YXJ0IDwgdm1hLT52 bV9zdGFydCkpIHsKPiA+ICsgICAgIGlmICh1bmxpa2VseSghdm1hKSkgewo+ID4gICAgICAgICAg ICAgICByID0gLUVGQVVMVDsKPiA+ICAgICAgICAgICAgICAgZ290byBvdXRfcHV0bW07Cj4gPiAg ICAgICB9Cj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K YW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==