From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91D68C55ABD for ; Tue, 10 Nov 2020 23:42:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2605620809 for ; Tue, 10 Nov 2020 23:42:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aUc15+h6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732054AbgKJXmT (ORCPT ); Tue, 10 Nov 2020 18:42:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34332 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726706AbgKJXmQ (ORCPT ); Tue, 10 Nov 2020 18:42:16 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7343AC0613D1 for ; Tue, 10 Nov 2020 15:42:16 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id p1so321169wrf.12 for ; Tue, 10 Nov 2020 15:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Rx4+AnDnGG2uOUuYvCD2kX/y5IPcI9grqVLoFPnDhZs=; b=aUc15+h6S0MbpN1QvMk3vVOBRorNBNoGdQU0AckwRRIZRe2lGbFnRVBWKIhb3LxBps 2m1ewRtGhI0hPHPvt9FCXpAAAn78wP7EBmgdQlxfswzLZvUADu3q8SUrFa4BqrW3TC5T 7PhMhwp+p84rcQpVHILNwqnVRkkJEpzzuCxuQl1HR71NzVa2CYGpSemDlzoZjj3bNoU9 4qhaXE6c4+s9Sl/lrDsKS4gBZO2E7EKYhlRHGSQkIp/9nbLLYInRcO64Z48cHexhAHBo zKecVlHHXC6M1eXy1Ww9Ncz8Vs520PqtihkJsa8S8ePk//5IwTeTxBT/nEpKyN1RtRx5 9iHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Rx4+AnDnGG2uOUuYvCD2kX/y5IPcI9grqVLoFPnDhZs=; b=h/xe3xAGsKa1gz9v7h09e30dRH3f4/Qf2t4AplkLhKZXvQc4yCSbMqFN8gBMWWSRoH KgXXaV8HPWwTXBsC3HszY1pNU0IKUNpSxAX1ijHgm2JiPTlYV2PAIQp2KX9ki3P3iHzI R8uD6K3RpIjdJU8SFBrZ3o1Drg6B1C9AUnrcvVGAQ4A++QFmlwY9VI76w+7qAaAOXLVK 1TwWbT4fh18fLqP8UpxZOsg2DFjBB9g9KVbJeEuOIpy38+r5B0M5XDDGZRgMDRsNTYD/ CanboFGQEXTLkeJirZinnQfBCJz6nPWoDWFugHcXf3sG5zfY4u5rPQpdYY6lb7mRM2X0 iXxA== X-Gm-Message-State: AOAM533JPF9vN1I3lnVS/CLlw/5doeLnqGeYi1QG+MWCGQB9xAj3av6h AkWiRnu2+Y0Q2/96ejhOFKeAyvYnf2EGAJJxD64= X-Google-Smtp-Source: ABdhPJwjbq17rx2WoHZy+mm45mILPxwoMZE4g1kekeZ4ir+vZXwFa9KxgzHwN2TiC2o7hCUQrO5NkZGXiJFjcL2X1Sg= X-Received: by 2002:adf:e8d0:: with SMTP id k16mr26256999wrn.362.1605051735175; Tue, 10 Nov 2020 15:42:15 -0800 (PST) MIME-Version: 1.0 References: <20201110193112.988999-1-lee.jones@linaro.org> <20201110193112.988999-9-lee.jones@linaro.org> In-Reply-To: <20201110193112.988999-9-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 18:42:03 -0500 Message-ID: Subject: Re: [PATCH 08/30] drm/radeon/ci_dpm: Remove set but unused variable 'dpm_event_src' To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 2:31 PM Lee Jones wrote: > > And the piece of code that has never been executed. > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/radeon/ci_dpm.c: In function =E2=80=98ci_set_dpm_event_s= ources=E2=80=99: > drivers/gpu/drm/radeon/ci_dpm.c:1369:28: warning: variable =E2=80=98dpm_= event_src=E2=80=99 set but not used [-Wunused-but-set-variable] > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/ci_dpm.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_= dpm.c > index 886e9959496fe..8324aca5fd006 100644 > --- a/drivers/gpu/drm/radeon/ci_dpm.c > +++ b/drivers/gpu/drm/radeon/ci_dpm.c > @@ -1366,7 +1366,6 @@ static void ci_set_dpm_event_sources(struct radeon_= device *rdev, u32 sources) > { > struct ci_power_info *pi =3D ci_get_pi(rdev); > bool want_thermal_protection; > - enum radeon_dpm_event_src dpm_event_src; > u32 tmp; > > switch (sources) { > @@ -1376,28 +1375,17 @@ static void ci_set_dpm_event_sources(struct radeo= n_device *rdev, u32 sources) > break; > case (1 << RADEON_DPM_AUTO_THROTTLE_SRC_THERMAL): > want_thermal_protection =3D true; > - dpm_event_src =3D RADEON_DPM_EVENT_SRC_DIGITAL; > break; > case (1 << RADEON_DPM_AUTO_THROTTLE_SRC_EXTERNAL): > want_thermal_protection =3D true; > - dpm_event_src =3D RADEON_DPM_EVENT_SRC_EXTERNAL; > break; > case ((1 << RADEON_DPM_AUTO_THROTTLE_SRC_EXTERNAL) | > (1 << RADEON_DPM_AUTO_THROTTLE_SRC_THERMAL)): > want_thermal_protection =3D true; > - dpm_event_src =3D RADEON_DPM_EVENT_SRC_DIGIAL_OR_EXTERNAL= ; > break; > } > > if (want_thermal_protection) { > -#if 0 > - /* XXX: need to figure out how to handle this properly */ > - tmp =3D RREG32_SMC(CG_THERMAL_CTRL); > - tmp &=3D DPM_EVENT_SRC_MASK; > - tmp |=3D DPM_EVENT_SRC(dpm_event_src); > - WREG32_SMC(CG_THERMAL_CTRL, tmp); > -#endif > - > tmp =3D RREG32_SMC(GENERAL_PWRMGT); > if (pi->thermal_protection) > tmp &=3D ~THERMAL_PROTECTION_DIS; > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D418DC4742C for ; Tue, 10 Nov 2020 23:42:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4379C20825 for ; Tue, 10 Nov 2020 23:42:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aUc15+h6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4379C20825 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EF08B89D46; Tue, 10 Nov 2020 23:42:16 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EC9989D46; Tue, 10 Nov 2020 23:42:16 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id l1so344549wrb.9; Tue, 10 Nov 2020 15:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Rx4+AnDnGG2uOUuYvCD2kX/y5IPcI9grqVLoFPnDhZs=; b=aUc15+h6S0MbpN1QvMk3vVOBRorNBNoGdQU0AckwRRIZRe2lGbFnRVBWKIhb3LxBps 2m1ewRtGhI0hPHPvt9FCXpAAAn78wP7EBmgdQlxfswzLZvUADu3q8SUrFa4BqrW3TC5T 7PhMhwp+p84rcQpVHILNwqnVRkkJEpzzuCxuQl1HR71NzVa2CYGpSemDlzoZjj3bNoU9 4qhaXE6c4+s9Sl/lrDsKS4gBZO2E7EKYhlRHGSQkIp/9nbLLYInRcO64Z48cHexhAHBo zKecVlHHXC6M1eXy1Ww9Ncz8Vs520PqtihkJsa8S8ePk//5IwTeTxBT/nEpKyN1RtRx5 9iHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Rx4+AnDnGG2uOUuYvCD2kX/y5IPcI9grqVLoFPnDhZs=; b=Smha48HoEdGE1MwS7MmdnkQCW0wcKtRPRxDwvLPJCpT2e0G1aTDz1YNFmPnjR3BSEU NUzzMnyY03l5BEHtHwlefhYqPTxMIJyFMN2o4cOUeJ23dxLIA16NAGPhYeUNLUbhCvyr JKyVFoRdv7V5qA4oZay8In1ZAh2eUP1FEZv3JlooQQcILSv5z2r/0jCSZHi2Wch1PR5F pr73s2VokEU/ZNOE+peVAzxtNdN48QIY1lhz1Q1URuM8h0bzWH0q8Cuil5kM3Ru1eXEF WUOPL6ZzU00w6ZxzrztpeP/uQNdro5x/7leakXLgdXP4dcTayPVbme12T+npDjXKj4oz wnIA== X-Gm-Message-State: AOAM530NSZOqFBbWf9B2vdEe9oPadEno//sALg8tnItyOnxhEJOuz/Di d0koZIvxaS/PrSmiTJm8rvitC4blNPM0IjEeWts= X-Google-Smtp-Source: ABdhPJwjbq17rx2WoHZy+mm45mILPxwoMZE4g1kekeZ4ir+vZXwFa9KxgzHwN2TiC2o7hCUQrO5NkZGXiJFjcL2X1Sg= X-Received: by 2002:adf:e8d0:: with SMTP id k16mr26256999wrn.362.1605051735175; Tue, 10 Nov 2020 15:42:15 -0800 (PST) MIME-Version: 1.0 References: <20201110193112.988999-1-lee.jones@linaro.org> <20201110193112.988999-9-lee.jones@linaro.org> In-Reply-To: <20201110193112.988999-9-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 18:42:03 -0500 Message-ID: Subject: Re: [PATCH 08/30] drm/radeon/ci_dpm: Remove set but unused variable 'dpm_event_src' To: Lee Jones X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBOb3YgMTAsIDIwMjAgYXQgMjozMSBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEFuZCB0aGUgcGllY2Ugb2YgY29kZSB0aGF0IGhhcyBuZXZlciBi ZWVuIGV4ZWN1dGVkLgo+Cj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdh cm5pbmcocyk6Cj4KPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9jaV9kcG0uYzogSW4gZnVuY3Rp b24g4oCYY2lfc2V0X2RwbV9ldmVudF9zb3VyY2Vz4oCZOgo+ICBkcml2ZXJzL2dwdS9kcm0vcmFk ZW9uL2NpX2RwbS5jOjEzNjk6Mjg6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmGRwbV9ldmVudF9zcmPi gJkgc2V0IGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPgo+IENjOiBB bGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gQ2M6ICJDaHJpc3RpYW4g S8O2bmlnIiA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+IENjOiBEYXZpZCBBaXJsaWUgPGFp cmxpZWRAbGludXguaWU+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiBD YzogYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+CgpBcHBsaWVkLiAgVGhhbmtzIQoKQWxleAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L3JhZGVvbi9jaV9kcG0uYyB8IDEyIC0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTIg ZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9jaV9k cG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vY2lfZHBtLmMKPiBpbmRleCA4ODZlOTk1OTQ5 NmZlLi44MzI0YWNhNWZkMDA2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24v Y2lfZHBtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2NpX2RwbS5jCj4gQEAgLTEz NjYsNyArMTM2Niw2IEBAIHN0YXRpYyB2b2lkIGNpX3NldF9kcG1fZXZlbnRfc291cmNlcyhzdHJ1 Y3QgcmFkZW9uX2RldmljZSAqcmRldiwgdTMyIHNvdXJjZXMpCj4gIHsKPiAgICAgICAgIHN0cnVj dCBjaV9wb3dlcl9pbmZvICpwaSA9IGNpX2dldF9waShyZGV2KTsKPiAgICAgICAgIGJvb2wgd2Fu dF90aGVybWFsX3Byb3RlY3Rpb247Cj4gLSAgICAgICBlbnVtIHJhZGVvbl9kcG1fZXZlbnRfc3Jj IGRwbV9ldmVudF9zcmM7Cj4gICAgICAgICB1MzIgdG1wOwo+Cj4gICAgICAgICBzd2l0Y2ggKHNv dXJjZXMpIHsKPiBAQCAtMTM3NiwyOCArMTM3NSwxNyBAQCBzdGF0aWMgdm9pZCBjaV9zZXRfZHBt X2V2ZW50X3NvdXJjZXMoc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYsIHUzMiBzb3VyY2VzKQo+ ICAgICAgICAgICAgICAgICBicmVhazsKPiAgICAgICAgIGNhc2UgKDEgPDwgUkFERU9OX0RQTV9B VVRPX1RIUk9UVExFX1NSQ19USEVSTUFMKToKPiAgICAgICAgICAgICAgICAgd2FudF90aGVybWFs X3Byb3RlY3Rpb24gPSB0cnVlOwo+IC0gICAgICAgICAgICAgICBkcG1fZXZlbnRfc3JjID0gUkFE RU9OX0RQTV9FVkVOVF9TUkNfRElHSVRBTDsKPiAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gICAg ICAgICBjYXNlICgxIDw8IFJBREVPTl9EUE1fQVVUT19USFJPVFRMRV9TUkNfRVhURVJOQUwpOgo+ ICAgICAgICAgICAgICAgICB3YW50X3RoZXJtYWxfcHJvdGVjdGlvbiA9IHRydWU7Cj4gLSAgICAg ICAgICAgICAgIGRwbV9ldmVudF9zcmMgPSBSQURFT05fRFBNX0VWRU5UX1NSQ19FWFRFUk5BTDsK PiAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gICAgICAgICBjYXNlICgoMSA8PCBSQURFT05fRFBN X0FVVE9fVEhST1RUTEVfU1JDX0VYVEVSTkFMKSB8Cj4gICAgICAgICAgICAgICAoMSA8PCBSQURF T05fRFBNX0FVVE9fVEhST1RUTEVfU1JDX1RIRVJNQUwpKToKPiAgICAgICAgICAgICAgICAgd2Fu dF90aGVybWFsX3Byb3RlY3Rpb24gPSB0cnVlOwo+IC0gICAgICAgICAgICAgICBkcG1fZXZlbnRf c3JjID0gUkFERU9OX0RQTV9FVkVOVF9TUkNfRElHSUFMX09SX0VYVEVSTkFMOwo+ICAgICAgICAg ICAgICAgICBicmVhazsKPiAgICAgICAgIH0KPgo+ICAgICAgICAgaWYgKHdhbnRfdGhlcm1hbF9w cm90ZWN0aW9uKSB7Cj4gLSNpZiAwCj4gLSAgICAgICAgICAgICAgIC8qIFhYWDogbmVlZCB0byBm aWd1cmUgb3V0IGhvdyB0byBoYW5kbGUgdGhpcyBwcm9wZXJseSAqLwo+IC0gICAgICAgICAgICAg ICB0bXAgPSBSUkVHMzJfU01DKENHX1RIRVJNQUxfQ1RSTCk7Cj4gLSAgICAgICAgICAgICAgIHRt cCAmPSBEUE1fRVZFTlRfU1JDX01BU0s7Cj4gLSAgICAgICAgICAgICAgIHRtcCB8PSBEUE1fRVZF TlRfU1JDKGRwbV9ldmVudF9zcmMpOwo+IC0gICAgICAgICAgICAgICBXUkVHMzJfU01DKENHX1RI RVJNQUxfQ1RSTCwgdG1wKTsKPiAtI2VuZGlmCj4gLQo+ICAgICAgICAgICAgICAgICB0bXAgPSBS UkVHMzJfU01DKEdFTkVSQUxfUFdSTUdUKTsKPiAgICAgICAgICAgICAgICAgaWYgKHBpLT50aGVy bWFsX3Byb3RlY3Rpb24pCj4gICAgICAgICAgICAgICAgICAgICAgICAgdG1wICY9IH5USEVSTUFM X1BST1RFQ1RJT05fRElTOwo+IC0tCj4gMi4yNS4xCj4KPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF52EC388F7 for ; Tue, 10 Nov 2020 23:42:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EB3F20809 for ; Tue, 10 Nov 2020 23:42:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aUc15+h6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EB3F20809 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4113D89D4F; Tue, 10 Nov 2020 23:42:17 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EC9989D46; Tue, 10 Nov 2020 23:42:16 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id l1so344549wrb.9; Tue, 10 Nov 2020 15:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Rx4+AnDnGG2uOUuYvCD2kX/y5IPcI9grqVLoFPnDhZs=; b=aUc15+h6S0MbpN1QvMk3vVOBRorNBNoGdQU0AckwRRIZRe2lGbFnRVBWKIhb3LxBps 2m1ewRtGhI0hPHPvt9FCXpAAAn78wP7EBmgdQlxfswzLZvUADu3q8SUrFa4BqrW3TC5T 7PhMhwp+p84rcQpVHILNwqnVRkkJEpzzuCxuQl1HR71NzVa2CYGpSemDlzoZjj3bNoU9 4qhaXE6c4+s9Sl/lrDsKS4gBZO2E7EKYhlRHGSQkIp/9nbLLYInRcO64Z48cHexhAHBo zKecVlHHXC6M1eXy1Ww9Ncz8Vs520PqtihkJsa8S8ePk//5IwTeTxBT/nEpKyN1RtRx5 9iHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Rx4+AnDnGG2uOUuYvCD2kX/y5IPcI9grqVLoFPnDhZs=; b=Smha48HoEdGE1MwS7MmdnkQCW0wcKtRPRxDwvLPJCpT2e0G1aTDz1YNFmPnjR3BSEU NUzzMnyY03l5BEHtHwlefhYqPTxMIJyFMN2o4cOUeJ23dxLIA16NAGPhYeUNLUbhCvyr JKyVFoRdv7V5qA4oZay8In1ZAh2eUP1FEZv3JlooQQcILSv5z2r/0jCSZHi2Wch1PR5F pr73s2VokEU/ZNOE+peVAzxtNdN48QIY1lhz1Q1URuM8h0bzWH0q8Cuil5kM3Ru1eXEF WUOPL6ZzU00w6ZxzrztpeP/uQNdro5x/7leakXLgdXP4dcTayPVbme12T+npDjXKj4oz wnIA== X-Gm-Message-State: AOAM530NSZOqFBbWf9B2vdEe9oPadEno//sALg8tnItyOnxhEJOuz/Di d0koZIvxaS/PrSmiTJm8rvitC4blNPM0IjEeWts= X-Google-Smtp-Source: ABdhPJwjbq17rx2WoHZy+mm45mILPxwoMZE4g1kekeZ4ir+vZXwFa9KxgzHwN2TiC2o7hCUQrO5NkZGXiJFjcL2X1Sg= X-Received: by 2002:adf:e8d0:: with SMTP id k16mr26256999wrn.362.1605051735175; Tue, 10 Nov 2020 15:42:15 -0800 (PST) MIME-Version: 1.0 References: <20201110193112.988999-1-lee.jones@linaro.org> <20201110193112.988999-9-lee.jones@linaro.org> In-Reply-To: <20201110193112.988999-9-lee.jones@linaro.org> From: Alex Deucher Date: Tue, 10 Nov 2020 18:42:03 -0500 Message-ID: Subject: Re: [PATCH 08/30] drm/radeon/ci_dpm: Remove set but unused variable 'dpm_event_src' To: Lee Jones X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Maling list - DRI developers , amd-gfx list , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gVHVlLCBOb3YgMTAsIDIwMjAgYXQgMjozMSBQTSBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5h cm8ub3JnPiB3cm90ZToKPgo+IEFuZCB0aGUgcGllY2Ugb2YgY29kZSB0aGF0IGhhcyBuZXZlciBi ZWVuIGV4ZWN1dGVkLgo+Cj4gRml4ZXMgdGhlIGZvbGxvd2luZyBXPTEga2VybmVsIGJ1aWxkIHdh cm5pbmcocyk6Cj4KPiAgZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9jaV9kcG0uYzogSW4gZnVuY3Rp b24g4oCYY2lfc2V0X2RwbV9ldmVudF9zb3VyY2Vz4oCZOgo+ICBkcml2ZXJzL2dwdS9kcm0vcmFk ZW9uL2NpX2RwbS5jOjEzNjk6Mjg6IHdhcm5pbmc6IHZhcmlhYmxlIOKAmGRwbV9ldmVudF9zcmPi gJkgc2V0IGJ1dCBub3QgdXNlZCBbLVd1bnVzZWQtYnV0LXNldC12YXJpYWJsZV0KPgo+IENjOiBB bGV4IERldWNoZXIgPGFsZXhhbmRlci5kZXVjaGVyQGFtZC5jb20+Cj4gQ2M6ICJDaHJpc3RpYW4g S8O2bmlnIiA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgo+IENjOiBEYXZpZCBBaXJsaWUgPGFp cmxpZWRAbGludXguaWU+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiBD YzogYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogZHJpLWRldmVsQGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwo+IFNpZ25lZC1vZmYtYnk6IExlZSBKb25lcyA8bGVlLmpvbmVzQGxpbmFy by5vcmc+CgpBcHBsaWVkLiAgVGhhbmtzIQoKQWxleAoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJt L3JhZGVvbi9jaV9kcG0uYyB8IDEyIC0tLS0tLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTIg ZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9jaV9k cG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24vY2lfZHBtLmMKPiBpbmRleCA4ODZlOTk1OTQ5 NmZlLi44MzI0YWNhNWZkMDA2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yYWRlb24v Y2lfZHBtLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL2NpX2RwbS5jCj4gQEAgLTEz NjYsNyArMTM2Niw2IEBAIHN0YXRpYyB2b2lkIGNpX3NldF9kcG1fZXZlbnRfc291cmNlcyhzdHJ1 Y3QgcmFkZW9uX2RldmljZSAqcmRldiwgdTMyIHNvdXJjZXMpCj4gIHsKPiAgICAgICAgIHN0cnVj dCBjaV9wb3dlcl9pbmZvICpwaSA9IGNpX2dldF9waShyZGV2KTsKPiAgICAgICAgIGJvb2wgd2Fu dF90aGVybWFsX3Byb3RlY3Rpb247Cj4gLSAgICAgICBlbnVtIHJhZGVvbl9kcG1fZXZlbnRfc3Jj IGRwbV9ldmVudF9zcmM7Cj4gICAgICAgICB1MzIgdG1wOwo+Cj4gICAgICAgICBzd2l0Y2ggKHNv dXJjZXMpIHsKPiBAQCAtMTM3NiwyOCArMTM3NSwxNyBAQCBzdGF0aWMgdm9pZCBjaV9zZXRfZHBt X2V2ZW50X3NvdXJjZXMoc3RydWN0IHJhZGVvbl9kZXZpY2UgKnJkZXYsIHUzMiBzb3VyY2VzKQo+ ICAgICAgICAgICAgICAgICBicmVhazsKPiAgICAgICAgIGNhc2UgKDEgPDwgUkFERU9OX0RQTV9B VVRPX1RIUk9UVExFX1NSQ19USEVSTUFMKToKPiAgICAgICAgICAgICAgICAgd2FudF90aGVybWFs X3Byb3RlY3Rpb24gPSB0cnVlOwo+IC0gICAgICAgICAgICAgICBkcG1fZXZlbnRfc3JjID0gUkFE RU9OX0RQTV9FVkVOVF9TUkNfRElHSVRBTDsKPiAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gICAg ICAgICBjYXNlICgxIDw8IFJBREVPTl9EUE1fQVVUT19USFJPVFRMRV9TUkNfRVhURVJOQUwpOgo+ ICAgICAgICAgICAgICAgICB3YW50X3RoZXJtYWxfcHJvdGVjdGlvbiA9IHRydWU7Cj4gLSAgICAg ICAgICAgICAgIGRwbV9ldmVudF9zcmMgPSBSQURFT05fRFBNX0VWRU5UX1NSQ19FWFRFUk5BTDsK PiAgICAgICAgICAgICAgICAgYnJlYWs7Cj4gICAgICAgICBjYXNlICgoMSA8PCBSQURFT05fRFBN X0FVVE9fVEhST1RUTEVfU1JDX0VYVEVSTkFMKSB8Cj4gICAgICAgICAgICAgICAoMSA8PCBSQURF T05fRFBNX0FVVE9fVEhST1RUTEVfU1JDX1RIRVJNQUwpKToKPiAgICAgICAgICAgICAgICAgd2Fu dF90aGVybWFsX3Byb3RlY3Rpb24gPSB0cnVlOwo+IC0gICAgICAgICAgICAgICBkcG1fZXZlbnRf c3JjID0gUkFERU9OX0RQTV9FVkVOVF9TUkNfRElHSUFMX09SX0VYVEVSTkFMOwo+ICAgICAgICAg ICAgICAgICBicmVhazsKPiAgICAgICAgIH0KPgo+ICAgICAgICAgaWYgKHdhbnRfdGhlcm1hbF9w cm90ZWN0aW9uKSB7Cj4gLSNpZiAwCj4gLSAgICAgICAgICAgICAgIC8qIFhYWDogbmVlZCB0byBm aWd1cmUgb3V0IGhvdyB0byBoYW5kbGUgdGhpcyBwcm9wZXJseSAqLwo+IC0gICAgICAgICAgICAg ICB0bXAgPSBSUkVHMzJfU01DKENHX1RIRVJNQUxfQ1RSTCk7Cj4gLSAgICAgICAgICAgICAgIHRt cCAmPSBEUE1fRVZFTlRfU1JDX01BU0s7Cj4gLSAgICAgICAgICAgICAgIHRtcCB8PSBEUE1fRVZF TlRfU1JDKGRwbV9ldmVudF9zcmMpOwo+IC0gICAgICAgICAgICAgICBXUkVHMzJfU01DKENHX1RI RVJNQUxfQ1RSTCwgdG1wKTsKPiAtI2VuZGlmCj4gLQo+ICAgICAgICAgICAgICAgICB0bXAgPSBS UkVHMzJfU01DKEdFTkVSQUxfUFdSTUdUKTsKPiAgICAgICAgICAgICAgICAgaWYgKHBpLT50aGVy bWFsX3Byb3RlY3Rpb24pCj4gICAgICAgICAgICAgICAgICAgICAgICAgdG1wICY9IH5USEVSTUFM X1BST1RFQ1RJT05fRElTOwo+IC0tCj4gMi4yNS4xCj4KPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9hbWQtZ2Z4Cg==